summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-19cid#1448215 RV: Bad use of return valueCaolán McNamara
Change-Id: Ie974436b9d639a676336a95d5fef6545869e1ca8 Reviewed-on: https://gerrit.libreoffice.org/75922 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#704863 Dereference after null checkCaolán McNamara
Change-Id: I472f48c64a6f2d13b124ede28a83dab3b46f759f Reviewed-on: https://gerrit.libreoffice.org/75915 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448308 Unintended sign extensionCaolán McNamara
Change-Id: I3d89afa66dc42144f0717c34593d48c4869aeec4 Reviewed-on: https://gerrit.libreoffice.org/75923 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19tdf#42949 Fix IWYU warnings in include/dbaccessGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie537e44054c0d1735f42e74385cc1bd8c8000c16 Reviewed-on: https://gerrit.libreoffice.org/75180 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-19sw btlr writing mode: remove not needed checkFrameBtlr() in the DOCX exportMiklos Vajna
Now that the DOCX import doesn't create this and instead uses the proper writing mode (neither VML nor drawingmL). Change-Id: I560c710866de8fb2f90d681e8cfc2d82afb1a327 Reviewed-on: https://gerrit.libreoffice.org/75930 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-19make cppunitassertequals a shared pluginNoel Grandin
Change-Id: Ied9c26248cb72f2146fbe1a985f825f7525fa17c Reviewed-on: https://gerrit.libreoffice.org/75836 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19coverity concurrency annotation attemptNoel Grandin
Let us see what happens if we annotate our mutex code, https://scan.coverity.com/models Change-Id: I7baf44d1a252f19b4ae47f3a6b318f7ccd9629d7 Reviewed-on: https://gerrit.libreoffice.org/75851 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19loplugin:constantparamNoel Grandin
and tweak the plugin to handle a crash seen with clang-9 Change-Id: Ie1ccf80c16a20dbca58e5bd081af13f75cf5ac8f Reviewed-on: https://gerrit.libreoffice.org/75850 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19NB fix context- behaviour in draw and impressandreas kainz
Change-Id: I943466895a51463be59dacb3686926d29562a371 Reviewed-on: https://gerrit.libreoffice.org/75931 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-07-19tdf#125609 toolkit: don't use XTabController::getControlsJustin Luth
Calling XTabController::getControls was supposed to give performance improvements (coded in OOo), but it pulls cached information which is not up to date if this listener for elementInserted events is handled before the formController's listener. It is missing the most recently created control - and thus it never sees the last control in the form, and fails to create the radio group. Additionally, when all of the controls are not yet created, this function seems to be designed to catch that and immediately return. With the "optimization" the missing controls were never noticed, and so unnecessary processing continued - a performance detriment while the form is being built. My impresssion is that the local getControl() function is not terribly inefficient, so the performance impact seems minimal, especially since it now only makes the call once and caches the result itself. Since not-yet-peered controls cause the function to again terminate early (as it was designed to do), this may have unintended side effects, in case anything was designed in the past 10+ years expecting the old behaviour, so I have no intention of back-porting this. Change-Id: Ica8ddab69043a30b23d008cd8db5df1c13b94ad2 Reviewed-on: https://gerrit.libreoffice.org/75163 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-07-19sw: fix missing OLE preview for actively edited OLE object on saveMiklos Vajna
Regression from commit 74844277cc2194c9e43f5bd7a6f78a9603da32f3 (disable generation of ole previews in ODF format until after load, 2016-09-13), if the user started an OLE edit in a Writer document, and saved without ending the OLE edit, then svt::EmbeddedObjectRef::UpdateReplacementOnDemand() removed the old replacement image, but no new one was created. Given that save is always an explicit user action (auto-save does not kick in for unmodified documents), restore the permission to update OLE replacement images during save. Do this check in SwDocShell::CalcLayoutForOLEObjects(), as that's OLE-related and is called from all the relevant save code paths (save, save-as, convert to alien formats). Change-Id: Idaad43909cd744a379e713efd70ffd000e2692bc Reviewed-on: https://gerrit.libreoffice.org/75867 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-19cid#1448438 Uncaught exceptionCaolán McNamara
Change-Id: I444e8c8833db6bb0af9cfc7c3b18b45178faa663 Reviewed-on: https://gerrit.libreoffice.org/75892 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448441 Unchecked return valueCaolán McNamara
Change-Id: I97f6ad2bd0a6d838871cfb9ff54f2e654d6abfd0 Reviewed-on: https://gerrit.libreoffice.org/75893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448426 Unchecked return valueCaolán McNamara
Change-Id: Ia6ad812f76d1f69eb91a7d4f65f221b6598ce05a Reviewed-on: https://gerrit.libreoffice.org/75887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448435 Unchecked return valueCaolán McNamara
Change-Id: I1c75280dfcfa1f475d657570bf390847ab922cc8 Reviewed-on: https://gerrit.libreoffice.org/75889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448436 Unchecked return valueCaolán McNamara
Change-Id: I971587c6340afc83ac3a28b148650a8f20120164 Reviewed-on: https://gerrit.libreoffice.org/75890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448437 Unchecked return valueCaolán McNamara
Change-Id: I2dec7a66f5609b1e34d9b337f8c562440d3f5132 Reviewed-on: https://gerrit.libreoffice.org/75891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-19cid#1448287 Unchecked return valueCaolán McNamara
Change-Id: Ifd6bd0f4218805ad52a256fad82a4d2455c6afa9 Reviewed-on: https://gerrit.libreoffice.org/75871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448418 Unchecked return valueCaolán McNamara
Change-Id: Ia2cceb8e169a363a21753fbcf79fa29669957e84 Reviewed-on: https://gerrit.libreoffice.org/75886 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448395 Uncaught exceptionCaolán McNamara
Change-Id: I7478aa8a971e834efee0effd998c68cb85368892 Reviewed-on: https://gerrit.libreoffice.org/75885 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448381 Unchecked return valueCaolán McNamara
Change-Id: I4f0b48df10bf8557e39e0769a61a36bacac8f02a Reviewed-on: https://gerrit.libreoffice.org/75884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448356 Uncaught exceptionCaolán McNamara
Change-Id: Iaa48face892514b5af769cdb3120f001940cf0ea Reviewed-on: https://gerrit.libreoffice.org/75882 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448372 Unchecked return valueCaolán McNamara
Change-Id: I63d8c9d145cd938fde289d680bdc0ed3f7357bd7 Reviewed-on: https://gerrit.libreoffice.org/75883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448347 Unchecked return valueCaolán McNamara
Change-Id: I18a43e9a033a7326563f37caa0292a2c34752be0 Reviewed-on: https://gerrit.libreoffice.org/75880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448353 Uncaught exceptionCaolán McNamara
Change-Id: Ia967db3f73bee9167be4fd88090b27bfdbd4aca0 Reviewed-on: https://gerrit.libreoffice.org/75881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448224 Unchecked return valueCaolán McNamara
Change-Id: Ie13b8b8f865e44f3746fdf79bf0b1b2cec2aba1d Reviewed-on: https://gerrit.libreoffice.org/75845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448294 Unchecked return valueCaolán McNamara
Change-Id: Iee0153a00df72cf9353d2e40ff02f81f96522afe Reviewed-on: https://gerrit.libreoffice.org/75873 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448288 Unchecked return value from libraryCaolán McNamara
Change-Id: Id1b8044126e65e67b2496cf7a4eb86b54ba6c1df Reviewed-on: https://gerrit.libreoffice.org/75872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448337 Unchecked return value from libraryCaolán McNamara
Change-Id: Ie43cc1888179340318ddefb7fa4ba5f0bc1dc896 Reviewed-on: https://gerrit.libreoffice.org/75879 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448323 Unchecked return valueCaolán McNamara
Change-Id: I2d1d3d2ce7302fa895820981e0c15b59d491ddc4 Reviewed-on: https://gerrit.libreoffice.org/75876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448296 Unchecked return valueCaolán McNamara
Change-Id: I09268bc22f4fb34160975063e38ea60a68123400 Reviewed-on: https://gerrit.libreoffice.org/75875 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448326 Unchecked return valueCaolán McNamara
Change-Id: I21dd0363ff8cad8737a25b3b79f960d44d03bdd4 Reviewed-on: https://gerrit.libreoffice.org/75877 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448333 Unchecked return valueCaolán McNamara
Change-Id: If23db9a245b4dd4b59b9b5410a094f2f374eedfd Reviewed-on: https://gerrit.libreoffice.org/75878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18It's Classical Armenian, not Classic [xcl-AM]Eike Rathke
Change-Id: I1c714c8a9ecfd3cf73e645e1693101e7fce433e4 Reviewed-on: https://gerrit.libreoffice.org/75856 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-07-18svx xml dump: show the SdrObject's properties / item setMiklos Vajna
Shows items usually accessed using GetMergedItemSet(), to help debugging. Change-Id: Id3c20e99c33d5e5762c3b58e2f76ab5686031734 Reviewed-on: https://gerrit.libreoffice.org/75852 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-18cid#1448377 silence Dereference null return valueCaolán McNamara
Change-Id: I8e124f005622091f7c3e989042c5298640ba819b Reviewed-on: https://gerrit.libreoffice.org/75816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#126461 incl. document name in link update msgJan-Marek Glogowski
If you open a OLE-linked document from the console, LO will ask to update the linked information on open. But this happens before the document shell has even has set the title of the shell, so a user has no way to know, what "This document" really refers to. This is even more problematic if you have multiple open documents restored by a session manager. So this changes the string to include the document name. Change-Id: Ife7b21f6eeb4dd5c1aebd383752cc62279da33fb Reviewed-on: https://gerrit.libreoffice.org/75777 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-18cid#1448237 Unchecked return valueCaolán McNamara
Change-Id: Ic53196270ececf407d75c2f76998253adf396c64 Reviewed-on: https://gerrit.libreoffice.org/75848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#703974 Unchecked return valueCaolán McNamara
Change-Id: I833175e7687df88719d4d946cf97181158187c67 Reviewed-on: https://gerrit.libreoffice.org/75840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1311945 Uncaught exceptionCaolán McNamara
Change-Id: I1f3c2d3e644c4cbb4e38740c05a623864219313e Reviewed-on: https://gerrit.libreoffice.org/75843 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1424266 Uncaught exceptionCaolán McNamara
Change-Id: I5e7373dbaef52184327596d029ab63baf57764d9 Reviewed-on: https://gerrit.libreoffice.org/75844 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448227 Uncaught exceptionCaolán McNamara
Change-Id: I6149b087217b9b34ecce984536aae52b8ee9d430 Reviewed-on: https://gerrit.libreoffice.org/75846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448325 Uncaught exceptionCaolán McNamara
Change-Id: I5bb61909d5d252de7465a29a3c8e49b7b1997ba3 Reviewed-on: https://gerrit.libreoffice.org/75847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#704107 Unchecked return valueCaolán McNamara
Change-Id: I6fb22b972a19b42787242d98d08fc425f5c0aea9 Reviewed-on: https://gerrit.libreoffice.org/75842 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#704106 Unchecked return valueCaolán McNamara
Change-Id: Ic0a9d173c24af8962539b00207b8dd24cbbcdbc0 Reviewed-on: https://gerrit.libreoffice.org/75841 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#703960 Unchecked return valueCaolán McNamara
Change-Id: I679e9e91261d468f2f2ee08f840ac3043d87817c Reviewed-on: https://gerrit.libreoffice.org/75839 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#125894: DOCX: import tracked changes in framesLászló Németh
Tracked changes weren't imported in frames, losing also the actual text content: also tracked deletion reappeared as normal text here, not only the tracked insertions. Change-Id: I5fc8135cfb7402ad71c5c24eae606aa7ed707dfc Reviewed-on: https://gerrit.libreoffice.org/75779 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-07-18cid#703956 Unchecked return valueCaolán McNamara
Change-Id: Ide2d83962c0a03e410443164f80522b2913ab998 Reviewed-on: https://gerrit.libreoffice.org/75838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#703953 Unchecked return valueCaolán McNamara
Change-Id: Id4164e0adc71e57e4c732016306bb53ae7ac4ad7 Reviewed-on: https://gerrit.libreoffice.org/75837 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#703937 Unchecked return valueCaolán McNamara
Change-Id: I38be419c6ed4857c52ac555696a614008aaad907 Reviewed-on: https://gerrit.libreoffice.org/75835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-11 08:59:03 +0000