summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-10-18tdf#163486: PVS: remove breakXisco Fauli
Since 07f8216e5722d2288143367a07f4d567ab060431 "Create string from token array directly from ScTokenArray. Still WIP." V622 Consider inspecting the 'switch' statement. It's possible that the first 'case' operator is missing. Change-Id: I5916fb8db4db3a0c238660a35ad1b5d985387292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175111 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-18find-unneeded-includes: add option to detect IWYU failuresGabor Kelemen
In some cases IWYU may fail to run and give back -1 status - A file does not have any headers included, such as sw/source/ui/vba/vbawordbasic.hxx - A header includes itself such as sw/source/ui/vba/vbaformfielddropdownlistentries.hxx - Checking headers is not called with correct -I switches such as with sw/source/writerfilter/dmapper/*hxx misses -I/home/gabor/core/sw/source/writerfilter/inc Such cases were not handled/reported separately so far, so add a debug-like option to detect similar errors. Solving such issues is still down the road. Change-Id: I47ac876eb4eb4a0c16bd838ce3c3e4d604a07a7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175099 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-10-18Relates tdf#162979 - Fix typoHeiko Tietze
Fixes patch 74e3f47723471f3ed4dc2dbffc95085bb04d9504 Change-Id: I3cd596f15c1d0ebc600b9b5f1bffa87b5225d0d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175091 Tested-by: Jenkins Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2024-10-18tdf#148526 sdext,pdfimport: clipToStrokePath: Set line joinDr. David Alan Gilbert
Set the line join type from our GC. Change-Id: I8f64ae032930e46028cd49efefb05af06d4866d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172926 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-18tdf#148526 sdext,pdfimport: rendering::PathJoinType to B2DLineJoinDr. David Alan Gilbert
Pdfimport is one of the few none render pieces of code to use css::rendering::PathJoinType, switch to using basegfx::B2DLineJoin instead. Use that type consistently instead of throwing in sal_Int8's with it. Change-Id: Ie1384a06558925c796ce6c83b458b4c150bcecc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172925 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-18tdf#148526 sdext,pdfimport: Expand path to contourDr. David Alan Gilbert
Poppler's 'ClipToStroke' call wants to clip to a paths rendered shape, i.e. with line thickness and possibly other attributes. Use get2DDecomposition to do that. Change-Id: I3ca54621dcb859520504e5c7d6cd41106f5c34d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172924 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-10-17tdf#163486: PVS: Expression is always falseXisco Fauli
V547: Expression 'aMDHelper.ISSET_Storage' is always false. Change-Id: Ibdeb820b606301f729bf09a3641ab44d726e356c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175095 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17tdf#163486: PVS: nullptr dereferenceXisco Fauli
V595: The 'pMethod' pointer was utilized before it was verified against nullptr. Check lines: 392, 394. Change-Id: I7c3cdcf9aacb76ca261733924dc238e836036433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175080 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17cid#1557611 Data race conditionCaolán McNamara
Change-Id: Id8a60317bcf068132900d4aff8d64dd9ad6dd8c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17tdf#159007 Revert "optimization to skip SdrObject::GetViewContent()"Caolán McNamara
This reverts commit 313be607903a381830600c0a60b2e299fcaec685. Change-Id: I2dc7489ecc302473edd763fd0e4d6784fadc9bb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17tdf#163486: PVS: Identical branchesXisco Fauli
V1037: Two or more case-branches perform the same actions. Check lines: 996, 999 Change-Id: Idfec4df06a578c63e52ef053b73dfa2d55b5cbf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175089 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17tdf#163486: PVS: identical conditional expressionsXisco Fauli
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 422, 426. Change-Id: Ib2bcd4b170b827c325628e0e7eabe6a19ca399ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175086 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-17tdf#163486: PVS: identical conditional expressionsXisco Fauli
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 507, 520. Change-Id: Ia376cad05bd4327662cd3b7adcbe43e25270da2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175084 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-17tdf#163486: PVS: identical conditional expressionsXisco Fauli
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 406, 410. V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 410, 418. Change-Id: I971f243870a96f7195d2819f2a0a44bb63840fac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175083 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17tdf#163486: PVS: identical conditional expressionsXisco Fauli
V581: The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 153, 157. Change-Id: I55b32aa4dfd479c3b64044a6749c3981f3b032a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175082 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17tdf#148526 sdext,pdfimport: Parse clipToStrokePathDr. David Alan Gilbert
Parse the soon to be created clipToStrokePath command and route it through the tree code. Change-Id: I8fa17457ffd062e91983b6ed80bd64259aa7114e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172923 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-10-17cid#1555697 Data race conditionCaolán McNamara
Change-Id: Ib022e1fbccf456e89f16a26efb50e6c8d98372ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175065 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-17cid#1555171 Data race conditionCaolán McNamara
Change-Id: Ibb49dbd5ce386c4e31c1dfbacb23477d1a08a5ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17tdf#34804 sd: enable keyboard shortcut for CharColor and CharBackColorJustin Luth
A followup patch that adds keyboard shortcut support to Draw/Impress for .uno:Color and .uno:CharBackColor to use recentColor. Change-Id: I1eea3b8330ca3c10e20b13e0fa83c15418eee6a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174828 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-10-17tdf#34804 sc: enable keyboard shortcut for CharColor and CharBackColorJustin Luth
A followup patch that adds keyboard shortcut support to Calc for .uno:Color and .uno:CharBackColor to use recentColor. Note that for Writer, it was .uno:FontColor (SID_ATTR_CHAR_COLOR2) but the rest of the applications are .uno:Color (SID_ATTR_CHAR_COLOR) I purposely did not add CharBackColor support to native Calc. Notice that the "fill" icon on the toolbar is CELL-background, so the color used would NOT NECESSARILY match what is seen in the toolbar, and the sidebar also does not include a CharBackColor button. [See patchset 1 for stuff needed for implementation.] formatsh is for entire cells - .uno:Color opens dialog when no args: OK editsc is for cursor-in-cell and for cursor-in-formula-bar. drtxtobj is for comments, shapes, and textboxes (draw stuff). Change-Id: I104b39eab1d475fc5c88837addf4bdbbd313d1be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174827 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-10-17tdf#34804 swdr: enable keyboard shortcut for CharColor and CharBackColorJustin Luth
A followup patch that adds keyboard shortcut support for the draw objects (textbox, shapes, comments) in Writer. Change-Id: I69dea0feb75c77fec615a3e478d4bb90db4ca84f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174805 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-10-17Fix Gtk-warning in condformatmanager.uiJulien Nabet
(soffice:502622): Gtk-WARNING **: 13:08:51.061: Could not read property GtkBox:position with value of type gint: Could not parse integer '' Change-Id: I43b1a0fd8d67ef60e9c252b914b4fe2d00d97c89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175079 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-10-17don't need to use dlsym for cairo_surface_set_device_scale...Caolán McNamara
for bundled cairo case Change-Id: I8ca48433b3be144d8347defe3831b92cc87d7cbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175081 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17Fix experimental Emscripten --enable-qt6 build resource issuesStephan Bergmann
...where window decoration icons and menu text glyphs were missing Change-Id: Iadff019a99fbe96442fc010df0d019ba5e2b98e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175088 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-10-17tdf#34804 sw: enable keyboard shortcut for CharColor and CharBackColorJustin Luth
The result of this patch is that a keyboard shortcut can now set the font fore-/back-ground color using the color shown in the toolbar/sidebar. This is now possible thanks to Maxim's work in 7.6.2 tdf#154270 Sync toolbar button recent colors and Andreas Heinisch's 24.8 commit 8c822b764b35a0116a0865e991a87c8315e0 tdf#72991 - Remember last used color depending in cui This patch does 3 things: 1. SetRecentColor when the app initializes 2. Uses SID_ATTR_CHAR_COLOR's recentColor for .uno:FontColor if no pItem was provided (i.e. a keyboard shortcut called it) 3. Uses SID_ATTR_CHAR_BACK_COLOR's recentColor for .uno:CharBackColor if no pItem was provided (Note that without a selection, CharBackColor isn't so useful for a keyboard shortcut, since it turns the drag-and-drop template on.) Setting the recent color right away is critical for user acceptance. Otherwise, it would only function after they first modified the color in the toolbar/sidebar. make CppunitTest_sw_uiwriter9 CPPUNIT_TEST_NAME=testTdf34804 Unfortunately, I can't reliably know if this request came from an awt::KeyEvent or not, because in that case we could just avoid CharBackColor's template altogether. [While there is rReq.GetModifiers() as a good hint, it is not a guarantee (in case assigned to a function key, or CTRL held while clicking the toolbar, etc.)] Change-Id: I7377f087dcdf7011205af005cd0d172100bade2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174804 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-10-17Adapt experimental Emscripten --enable-qt6 to recent Qt6 upstreamStephan Bergmann
At least when building against recent upstream dev branch, qtloader.js needs FS due to <https://github.com/qt/qtbase/commit/64007c749703090ebf7f9b1b49b4267bb9993b99> "wasm: add 'preload' qtloader config property" Change-Id: Ie505d531670649635774152032123389b6d106ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175085 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-10-17lok: sd: transition information: export fade colorMarco Cecchetti
Change-Id: I955c18cc5d131cfa5a246bb4506a81b8cf40b7ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175071 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-17tdf#161145 sw: Conform doc grid advance layout for DOC/DOCX importJonathan Clark
This change modifies the Writer document grid algorithm to behave more like Word when the MS_WORD_COMP_GRID_METRICS compatibility flag is set. This flag is automatically set when importing DOC/DOCX files. Change-Id: I99765a3ad689b319ebd14e3620b22f18661efcf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175077 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-10-17tdf#140061 CPPUNIT Test for fix swlo!sw::WriterMultiListener::StartListeningSamuel Adesola
A CPPUNIT Test for the bug fix on swlo!sw::WriterMultiListener::StartListening crash. The sample file was added to the sw/qa/uiwriter/data. Without this fix, writer crashes when the reproducing steps were followed. The bug fix was reverted, when the test was ran, the test failed, i.e the assert was not reached. The bug fix was reintroduced and the test passed showing that the test catch the bug. Change-Id: I688672d96a36d89c940bf0d401daaaeb732590a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174908 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-17CppunitTest_sw_layoutwriter3: split in twoXisco Fauli
it already has 133 tests Change-Id: Idb67ab8af7ead44db1330a0437cc099c39b65cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175073 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17cid#1557492 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I6fd226cad714fab0eb0f8c0806dcf73c2ff20426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17cid#1608473 Data race conditionCaolán McNamara
Change-Id: I5152a3ba56aa9d739232ba6f6c95448b26fd22a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17tdf#160163 improvment when reset placeholder in Text fieldJuergen Funk
- this patch improve e8a271dd53d605a835c493eef5c34e4fb077f16d when replace the empty-placholder, it was missing the selection of the whole placeholders. - with this change have solved a other problem, when select with the field with mouse or tab, and press backspace, then the cursor has the wrong position, after tip text the view was wrong. - reduce code Change-Id: I6c2c7b2849298552770ea2d257ab844d250a97a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174965 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2024-10-17cid#1555042 Data race conditionCaolán McNamara
Change-Id: Ifc3e2134520a6947ab66014c40b962b1de8a22be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175066 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-17sw: move these tests where they belongXisco Fauli
Since they use DECLARE_ODFEXPORT_TEST they should be inside sw/qa/extras/odfexport/ Change-Id: Ia080f006c08ecf584232428563ec2aa94f6a4ce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175067 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-17cid#1606687 silence Overflowed integer argumentCaolán McNamara
Change-Id: I692ac9745c0f2811e7e8d155d0aeeee578d358fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17cid#1606973 silence Overflowed constantCaolán McNamara
Change-Id: I333110570dba4b7410b9c4b5595afc5d2b06cb94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175062 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-17cid#1606594 silence Overflowed constantCaolán McNamara
Change-Id: I1aff57f76eac334feea9fba02233b9b004ca759c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175063 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-17extract NaN payload test from single unit testSakura286
Change-Id: I51a029c9ac729352fe435b9a70c5e8bd2cf746b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174964 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2024-10-17configure.ac: Drop bashismĐoàn Trần Công Danh
- ${var/pattern/replacement} and here-string are bashism. - here string (<<<<) is bashism too, depsited it's intended for Windows build only (which uses Bash inside msys), however the code block is still parsed on other platforms (without bash a /bin/sh) before evaluated. Let's remove that too. Change-Id: I3ba59d97b9e9a6b29496b3401c29c4fbf99f46d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170969 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-10-17we don't need to copy the Name here, a reference is sufficientCaolán McNamara
48s -> 47.8s Change-Id: Ib95b701d424b0b92aa3848b75f81c41eff0af2ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175029 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-17tdf#143148 Use pragma once instead of include guardsMuluh MG Godson
Change-Id: I7cfacc4fa2b302f01a284f750a99fc777b7ae43a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175037 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-17tdf#145614 Convert #define to 'enum'Chizoba ODINAKA
Change-Id: I92cd029034015fe8b664ee75b4e4f107ba365e1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175034 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-10-17Partially revert "loplugin:unusedmethods" to fix --enable-cpdb buildMichael Weghorn
This PPDParser ctor is used by CPDManager::createCPDParser, which gets built with the `--enable-cpdb` autogen option. This partially reverts commit 5c4fac1e9f50832852e87452f3152f01b905f9e6. Change-Id: Ic22fc4e776c0b0ef2013b9296c7dbe9345c4e51c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175040 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-17Optimize a bit: only create std::locale once in parseDudenResponseMike Kaganski
Change-Id: If1aee9fa908b4ad730d858738f3e472a17fd235a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175039 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-17sw: reduce usage of DECLARE_SW_ROUNDTRIP_TESTXisco Fauli
Change-Id: Ib2884a766ff891aa768530e62cb2825402b84d03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175026 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-17tdf#161351 Revert "tdf#99528 Use vertical tabs in list style dialog"Samuel Mehrbrodt
This reverts commit d9bcf481b40d2a20169a98eb53caf7b19a03f3b8. Change-Id: If3cffb089c22a32d558f299616ee1a4ec515d01c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174820 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-10-16Resolves: tdf#163448 An unsaved new document don't allow movingJim Raykowski
headings with Content Navigation View option (by drag and drop) Change-Id: Id1f4cbc0538e75abfb2a133d2d6fb82ddaf580fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174986 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
2024-10-16crashtesting: assert on fdo87790-1.odsCaolán McNamara
and gnome704765-1.ods Change-Id: I037b3c7d1f3887634ead05e5464435ae0fbeea60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175028 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-16SwModelTestBase: Remove unused executeImportExportXisco Fauli
Since b67991ecdb12bfa385496731f192ac081947c779 "CppunitTest_sw_htmlexport: use more CPPUNIT_TEST_FIXTURE()" Change-Id: I572649a1f70180084846aa47446689b331f35f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175024 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-10 18:27:29 +0000