summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-12-12Version 24.8.4.2, tag libreoffice-24.8.4.2libreoffice-24.8.4.2Christian Lohmaier
2024-12-12bump product version to 24.8.4.2Christian Lohmaier
Change-Id: Ic83c01bedcc41eabc4ad08fcee1e150a58628aa5
2024-12-12update creditsChristian Lohmaier
Change-Id: Ic661fad279ad26f8aebc9ca1a2c8b271090e7d62 (cherry picked from commit 2976e22f7a6740bb17933f67895ecbdbbe48cbd6) (cherry picked from commit bc0779ff918f44ef57720981d5818f56e501eb2b)
2024-12-12Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-24-8-4' to fda60c9b20d87333ac44afb54fc8c5e9cbc78ed9 - update translations for 24.8.4 rc2 and force-fiix errors using pocheck Change-Id: Ia8ab38902787b6c054ff427064cc0e5bf2fc0443 (cherry picked from commit 06f2f2e19bd7140228a2b028592c4058e9190044)
2024-12-12tdf#147067 Jump to clicked spot if left mouse click with Option keyPatrick Luby
Most macOS applications such as TextEdit and Safari jump to the clicked spot if the Option key is pressed during a left mouse click. Change-Id: I56149e42daf1825cfebde8be8cfbb53645b31928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178369 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> (cherry picked from commit 94508506e7f6b9e53c77b631c5d7de1e06ff78d9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178382 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-12tdf#163948: fix crash when NotesPane is enabled on Tabbed UISarper Akdemir
Pane shells (BottomImpressPane, LeftImpressPane etc.) do not implement any slot handling, so make sure they are not activated on the top of the shellstack. Another solution for this could have been getting ChildWindowPanes properly dispose instead of Hide() at BasicPaneFactory::releaseResource, and adapting the rest of the code which assumes these Panes are recycled. This is since ConfigurationUpdater::UpdateCore attempts at releasing via ConfigurationUpdater::CheckPureAnchors and ConfigurationControllerResourceManager::DeactivateResources calls. But in the end the ChildWindowPane is hidden on the DeactivateResource call instead of being diposed, so the "PureAnchor"'s Shell stays at the shellstack. Change-Id: I52788d350b66ae22875683f57d87326f4a9a77de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177686 Reviewed-by: Sarper Akdemir <sarper.akdemir@allotropia.de> Tested-by: Jenkins (cherry picked from commit ae281b51456196246a5b21929f6624bf6c030294) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177712 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 379857ddce35cf20d489a05e7aed73fb61d6cbf6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177753 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-12crashtesting: fix failure of forum-en-13617.odt to reload from .docCaolán McNamara
Change-Id: I907e282c9e7b75abca9a4c91ba12a2c57fc45f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177733 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 63594c62024b894251e1c88d5f65980c553dec4e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177752 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 0ded71cc45edd4fb372f1c77857178597f949fbe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177761 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-12curl: upgrade to 8.11.1Xisco Fauli
Downloaded from https://curl.se/download/curl-8.11.1.tar.xz Change-Id: Id6ac29867e0f09daf239f8585c870181e606cd02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178340 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-12tdf#163483: implement export of Math formula's fallback image to PPTXMike Kaganski
This was left as a TODO in commit cb890ae43bacd2be24bc74fad2e2e5cce8910995 (oox: export Math objects to PPTX files, 2016-01-15). Now after commit 7cfff4751befd678b3db4b6f16b020d38f4e9c32 (Related: tdf#129061 Avoid formula import and use fallback for now, 2024-09-11), that relied on the fallback being present, our exported documents lost the formulas completely on load. So the fallback export became a necessity. Change-Id: I52d4ef0400ce72ee10fda10a1131b4ba29ea56be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177564 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177653 (cherry picked from commit e425b6e0d270b1a315dfecc1ec6571bd5c7a6b52) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177665 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de>
2024-12-12Related: tdf#163945 don't directly flush graphics with Skia/MetalPatrick Luby
When dragging a selection box on an empty background in Impress and only with Skia/Metal, the selection box would not keep up with the pointer. The selection box would repaint sporadically or not at all if the pointer was dragged rapidly and the status bar was visible. Apparently, flushing a graphics doesn't actually do much of anything with Skia/Raster and Skia disabled so the selection box repaints without any noticeable delay. However, with Skia/Metal every flush of a graphics creates and queues a new CAMetalLayer drawable. During rapid dragging, this can lead to creating and queueing up to 200 drawables per second leaving no spare time for the Impress selection box painting timer to fire. So with Skia/Metal, throttle the rate of flushing by calling display on the view. Also, with the reduced Skia/Metal flushing load from this fix, the color conversion when drawing to an NSBox appears to be no longer needed. The converted color appeared less saturated, at least to me, so accept the (hopefully now imperceptible) performance hit of drawing an NSBox with native colors. Change-Id: I55b4ab763bf20c6c2acad65587b703fc6f645264 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177530 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins (cherry picked from commit c585b697b583fa0f8cdadeab594c31d270367ba7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177732 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2024-12-12Related: tdf#152703 Reuse existing CAMetalLayer to stop flickerPatrick Luby
When live resizing a window, replacing the CAMetalLayer with each resize event repaints the window's background which causes a noticeable flicker. So reuse any existing CAMetalLayer already assigned to the native view. Change-Id: I03bda5f0d40b84606b6602961e5f0d3b0dfcc6ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177921 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> (cherry picked from commit cd983f0af4d0d2a187e30f070bc96241d362302f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177983 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-12-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-24-8-4' to b0d24b26fc1c6bc0bf865ea8f8db674d757da675 - Add Tagalog to online help dropdown list Change-Id: Ie22b89529b3937a36806f87b3e9a049a14bc85b9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178120 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 2fd0b5ff3a8599ee49a04b36c9203a03e6295f54) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178303 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit bbe83a4a6e6a36669fa0486247d7ade7005812fc) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/178317
2024-12-11Resolves: tdf#164239 Can force Y-M-D to ISO 8601 if no date acceptance patternEike Rathke
... was matched at all, even for a-b-c with MDY a<=12 or DMY a<=31. Change-Id: Ie2d62c73c91794a96114b787d6ad2357c7affb2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178171 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 47b4b1633a08dd4c97d66feabe8cd3290074dc0f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178174 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 224c0bb32232a29d08611365d25be1c340032bc8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178191 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-11crashtesting: crash on load of forum-en-40508.odt + F9 to update fieldsCaolán McNamara
seems to already exist in oldest version I have Change-Id: I3f3652952476678c121cbe3f800b7adf7f7aa1a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177628 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit b9c91699697e405b591aef1addd7a4b8da5a2a04) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177662 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-11crashtesting: unbalanced rtf {} on inability to export a math objectCaolán McNamara
Seen in export of forum-mso-en-11772.docx to rtf and reimport so rtf cannot be imported, a problem probably since: commit c14355592ccc249500ca58b3607888db195b06c0 CommitDate: Tue Dec 31 18:02:07 2013 +0100 Related: fdo#66440 RTF export: handle NULL component in FlyFrameOLEMath() A problem with casting the uno proxy obj probably got fixed with: commit ef533553559fe09b4afab651fc692885d1acf4ed CommitDate: Wed Jan 4 13:49:58 2023 +0000 Rudimentary support for dynamic_cast on UNO proxy objects At least now converting the original test case to rtf doesn't crash for me on export, and now uses "if (pBase)" to keep balanced and at least output a preview image if not the math text content. Change-Id: Ib428ab89fac6f36f1fa8e3bd7b3b01cd0a889d7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 50fec9db063edd2fdf63ca22277ef16b3727ca4c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177474 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit df95540dec164c7de2bf1aa6b85269435023c040) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177538 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10crashtesting: HLINK_MARK embedded null import from forum-mso-en4-7137.docCaolán McNamara
which causes problems on export to docx. Sanitize at the original import. Change-Id: I8b9fa86465c455fe872c41386889dc54e38eb9ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177905 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 5e84620b1a5a60e14da0da942c87a86326ae6dae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177970 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-10crashtesting: failure to reload conversion of forum-de3-6592.odt to docxCaolán McNamara
Change-Id: Ic2781bbd25e794992a181b2f4807fc0ca08ef33b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177675 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins (cherry picked from commit 9efc47ac6fb7c6b82ac35f114898e4e8e510c5f4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177689 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-12-10Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-24-8-4' to 88cfd45399919efd1b9346fdd4cd27676a81f5bc - update translations for 24-8 and force-fix errors using pocheck Change-Id: I78c9fa8a5995c12202bec5c6f7e9689536b6949c (cherry picked from commit 824f5a25cc0662a509b3717f7b2f3c7940e09dd8)
2024-12-10Get SwFieldType after broadcastMike Kaganski
A crash was reported in HasOnlyOneListener, with the following call stack: ntdll.dll!KiUserExceptionDispatch() swlo.dll!SwModify::HasOnlyOneListener() Line 204 swlo.dll!SwFormatField::~SwFormatField() Line 142 swlo.dll!SwHistorySetTextField::`scalar deleting destructor'(unsigned int) swlo.dll!std::default_delete<SwHistoryHint>::operator()(SwHistoryHint *) Line 3090 swlo.dll!std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>::{dtor}() Line 3198 swlo.dll!std::destroy_at(std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> * const) Line 311 swlo.dll!std::_Default_allocator_traits<std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>::destroy(std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>> &) Line 688 swlo.dll!std::_Destroy_range(std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> * _First, std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> * const) Line 905 swlo.dll!std::vector<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>,std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>::_Destroy(std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> * _Last, std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>> *) Line 1667 swlo.dll!std::vector<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>,std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>::_Tidy() Line 1751 swlo.dll!std::vector<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>,std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>::~vector<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>,std::allocator<std::unique_ptr<SwHistoryHint,std::default_delete<SwHistoryHint>>>>() Line 699 swlo.dll!SwUndoSaveContent::~SwUndoSaveContent() Line 740 swlo.dll!SwUndoDelete::~SwUndoDelete() Line 633 swlo.dll!SwUndoDelete::`scalar deleting destructor'(unsigned int) svllo.dll!std::default_delete<SfxUndoAction>::operator()(SfxUndoAction *) Line 3090 svllo.dll!std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>::{dtor}() Line 3198 svllo.dll!std::destroy_at(MarkedUndoAction * const) Line 311 svllo.dll!std::_Default_allocator_traits<std::allocator<MarkedUndoAction>>::destroy(std::allocator<MarkedUndoAction> &) Line 688 svllo.dll!std::_Destroy_range(MarkedUndoAction * _First, MarkedUndoAction * const) Line 905 svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::_Destroy(MarkedUndoAction * _Last, MarkedUndoAction *) Line 1667 svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::_Tidy() Line 1751 svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::~vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>() Line 699 svllo.dll!SfxUndoArray::{dtor}() Line 1389 svllo.dll!SfxListUndoAction::~SfxListUndoAction() Line 1318 svllo.dll!SfxListUndoAction::`vector deleting destructor'(unsigned int) svllo.dll!std::default_delete<SfxUndoAction>::operator()(SfxUndoAction *) Line 3090 svllo.dll!std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>::{dtor}() Line 3198 svllo.dll!std::destroy_at(MarkedUndoAction * const) Line 311 svllo.dll!std::_Default_allocator_traits<std::allocator<MarkedUndoAction>>::destroy(std::allocator<MarkedUndoAction> &) Line 688 svllo.dll!std::_Destroy_range(MarkedUndoAction * _First, MarkedUndoAction * const) Line 905 svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::_Destroy(MarkedUndoAction * _Last, MarkedUndoAction *) Line 1667 svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::_Tidy() Line 1751 svllo.dll!std::vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>::~vector<MarkedUndoAction,std::allocator<MarkedUndoAction>>() Line 699 svllo.dll!SfxUndoArray::{dtor}() Line 1389 svllo.dll!SfxListUndoAction::~SfxListUndoAction() Line 1318 svllo.dll!SfxListUndoAction::`vector deleting destructor'(unsigned int) svllo.dll!std::default_delete<SfxUndoAction>::operator()(SfxUndoAction *) Line 3090 svllo.dll!std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>::{dtor}() Line 3198 svllo.dll!std::destroy_at(std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> * const) Line 311 svllo.dll!std::_Default_allocator_traits<std::allocator<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>>>::destroy(std::allocator<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>> &) Line 688 svllo.dll!std::_Destroy_range(std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> * _First, std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> * const) Line 905 svllo.dll!std::vector<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>,std::allocator<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>>>::_Destroy(std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> * _Last, std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>> *) Line 1667 svllo.dll!std::vector<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>,std::allocator<std::unique_ptr<SfxUndoAction,std::default_delete<SfxUndoAction>>>>::clear() Line 1442 svllo.dll!svl::undo::impl::UndoManagerGuard::~UndoManagerGuard() Line 325 svllo.dll!SfxUndoManager::ImplClearRedo_NoLock(const bool i_currentLevel) Line 468 swlo.dll!sw::DocumentContentOperationsManager::InsertPoolItem(const SwPaM & rRg, const SfxPoolItem & rHt, const SetAttrMode nFlags, const SwRootFrame * pLayout, SwTextAttr * * ppNewTextAttr) Line 3694 swlo.dll!SwXTextField::attach(const com::sun::star::uno::Reference<com::sun::star::text::XTextRange> & xTextRange) Line 1972 swlo.dll!SwXText::insertTextContent(const com::sun::star::uno::Reference<com::sun::star::text::XTextRange> & xRange, const com::sun::star::uno::Reference<com::sun::star::text::XTextContent> & xContent, unsigned char bAbsorb) Line 606 mscx_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long nParams, _typelib_MethodParameter * pParams, void * pUnoReturn, void * * pUnoArgs, _uno_Any * * ppUnoExc) Line 214 mscx_uno.dll!unoInterfaceProxyDispatch(_uno_Interface * pUnoI, const _typelib_TypeDescription * pMemberTD, void * pReturn, void * * pArgs, _uno_Any * * ppException) Line 430 binaryurplo.dll!binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny * returnValue, std::vector<binaryurp::BinaryAny,std::allocator<binaryurp::BinaryAny>> * outArguments) Line 239 binaryurplo.dll!binaryurp::IncomingRequest::execute() Line 79 binaryurplo.dll!request(void * pThreadSpecificData) Line 84 cppu3.dll!cppu_threadpool::JobQueue::enter(const void * nDisposeId, bool bReturnWhenNoJob) Line 101 cppu3.dll!cppu_threadpool::ORequestThread::run() Line 169 cppu3.dll!threadFunc(void * param) Line 190 sal3.dll!oslWorkerWrapperFunction(void * pData) Line 67 I don't know why pType->Which() succeeded before the broadcast and reset, and pType->HasOnlyOneListener() crashed; field destructors themselves do not seem to destroy their types (except SwDBField, which is handled here explicitly). My blind guess is, that a change could happen in broadcast. Change-Id: I5c7f07da2e1283510bce3a3e3e80b6f8d849f38b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177854 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a81c1e16516dccd0e4a37c4ea5d37e9c85b5a3d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177877 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit b0bb7044824f242fec51143a64754d88a6931c3a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178044 (cherry picked from commit c891e60b1fd936fe88d8d77e4de416abb7af58c5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178192 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10crashtesting: reimport of fdo61125-1.docx has negative image widthCaolán McNamara
we probably shouldn't do that anyway, but the assumption at this import check appears to be for >= 0 Change-Id: Ibf98b1b0802a15bc283b3d1e3db7e4e8163837dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178134 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins (cherry picked from commit 0e5ad67de1516e3553cf787107316ddbdbeefc69) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178187 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10Fix check for further exotic protocolsStephan Bergmann
...that were added in 59891cd3985469bc44dbd05c9fc704eeb07f0c78 "look at 'embedded' protocols for protocols that support them" Change-Id: I42836d6fd27cd99e39ab07e626053f002a2651f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178047 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> (cherry picked from commit 8075798b22f2188530f57b8747589923bfd419ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178065 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178194 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10look at 'embedded' protocols tooCaolán McNamara
Change-Id: Ie99f5f5a390639bdc69397c831e0a32594a5030c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177981 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 59891cd3985469bc44dbd05c9fc704eeb07f0c78) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177987 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178193 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10crashtesting: failure to reimport forum-it-2308.odt rtf exportCaolán McNamara
Change-Id: I9908dea4aa822b7793ece91874de0282239bd17b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177990 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins (cherry picked from commit 4d4bbb85c74869f4e9ea8a89bfc046fa2e8c081a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178016 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10Revert "Related: tdf#163903 Add French (Republic of Guinea) {fr-GN} [0x940C]"Eike Rathke
This reverts commit c79b2bfc433ba45450802f02e10d7e13e4938207. Reason for revert: broke string freeze that's only acceptable for security or emergency issues. Change-Id: I5f43dfd7ab0ad19e44dae72ad1b683250808202e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177986 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10crashtesting: HLINK embedded null import from ooo98294-1.docCaolán McNamara
which causes problems on export to docx. Sanitize at the original import. Change-Id: I3b5521dac6a2b6926db6362d33500b11f0a69098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177870 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins (cherry picked from commit 47a9360de91bb50c19a0d5f2e8408042931933ab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177890 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-12-10crashtesting: failure to reimport forum-es-2526.odt after export to odtCaolán McNamara
2nd arg to copy is len, not index. Probably a problem since: commit 12a7a3d57d3dcf222b13fa9143c37736f8ea3d0b CommitDate: Thu Sep 3 15:33:36 2020 +0200 Fix crashtest fdo77855.odt in forum-es-2526.odt the input has: fo:border-=".009cm solid #595959" where 'fo:border-' is an unknown attr and "fo" ends up truncated to "f". On export and reimport the 'f' is further truncated to '' and we assert on this oddness. Change-Id: Ie85d81947504bf15b9caefb92477c7f977eb5cb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177806 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit c599597b35a312ccc6fdb71eb2b1bd165dcdf94b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177819 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10tdf#162912 i18npool: Updated CJK BreakIterator to use custom rulesJonathan Clark
Regression from commit 14c6cde779d64596eab0f4d3f32f181ce2243929: "tdf#49885 Updated CJK BreakIterator to use ICU" Previously, languages requiring dictionary-based break iterators were handled by instantiating a stock ICU break iterator as a special case. tdf#49885 upgraded our custom rules to support passthrough for dictionary-based breaking, so this special case is no longer necessary. Change-Id: Iebb06de82eb511946e5b220e5dc414440838b03c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177713 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177754 (cherry picked from commit 10ee7d30f7c1c8c9b80155341c2bf1639ca21d5f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177764 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-12-10crashtesting: crash on load of .doc output of forum-de3-398.odtCaolán McNamara
Change-Id: Ibcd898e25c8807dba36226d0ec7126588ba38837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177633 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 14acee58718a82608120a002de2bfc62a4548203) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177655 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10crashtesting: failure to export forum-mso-en4-491312.xlsx to odsCaolán McNamara
probably since: commit 65129e0bc5abfe7afc612eb46f1434e627265a7d CommitDate: Tue Feb 2 22:06:18 2021 +0100 tdf#137081, tdf137082 fixes shape handling in RTL sheets Change-Id: Ife720a0ccbff0029ace822d246dc227e01846734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 8aea35ec4f19419b714879eb09fc6658fd3eeb1f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177550 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 80e8af250e81b28feba698569ff8db4d805c4c9a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177656 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10crashtesting: failure to import rtf output of forum-en-44797.odtCaolán McNamara
field text ended in \ so next } was escaped Change-Id: I2129f410a1d1c3d507a223c3576f02b78f7aac63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177682 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit cd766522eac08392044b1b0c155001899f52c57b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177688 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10crashtesting: further failure to reload forum-de3-6592.docxCaolán McNamara
git show -w Change-Id: I2963833726779d784bcdfa772e152e65dfde3af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177676 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins (cherry picked from commit a4b9ff56e6141848d3289431f537254e28254bb5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177687 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10m_pDocShell seen as null in SwXTextDocument::getPostItsCaolán McNamara
#2 SwView::GetPostItMgr (this=<error reading variable: Cannot access memory at address 0xc8>) at sw/inc/view.hxx:659 #3 SwXTextDocument::getPostIts(tools::JsonWriter&) () at sw/source/uibase/uno/unotxdoc.cxx:3351 #4 0x00007f6238ac7cc8 in getPostIts (pThis=0x36aa6cb0) at /opt/rh/devtoolset-12/root/usr/include/c++/12/ext/atomicity.h:111 #5 doc_getCommandValues () at desktop/source/lib/init.cxx:6739 #6 0x00000000005863e0 in lok::Document::getCommandValues (pCommand=<optimized out>, this=<optimized out>) at /home/collabora/jenkins/workspace/package_cool_24.04_rpm/rpmbuild/BUILD/coolwsd-24.04.9.2snapshot/bundled/include/LibreOfficeKit/LibreOfficeKit.hxx:492 #7 ChildSession::getCommandValues(StringVector const&) () at kit/ChildSession.cpp:1180 Change-Id: Ib2a3c2e7eb1a108ad969588f6c313cade145e8ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176600 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit c0542a438d91051bcdab1f5bc19ee46c90bd91a7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit e854f1d7a0a3a8bac6429a1dbe80ab2a6973c00a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177526 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit a237eaf581fe63eae36ff9e90a45166d1763f1ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177531 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-12-10mac-sandboxing: also exclude AppleRemote when using --enable-mergelibsChristian Lohmaier
mergelibs have been added to the LibreOfficeMacOSX distro config in e6e22bee153e36989069124e8d1a55d6d6ba433a, but AppleRemote has been disabled in the sandboxing case since 2013 4fe9ef81aa83403bd3b7df555ccbd96cbdfd7c2d "The AppleRemote code is blocked by sandboxing so bypass it in that case" (unclear to me whether fundamentally not working or whether it was disabled to get sandboxing as a whole in a working state quickly, since there was an earlier entitlement for mac.remotecontrols) Change-Id: I8514319b1d9ffa3a993267eaebac0c2ff058740f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177621 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 827fa4cb7bba8dc5f101c6325075d5b54210cd01) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177623 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 1bac856b6081a10397c8511405233ef4d548af4f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177724 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-10Resolves: tdf#164124 Do not trap incomplete date 2021-6/1 as fractionEike Rathke
In fact do not accept anything else than blanks after integer portion for a fraction. Change-Id: I29746bb7cd78ecc6a7810e8841bee748589a36e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177899 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6926c820ceea1a1337a97b0afda95b072027a6ff) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177959 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> (cherry picked from commit da87646c4f407532b41e288f3ddac9f09e42be47) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178018 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-12-10tdf#163325 - Check Lower() frame during ToC previewAndreas Heinisch
Change-Id: Ife0e974d66d5ddbe3c831c64e4da28442e476da4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177234 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins (cherry picked from commit 2145204724049cad1585743c0b980ed2c6561212) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177529 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 2d57e13895703b541b918c0933b7dc5bbe25c300) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177666 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-12-09tdf#119745: Fix touchpad scrolling for Slides and Pages panes.Marc Mondesir
Use fractional lines scrolled to calculate distance to scroll view, instead of jumping forward or backward a full page every call based on sign. Also fixes existing bugs: horizontal pane can scroll too far to right; and snapping pane from vertical to horizontal can break scrolling if view partially scrolled. Change-Id: I0ead4710a296aac26f1cf1a0fc48e6ea403271a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177836 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> (cherry picked from commit 143e89dbf85b13e1acccb76877d774a7fca1b016) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178085 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-12-04Python: upgrade to 3.9.21Xisco Fauli
Downloaded from https://www.python.org/ftp/python/3.9.21/Python-3.9.21.tar.xz Change-Id: I8ef63130b2cbed9a7a9e6686f9c05b06d4d9e4bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177763 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-12-04tdf#162514 i18npool: Handle abbreviations in dictionary breakiteratorJonathan Clark
Restores abbreviation handling to spell checking. Regression from commit 44699b3de37f07090ac6fee1cd97aa76036e9700 "tdf#49885 BreakIterator rule upgrades". Change-Id: I2883f984952aa3e54cfe800590a16c0de74ae0e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177506 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins (cherry picked from commit f4fe6df6aa92573368c3fa0edb9fd03e64d9d059) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177556 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit a6e516fd615004d3025f2ffd696b6c28fa494cb4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177663 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-28bump product version to 24.8.4.1.0+Christian Lohmaier
Change-Id: I0e3f67dac062ce9b6fd35467dc0b22ac0241fc00
2024-11-28Branch libreoffice-24-8-4Christian Lohmaier
This is 'libreoffice-24-8-4' - the stable branch for the 24.8.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 24.8.x release, please use the 'libreoffice-24-8' branch. If you want to build something cool, unstable, and risky, use master.
2024-11-28Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-24-8' to 14ca3ba241258f3ce46fd9b9a1588655529c2494 - update translations for 24.8.4 rc1 and force-fix errors using pocheck Change-Id: I44564a43201a6e77b8cce8ea294f950a3398ae71
2024-11-28crash seen in export of forum-mso-en-2962.doc to rtf and reimportCaolán McNamara
Change-Id: I3813d8ebcb1e678ece2e3c3554bb0ddb7b546b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177491 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-28tdf#157130 undo and track changes not restoring characters (macOS)Noel Grandin
Not sure about the real underlying issue here. In debug mode, we hit this assert. Changing it from an assert to a "do decrement mnEmptyMark if it would become negative" seems to help. Change-Id: Ie23a685552d2f8153b67e18f9c0203ecbaad0ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174905 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 148fa9e9405b143f9fc228d9b5f967cad3139967) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175493 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-28tdf#163876 ignore marked text generated from Command-` eventsPatrick Luby
For some unknown reason, when using the standard macOS French layout, pressing Command-` causes -[NSView interpretKeyEvents:] to temporarily set and unset the marked text. Command-` should only cycle through the application's windows so ignore marked text changes from such key down events. Change-Id: Ifeb4ad637d572b339d7b389466815bb60a4b3120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176652 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins (cherry picked from commit 0c065c5e233044361713c0003dac6294a82a6e6e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176653 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-28tdf#163792 gtk3: Don't always focus combobox when its popup closesMichael Weghorn
Since commit 405cf00e4818886b0d3053d03cfb2e3f3a5e8eb8 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue May 28 11:50:12 2024 +0200 related tdf#160971 gtk3 a11y: Keep new combobox value , closing an (editable) combobox like the font size one in the Writer formatting toolbar resulted in the combobox's entry having focus, while the focus was set to the document before that commit. Make this work as expected (again), by making grabbing the focus conditional in 2 places: 1) In GtkInstanceComboBox::signal_popup_toggled, only set the focus to the GtkEntry of the custom combobox implementation if the child focus is already inside of the combobox. As I understand it, the intended logic is "move focus from the combo box's button to its entry", not "unconditionally grab the focus". This also matches what the gtk4 implementation does. Sync the comment from the gtk4 implementation, which explicitly mentions the case of the font combobox in the toolbar (which behaves the same as the font size one in that regard) where focus should not be grabbed. 2) In GtkComboBox::menu_toggled, only explicitly set focus to the toggle button if the combo box is located inside of a popup. This is the same condition used to grab all keyboard events. The code to do both was introduced in commit 131c1c7da8c567636ca55751e49d24cb6d6c9b9e Date: Sun Nov 21 19:53:47 2021 +0000 Related: tdf#145786 cooperate between our own grabs whose commit message only explicitly mentions grabs for popups. The scenarios described in the commit message still work as expected with GDK_BACKEND=x11. With this in place, focus now moves to the document as expected when clicking on a combobox entry in the popup for the font size combobox in Writer's formatting toolbar, while clicking an entry in any of the comboboxes in e.g. Writer's "Format" -> "Character" dialog's "Font" tab still results in the entry of the combobox getting focus. Change-Id: Ib07b034f8327dab19a2264ae3ed8e20ea918dd89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176713 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 4e770803c63417791cf2e38e27ec85127056b7a5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176730 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-28tdf#163684 gtk3 a11y: Don't use combobox role twice for non-editable oneMichael Weghorn
Since commit 9f078ed7b625e86182d64d5ccfbb410cdd38081c Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue May 7 10:04:16 2024 +0200 tdf#160971 gtk3 a11y: Set role for custom editable combobox Set the combobox a11y role for the box in the .ui file used for the custom gtk3 combobox implementation. With this in place, moving focus to the "Font Name" or another editable combobox in the Writer toolbar now makes Orca announce that one as "editable combobox" rather than just "text". , the combobox a11y role is set for the GtkBox of the custom combobox implementation used for gtk3. That box contains the edit (for editable comboboxes) and the button. While this is needed for editable comboboxes for AT to identify this as a combobox when the edit receives focus (by the fact that the edit's parent has a combobox role), this resulted in Orca no longer announcing the combobox role when the button receives focus for non-editable comboboxes. While the button also has the combobox role, Orca has logic to not announce the role of combobox children. (`SpeechGenerator._should_speak_role` returns `false` for that case [1].) To avoid this problem and make announcement for both, editable and non-editable comboboxes work as expected, no longer set a combobox role for the box in the .ui file, but set it only for the editable combobox in the C++ code. [1] https://gitlab.gnome.org/GNOME/orca/-/blob/78e44c625ef5fb082907ca484230458624d24ee8/src/orca/speech_generator.py#L365-366 Change-Id: Ia3ff00688f47e61d5a98c79f1a256061b2fb18a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175823 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit cf627ab2c8c070a620c81cff1faf7b6f04205255) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175842 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-28Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'libreoffice-24-8' to bad768594be416143c007c52fecb5a26c495f396 - enable help for Tagalog (tl) Change-Id: I0e35015d4d2526ea0d09404140a1ee73ce658350 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177502 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-28Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'libreoffice-24-8' to fce7eb57bb9b4fb063ff2eb7bc44f17a9221c020 - add screenshots and files for Tagalog run through optipng -o7 to reduce the filesize XMLSourceDialog.png as well as the sample files were copied from existing languages Change-Id: Ie40b83f115342832f040a619f057b0ea83dc709d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/177501 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2024-11-28openldap: upgrade to 2.6.9Xisco Fauli
Downloaded from https://www.openldap.org/software/download/OpenLDAP/openldap-release/openldap-2.6.9.tgz Change-Id: Ie26290f4443d92cb9f0801548782c0f10a518984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177401 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit e73b5b0afad2daaafe76b9a201ddcad74560c4d2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177411 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-11-28show extension link on startcenter for macosxsandbox caseChristian Lohmaier
the ShowDonation has already a default value of true via the schema, so it is enough to override it to false for the macosxsandbox case similar to how it is done with the Infobar / using the install:module method Change-Id: I8f1ea6d3530e66806f66f9f2d2fb16ef0276e460 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177333 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit fd2c9abe5229f98e062b7b32994e9e015975ca90) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/177358 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
generated by cgit (git 2.34.1) at 2025-01-05 09:53:44 +0000