Age | Commit message (Collapse) | Author |
|
Change-Id: I5af3c5cc17e838cc9c856d1a24c1a7cd3e350345
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89955
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
regression from
commit 52fece12345161911da2a531213b7d5541192aad
Date: Wed Jan 15 12:43:19 2020 +0200
tweak GetBitmap methods in BitmapEx
we end up self-assigning, and with a little bit of optimisation, we can
up overwriting parts of the graphic we need to construct the new
graphic.
Change-Id: Ie7e9ce3f9a69f1fe954079873c206985b81db68a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89954
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The property "PreviewSizeHint" and the enum value ForPreview in
GraphicFilterImportFlags doesn't seem to be used from outside, so
let's remove it as it simplifies the PNG and JPEG import filters.
It is generally more recommended to load the bitmap file fully and
only then resize it to a smaller (preview) size.
Change-Id: I97f333686c25f7a7a4bdf6c6f0885154b515fd3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89932
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Only have an impact on PNG anyway, and it's not really clear in
what way. I don't really find any references where this is set.
Change-Id: I49519f2116bb0d90648910acddd6176261398c6c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89931
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Doesn't seem to be used and we always want to creat a native link
anyway.
Change-Id: I2e50093491b771bb251816525cf492cf030bc496
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89930
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
typically ok and accept the dialog. alt+down is documented as the
default menu-activate key binding, space will also work to popup
the menu from a combobox.
Change-Id: I7bec880670cc006b288996d6f59a88fe9a9fb8cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89950
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I4915bc5ecf854e8ac76748f3af204b0eab5d2ff8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89952
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
[MS-OSHARED] 2.2.1.3 MSONFC says msonfcArabicLZ / 0x16 should be used
for this.
Change-Id: I6bdf460d77acabf54cecc2ec2d2bca91bc814518
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89951
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
GetContext is a very generic method name, so rename it to a more
specific GetReaderContext name. It is easier to find references.
Change-Id: Ieb05ac63080598357107dc3e485b481910cd79cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89929
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I484cc39ebde5bfefa8ea26f3e6351ef12e303f1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89755
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
The problem is that the code that adjusts pLastNode in
SwContentNode::DelFrames() assumes that the nodes are deleted forward
but MoveNode() runs backward so the only solution is to put pLastNode
temporarily onto some node without checking if it has been fully
deleted, while skipping over tables and sections.
At the end of MoveNode() it must be on a valid (not fully deleted) node
again.
(regression from b86ff2c6a88aa41379e74f11e8ec8497ff85ffd0)
Change-Id: If54c01f885e0c040aed9068823deae7dd167fd50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89896
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
|
|
DOCX uses <w:numFmt w:val="decimalZero"/> for this.
Change-Id: I12a4a88f472af42a04244d30f9e59fc0b8b4855c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89945
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
E.g., trying to open time control properties in test file in
https://gerrit.libreoffice.org/c/core/+/89895
See commit b9d6ea1dd7541c4bd866571f9e3f0aa894687c07 for explanation
Change-Id: Icfa5d940cd595937e3bc83c752719d76d55d4081
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89944
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ifa29416c4a716b3759f279ae4f0ce9179325f7a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89927
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
And then remove the manual measuring from the RTF import.
Sample output:
comphelper::ProfileZone: RtfFilter::filter finished in 180 ms
Change-Id: I85e2e12d82ff491a2991a41e5a6f6d1410e12363
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89905
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
See https://bugs.documentfoundation.org/show_bug.cgi?id=131044#c0
for a scenario
Change-Id: Ie247b6441df91e6831cfa18e66771af5d070dad8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89933
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8d063fc432506fd620e99f561bca37c3dfb5a01e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89934
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: I7168701de59f4b625f1ca5bb2fc9d06f521c681d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89935
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Id8b8e8d1676260d4a075166156c60965242c9fd5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89936
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
For more info and discusson please have a look
at the task. It reverts the change from tdf#99680
which did a wrong paradigm change in how clip in
Region(s) is defined and tries to fix the
underlying error in a more correct way.
This includes problems noted in tdf#44388 and
tdf#113449.
This is a decent improvement, but - due to dealing
with numerical problems - not yet the whole healing.
Still thinking about how to solve this for good.
Adapted PdfExportTest::testTdf99680() and
PdfExportTest::testTdf99680_2() as needed, empty
clip regions are allowed again. Added comments, too.
Had to change solvePolygonOperationAnd to work
on ranges if both inputs *are* ranges. The AND-case
is then completely solvable. Also increased geometry
for transformations of clip geometries - may help
later.
Change-Id: I2370447597faa6efb81d58ee31c63654e304262e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89874
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I27c9fb174255f52305452ce8ff0ed5ecb576a771
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89903
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
Change-Id: I2db9729620ab87c8934fa26a63f31c6a95e5a4fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89894
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
Change-Id: I79230d50083a1ddb1543f4cee54f1c489aa246bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89893
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
|
|
Change-Id: Idd102b386c19ed699761428b3347f438a42a1878
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89898
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I003dd9e82e7ee5924064e34306de1abed8cdf4ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89899
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
- add colon to Character label with buddy control
- add tooltips to arrows in Edit Footnote/endnote
Change-Id: I5baf59fffd39771101ff0b40105ffcecc7489aec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89580
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
|
|
Change-Id: I26dda20f0a1e51cc4ea820f9814a978e23ba9b96
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89892
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Orientation here clashes with Orientation in include/vcl/prntypes.hxx
Change-Id: Ib68dec61990aebad6154eb2f5e00eb8680ebe196
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89888
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I201b195438ef3df067cfa6db97c3b37b23061142
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89887
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
ODF allows any string as style:num-format="...", go with "01, 02, 03,
...", because that seems to be consistent with both
DefaultNumberingProvider::makeNumberingIdentifier()'s fallback mechanism
and with OOXML (which uses "001, 002, 003, ..." for the "pad to 3"
case).
Change-Id: I5c5c7ee5bd61175afc3e682276e69344852106d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89891
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
We don't use MULTIPLE_THREADS for that to avoid performance
penalty due to locking and memory allocation.
Use dtoa.cxx stub to compile dtoa.c as C++, to allow using
thread_local keyword in MSVC, which still implements pre-C99.
Also don't expose dtoa() and other symbols - make them static.
And define IEEE_MC68k, not IEEE_8087 on big endian platforms.
Change-Id: Ie59fe0cf057b043556a5ac15ec6b11a1a5b41f47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89629
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I1f4396eea206e2a8852a96e793be1f179ae837b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89773
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
...and auto superscript too (although not as noticably).
THIS WILL CHANGE THE POSITION OF EDITENG SUBSCRIPTS
AND SUPERSCRIPTS IN EXISTING DOCUMENTS!
That is because they were very poorly placed
before - using a formula that is very different
from how Writer does it. Everyone in the bug reports
indicates that Writer does it good, but Impress
does it really bad. (tdf#89849, tdf#63083)
FOR EXAMPLE, when the char-size is reduced to
the default OF 58%, it will now be raised by 33%, not 42%.
Likewise, the subscript will now be lowered by 8%, not 42%.
THIS AFFECTS/FIXES Writer textboxes, Calc, Draw/Impress.
"Automatic" indicates that there is not a
"correct" answer, but that the computer should make
it "look good", so the user should be able to accept
this change in positioning, as long as it looks good.
The number of documents affected might be less than
one would expect. By default .uno:SuperScript
does NOT set auto mode (although Format-Character does).
Since most people would use the toolbar instead of the
format menu to create a superscript, auto will be rare.
So there will be relatively few cases where
subscripts are automatic in editeng, especially since
it looks so poor that most people probably turned
automatic off...
This patch has no effect on non-automatic escapement.
It uses the same fomula that calculated DFLT_ESC_SUB
(since it isn't an arbitrarily chosen value).
This is an approximation of the formula that Writer
uses (since Writer does exact calculations based
on each font's metrics).
This Writer-inspired formula was introduced in LO 6.4
for more accurate exporting to MSO
word processing formats (tdf#127316).
Change-Id: I0267810efe31a2b3be41bf2d39e2278ce9bc99e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88911
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
This ignores the *_DONTKNOW and _FORCE_EQUAL_SIZE values, except
for the stretch, where we map DONTKNOW to QFont::AnyStretch.
Change-Id: Ifdf55e798566681852ad4b585f4aeb0ebfbd1cf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89884
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Glow effect is a color-blurred outline outside of the shape. In ooxml
document it is specified with the <a:glow> element.
The commit contains the following:
- Add support for importing and exporting <a:glow> from ooxml documents.
- Assign new properties to XShape which stores glow-related attributes.
- A new 2D primitive is introduced in module 'drawinglayer' which is
responsible for representing the glow primitive which is to be rendered.
+ A glow primitive is a clone of the original shape which has been
scaled up slightly and a new color has been assigned to it. The
radius of the glow effect and the color is defined in the <a:glow>
element being imported.
- A blur algorithm is introduced in module 'vcl', which is called during
rendering the primitive.
+ The blur algorithm works on a bitmap.
+ Since the algorithm is CPU-intensive, the result is cached in the
processor and it is recalculated only if needed.
- Add support for importing and exporting glow effect to ODF format. For
that, new attributes of element <style:graphic-properties> has been
added:
+ loext:glow, which can have the values "visible" or "hidden"
+ loext:glow-radius: which holds the radius of the glow effect in cm.
+ loext:glow-color: holds the color of the glow effect
- Tests have been added to assert properties after pptx import and
export.
Change-Id: I836aeb5e0f24e2c8d5725834c8c0f98083bc82e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89125
Tested-by: Jenkins
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
|
|
there isn't a --with-system-dtoa option so add an explicit patch
Change-Id: I6ae00fefd3352b1501da3e94e108d3183f951907
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89870
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3fd06ddf1548c1d6b5d8e91db944d2c720040718
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89873
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
The validator cmdline is fairly nontrivial, log it so that in case it
fails, one can invoke it manually without having to hunt down the string
in a debugger.
Change-Id: Id18c6d67f1b3b78da31e8be8c60f703623b80309
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89875
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Follow-up of the following commits related to the new UNO property
DeletedLegendEntries for pie charts:
commit a96ec04a07c35338f5f9a0cb361b9322e5ca9cec
(tdf#130225 implement ODF export of deleted legend entries of pie
charts)
commit 86be3422cd55fa9e44104f1628648061bb6a3495
(tdf#129857 Chart OOXML export: fix deleted legend entries)
commit 6e847aa817999ab18acd534f9e6a86685bb268fc
(tdf#129859 XLSX import: don't show deleted legend entries)
Change-Id: I8b13823da745dfbfbf20f1d30f742c4baf803fc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89456
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I87ebc1d7e095f465c76fcd9b76c01749fe6b57df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89871
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I026f920d475c4ce56a12d6b29a702673e8bd7a1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89866
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
by limiting paragraph-level character property expansion
for the whole table paragraph based on all text portions.
Follow-up of commit abb9c7db8bcc06f907d39a7811711882161d5803
(tdf#130494: DOCX import: limit paragraph-level character property)
regression from 2ab481b038b62b1ff576ac4d49d03c1798cd7f84
(tdf#90069 DOCX: fix character style of new table rows)
Change-Id: I4d14fd30c9fbc8464c2430726faf16e292f24e38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89848
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: Ic718fbd4063c961555997014702e16ab4bf42a54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89834
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
|
|
- Remove links.txt duplicate contents
- Update icons in Insert Hyperlink dialog
Change-Id: Ibddba73ea989c4cf996eefbdca3d8704e3c83700
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89863
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
|
|
...where $(PYTHON) is undefined, but which was mostly masked by
solenv/bin/gentoken.py happening to have a shebang line, except for flatpak
builds now failing with
> /usr/bin/env: ‘python’: No such file or directory
> make[1]: *** [/run/build/libreoffice/editeng/CustomTarget_generated.mk:18: /run/build/libreoffice/workdir/CustomTarget/editeng/generated/tokens.gperf] Error 127
(See also discussion in the comments of
<https://gerrit.libreoffice.org/c/core/+/89262> "Convert gentoken from Perl to
Python.")
Change-Id: Iebdf98d7b7ee4da9d861231064549ffef5445edc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89828
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...in a way that hopefully works for each of our "any Python >= 2.7 used during
the build" scenarios (thanks to vmiklos for suggesting the actual changes to
gentoken.py). This is a necessary prerequisite for
<https://gerrit.libreoffice.org/c/core/+/89828> "Fix call of Python", which
would otherwise on Windows generate *.gperf files with DOS-style line ends, but
where the Cygwin gperf expects them to have Unix-style line ends and fails with
> C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/editeng/generated/tokens.gperf:9: warning: junk after %% is ignored
> unsupported language option C++
> , defaulting to ANSI-C
> C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/editeng/generated/tokens.gperf:2: junk after declaration
> make[1]: *** [C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/editeng/CustomTarget_generated.mk:22: C:/cygwin/home/tdf/lode/jenkins/workspace/gerrit_windows/workdir/CustomTarget/editeng/generated/tokens.cxx] Error 1
(<https://ci.libreoffice.org/job/gerrit_windows/58956/console>)
Change-Id: I0cc420e4f8342225bd01ee326b1e517fdc57005e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89865
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
lcl_formatArabicZero() looks a bit over-complicated with its hardcoded
limit of 2. Word supports limits of 3, 4 and 5 as well, so prepare for
handling them in a generic way.
Change-Id: If6e5634b11616f0ac05e1387016e22f4b171bbfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89864
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Iad22a84820056f05a3aae6d68f008fe904c56ffa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89750
Tested-by: Jenkins
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I83d690715a9e427d23b3f2316fd114c037487d54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89841
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia9f5f02a0993c3b28ca5fecef3ce6333ba85806b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89823
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|