summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-04-04jsdialog: send full update when shown not when createdSzymon Kłos
Change-Id: I02cb63b57960c1d7425fe97c341eaf24f216c3a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149496 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150013 Tested-by: Jenkins
2023-04-04jsdialog: dump label relation between widgetsSzymon Kłos
Change-Id: I625346049b866d9f231bba461f40b671f4959e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149717 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150012
2023-04-04Resolves tdf#154446 - Remove redundant option for grid line colorHeiko Tietze
Change-Id: I41d39b763e651f90660f2a451ed0a9b473ead206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149715 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-04-04jsdialog: enable missing chart related dialogsSzymon Kłos
Change-Id: Ia33980d3536b3a52a24161e789f04ee4de75f2e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149540 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149999
2023-04-04jsdialog: update drawing area when resizedSzymon Kłos
Change-Id: I429a5d750fc84b42d0d399cf3833f22e7479cfe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149455 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149998 Tested-by: Jenkins
2023-04-04resave with latest gladeCaolán McNamara
Change-Id: Ida60773e87cc607de6763fb6676aad83c316e8b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150000 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-04tdf#41652: Variable width NBSPVojtěch Doležal
Adds a flag that when enabled (opt-in for both old and new documents) changes behaviour of NBSP to not be strictly fixed width. This commit also implements this behaviour such that NBSP has always the width of a standard space (0x20) on the given line. This change is only noticeable when the paragraph is justified. Lastly a tilde or a degree character is now shown in place of NBSP when nonprintable characters are enabled, since the gray field alone is not visible in many circumstances. Change-Id: Iabb30b5930ced62691cc4304f60c5e6dc886ed61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149576 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-04Fix typo in codeAndrea Gelmini
Change-Id: I9386ce811885e46ffedfc5bd8cc05007ddf75f10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149968 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-04sw: document at-char vs as-char layout framesMiklos Vajna
"bound to a character" is a bit misleading for as-char. Change-Id: I0c322c88f81bf96c7b4818598cfbef4fc7f4baea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149996 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-04Update git submodulesIlmari Lauhakangas
* Update dictionaries from branch 'master' to ff606081bb42acb96611ff232f5606dd76f411bf - tdf#154459 Improve grammar for hlp_ellipsis Change-Id: Ia488470069a9a4818dd3152250cc053842d161a2 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/150006 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-04-04Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 17ff420d14f2d7289bcee4ce7c652b4dfeb5a4d9 - add missing < to embedvar Change-Id: Ief1b8c7f78f6756d178c70d27020f6b483abfb24 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149977 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-04-03Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 1964fcaee6441a576976a8730287ebd955f9128e - Proofread and add missing markup Change-Id: I1269d775307dcc5ad022d5d99f640bfb778386fa Reviewed-on: https://gerrit.libreoffice.org/c/help/+/150001 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03Hyphenate this compound adjectiveAdolfo Jayme Barrientos
Change-Id: I7e19c90fd0106f59398205579d7b5d60cbf4a07e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149945 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-03Resolves: tdf#154582 Obtain English DisplayName before CompatibilityNameEike Rathke
... for Add-Ins from configuration. Change-Id: If13d692ca7550e69d2f6e3ff72747d17aee3e7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149995 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-04-03jsdialog: enable impress format dialogsSzymon Kłos
Change-Id: If7bcdf7afdf6e272e47531c2b2b0b75046c561a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149425 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149965 Tested-by: Jenkins
2023-04-03jsdialog: enable slide properties dialogSzymon Kłos
Change-Id: I5c6b0c24a049a2368dbe084bcfffc4f777d88625 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149423 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149964 Tested-by: Jenkins
2023-04-03set a parent for embedded object warning dialogCaolán McNamara
calc does a lot of "CaptureMouse" which then leads to a lot of "ReleaseMouse", I'm somewhat unconvinced that there should be any CaptureMouse calls in there. Change-Id: I7c44d2c36c89a5c32c525d65939723da9be77a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149973 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03tdf#152257 popup already launched, don't relaunchCaolán McNamara
Change-Id: I2503803b756fed179f6aa62cee2c549b6bc7c3c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03Fix typoAndrea Gelmini
Change-Id: I49fe9dbdc11291c02be1dd5e41171a987d896008 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149997 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-03Fix typoAndrea Gelmini
Change-Id: I5f5d819f5068869d78bd52f820a24d1d9702f6ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149967 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-03tdf#124525: sc_subsequent_filters_test4: Add unittestXisco Fauli
Change-Id: I16321c8e22a205d211536b189191db453ebf1ce9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149956 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03MCGR: Unify Gradient intensity handling in toolingArmin Le Grand (allotropia)
Moved the Gradient intensity handling to tooling since it is also needed for TransparencyGradients. Added missing use of GradientStepCount for transparency. Change-Id: I63ae6683fa0131be7faadc8572e19f5c43bf27e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149957 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-04-03Ensure valid SdrItemPool for drawing stylesMaxim Monastirsky
... when pasting cells as OLE object. Problem caught by UBSAN build with UITest_conditional_format UITEST_TEST_NAME=tdf117899.Tdf117899.test_tdf117899: /sc/source/core/data/stlsheet.cxx:238:53: runtime error: reference binding to null pointer of type 'SfxItemPool' #0 0x7f9cb1ef60ce in ScStyleSheet::GetItemSet() /sc/source/core/data/stlsheet.cxx:231:28 #1 0x7f9cb1ed52e3 in ScStyleSheetPool::CopyStyleFrom(SfxStyleSheetBasePool*, rtl::OUString const&, SfxStyleFamily, bool) /sc/source/core/data/stlpool.cxx:144:40 #2 0x7f9cb1ed9285 in ScStyleSheetPool::CopyStdStylesFrom(ScStyleSheetPool*) /sc/source/core/data/stlpool.cxx:223:5 #3 0x7f9cb0e25d51 in ScDocument::CopyStdStylesFrom(ScDocument const&) /sc/source/core/data/documen8.cxx:292:35 #4 0x7f9cb4602d7c in ScTransferObj::InitDocShell(bool) /sc/source/ui/app/transobj.cxx:683:14 ScStyleSheetPool::CopyStdStylesFrom wants to create/update the default drawing style, but in case the source clipdoc didn't have shapes - without creating ScDrawLayer first, which means no SdrItemPool exists. Fix that by creating ScDrawLayer unconditionally, as we attempt to do this later on anyway. Regression of commit 685a864cfc40227559ed55f6273fd118174e8e6e ("sc drawstyles: Clipboard support"). Change-Id: I3def9860ab4f11c70c120f5324a60adf63056a7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149966 Tested-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-04-03tdf#153806 a11y: Allow opening context menu in special char dlg using keyboardMichael Weghorn
Open the context menu for the `CommandEventId::ContextMenu` command for the character table that is used in the special characters dialog, so opening the context menu is not only possible by right mouse click, but also using the keyboard (by pressing the context menu button or Shift+F10). Move the handling for the case where the context menu is activated using the mouse from `SvxShowCharSet::MouseButtonDown` to `SvxShowCharSet::Command`. When the context menu is activated using the keyboard, use the centre of the currently selected item for the context menu position. Adding support for opening the context menu for the recently used and favorite characters further down in the special characters dialog is independent of this and would have to be added separately. Change-Id: I55ef43708b95f5a90b06777a8aeb32a64609160d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149927 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03Pass special char dlg context menu pos as param, drop memberMichael Weghorn
The `maPosition` member was only used for the position of the context menu. It was set before calling `SvxShowCharSet::createContextMenu` and then only used in there. Pass the position directly as a parameter instead and drop the extra member. Change-Id: I7ba9ec60ffb993ca1269d86efeddbe0950ed7fbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149926 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03tdf#153806 a11y: Insert special char + close dialog on return keyMichael Weghorn
As discussed in tdf#153806, insert the currently selected character from the special characters dialog and close the dialog when the return key is pressed on the table of characters (either showing all characters or just the search result). Something similar should probably be done when the return key is pressed with one of the recent characters or favorite characters in the dialog having focus, but that needs to be handled separately, possibly along with the other remaining suggestions to improve keyboard handling in the special characters dialog as discussed in tdf#153806. Change-Id: Iccc19e4808ddf6f15c32710f9bea931e46b046bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149920 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03tdf#153806 a11y: Improve keyboard interaction in special char dialogMichael Weghorn
Make interacting with the "Special Characters" dialog using the keyboard more intuitive and consistent: * Call the selection handler (that changes the "OK" button to be sensitive) when a new entry is selected, as happens e.g. when tabbing into the table of characters, at which point the currently focused character is already considered selected (as e.g. indicated by the fact that other UI elements in the dialog are already updated according to that selection). This previously required pressing the space key (or moving back and forth using the arrow keys) for no apparent reason. * When a character in the character table is selected, insert it into the document when pressing the space key, as happens when double-clicking the entry using the mouse. Insertion using the space key already works for the characters in the "Recent Characters" and "Favorite Characters" sections below the table, so this also makes the behavior more consistent within the dialog. Change-Id: I35072f565b26d1f6c12c7dc8b7c6592f6a985a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147657 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03tdf#153806 cui: Deduplicate code for special char dialog handlersMichael Weghorn
Various handlers for `m_xShowSet` and `m_xSearchSet` are the same, except that they operate on the different objects. However, since a pointer to the `SvxShowCharSet`/`SvxSearchCharSet` is passed as an argument to the handler, use that and reuse the existing handlers instead of duplicating them. Also extract a `SvxCharacterMap::insertSelectedCharacter` method from the `CharDoubleClickHdl`, since that will be reused elsewhere in a follow-up commit for tdf#153806. Change-Id: I14e8e7fd7add33f86fa0246c65927ceb88bb7899 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149919 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-04-03Optimize a bitMike Kaganski
Change-Id: I5a2c37e4ff1e19cfbc29e1e61b025f44d067b95a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149893 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-03add CVE-2017-18013 test caseCaolán McNamara
Change-Id: I43324a4159a0562a87594662a634fae91b216055 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03move to libwebp 1.3.0 releaseCaolán McNamara
Change-Id: I88205be86e15d9878040958b96dc30043d9eb0b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-03Simplify JsonWriter a bitMike Kaganski
Change-Id: I0ca4a0fcf4f19bc26ae931bae0b2ee53db47f12c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149951 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-03tdf#146312 - Chapter numbering dialog: show paragraph style [None] in previewAndreas Heinisch
Change-Id: Icb576df2f0de255aba9fdfddad81b654a48c6c36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149948 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-03Fix rtl_(u)str_valueOfBoolean return value documentationMike Kaganski
The reported numbers are factually wrong. See rtl::str::valueOfBoolean, and back to commit cb6ab44fbef0a71984a15766d5ad7dcbe0a82a10 (template implementation for String/UString, 2001-03-16) that introduced the actual return values. Change-Id: Ib692ee7164be31bde3d884823a77e6452dbf9cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149890 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-04-03tdf#89920 - Handle embedded newline in Calc's search cellAndreas Heinisch
Update short-circuited boolean expression so the least expensive subexpressions will be executed first Change-Id: I8c924e00e8de809f3e6df2828f8537185e71c18c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149891 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-03jsdialog: keep button under content in SpellCheck OptionsSzymon Kłos
Change-Id: I75b1424fe688f975b88634d6355cd0311fc07057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149227 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149825 Tested-by: Jenkins
2023-04-03jsdialog: enable spelling options dialogSzymon Kłos
and make it async Change-Id: Idbf8661aa106d69e60ab6037052fd3d6dec28c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149205 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149824 Tested-by: Jenkins
2023-04-03Fix heap-use-after-freeStephan Bergmann
...seen with CppunitTest_desktop_lib CPPUNIT_TEST_NAME=DesktopLOKTest::testControlState after 116b9d6ddf2b61186b29f0370234eec9c1bbe306 "Avoid conversions between OUString and OString in VCL", > ==883385==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000937904 at pc 0x7fe40a2ef6ad bp 0x7fff0a077390 sp 0x7fff0a077388 > READ of size 4 at 0x603000937904 thread T0 > #0 in rtl::OUString::equalsAsciiL(char const*, int) const at include/rtl/ustring.hxx:1279:21 > #1 in rtl::libreoffice_internal::ConstCharArrayDetector<char const [11], bool>::Type rtl::operator==<char const [11]>(rtl::OUString const&, char const (&) [11]) at include/rtl/ustring.hxx:1815:24 > #2 in JSDialogNotifyIdle::Invoke() at vcl/jsdialog/jsdialogbuilder.cxx:283:27 > #3 in JSDialogSender::flush() at vcl/inc/jsdialog/jsdialogbuilder.hxx:172:34 > #4 in JSDialogSender::sendClose() at vcl/jsdialog/jsdialogbuilder.cxx:345:5 > #5 in JSDialogSender::~JSDialogSender() at vcl/jsdialog/jsdialogbuilder.cxx:320:5 > #6 in JSInstanceBuilder::~JSInstanceBuilder() at vcl/jsdialog/jsdialogbuilder.cxx:706:1 > 0x603000937904 is located 4 bytes inside of 24-byte region [0x603000937900,0x603000937918) > freed by thread T0 here: > #0 in free at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:52:3 (workdir/LinkTarget/Executable/cppunittester +0x139452) > #1 in void rtl::str::release<_rtl_uString>(_rtl_uString*) at sal/rtl/strtmpl.hxx:875:9 > #2 in rtl_uString_release at sal/rtl/ustring.cxx:1204:12 > #3 in rtl::OUString::~OUString() at include/rtl/ustring.hxx:546:13 > #4 in JSInstanceBuilder::~JSInstanceBuilder() at vcl/jsdialog/jsdialogbuilder.cxx:706:1 Change-Id: Ib95b4d16c7a7d74ad989716e7829de775ed0de8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149954 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-03tdf#143148: Use pragma once instead of include guardsjpuronah
Change-Id: I8369e0bdb6a01838d87e7cddc1cbaed911fe461a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149952 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-04-03sw floattable: fix removal of empty master flys on master table removalMiklos Vajna
The bugdoc has 2 pages, a floating table covering both pages, row 1 on page 1, row 2 on page 2. Once row 1 was deleted, the text around row 2 moved up to page 1, but row 2 remained on page 2, which is unexpected. What happened is that we correctly deleted the fly of row 1, even moved the text of the anchor on page 2 to page 1, but nobody moved the fly of row 2 to page 1, which is inconsistent. Fix the problem by invalidating the position of the follow in SwFlyAtContentFrame::DelEmpty(), since deleting a master fly potentially creates space for follows, so they can move up. This helps in the 2-page case, the case with more than 2 pages still needs work. Change-Id: Ida9cc1d586963867e8fc7ee92d4b3f5dfafd3579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149947 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-03xmloff: prefix members of XMLTextParagraphExportMiklos Vajna
See tdf#94879 for motivation. Change-Id: I894665f1af47cf1e5f0f191bfdf3100e426fa6d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149946 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-04-03BinaryDataContainer: pure re-factor to encapsulate stream copying.Michael Meeks
Change-Id: Iab24e8d18bf7badbca672fbdbf455f78d08f41a0 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149905 Tested-by: Jenkins
2023-04-03tdf#89920 - Handle embedded newline in Calc's search cellAndreas Heinisch
If the replaced string contains a newline after find and replace, insert an edit cell in order to handle an embedded line correctly regardless of the content in the source cell. Change-Id: Ic8a5fc80b85546897572a228511b319cd5a8b9aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148752 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-04-03Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 5041e95a2e3804ded772be4b6d6a3d6d7f9e5039 - tdf#153499 add new section title and missing options; corrections to "Level" and navigation + add "Update entry from selection" option, with icon table + add icon table for "New User-defined Index" + add new "From Selected Entry" section title and explain the purpose of the section - remove "Selection" section title, and modify heading levels * update "Level" -> "Index level" and correction to explanation * corrections to navigation button labels, and icons * correction to description for "Next entry (same name)" and "Previous entry (same name)" * order options according to dialog Change-Id: I937eb727f303b3e4990de117f962eecc30bc0194 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149594 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-04-02tdf#154545 sw Navigator: select & track nested bookmarksLászló Németh
After selecting a nested bookmark in the Navigator with double click or Enter, the selected item changed to the item of the main bookmark in the tree list. This jumping was very annoying especially with multiple nested bookmarks inside the same bookmark. Navigator didn't track nested bookmarks, i.e. it always showed the main bookmark instead of the actual nested one under the text cursor. Change-Id: Ic3f1e8321454d4ad892708e76c001da6eca30cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149915 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2023-04-02make some methods final in chart OPropertySetNoel Grandin
so that the subclasses use the right overrides to implement custom behaviour Change-Id: Ida9d1de51b5595c4d9532a5c98a220bf39d9a208 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-02cid#1524674 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia32ed66c35f7d32b626e0bf719269ae8f45241c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149938 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-04-02map->unordered_map in chart OPropertySetNoel Grandin
no need for ordering here Change-Id: I7e0928284c98aca297d4452e65efd8a4f3b1e56d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149941 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-02remove IEventNotificationHook from comphelper::OPropertySetNoel Grandin
this class is a copy of cppuhelper::OPropertySet, and this feature is unused in that class too, so we are not likely to need it Change-Id: I9e3f0f7d786052f87f5a18c67e9b78409752fd99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-02Avoid conversions between OUString and OString in VCLMike Kaganski
Standardize on OUString, which is the main internal string class. Convert from/to OUString only when communicating with respective external APIs. Removes about 200 conversions from the code. Change-Id: I96ecee7c6fd271bb76639220e96d69d2964bed26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149930 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-07 18:32:48 +0000