summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-11-04loplugin:stringconstantNoel Grandin
Change-Id: I9d3b60bb9f0d8c09968e2be1035fb8e654ac9c95 Reviewed-on: https://gerrit.libreoffice.org/19769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-04loplugin:stringconstantNoel Grandin
Change-Id: I6cc11a273902da8acdb6adbccccc31fe30ab274e Reviewed-on: https://gerrit.libreoffice.org/19768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-04Clean up osl_getSystemPathFromFileURL implementationStephan Bergmann
Change-Id: I2daa355c4a46c4edc73c30185f2b31852351c45f
2015-11-04Don't dereference null pointerStephan Bergmann
Change-Id: If35672fae14541d5aa5f28e117bd63b69013d418
2015-11-04Tweak MenuBarManager a bit for use with context menusMaxim Monastirsky
Change-Id: Ie28277e692d3b3286f1961e66f90b5ae59810fe7
2015-11-03loplugin:simplifyboolStephan Bergmann
Change-Id: I7fdcc939154ca6804707039c3311728a0249dec7
2015-11-03-Werror,-Wformat-securityStephan Bergmann
Change-Id: I23f4b906456fdba84f2772a4ed15ac6c141a094d
2015-11-03get-bugzilla-attachments: RSS query doesn't work with '+' characterXisco Fauli
eg. image/xml+svg Change-Id: I1b6b6f71d02fa415c3470faadbe8d316aaf0f677 Reviewed-on: https://gerrit.libreoffice.org/19761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-03Support of popupmenu resource typeMaxim Monastirsky
Reusing the same xml format as the menubar, except that a popup menu use menu:menupopup as the root element. Change-Id: I2987af0dc698b09aeeb757cff828617515bc3009
2015-11-03tdf#81144 Chinese full-width punctuation does not align properlyMark Hung
Ideographic fullstop and comma in most Chinese fonts are centered, while those in Japanese fonts align closer to the left. Original compression algorithm trimed right side of the punctuation, making fullwidth fullstop or comma in Chinese font visually unbalanced. In worst case, it crowds together with the followed compressed punctuation. This patch fix the situation in the folowing way 1) make compression less stronger. 2) Trim space according to glyph bearing to font height ratio. 3) fix a memory access violation issue Change-Id: Icff215064e6c442fd36eac8e01b01fb6acb27594 Reviewed-on: https://gerrit.libreoffice.org/19517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-11-03dynamic_cast fixed againOliver Specht
changes commit 5ae015fc74330ac4c24b67370c59518084f1d201 to check the SvxFieldItem Change-Id: I2c327a0a16fdd3e9341365554e10fb6fe04e1efe Reviewed-on: https://gerrit.libreoffice.org/19757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-03vcl: Prefer std::abs to a home-brewed macroTakeshi Abe
The arguments in use are of type sal_Int16, so now it's the overloaded one of type int in <cstdlib>. Change-Id: I83336c093cf58a351e9390c0eb4e20a5d5340f9e Reviewed-on: https://gerrit.libreoffice.org/19754 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-03lok: Fix crash due to non-initialized callback.Jan Holesovsky
Yay for unit tests! :-) Change-Id: I06b3f929b53d5c03f5722acfdaf0eaf841325e34
2015-11-03lok: Unit test for LOK_CALLBACK_UNO_COMMAND_RESULT.Jan Holesovsky
Change-Id: I917d47478504dc6fafd3fc675fe8458690c7cc2a
2015-11-03sc lok: avoid placeholder row when providing all headersMiklos Vajna
In case the logic visible area is known, info is provided only about the visible headers. Given that only relative sizes (no absolute positions) are provided, a placeholder row/col is added to the result that contains the total size of the skipped items. These placeholder items are not needed when providing all headers, so don't emit them. Change-Id: I48ccb73554313f4d2bb420e4402995719b0f9f7d
2015-11-03-Werror,-Wformat-securityStephan Bergmann
Change-Id: I34976a4900a73505a91d3e58736675ab39ad174c
2015-11-03sc lok: allow requesting column headers only for a logic areaMiklos Vajna
Change-Id: Iacd8f11917e929c6a1579c6a1553eb7840df5fba
2015-11-03sc lok: allow requesting row headers only for a logic areaMiklos Vajna
So that for large documents it's not needed to query all of them on load, but (similar to tiled rendering itself) it's possible to query the data that affects the visible area. One catch is that the row sizes are relative, so there is a placeholder row in case the visible area is not the top left corner, and constructing its size needs special care. Normally the handed out twip values have to be floored after twip->px conversion, but this one is already rounded (as the total is a sum of px values, again becase of the previous floor rule), so need to play the +0.5 trick to allow clients always just flooring the logic conversion result they get. Change-Id: I64a155582acdee7b2acc741d77a2c462409b91a8
2015-11-03ScGlobal::UpdatePPT: make conversion more preciseMiklos Vajna
Old situation was (96 DPI, 100% zoom): 0.06669 factor, 1088 pixels, result is 16311 twips (1087.4 pixels). New situation is: 0.066669 factor, 1088 pixels, result is 16319 twips (1087.93 pixels). Change-Id: I0ff11520fd719aefd2b351a6d4ef949d66b66282
2015-11-03Bin a few pointless variablesTor Lillqvist
Change-Id: I5198163e43b17786d3646cf398ec1b8e6ab1b438
2015-11-03read past end of pCellInfoCaolán McNamara
Change-Id: Ic024f8dd3aaf368877f5914c6106164508760da8 Reviewed-on: https://gerrit.libreoffice.org/19752 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2015-11-03Use newly introduced gb_DEBUGINFO_FLAGS instead of hardcoded -gStephan Bergmann
Change-Id: Iaaa80d997fa7babb9212787653c149b72d842a6c
2015-11-03CPP_LIBRARY has never been used outside configure.acStephan Bergmann
...ever since its introduction with f5aa04485c86a5753bd7af057b86336efe089fae "Enable optionally using libc++ on OS X (when targeting 10.7 or later)" Change-Id: I26ece69d7a00c7452cd027928c318bbf31d6284b
2015-11-03build fix?Stephan Bergmann
Change-Id: Icb48acfdba90b95ae55d2f4b9f05871dc3a8732b
2015-11-03desktop: minimal Android build fixMiklos Vajna
Change-Id: Icb9a40c5ded676ff3f8f7db198a90bb94540bdf4
2015-11-03implement assignment in only one placeEike Rathke
... and comment on what to do if we really wanted a copy-swap-idiom. The need to doc comment about not to use assign() after default ctor is also gone with the temporary swap. Change-Id: I2a49091b2a41cf155e912e3c373dbbe81c7f9737
2015-11-03remove superfluous call to clear() in ScRefCellValue dtorEike Rathke
Change-Id: Iea7788f985e2c5dc7a96eab711bf7d13732ab86e
2015-11-03lok: Introduce LOK_CALLBACK_UNO_COMMAND_RESULT callback.Jan Holesovsky
Posting of the .uno:Something commands is asynchronous. To be able to find out when eg. .uno:Save finished, this commit introduces a callback that fires when that happens. To be able to receive such a notification, the appropriate postUnoCommand() must be called with 'true' as the parameter for bNotifyWhenFinished (defaults to 'false'). Change-Id: I254939ebc8ea5f309ae39686dcaaeddd5148b0c9
2015-11-03lok: Fix typo search-result_count -> search-result-count.Jan Holesovsky
Change-Id: Iccd5b39f6bdf1c7a43131fc50186ea5a2838d77e
2015-11-03notifyer -> notifier.Jan Holesovsky
Change-Id: Ic009398d1d00550577d9f25b4d904632b063d54f
2015-11-03tdf#86595: Highlight color it isKatarina Behrens
Change-Id: Ic0a3083c05ba1cce974d76aecf60ed7bc4c72a36
2015-11-03vcl: Mark it as constTakeshi Abe
Change-Id: I0ddaf1cf9d0a3f36f88bea3101b7059e04d755ff
2015-11-03vcl: Mark them as constTakeshi Abe
Change-Id: Ia19d3512d156be725840c24d441a3eaa08e83a5e
2015-11-03tdf#86595 Change 'Highlighting' to 'Highlight Color'Yousuf Philips
Change-Id: I11ef97b4b4589d21afc40e862bb68a512db18831 Reviewed-on: https://gerrit.libreoffice.org/19741 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-03libreofficekit: -Werror=unused-parameterMiklos Vajna
Change-Id: I89c4d9752ef650d516bed8fcdc5873de8ae87e18
2015-11-03lokdocview: Separate "painting" and "saving" of tilesPranav Kant
Lets separate the task of painting the tile, and saving the tile in tile buffer using GAsyncReadyCallback. This will provide us with better control over tiles -- cancelling the painting operation, and filtering tiles that should not be saved in the tile buffer. Change-Id: I6aae928d8cc0c906034570ed0e9a054763d493a3 Reviewed-on: https://gerrit.libreoffice.org/19725 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-03Smart pointers for SwBorderAttrAccessAshod Nakashian
The short-lived SwBorderAttrAccess is manually deleted which is not exception safe and can potentially leak. This wraps it in unique_ptr. Change-Id: Ib45c1c36214583e0bf205231f9f793e023d106c7 Reviewed-on: https://gerrit.libreoffice.org/19701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-03Wrong dynamic_castJulien Nabet
EditCharAttrib doesn't inherit from or related to SvxFieldItem Moreover, we can see lines like this: const SvxFieldItem* pFieldItem = dynamic_cast<const SvxFieldItem*>(pAttr->GetItem()); Change-Id: I9f5710dc4a9a4e71d31538620a9ddc1dedee063f Reviewed-on: https://gerrit.libreoffice.org/19575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-03cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I082e644857a6eb139b5f805e2920a40164ed4cd7
2015-11-03Solved CID 1338058 and CID 1338057jan iversen
terminated buf correctly before calling printf. This should be done automatically but coverity does not see it. Change-Id: I0bcf8486b27dbfa9f7c49b338bbf483029b523cb Reviewed-on: https://gerrit.libreoffice.org/19751 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-03Fix create/destroy mismatchStephan Bergmann
Change-Id: Ibff6caedae0c5ed84cf4864c7a52af56a7cea527
2015-11-03sw: indentation fixesMiklos Vajna
Change-Id: I00bb0a4390524b569609d36d97120bdd2b55496e
2015-11-03sw: prefix members of SwFrmNotifyMiklos Vajna
Change-Id: Idc0290d82bb51fec0fcc1db003bd48f3cc402a0f
2015-11-03sw: prefix members of SwAttrSetMiklos Vajna
Change-Id: I0f38c87d46f913a3bbb5f3e40b6ae71c515a8c9c
2015-11-03sw: prefix members of SwAttrPoolMiklos Vajna
Change-Id: I3f55c4b8b12832b82e071d8cf62b2aa55f8913e7
2015-11-02cli_ure: fix buildMichael Stahl
Change-Id: Ib35a951ea813151ca330c3eb2286cbada91bd972
2015-11-02tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-11-02No need for this debug codeStephan Bergmann
Change-Id: I05a6d15a0c54ca5457d662c2467cb15c14991a0a
2015-11-02Assume this shall be conditional on DBG_UTILStephan Bergmann
...and not that MSVC-special _DEBUG Change-Id: I927f1d49dcbb24fd8fb91032ded6215390c97d79
2015-11-02tdf#74608 xmloff: Constructor feature for XMLMetaImportComponent.kripton
Change-Id: I3f97625552bf993d67b537456e09c9acf3cba6b8 Reviewed-on: https://gerrit.libreoffice.org/19671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>