summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-07-14fix vcl::DeleteOnDeinit example in its docsLuboš Luňák
The ctor does not take 'new T', now it takes arguments that are passed to T ctor. Change-Id: I04b330d98dd84c86e00ec937a00d1097f21c55c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137039 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-07-14sw: prefix members of ww8toolbarMiklos Vajna
SwCTBWrapper, SwTBC, TBDelta and Tcg See tdf#94879 for motivation. Change-Id: I778c3d47e6facc1fe69a9eb9d7af92fb2ef20cdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137042 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-07-14tdf#148198: merge identical hyperlinks of adjacent text ranges on ODF exportMike Kaganski
The true hyperlink boundaries are available as SwpHints starts/ends, which are used in DOC(X) export (see SwWW8AttrIter::OutAttrWithRange). However, I don't see a reasonable way to expose this information to xmloff, so I decided instead to just merge the identical hyperlink properties of adjacent ranges into a single hyperlink. This will allow to fix already split hyperlinks saved in previous versions. The downside is that this disallows to have separate adjacent identical hyperlinks - I hope that this would not be a real issue. Change-Id: I901e6035a5e89bc515b5742c6a5f564c77faf05b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137013 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-13tdf#139759 writerfilter: import comment highlightJustin Luth
Although it is a highlight, LO doesn't have such a silly duplicate thing in the editeng code. So just map this as normal char background instead of char highlight. As of LO 7.x, we default to exporting as char background anyway, so highlight is on the way out in LO. P.S. Highlight is one of 17-ish colors. It is the background button in the Char panel in MS Word. Background is on Word's Para panel (even though it is a character property), and so it can fairly easily be removed in MS Word. I didn't add a unit test because it doesn't round-trip, and an import-only test is basically useless. I'm having a surprisingly hard time finding why it doesn't export. Change-Id: Iad279b503b9f307994f1d9b96e7d984d6d8b44fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137036 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-07-13tdf#149950: svl_qa_cppunit: Add unittestXisco Fauli
Change-Id: Iae7facef72ad17b29b49ea5b52aab77c16357da8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137031 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-13svgio: use href along with xlink:hrefXisco Fauli
xlink:href has been deprecated. See https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href Change-Id: I622cd975c0bcc1a819831d7b9c867312ff59affa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137035 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-13basegfx: zoomIn() and zoomOut() should be sal_uInt16Chris Sherlock
All zoom functions use sal_uInt16 values. For some reason, basegfx used long when zoomIn and zoomOut were created in 2012 (see commit 315d2ddc16: "optimized zoom to use more common intervals"), this then got mass converted to tools::Long in commit 387a88fa25: "use tools::Long in basegfx..chart2". So fix is to change zoomIn/Out() to use sal_uInt16. Change-Id: I2a56d6f58e14f77aeb8741d332fe9bc282eb969f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135715 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-07-13Resolves: tdf#149950 Handle LongDateOrder vs DateOrder for middle month nameEike Rathke
Change-Id: I30598f7081cea73fa368374084c03b0df108be84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137026 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-13Remove unused --enable-chart-testsXisco Fauli
On 2022-07-04 I submitted 268f0f3f0d70902acaeb3f99e0d206ad66ffd67c "run CppunitTest_chart2_xshape without ENABLE_CHART_TESTS" to see if CppunitTest_chart2_xshape would fail for anyone. Since then, no one has complained about it, so I suppose the tests are stable nowadays, thus removing --enable-chart-tests which does nothing since the mentioned commit Change-Id: I0407c0379ea45eee93bd6689c90d1759b48e2844 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137022 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-13sw: fix spurious layout invalidation from ~SwCallLink()Michael Stahl
This code was added in commit 56b2cf0c10d9caa01ebae1d80465e342d046a85c "sw-collapse-empty-table-par-like-html.diff" and leaves us to guess what it should do. Apparently it's trying to replicate a Word feature where an empty paragraph at the end of a table cell and preceded by a nested table is effectively hidden, *unless* the user moves the cursor into it, at which point it grows to its ordinary height. The problem is that this is implemented by invalidating the position of any table once the cursor is moved into it, causing it to be reformatted, at potentially great expense, regardless if the cursor is actually on a paragraph that may be hidden. Also limit invalidations to when the cursor has actually moved to a different node. To fix tdf#105330, un-collapse a paragraph after Undo, requires additionally doing the same notification from SwUndoInsTable::UndoImpl() because the SwCallLink won't see the removed table any more. Mysteriously this causes the test SwLayoutWriter2 testTdf124261 to fail in Jenkins, but only on MacOSX so impossible to debug; tb86 fails with: layout2.cxx:2227:testTdf124261::TestBody equality assertion failed - Expected: 1721 - Actual : 5437 ... and tb84 with: layout2.cxx:2227:testTdf124261::TestBody equality assertion failed - Expected: 1721 - Actual : 3740 Change-Id: Ifd55097735d3675e6b82264f455baa44e9c9e30a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136963 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-07-13move Skia setup code to a shared functionLuboš Luňák
Change-Id: Ifcd434512854b5fedb0baf4ce1251a05f659b006 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137017 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-07-13fix #include locationNoel Grandin
added in commit 54a97eb9ddd66294f303189ca12ef726177453cb Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Tue Jul 12 15:52:29 2022 +0200 clang-tidy modernize-pass-by-value in vcl Change-Id: If1f468bc6d601809e3a7802f4414c3a49e54c2c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-13tdf#147132 Flatten a Basic functionRoman Kuznetsov
Change-Id: I85eef5ca499197cfd96fecc4d05a82f7d11089cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136856 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-13loplugin:unusedmethodsNoel Grandin
Change-Id: Ifa9c3fe86e7bad6d3839fd3fdfdb8c1f7b5053c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-13Related: tdf#149956 Keep in sync after icon theme changeMaxim Monastirsky
We can't just refresh the listener for .uno:ImageOrientation, as that won't work for tdf#149741. Change-Id: Iee584c98f5b81542cd9be4760433b96e97981f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137015 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-07-13tdf#149956 Pass the correct frame to VclStatusListenerMaxim Monastirsky
Starting directly to Writer (i.e. with "--writer") will attempt to create VclStatusListeners for .uno:ImageOrientation before the frame is activated, causing the dispatcher to not be found. Also defer that stuff to after a toolbar is filled, so we get a correct initial state for toolbars which shown when the current paragraph is rtl already. (There is a similar problem with the NB, but it isn't handled in this patch.) Change-Id: Ie482007c10a4014b4a2fd4d53f05d433777ecfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137014 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-07-13gtk3 a11y: Activate code that needs AtkRectangleMichael Weghorn
I don't see where `HAS_ATKRECTANGLE` would be defined, not even in what we have as a single git commit that adds the code: commit 9b5df79fbd9e84ef9c2dde845867dbb1f98ac98a Date: Fri May 5 09:55:52 2006 +0000 INTEGRATION: CWS atkbridge (1.1.2); FILE ADDED 2006/03/31 14:09:17 obr 1.1.2.20: #i63580# AtkRectangle already in atk 1.7.0, but ATK_TYPE_RECTANGLE in 1.7.2 2006/03/31 12:19:39 obr 1.1.2.19: #i63583# eliminated warnings 2006/03/30 12:39:35 obr 1.1.2.18: #i63580# AtkRectangle not defined in older atk versions [...] The above extract from the commmit message as well as a quick look into the corresponding OOo ticket [1] suggest that the only concern were old ATK versions that didn't have `AtkRectangle` yet. Since the code looks sane at a quick glance at the corresponding ATK doc [2], just drop the `#ifdev HAS_ATKRECTANGLE` check and enable this unconditionally. (atk >= 2.28.1 is required by now, which definitely has AtkRectangle.) While at it, switch to the new style of using a dash instead of an underscore in the signal name. [1] https://bz.apache.org/ooo/show_bug.cgi?id=63580 [2] https://docs.gtk.org/atk/signal.Component.bounds-changed.html Change-Id: If448c5e79df6f2dd38c3a9acd414cc778f4d1f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137011 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-13Simplify XMLTextParagraphExport::addHyperlinkAttributesMike Kaganski
Change-Id: I283fc348d1ecaee92095f50c6f7d92fff8b09dce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136994 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-13clang-tidy modernize-pass-by-value in vclNoel Grandin
Change-Id: I9ddb786eb88213c53cf53067ced6899ca40ac6e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-13add first writer vba test - for find behaviorHannah Meeks
Change-Id: I25136c7954339d79521f84ad9eca79a701930fdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136944 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-13tdf#149723 Fix Piano Impress templateLaurent BP
Add presentation:class attributes to date-time, footer and page-number of Piano master page Add light grey color to footers on Piano1 master page Change-Id: I08c405df32639d77ef9ae8d59c1333e70215ce40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137007 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-12tdf#149313: DOCX import: improved conditions for removeparagraphVasily Melenchuk
Quite complex conditions to define if current paragraph can be removed for document were forcing to keep paragraphs after page break with only section definition. Usually these pars are removed, but since tdf#103975 fix they were kept. It looks like to resolve that problem will be enough to ensure current break is a column break: they are bit different and processed in a different way unlike other break types. So this condition part instead of "do not remove par with section info after any break" it is right now "do not remove par after column break". Change-Id: Ib6290dc6254430883a598bef3ecd1f7ab7063922 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135969 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2022-07-12tdf#114734 docx export: save comment paragraph propertiesJustin Luth
DocxExport::WriteOutliner is only called for TXT_ATN, so it is safe to change this generic-sounding function. Anything in the future that wants to save "draw" text likely also would want to save paragraph properties as well. Change-Id: Ied37670f2d3d0d6096300dbc9749c8230abfdc44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136965 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2022-07-12tdf#149707 sw_redlinenum DOCX export: fix tracked moving of list itemsLászló Németh
Change tracking of the paragraph mark of moved list items wasn't exported. I.e. moveFrom and moveTo paragraphs are exported as old paragraphs with new content, e.g. accepting a removed list item and rejecting an inserted list item leave empty list items instead removing the list items completely in MSO. Note: in Writer the import of the old (incomplete) DOCX export worked before this commit, too. Change-Id: I9367d880af16aab376178ab6d226b3013688997c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137005 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-12elide some dynamic_castNoel Grandin
Change-Id: I32c804e64cf219364e27ad6d9549c68c1f737a19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-12use a read-only stream when reading graphic dataLuboš Luňák
EmbeddedObjectRef::GetGraphicStream() creates a writable SvMemoryStream, read the graphics data into it and then returns the stream, which will be afterwards used to decode the graphics. But if the data is broken, incorrect seeking may cause a seek way past the buffer, and since the stream is writable, it would be done and cause problems such as running out of memory. The VersionCompatRead class is one such place that reads size from the stream and then seeks based on the read data. Add SvMemoryStream::MakeReadOnly() that will change the stream to be read-only after the initial read of the data into it. Change-Id: I1d44aabaf73071a691adafa489e65e4f5e3f021d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137002 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-07-12tdf#96723 Number format: embedded text in decimalLaurent BP
Embedded text in decimal part is represented by negative position Use number:position as it is defined as integer in schema [1] Add Unit test to import XLSX file with embedded text in decimal and export to ODS [1] https://opengrok.libreoffice.org/xref/core/schema/odf1.3/OpenDocument-v1.3-schema.rng?r=7f3c9da5#7142 Change-Id: Ic68471a071ccbb1c3bec442bfcbe21d84f41ebd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135918 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2022-07-12unittest: Split out registry entries to alter UI definition search pathColomban Wendling
Accessibility tests will require testing the normal UI, so will need not alter the search path for definitions. It will however benefit from other environmental overrides (locale, fonts, etc.). The solution here splits out to a separate registry the piece of configuration that alter the UI, so users can select the features set they need. The default gb_CppunitTest_use_configuration is updated to keep working the same as before, using both layers. gb_CppunitTest_use_unittest_configuration is replaced by specific ones for each configuration layer, and the two direct call sites removed as they were redundant anyway (gb_CppunitTest_use_unittest_configuration is only a subset of gb_CppunitTest_use_configuration). New macros are gb_CppunitTest_use_common_configuration for the common layer and gb_CppunitTest_use_user_ui_configuration for the UI one. Change-Id: I75f82092079752b4e173e48ab463636e7b7515b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136997 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-12elide some temporary OUStringsNoel Grandin
Change-Id: I93ee61a04dfc1bb3dc758fd83a503f7374824ae8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136999 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-12clang-tidy modernize-pass-by-value in xmloffNoel Grandin
Change-Id: Ica07e393763343d0f5caaad6a89fa3378f6ad344 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136995 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-12tdf#142715 sw: fix crash on exit when textbox inserted to tableAttila Bakos (NISZ)
This reverts commit 06e2cbb31d0ea703df872b91eb8eacdcaced7653 "tdf#130805 SwTextBoxHelper::create: fix frame position in shape" which caused this regression. That fix is not necessary any more: synchronization does the same without crashing. Note: according to this, unit test of commit 06e2cbb31d0ea703df872b91eb8eacdcaced7653 wasn't removed. Change-Id: I45bc15d3cf6a5d93b8c54cb4e68018702e58efff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136674 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-12close object tag if writing out the preview(?) failsLuboš Luňák
When writing out OLE frame, if a picture of it (or is it preview?) is not available, the code bails out, but that leaves the object tag unclosed. Since it sets only a warning and so it appears to be non-fatal, close the tag properly before bailing out. Change-Id: Ib8a6d692b0c3b4cb9ff5bcfe3c964efdaed3dab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136962 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-07-12sdext: these tests won't run without popplerAndras Timar
Change-Id: I61deb7d5271bf87ac1bb3aad54c430ace8fd3f9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136975 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-07-12tdf#149775 - VBA: Find should stay around.Hannah Meeks
Previously we would create and destroy it for each set of a property on it making it useless. VBA Find object oddly represents the Find dialog in Word. Add it to SwDoc. Change-Id: Id9850cbd2296b24f9c93dc99b2967095bd84921f Signed-off-by: Hannah Meeks <hmeeks4135@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136630 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-12tdf#149947: simplify filter list creationMike Kaganski
Change-Id: Ic44d217a5593cc8694bc2f2f2e19e0c66d3ae9a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-07-12Breeze tdf#149753: Distinguish between New Presentation and Start from First ↵Rizal Muttaqin
Slide Change-Id: I1a60b846343f25ee6bad8a4de2ab864d5a9acb5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136967 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-07-12Breeze: tdf#141110 Update No List iconsRizal Muttaqin
Change-Id: I00563049f1d3ee4a131df9ae73bc081da70905fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136970 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-07-12Sifr: tdf#141110 Update No List iconsRizal Muttaqin
Change-Id: Ie93d72783a078125c87631e79bea8466a9f3814a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136972 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-07-12elementary: tdf#141110 Update No List iconsRizal Muttaqin
Change-Id: I696c964fe5051eecb65a0c95820c3fd69897e735 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136971 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-07-12Colibre: tdf#141110 Update No List iconsRizal Muttaqin
Change-Id: Iaa8e71c91b183c99c5ba7f4a13e7527c087cc6c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136968 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-07-12Sukapura: tdf#141110 Update No List iconsRizal Muttaqin
Change-Id: Ie043cb6933279d9d082c0636947ff42a0fb91286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136969 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2022-07-11tdf#149951: MySQL/MariaDB (direct connection) save images in BLOB-fieldsJulien Nabet
There were several pbs: 1) no size value was given to resetSqlVar whereas all BLOB or related need an explicit size so was 0 => provide size value with x.getLength() 2) Type provided was Sequence instead of a sal_Int8 so unitSize was 8 instead of 1 => provide "&x[0]" instead of "&x" 3) m_bindMetas[nIndex].length wasn't filled => initialize it with x.getLength() Change-Id: Iaca6a8f8142601c224d6f7aabe4414e61586d29f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136964 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-11tdf#114734 writerfilter: avoid PostIt exceptionJustin Luth
Comments (aka AnnotationMarks) cannot contain a paragraph style. The exception was causing all properties to be dropped. This fixes the right-to-left text direction issue. Additionally, I need to cancel code when dealing with justify. There is no underlying style to deal with, and also MS Word seems to treat justify literally when dealing with comments. IIRC, LO interally always refers to justify literally, while DOCX normally depends on the RtL context, treating LEFT as START and RIGHT as END. Hmm - I bet that complicates things for export, since exporting comments needs to be handled uniquely. Change-Id: I4f604f90aaad36ea56b8a9157a8a8458f39877c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136690 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2022-07-11Resolves: tdf#141565 Correct character sequence for Devanagari unique IDEike Rathke
A copy-paste error of the Farsi sequence. Change-Id: Ib19f97f0bc3bf018d659f8e998d0daa71e1d5c24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136958 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-11tdf#149649: sw_ooxmlexport16: Add unittestXisco Fauli
Change-Id: I764e8803d4067572516c2f1e3995f4a19b78b7c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136956 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-11Re-work extension handling to make tests easier to add.Hannah Meeks
Change-Id: Idddbb99804bdc1354db7a1059c68c820ba6a98b3 Signed-off-by: Hannah Meeks <hmeeks4135@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-11tdf#148687 tdf#149173 tdf#149546 sw: fix crash with textboxesAttila Bakos (NISZ)
Regression from 2110597ac730fa07dbbdd603fda82b182ed27c9e "tdf#147485 sw: fix group shape crash using std::shared_ptr". Details: 1) Using reference instead of copy assignment in SwTextBoxHelper. 2) Cleanup: Unused parts of SwTextBoxHelper were removed. 3) Fixing destruction of textboxes, in case when first the shape is removed, with clearing all textboxes from the doc and the shape before the pointer is released. All of this only have to be done if the call is not coming from the swdoc dtor, unless there will be double freeing. 4) Missing style conversion was fixed in writerfilter. 5) Don't import sections in textboxes, unless the hack of dummy paragraph before tables in sections will be applied and the paragraph with anchored objects inside will be removed with the objects; 6) ConvertTextRangeToTextFrame also fixed, so embed frames in frames are imported from now. (Also textboxes in frames, this can be useful when there is a floating table having group textbox with nested complex content inside, or floating table in floating table, etc...) Note: Follow up commit will enable group textbox import in frames and tables. 7) Import of group textboxes with complex content in header/footer was impossible, from now this is also supported both from DOCX and ODT (test included). 8) Guard class for blocking unwanted recursive textbox sync has been introduced, and maybe some speedup with group textbox import has been achieved. 9) The anchor sync method got a new function which avoids unnecessary sync when the anchor is the same. 10) Sync of As_char textboxes during layout calculation caused crash so that has a workaround from now, for DOCX import anchor change and Undo. That syncs starts before the layout calculation so sync not needed later. 11) A memory leak was found in Undo, which has been fixed. Note: layout test "testTdf147485Forcepoint" has to be limited to Windows and Mac builds, because font substitution causes crash on the Unix based systems. Change-Id: I69d5d79cc120e3a70ba9285be32ec36a434b2a04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136192 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-11tdf#149738: Minor inconsistencies in sparkline related UI stringsJulien Nabet
Change-Id: I5b4c31e69743ad519a8bcc99fa3a5a7512a4cc18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136955 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-11tdf#143148 - Use pragma once instead of include guardsArman Rezaei
Change-Id: Ie8daf1c7baa6937bbc44538abed9074b4813f858 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136953 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-11tools: rename getHeight/Width() to GetOpenHeight/Width()Chris Sherlock
By default Rectangle uses closed interval, if we really want to use half open intervals then we should specifically say as such in the name. Change-Id: Id7a91120ba1a1a4bc330014216b73a692dbf03a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136575 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-12-29 03:40:10 +0000