summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-26iOS, wrong app path.jan Iversen
changed tar backup path Change-Id: I4a1701d856bcdf6f20d3d869f1ba84a18c67b278
2017-09-26iOS, build instructions.jan Iversen
Added README with instruction on how to build for the different platforms, updated iOS files corresponding Change-Id: I8a85f808841d682bc09f1e3b039192e342ecc484
2017-09-26Call pyuno.private_initTestEnvironment() only onceStephan Bergmann
...instead of once for each class derived from CollectionsTestBase (as listed in pyuno/PythonTest_pyuno_pytests_testcollections.mk), causing the assert(!pSVData->maDeInitHook.IsSet()); in Application::setDeInitHook (vcl/source/app/svapp.cxx) to fire. This is probably far from being idiomatic Python code... Change-Id: I8cd1470c085b16b7b82468a308cfd1dead2db034
2017-09-26sw: convert that to assert, and remove a duplicate OSL_ENSUREMichael Stahl
Change-Id: Id454ed0efbb90cfe3ece0bdedf51f385962ee357
2017-09-26tdf#112574 sw: assert if a frame style contains a RES_ANCHORMichael Stahl
... in SwFrameFormat::Modify(). Change-Id: I3b7ea1493277d8d705bdf77c50fdff49872bac05
2017-09-26tdf#112574 sw: don't insert RES_ANCHOR into style item setsMichael Stahl
Styles don't have anchors, only frames have anchors. When using "New Style from Selection", clear the RES_ANCHOR from the style item set. Also, don't insert it in SwFramePage::DeactivatePage(). This was always broken and reportedly crashes since commit e07feb9457f2ffb373ae69b73dda290140e4005f Change-Id: I9320dbbcae980dfa0b00459b8cd808553d1a04f4
2017-09-26Fix typosAndrea Gelmini
Change-Id: Id8f863963cb2f34d81f2ad82353caaa2d03d59be Reviewed-on: https://gerrit.libreoffice.org/42807 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-26AddressSanitizer: undefined-behaviorCaolán McNamara
Change-Id: I55a92512ad9e1508c49ee3149394196f5be5f162 Reviewed-on: https://gerrit.libreoffice.org/42784 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26Cleanup unused strings in cuiMuhammet Kara
Change-Id: I7ab055f301785a73d189e58465056ac4b2e8b494 Reviewed-on: https://gerrit.libreoffice.org/42783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26loplugin:flatten in swNoel Grandin
Change-Id: I77d92e7adc9af5c88ca1930c25a0585713f9e0d3 Reviewed-on: https://gerrit.libreoffice.org/42788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26Unexport the other SolarMutex*Guard templatesJan-Marek Glogowski
The logical follow-up on commit 6d1c8a43586503e703baebabc5330a1898f7ec43. Also complete inlined templates, so no need for explicit export, which actually can break the non-pch build on Windows. Change-Id: Ifebd7608673bba9f3530c01be30bab6414a66976
2017-09-26Unify hyphenator loading and ensure Unicode paths on WindowsMike Kaganski
Change-Id: I2f910194c541cb0b882c69d03b02749ef9b93d29 Reviewed-on: https://gerrit.libreoffice.org/42777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-26tdf#112647: Fixed line spacing is saved incorrectly to PPTXTamás Zolnai
The values were not converted to the right unit. Also the spcPts attribute means an exact value not a minimum one. Change-Id: Ia49683e66153611e96a830f821e3a2487adec505 Reviewed-on: https://gerrit.libreoffice.org/42763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26EPUB export: test not loosing nested list contentMiklos Vajna
Just focus on the content, no formatting yet. Change-Id: I109f049bafae6a20d6b617f3be6a9c4f237e782b Reviewed-on: https://gerrit.libreoffice.org/42785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-26TSCP: refactor paragraph metadata field checkAshod Nakashian
This moves the logic into SwEditShell next to the exiting paragraph metadata infrastructure. Change-Id: I6c12bfca3d2e1b2bc8697f03f4de1b7c3e14b95a Reviewed-on: https://gerrit.libreoffice.org/42742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: cleanup more constant stringsAshod Nakashian
Change-Id: I244a3fc7899b3269cfdc76172f5dd57a2b987373 Reviewed-on: https://gerrit.libreoffice.org/42741 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: cleanup constant stringsAshod Nakashian
Change-Id: I5c307db7ef1c5980c9ae7706ae95970b5705ab58 Reviewed-on: https://gerrit.libreoffice.org/42740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: paragraph signing implicitly done at cursorAshod Nakashian
Change-Id: I9fc01072373dac0cade7b30c3654827bd82d78cc Reviewed-on: https://gerrit.libreoffice.org/42739 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: sign paragraph from classification dialogAshod Nakashian
Change-Id: Iebd50de0abecb80a4de38257fa2eea10b81962b7 Reviewed-on: https://gerrit.libreoffice.org/42738 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26TSCP: paragraph classification dialogAshod Nakashian
Change-Id: I3a5f201f9ed28452ee7392cb30aebf21955f3620 Reviewed-on: https://gerrit.libreoffice.org/42737 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26tdf#49634 Fix positioning of focus rectangle in Navigator content treeJim Raykowski
https://bugs.documentfoundation.org/show_bug.cgi?id=49634 Change-Id: I3beb41142281b2cda337b457ed287a2cc1f665a6 Reviewed-on: https://gerrit.libreoffice.org/42364 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-26sw: refactor updating paragraph signatureAshod Nakashian
Change-Id: If86e4b1664f88c9e51ab4ac2d819f8726991fa98 Reviewed-on: https://gerrit.libreoffice.org/42736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: refactor inserting paragraph signatureAshod Nakashian
And move signatures to the end of the paragraphs. Change-Id: I56cb501451a52a89dc256432823d10856a6e73dd Reviewed-on: https://gerrit.libreoffice.org/42735 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: move paragraph signature field to the endAshod Nakashian
This is both more readable (esp. at a glance) and for undoing. Change-Id: I817699b4eed15e05b0578d0f08ac451633b1d0dd Reviewed-on: https://gerrit.libreoffice.org/42734 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: improve undo handling of Paragraph SignatureAshod Nakashian
Change-Id: I46f395d5f9105d1d3dac6d2af6e9b43ae95ec78e Reviewed-on: https://gerrit.libreoffice.org/42733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26tdf#112288 Clarify Reschedule implementationsJan-Marek Glogowski
Application::Reschedule(true) must just process all currently pending events and ignore all new events generated while processing them. In contrast to Scheduler::ProcessEventsToIdle, this way it can't busy-lock the application with background jobs. This way we also can drop nMaxEvents from the Windows backend. This limit was also never implemented on OSX and for the KDE4 backend it's actually impossible to handle single events, and a call to QAbstractEventDispatcher::processEvents works like this. Also changes various call sites to just process all pending events instead of some made up number of times. Change-Id: I1ab95df89b079cc8c6319a808194fe3127144d1c Reviewed-on: https://gerrit.libreoffice.org/42659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26tdf#100065 Fix scale of transformationPaul Trojahn
The shape needs to be flipped to compensate the change of mbFlipH/mbFlipV. Change-Id: I7b680497fee6ae9ed7bbd6f4ed9089d1a25a1deb Reviewed-on: https://gerrit.libreoffice.org/42766 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26tdf#39468: Translate some random German comments and termsJens Carl
Change-Id: I5499676506a7570482388eb153f4667785b016ed Reviewed-on: https://gerrit.libreoffice.org/42770 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-26close sc and sw docshells tooCaolán McNamara
Change-Id: I2cf06762d50736debd63f385dcae3022412ac0c0
2017-09-26ofz#3483 Floating-point-exceptionCaolán McNamara
Change-Id: I3c8dc5e4ec9ce342d2da39459c49eeb0459f76d8
2017-09-26improve unnecessarycatchthrow pluginNoel Grandin
it is not legal to eliminate a catch/re-throw where the re-throw expliciting mentions the exception variable and the exception variable is a non-final class Change-Id: I7fd88b0d004d2efa66aef2c0876e07f203da3c28 Reviewed-on: https://gerrit.libreoffice.org/42782 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26oom in fodpfuzzerCaolán McNamara
Change-Id: Iba6ce63f21f9dfe7187eea81c6d76fad12ccc498
2017-09-26Blind fix for Xcode 9Stephan Bergmann
...which started to run into the same undefined reference issue as 5a55bef38b047b9c60d1b219c572287938265610 "Temporary fix for Clang on F26". (Unfortunately, Apple's Xcode Clang uses version numbers that can be confused with upstream Clang version numbers, so this patch will also affect users of upstream Clang 9.0 on macOS, when that eventually gets released.) Change-Id: I721f01f76d93c044fdbc02e68002b60b17b5e9fb
2017-09-26tdf#112211 RTF import: fix unwanted direct formatting for left indentsMiklos Vajna
Commit f528f9499bd91b700c549575e88fa102cfffede9 (tdf#106953 RTF import: fix missing paragraph left margin, 2017-05-16) fixed a problem around inheriting indents from numbering styles vs paragraph styles, but it turns out that document was rather special and in general the old behavior was correct. So fix that bug in a different way again, this time without less side-effects. The trick is that in case the level numbers group in a list definition ends with \u59 (instead of an ASCII ';'), then that group is considered to be invalid by Word. RTF import already was aware of this, but it wasn't known that when this invalid state is reached, that also means that the indents of the list level definitions should be ignored. So in general not putting direct formatting on a paragraph is a good thing: that way in case the paragraph style and the number style both has indent infos, then the numbering style wins, and that is what we want -- but in case \u59 appears in the list definition, then the indentation from the numbering style should be ignored. So fix up the tokenizer to import the indentation from list levels in general, ignore it for invalid list levels, and then we can remove the direct formatting from the paragraphs, which fixes this bug and keeps the old one fixed as well. This required fixing up two poor testcases, which tested paragraph properties, but in fact are interested in the real source of indentation, which is now the numbering style. Visually both bugdocs are unchanged. Change-Id: I6390aa870659a8ad02ba5512d84dea34dba29e9f
2017-09-26Don't pessimize to RTL_TEXTENCODING_DONTKNOWStephan Bergmann
...when aTextEncodingOrg can't represent all chars, but getBestMSEncodingByChar doesn't know any better encoding, either. (This happened during CppunitTest_sw_rtfexport, where it caused OUStringToOString to be called with RTL_TEXTENCODING_DONTKNOW from WMFWriter::WMFRecord_Escape_Unicode.) Change-Id: Ia975a2907f519172e7da4a370d97e1f4317b78b3
2017-09-26Map RTF codepage 0 to osl_getThreadTextEncoding()Stephan Bergmann
...instead of RTL_TEXTENCODING_DONTKNOW. (A file actually using that codepage is sw/qa/core/data/rtf/pass/CVE-2014-6357.rtf, processed by CppunitTest/sw_filters_test, where it caused OStringToOUString to be called with RTL_TEXTENCODING_DONTKNOW from writerfilter::rtftok::RTFDocumentImpl::resolveChars.) Change-Id: I41081c5df5c3aa80b4f1c7d52b158e73ef68cf38
2017-09-26Silence macOS 10.13 -Werror,-Wdeprecated-declarationsStephan Bergmann
Change-Id: Idde11cd740dd67b5df06945557e5580c7d16b1e3
2017-09-26loplugin:redundantcast: cstyle_cast within reinterpret_castStephan Bergmann
Change-Id: Ie31c9dd6d8741aa856553b798bb5b7f695a3fe0f Reviewed-on: https://gerrit.libreoffice.org/42776 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-26Silence macOS 10.13 -Werror,-Wdeprecated-declarationsStephan Bergmann
Change-Id: I84e9d3fc344fdc9fcf90ab63303d86e7a1cb20da
2017-09-26WIN run main thread redirects ignoring SolarMutexJan-Marek Glogowski
This way we can drop all the special nReleased handling. Instead we use the same mechanism as on Mac, where we keep the lock, but disable it for the main thread. As a security measure we assert on duplicate redirects, which should not happen. As a result we can't use SendMessage on the main thread itself, which would normally just call the WinProc directly. This could be accomplished by converting the redirect bool into a counter, which should be safe, as no other thread could acquire the SolarMutex, as we don't release it. Change-Id: Icd87b3da37a2489f3cad2bc80215bf93fc41d388 Reviewed-on: https://gerrit.libreoffice.org/42583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26Remove double 'using' statementMuhammet Kara
Change-Id: I103f8d267b1f34f9e3d1fe03e395c8d444150204 Reviewed-on: https://gerrit.libreoffice.org/42772 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26loplugin:flatten in scNoel Grandin
Change-Id: I40653af2d90ef123cf77d7223c520cba0e5a3aca Reviewed-on: https://gerrit.libreoffice.org/42661 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26external/libmspub: Update config.{guess,sub}Stephan Bergmann
...with versions of those files from the latest <http://ftp.gnu.org/gnu/automake/automake-1.15.tar.xz>. The current versions would fail for Flathub aarch64 builds. Change-Id: I4b42fa7c04f0570b31170b72d8a42786ae1dc252
2017-09-26Revert "tdf#106894 Rewrite packimages.pl in Python (pack_images.py)"Samuel Mehrbrodt
This broke the build: https://ci.libreoffice.org/job/lo_tb_master_win/14994/console This reverts commit 423ee1020afe1bca896f2ecfc67ffbd49db5081c. Change-Id: I05e6fd68f2bbec189236cbe265f6510731327997 Reviewed-on: https://gerrit.libreoffice.org/42778 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-26EPUB export: add testcase for EPUBExportUIComponent::setPropertyValues()Miklos Vajna
Making sure python produces sequence<PropertyValue> and not sequence<any> is a bit tricky. Change-Id: I1f3ee4664202576ab6777b719b3712b164c5002d Reviewed-on: https://gerrit.libreoffice.org/42759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-26tdf#106894 Rewrite packimages.pl in Python (pack_images.py)Jens Carl
Change-Id: Id627d9295edc77e561f15e0886fdcf9fb64fe68d Reviewed-on: https://gerrit.libreoffice.org/41667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-26loplugin:cstylecast (clang-cl)Stephan Bergmann
Change-Id: Ic61a2d58e260e11f3698524891201e8b761c97fc
2017-09-26external/firebird: Update config.{guess,sub}Stephan Bergmann
...with versions of those files from the latest <http://ftp.gnu.org/gnu/automake/automake-1.15.tar.xz>. The current versions would fail for Flathub aarch64 builds. Change-Id: Id53754e989244134bdc533eb7f37e08c598b03e0
2017-09-26sw: make paragraph signature fields read-onlyAshod Nakashian
Change-Id: Ib0218e2a92cdde81030c517b0826bd6062a333f3 Reviewed-on: https://gerrit.libreoffice.org/42732 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>