summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-03-12do same set error state as ReadAndVerifySignature doesCaolán McNamara
this function is nearly exactly the same as ReadAndVerifySignature except it doesn't set error-state on exception during parse Change-Id: Ife881f639a11d3185920ca62cc2cd22812fae36d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112366 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-12tdf#105268: sc: move UItest to CppUnittestXisco Fauli
Change-Id: I90d896b14b7e75d1586aa4ea329b0d80a32d45fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112380 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-12tdf#64001: sc: move UItest to CppUnittestXisco Fauli
Change-Id: I8d1e2cddc95d723f02c18b94ce9c7cbe4cdcef8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112376 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-12tdf#137626 XLSX import: fix missing datetime filtersBalazs Varga
by convert string representation of the datetime data to ISO 8601 (with blank instead of T) datetime to eliminate locale dependent behaviour when filtering for datetimes. Follow-up of commit 0e751d0cb816197f15a2448ec36c57df17387e40 (tdf#116818 sc,offapi,XLSX import: fix autofiltered date columns). Change-Id: I3a0f41dbbf28a1a60a54fe7b2c8c338516edb079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111851 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-12tdf#37424: sc_ucalc: Add unittestXisco Fauli
Change-Id: Ic7accef0592b5f404661e087a8d72c65820f214f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112375 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-12enable libpng hardware optimizations (such as SSE)Luboš Luňák
The implementation is rather poor, but it's still something. Change-Id: Id0a967d55d079327ae41d5dd3446a492fd247cfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112361 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-03-12Avoid modifying then restoring this const iterator, its copy is trivialCaolán McNamara
Change-Id: I354010fbc47087bf7587a9662b9218606ba37dd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12ODF save: write explicit "gregorian" calendar, not empty if defaultEike Rathke
Other implementations may have different opinions about default calendars and the context here is to switch to Gregorian. Change-Id: I14a27826e627f890911adaf01935c58b43ad766a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112354 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-03-12Revert "tdf#114076: Expand ClipRange to next PixelBound" ...Xisco Fauli
and "tdf#124272 use ClipRegion's geometry if not a rectangle" This commit reverts c1230cede19ae3633e51c7ca780cb34d9dbaa20f and 362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c tdf#114076, or any of its duplicates, is not reproducible in master if c1230cede19ae3633e51c7ca780cb34d9dbaa20f ("tdf#114076: Expand ClipRange to next PixelBound") is reverted. (Tested on Linux and Windows) So, if we revert it, we no longer need 362c1cf2bd580f6dc8bf27bdcd79174111bc1b5c ("tdf#124272 use ClipRegion's geometry if not a rectangle"), which was a follow-up fix for a regression introduced by the first commit. This also fixes tdf#129085 and all the duplicates, which were introduced by the follow-up commit. I plan to add the unittests in a different commit Change-Id: Ie4328c15b24b521127c1b653bd621bfc92ac39cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112340 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-12explicitly assert that xSignatureInfo shouldn't be emptyCaolán McNamara
Change-Id: I4cd1be8b4c0b7ecb727e6a997679a9b74c03bc15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112362 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12tdf#140136 sc: fix tree list expansion in AutoFilterAttila Szűcs
Now clicking on +/- buttons (i.e. before the checkbox) only expands/collapses the tree without toggling the associated checkboxes, using the new GetItemPos() to get the position (and width) of the checkbox in the actual list item. Regression from commit 2471d6f44c7e8ecbe86a90eeb593b899a08a7408 "tdf#116675 vcl tree list: toggle by label click (e.g. in AutoFilter)". Note: Use generic VCL plugin to test it on Linux: SAL_USE_VCLPLUGIN=gen instdir/program/soffice Co-authored-by: Tibor Nagy (NISZ) Change-Id: Iceb17bc9b235d297c313361429ee89f04d809e96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111668 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-03-12log if there was an exception in GetDocumentSignatureInformationCaolán McNamara
Change-Id: I335ba7916142f07ed8408453bfe8aa7068c35711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112363 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12do same logging as ReadAndVerifySignature doesCaolán McNamara
Change-Id: I89c0e29f595049096afa73ff86badc06c0b40d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112365 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12drop unneeded includeCaolán McNamara
Change-Id: I2f75748d5601d699471d050558885c0efb977223 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12drop unneeded includeCaolán McNamara
Change-Id: Idcae44440a197f6b3b824cbbac430e370964ac25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112368 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12Revert "merge sw::hack::Position and SwFltPosition"Caolán McNamara
This reverts commit 4f35958c64d5e63c30e67434936c3a0352f57698. (which was an attempt at groundwork at fixing ofz#31538) because ooo46246-1.doc fails to load in crashtesting Change-Id: I334fc4ff1d1a934d92fe69eae63206c0a480e55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12move hatchwindow to toolkitCaolán McNamara
because it wants to use toolkit headers Change-Id: If92b174bd4971b88f288f93c1beaed6f2103a83c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12use some forward declares to avoid including vcl/window.hxxCaolán McNamara
Change-Id: I67992b7743f98d6228a0a52d2e5a92e4f25eaa15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112347 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12use preferred variant when window arg is nullCaolán McNamara
Change-Id: I8fad194b6f147b40ecee6fff9fbbe947e7faa014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12use the DocShell GetDialogParent as explicit dialog parentCaolán McNamara
Change-Id: I4b7c09ea7f6d387d220e35430299ffdaa73e7718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12use the parent available from the SfxRequestCaolán McNamara
Change-Id: Ie03182217b2165af45a1a89a35bf7d4be6ee1acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12transport error dialog parent as awt::XWindow earlierCaolán McNamara
Change-Id: Idfc6ffdb31d28316886800eed12ac46c1dbcc191 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12use VCLUnoHelper::GetWindowCaolán McNamara
instead of directly using VCLXWindow Change-Id: I80c70c9773b1963ec4d58c833ff2fdba9cfc4b92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112353 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12awt::XWindow has setVisible so don't need to fetch VCLXWindow to do thatCaolán McNamara
Change-Id: Idc471c7a1dfd10821c8644a02d482cf8edc09fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112352 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12use VCLUnoHelper::GetWindowCaolán McNamara
instead of directly using VCLXWindow Change-Id: I86499a1238595189dd430f2809af08b4869f7fd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-12tdf#126742 make Windows file handling more unx-likeArmin Le Grand (Allotropia)
The bug mentioned happens due to a system-dependent difference: Unx-systems allow files to be opened for write multiple times while our windows implementation until now did prevent that. For that reason an embedded OLE which is still opened in the same LO instance behaves wrong/strange - the e.g. changed size cannot be written (to the file). Since we already have unx-like handling and in that scenario useful sync has to be done anyways, no new scenario will be created. Only Windows implemenation will change to behave closer to unx-like behaviour, I already test-built that on gerrit to make sure all tests for Windows work as before. I thought about this for quite some time, but see no too big risk. For thoughts/discussion please refer to the task. Change-Id: I8dbfd70c2f69d0a013f445e152e597f37fa6ecc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112237 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-03-12tdf#128469 rename "Standard" to "Reset to Parent" plus tooltipSeth Chaiklin
Change-Id: I73ad5450450c328911d8464924a163faaba9b70c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112301 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-03-12Drop some unused includesMiklos Vajna
Change-Id: Ic79d81387867f028eb8dc9553fb87f5961d6c771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112364 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-03-12tdf#89754: sc_ucalc: Fix testXisco Fauli
The original UItest added in 3ba901f050d262cdeccefa5b21b0d32aa7332dc7 < tdf#89754 - don't increment non different consecutive date cells > didn't fail without the fix in place Change-Id: I297f9b3fe713910c1ed40b2de560171911b1ba79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112357 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-12Use range-based for; mention similar method in commentsMike Kaganski
Change-Id: I2659faf75e88eecccfdb33368393c140563030e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112304 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-12No need to const_cast hereMike Kaganski
Change-Id: I2ecac05f41b5656714a656fe5289dc21c9f6051a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112300 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-12Avoid modifying then restoring this const iterator, its copy is trivialMike Kaganski
Change-Id: I2a129714f726fb2b15f76550f7e2e265205d0112 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112299 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-12Fix wrong position on move when page has marginmert
Change-Id: I9ac2d9914b86210ca2148b44488c2c70cc5870d4 Signed-off-by: mert <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111949 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111929 Tested-by: Jenkins
2021-03-12Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to ae361f8f4f70c43d7082dd37c0a3f69bf49fa3e0 - Create SF_Database Help page Change-Id: I4ab158e8089973af24155d3b9d0697734acdf4bb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/112228 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-03-11tdf#127217: Fix buttons in forms not working in Adobe ReaderJulien Nabet
Regression from 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb: author Thorsten Behrens <Thorsten.Behrens@CIB.de> 2019-04-09 02:19:14 +0200 committer Katarina Behrens <Katarina.Behrens@cib.de> 2019-07-03 14:48:45 +0200 commit 76b5dca9dc0ff60f8f62cbecdee68f8f3b287ceb (patch) tree e778dad33073a228eb61ab62ce5f38e2a26d07ca parent 1e8a9c19a6f7b82c9e0c481aee0c04c0780f4433 (diff) tdf#113448 don't export any font for radio buttons Don't let only color value in m_aDAString since it'll go here: if( !rWidget.m_aDAString.isEmpty() ) { if( !rWidget.m_aDRDict.isEmpty() ) { aLine.append( "/DR<<" ); aLine.append( rWidget.m_aDRDict ); aLine.append( ">>\n" ); } else { aLine.append( "/DR<</Font<<" ); appendBuildinFontsToDict( aLine ); aLine.append( ">>>>\n" ); } aLine.append( "/DA" ); appendLiteralStringEncrypt( rWidget.m_aDAString, rWidget.m_nObject, aLine ); aLine.append( "\n" ); if( rWidget.m_nTextStyle & DrawTextFlags::Center ) aLine.append( "/Q 1\n" ); else if( rWidget.m_nTextStyle & DrawTextFlags::Right ) aLine.append( "/Q 2\n" ); } But if we shouldn't have /DR at all since we don't want fonts for radiobutton, it also means we don't want /DA too. Indeed at the end of 12.7.3.3 https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf: The default appearance string (DA) contains any graphics state or text state operators needed to establish the graphics state parameters, such as text size and colour, for displaying the field’s variable text. Only operators that are allowed within text objects shall occur in this string (see Figure 9). At a minimum, the string shall include a Tf (text font) operator along with its two operands, font and size. The specified font value shall match a resource name in the Font entry of the default resource dictionary (referenced from the DR entry of the interactive form dictionary; see Table 218). Change-Id: Ib350495d7fc5a7a4fba88d710614a0f67a0b1553 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111724 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-03-11Turn CppunitTest_xmlsecurity_signing into a subsequentcheckMiklos Vajna
This is one of the most unreliable tests on Windows, probably due to reading the real system cert store, unlike macOS/Linux (which have a per-test NSS template). Give up on running this on Windows / macOS for pre-submit CI to get more reliability instead. Local 'make check' on Windows keeps running this, since it does pass most of the time. The change can be reverted once somebody can figure out how to reliably reproduce this failure on Windows. Change-Id: I50df09bda9c353ce08038dab8d307bbf7738bb5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112358 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-03-11Don't use std::ostream operator <<(char16_t const *) deleted in C++20Stephan Bergmann
Building with --with-latest-c++: > C:/lo/core/xmlsecurity/source/xmlsec/mscrypt/x509certificate_mscryptimpl.cxx(664): error C2280: 'std::basic_ostream<char,std::char_traits<char>> &std::operator <<<std::char_traits<char>>(std::basic_ostream<char,std::char_traits<char>> &,const char16_t *)': attempting to reference a deleted function > C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\1428~1.299\Include\ostream(951): note: see declaration of 'std::operator <<' etc. Change-Id: I70ae201c761fae907e602b6a929e23e3c8e7f692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112318 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-11awt::XWindow has setVisible so don't need to fetch VCLXWindow to do thatCaolán McNamara
Change-Id: I3da36a5e54276dad483abb263fc15fd9d045ec59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use VCLUnoHelper::GetWindowCaolán McNamara
instead of directly using VCLXWindow Change-Id: I886525169834d24b6c060fb4722e1afda23dbc26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112346 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use an explicit parent for error messageCaolán McNamara
Change-Id: Idf5a1c6a4313ab58c2bf6ee0ec02a8d003eee83a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11refactor getDialogParentWindow to take an XFormController argCaolán McNamara
Change-Id: I4c42adfa079babf7d3efbd881293102d6cb526ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112334 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use an explicit parent for error messageCaolán McNamara
Change-Id: Ib171ee0e7dc4936552b5a9a5c9d50ae7fd6a54d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112333 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11factor out a FmXFormView::GetParentWindowCaolán McNamara
Change-Id: I35d5de294ac08e1ec6a597835b879dc1f377ef86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112332 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11TransferableDataHelper::CreateFromSelection doesn't use its argumentCaolán McNamara
Change-Id: Id43995411d850ae051d1d803bcea2745e1dc17a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112331 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11remove some unneeded vcl/window.hxx includesCaolán McNamara
Change-Id: I2b716371e2bebe7390e7f0c7b747140d9f4bdec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11keep SfxObjectShell::GetDialogParent ret as an awt::XWindowCaolán McNamara
instead of extracting the vcl::Window impl details from it Change-Id: Ia13c1559861ab2a65a2108c8ccd704cba711916c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112329 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11check current floating state of DockingWindowCaolán McNamara
regression from... commit cf234dc05a3a75199890e953d789bd19b02c1725 Date: Tue Mar 9 20:15:28 2021 +0000 rename SfxChildWindowContext::GetFloatingWindow to what it does Change-Id: Ie52946739439ef66c224f2e388fc407912783bb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11use some forward declares to reduce includesCaolán McNamara
Change-Id: Ic3a6d9a9569f909a7480d9da09709dbd60259e97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112323 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11remove intermediate containers in sidebarsCaolán McNamara
tested extension sidebars of: a) Wollmux extension sidebars b) Analog Clock Extension demo https://wiki.openoffice.org/wiki/Sidebar_for_Developers#Example:_Analog_Clock_Extension Change-Id: If9729e20526681928137989f01a8ae733a9b0cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112035 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-11lok: avoid a set of invalidations per view on re-size.Michael Meeks
Unfortunate to have N^2 invalidations in the number of views on resize - particularly for calc, when you re-size/wrap-text on a row during editing. Change-Id: I93f75c4543ad072684e5575a2cbe0e8abcab0d80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109913 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112094 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-15 04:07:17 +0000