summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-05-05vertical text test fails with latest harfbuzzCaolán McNamara
with font "Droid Sans Japanese" which doesn't seem to be available in ci, but is by default in the Fedora 37 build roots I suspect since: https://github.com/harfbuzz/harfbuzz/issues/537 Change-Id: I23d9415444668ce379765f32a96ed67f057ebfd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-05use more o3tl::getTokenNoel Grandin
found by inspecting call sites of OUString::getToken Change-Id: I4269c7476c7aa46fac39528227e350568f0eb34a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05tdf#146007: make sure to not hold solar mutexMike Kaganski
COM might need to forward the call to another thread (with corresponding apartment); if that thread happens to wait for solar mutex, COM call may deadlock. Change-Id: I8fcf04619cd29b678fd7ade87254b9aad2f639a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133853 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2022-05-05Just use Any ctor instead of makeAny (Linux, sequel)Stephan Bergmann
Change-Id: Idcf537a838bb0e47cfa31db8bc09e477b277ee37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133875 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05sfx2: remove misplaced try-catchMichael Stahl
The exception is actually caught in an inner catch block; it was like this already when added in commit b4576f3da4d90139fc5140962d13cb91dab98797. Change-Id: I054c59493efe7d2d69877559b048bcf3c1f173e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133837 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-05ucb: webdav-curl: if LOCK fails, display error messageMichael Stahl
Sharepoint may reject LOCK with HTTP/1.1 403 FORBIDDEN and then a dialog pops up via UUIInteractionHelper that says "Server error message: ." Let's actually put some error message in the dialog, why not the HTTP status line, plus a little prefix to see which method failed. Change-Id: Ied895787f813c5cddcb18eb4f693d5bfc8c62076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133835 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-05tdf#148921: sd_import_tests-smartart: Add unittestXisco Fauli
Change-Id: Ib2016afb06914d453fe398127b2f6f50e48c0e93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133834 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-05sw content controls, drop-down: show list items on clickMiklos Vajna
- add a generic SwContentControlButton, to be used for dropdowns, but meant to be useful for other types in the future (e.g. date picker) - add a contentcontroldropdown .ui file for the welded list items - add a SwDropDownContentControlButton, which contains the drop-down-specific logic - invoke content control button from HighlightContentControl(), so list items are shown on button click Change-Id: Ib3c6765020c5b3b1dd343a40a2b1862c73feaac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133874 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-05use more string_viewNoel Grandin
found by examining the call sites of OString::getToken which means I needed to add a new o3tl::equalsAscii function Change-Id: I7dc0ea1cf5ce8090a708d44f2cf7c938fa200c5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05tdf#148921 Smartart: Incorrect Text positionNoel Grandin
Revert commit b6fe3b13206eee0543ded37c3a1566add284e6da. no need to have two weak references to SdrObject in SvxShape Change-Id: Ie29d0002fd86226eb7634f621b43e7cb8dfc8aa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-05tdf#148299 Don't unmotivatedly mess with spaces in file namesStephan Bergmann
This conversion of double to single spaces had been done ever since 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import", but it is unclear to me why. The same conversion functionality is also used at two places in sw/source/ui/dialog/uiregionsw.cxx. Not sure if it has any motivation there, so lets keep that intact for now. Change-Id: I0558f015c53f69a9a405891b9dad21a98de3533c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133841 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05sd theme: add ODP import/export for shape fill color effectsMiklos Vajna
Map a themed color with effects to: <style:graphic-properties draw:fill-color="..." loext:fill-theme-color="..." loext:fill-color-lum-mod="..." loext:fill-color-lum-off="..."> Change-Id: I18d8ddf8d6050ef468a8d67a9e797a576f682e85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133843 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-05Just use Any ctor instead of makeAny in avmediaStephan Bergmann
Change-Id: Ib43fa3be2e63de8ad6967682c2b00e702eb527ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133850 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05Just use Any ctor instead of makeAny in accessibilityStephan Bergmann
Change-Id: I7860a176bfd44d8f5071ece03229bc7f768d9d52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05Just use Any ctor instead of makeAny in basicStephan Bergmann
Change-Id: I21d9679064c4e68a1492d3550f083c3c91b5b43b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133848 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05Just use Any ctor instead of makeAny in basctlStephan Bergmann
Change-Id: I4bd58031623dea1243193aaa60f6ca5bb0f7d562 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133849 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05Just use Any ctor instead of makeAny in chart2Stephan Bergmann
Change-Id: I156cd5597a4b9e683913d9730b8d8bb22e8064f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133845 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05Just use Any ctor instead of makeAny in canvasStephan Bergmann
Change-Id: Iade345e814f2809bead96b228afa925d86057696 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133847 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-05T no more...Olivier Hallot
Change-Id: Ide06d5b57ddc203f5877b1f8ea8309234da7fca7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133854 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-05-04Just use Any ctor instead of makeAny in cli_ureStephan Bergmann
Change-Id: Iae41d9c4b600635bd5e2e61b65ea3859a14e6a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133840 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in comphelperStephan Bergmann
Change-Id: Ib3edbef27c2d25dae8bac07e0199af071131170e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133839 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in cuiStephan Bergmann
Change-Id: Ibc76372e161a579df60c2265a4727b619e4a0b63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133830 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in connectivityStephan Bergmann
Change-Id: I68e7354f094ee0e673d105dd8770a658810703d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133838 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in cppuStephan Bergmann
Change-Id: Ie178e13251b7cb1b69facbbc12e530f6dc4632ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133836 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04upgrade to cairo 1.17.6Caolán McNamara
Change-Id: Ibdf84df380c89d3a0713163920a576bf1c47873a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133825 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-04Resolves: rhbz#2081661 gtk-critical gtk_tree_view_scroll_to_cell assertionCaolán McNamara
Change-Id: I4c7c4caed907072ef3a73ccfafabe882d618fa0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in cppuhelperStephan Bergmann
Change-Id: I296f297060f10e09639da837df44cc9d30cc594b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133832 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in desktopStephan Bergmann
Change-Id: Ieca85ea1b822ffa80420ed1cb6950bdedd15d000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133828 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in extensionsStephan Bergmann
Change-Id: I0441d30044168563b0d5b8406fcc99b51a9cbc1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133817 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in dbaccessStephan Bergmann
Change-Id: I8b20d60d536a8fb3d3396e1ce26bacf309637f40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133829 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Some JREs need the bin/server/jvm.dll path after allStephan Bergmann
...which had been removed in 18bdf78e156f3cd1e6ccbb3ae28e919583bac70c "Azul is just another OpenJDK variant", when fixing the previously mis-classified Azul JRE from "uses OtherInfo" to "uses SunInfo". But the IBM Semeru Runtime (<https://developer.ibm.com/languages/java/semeru-runtimes/downloads/>) is another arguably mis-classified case due to its java.vendor of "IBM Corporation" (and where the VENDOR_MAP_ENTRY<OtherInfo>("IBM Corporation"), line in jvmfwk/plugins/sunmajor/pluginlib/vendorlist.cxx might be relevant for some other JRE from IBM; at least, that entry is present ever since the introduction of vendorlist.cxx in 738e9b77b9d181b376188e405e1eb353cf93c597 "INTEGRATION: CWS jl8"). So just generally support the bin/server/jvm.dll path here for "uses OtherInfo", even though it should actually only be necessary for "uses SunInfo". (See the mail thread starting at <https://listarchives.libreoffice.org/global/users/2022/msg00246.html> "[libreoffice-users] LibreOffice 7.3.3.2 Windows 64 bit seems not detect AdoptOpenJdk JRE Windows 64 bit runtime".) Change-Id: I3a4d02309b7c833c3cd32dc2dda4f4cb7b216693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133827 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04upgrade to latest harfbuzzCaolán McNamara
Change-Id: I149d7a5d36c6546d3e6898b2b55ce6cd585d4d41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133824 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-04Drop --with-iwyu optionGabor Kelemen
Nowadays the bin/find-unneeded-includes script is a better solution for this problem This essentially reverts the commits: c716b3888e7e8150d1c1053ee6550afb56438b1f 096c7e889f3b9bd42a81fb0216e2a68fb27159fc 40e7eecb7efeeb9af59206d7a9c82ac55adf5279 Change-Id: I404a4b34176efaacf961605559af9de6d6cba10a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133540 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-05-04Fix typo in cbc34f69ec6363cd234ad2b1dfe09bfb531238dbAurimas Fišeras
Signed-off-by: Aurimas Fišeras <aurimas@members.fsf.org> Change-Id: Iee5c7aec7817bc7af5f45d192165fe30301788d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133823 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-05-04Just use Any ctor instead of makeAny in editengStephan Bergmann
Change-Id: Ic6a392ce006c9348abc28a5940c4ee0425e5b990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133820 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny (macOS)Stephan Bergmann
Change-Id: I6c185eecf943205f78567393f0ef588580ee4dab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133821 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04remove unused layout callLuboš Luňák
I should have removed this in bfb6a42e26de28d88ced43eb3a2c63ce323. Change-Id: Ieb4b5fabcc1eecf82dbacef66bef8288b6c51761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133815 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-04libxml2: upgrade to release 2.9.14Michael Stahl
Fixes CVE-2022-29824. Change-Id: I31d6ec794b01dee0bb17022ef2e18d2acd8255df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133813 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-04Just use Any ctor instead of makeAny in embeddedobjStephan Bergmann
Change-Id: I7e00a4b17b9fc3ccfb360ae5737d253a7d31d02b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133819 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Just use Any ctor instead of makeAny in embedservStephan Bergmann
Change-Id: I2e5f94454a9e5d157cec1f883546655e8c11bd1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133818 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 87be4f00f4c2a9b269779ee4f1d6b2417a45a113 - update translations for master and force-fix errors using pocheck Change-Id: I6f0fe9f8928d5a663a14c9d21990e37f94ee18f6
2022-05-04reduce string conversions in jsdialog::ExecuteActionNoel Grandin
Change-Id: Id1b908e06ebaa7f6ba5981abff51584623770215 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-04Just use Any ctor instead of makeAny in filterStephan Bergmann
Change-Id: I68bbbc2cc80ac5efde78e10706b488bf78c058bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133816 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-04use more string_view in oox::vml::ConversionHelperNoel Grandin
Change-Id: I8616f608ee4cc62114acb4fbd774796bc11d1911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133812 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-04android: Don't use log tag longer than 23 charsMichael Weghorn
Addresses this lint error: > .../android/source/src/java/org/mozilla/gecko/gfx/SimpleScaleGestureDetector.java:146: > Error: The logging tag can be at most 23 characters, was 31 > (GeckoSimpleScaleGestureDetector) [LongLogTag] > Log.e(LOGTAG, "No gesture taking place in getFocusX()!"); Change-Id: I1d18fb3717ccea8dc36695bfef888d035efe8d55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133799 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-05-04android: Make clear that column index is non-negativeMichael Weghorn
Use `Cursor#getColumnIndexOrThrow` instead of `Cursor#getColumnIndex` here, as suggested in the `Cursor#getColumnIndex` doc [1]: > Returns the zero-based index for the given column name, or -1 if the > column doesn't exist. If you expect the column to exist use > getColumnIndexOrThrow(java.lang.String) instead, which will make the > error more clear. As described in the `OpenableColumns` doc [2], `OpenableColumns.DISPLAY_NAME` is one of the two standard columns that must be supported: > These are standard columns for openable URIs. Providers that serve > openable URIs must support at least these columns when queried. Addresses this lint error: > .../android/source/src/java/org/libreoffice/ui/FileUtilities.java:139: Error: Value must be ≥ 0 [Range] > displayName = cursor.getString(cursor.getColumnIndex(OpenableColumns.DISPLAY_NAME)); > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Explanation for issues of type "Range": > Some parameters are required to in a particular numerical range; this check > makes sure that arguments passed fall within the range. For arrays, Strings > and collections this refers to the size or length. [1] https://developer.android.com/reference/android/database/Cursor#getColumnIndex(java.lang.String) [2] https://developer.android.com/reference/android/provider/OpenableColumns Change-Id: I946fcd32a905a4bb8c0527fc1199b9dcc52bccfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133798 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-05-04android: Call base class implementation in 'onActivityResult'Michael Weghorn
Addresses this lint error: > android/source/src/java/org/libreoffice/ui/LibreOfficeUIActivity.java:253: Error: > Overriding method should call super.onActivityResult [MissingSuperCall] > protected void onActivityResult(int requestCode, int resultCode, Intent data) { > ~~~~~~~~~~~~~~~~ > > Explanation for issues of type "MissingSuperCall": > Some methods, such as View#onDetachedFromWindow, require that you also call > the super implementation as part of your method. Change-Id: Iab2bdadae7a776e4f52d671a6fd47c1b8146b2a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133797 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-05-04remove stray printfCaolán McNamara
not one of mine for a change Change-Id: Iaa4151f8fcb0b31d98514075473d2768fbadd69c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133810 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-04ofz#47199 AbortCaolán McNamara
Change-Id: I5e18242b3a18f0c9ca1891ab4e29bd43aaab1f26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133811 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-04Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 21955867dc01dbc9e897c585c3a85299eb8f36ad - tdf#148444 corrections to Print Preview Bar and related pages text/swriter/main0210.xhp (Print Preview Bar) *change order of commands to match toolbar +add <embed> to (new) Single Page Preview +add "Jump to Specific Page" command (no icon exists) +add Print command and icon +add Close Preview command and icon +add <embeds> to "zoom in" and "zoom out" icons *refactor to <h1> text/swriter/02/10040000.xhp + add this file for Single Page Preview, with icon table text/swriter/02/10070000.xhp (Multiple Pages Preview) +commit beginning with 0f337351 in 2013 accidentally removed the <h1> line, now added back. *changed description to match current behavior of command +added More Options header *refactor to <h3> -remove colspan= rowspan= *change image to .svg *change image size to 1cm text/swriter/02/10080000.xhp (Book preview) *refactor to <h3> *change image to .svg *change image size to 1cm text/swriter/02/10020000.xhp (Zoom out) +add section to icon table *refactor to <h1> -remove colspan= rowspan= *change image size to 1cm *change image to .svg text/swriter/02/10010000.xhp (Zoom in) +add section to icon table *change image to .svg text/swriter/01/01120000.xhp (Print Preview) +add link to Print Preview Bar page in description -drop Related topics and link with incorrect label *refactor to <h1> Change-Id: I902fe42d7f0405e2cfe3600199f5ab3fcb7e459c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/132610 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
generated by cgit (git 2.34.1) at 2025-01-09 07:29:30 +0000