summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-07-16tdf#46950 Allow intra-word right double quotation markJonathan Clark
Hebrew text may use the character RIGHT DOUBLE QUOTATION MARK as a substitute for HEBREW PUNCTUATION GERSHAYIM. This change customizes the ICU word BreakIterator rules to that end. Change-Id: I03a48729de103505a2f68f9a1635c0f0cd7d126a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170536 Reviewed-by: Jonathan Clark <jonathan@libreoffice.org> Tested-by: Jenkins
2024-07-16libffi: Upgrade to 3.4.6Taichi Haradaguchi
* external/libffi/implicit-function-declaration.patch was obsolete after https://github.com/libffi/libffi/pull/764 * Backport external/python3/0001-bpo-45898-Remove-duplicate-symbols-from-_ctypes-cfie.patch.1 from upstream to fix build errors on Windows. Change-Id: I6d7cd70dd29ea0ce4b22738637afa0e7eb76a93f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167337 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2024-07-16Add lokconvert odk exampleHossein
This exmaple converts a file to PDF using LibreOfficeKit library. Change-Id: Idc4afafc9541986617f0cc4d46cd89e25ae12051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169998 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-07-16tdf#161914 Rename "Pen Width" to "Pen Thickness"Bogdan Buzea
Change-Id: I3a6bc7143a7a621c7c1ebdfd2b33d6021f6b4a66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170482 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-07-15-Werror,-Wgnu-folding-constantStephan Bergmann
> desktop/unx/source/start.c:788:23: error: variable length array folded to constant array as an extension [-Werror,-Wgnu-folding-constant] > 788 | char resp[strlen("InternalIPC::SendArguments") + 1]; > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ since <https://github.com/llvm/llvm-project/commit/e4163c0927772f2ec73cf16d53e000614c419c45> "[clang] Emit bad shift warnings (#70307)" (and see the comments starting at <https://github.com/llvm/llvm-project/pull/70307#issuecomment-2228342153> "[clang] Emit bad shift warnings" for how this new warning is indeed intentional) Change-Id: Ie439a0f5f6f3b256fa82ec3a05fdc5fb3b840715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170510 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
2024-07-15CppunitTest_sw_autocorrect: move some tests hereXisco Fauli
and name them by language Change-Id: I634d31cd968ffdcbf2b92766980cae8bfb2afdb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170506 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-15Simplify use of close_dialog_through_button: allow button by nameMike Kaganski
Change-Id: I59a74e7221808308853f0d893a416fababaf2318 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170493 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-15tdf#158977: remove obsolete rtfexport testFdo44174Justin Luth
Some unit tests were changed or disabled with tdf#136472 adjust ooxml import to handle first header/footer This unit test is basically the same file as rtfexport2's fdo44176.rtf except that one actually has two pages, while this one SAYS it has two pages but only actually has one. Nor are there any headers or footers involved, so it is a completely pointless test. Change-Id: I4ce90f5749ce95426f93d7d0e4fd507c7fdfe5d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170507 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-07-15tdf#158977: restore disable ooxmlimport unit testJustin Luth
Some unit tests were disabled with tdf#136472 adjust ooxml import to handle first header/footer This one simply needed to be re-written to reliably test if it was laid out on page 1. Change-Id: Id749ff9d049691feba7fb155605291a2081a54c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170505 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-07-15Use WeakReference to CWinClipboard instead of pointerMike Kaganski
Change-Id: I30cbbec885e9132d45bf19293890b3e2f581e928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170515 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-15tdf#161264 don't hide paragraph with empty mail merge fieldsOliver Specht
With tdf#35798 db04be037b611e296ef9f2542322c52ed82d7a2b paragraphs containing empty mail merge fields are hidden by default to remove empty lines in address blocks. This is now switched off when importing Word documents. Change-Id: I0f550ff3d29ac499446df9a04676a08d914d12f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169469 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-07-15tdf#161864 Apply character properties to SYMBOL fieldOliver Specht
In RTF import character attributes are applied to symbols imported from \field{ SYMBOL }. Change-Id: I088c47e799380813dce19fd9823cdba6b8048af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169864 Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-07-15tdf#161782 Focus document when Esc is pressed in the Gallery/NavigatorRafael Lima
When Esc is pressed on a Panel that has no visible title, move focus to the document. Change-Id: Ib5571dbd9f8a37017e21d2e01e7b546eb2330751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169668 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2024-07-15tdf#121140: GPG checkbox only for file formats with GPGENCRYPTION flagMoritz Duge
Only ODF-1.2 and ODF 1.3 support GPG encryption. Flat ODF and other formats do NOT, so lets not offer an option that subsequent code path ignores. Change-Id: Ie43be433fbcaa56c76b25e12b58b084ea9bcfd6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168001 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-07-15Simplify boolean logic locally for mbIsPwdEnabled.Moritz Duge
Change-Id: I2b2611e51ce0fdffdd25a75b211ce06b5bfd6b43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167999 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-07-15tdf#148554 RTF import - reset borders on fill cellsOliver Specht
In documents containing tables with rows having different right margins an additional cell is added to fill the gap. These cells should be 'invisible' and therefore need to have no border. Change-Id: I802310251f36fb6b2c00f3cb38786f438e4565a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170179 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-07-15tdf#122756 clone formatting includes table number formatOliver Specht
In clone formatting the number format of the current cell(s) is copied and applied if the target is a table Change-Id: I0b7dc1d5015aeb2262c8d37f76442519c5b6d655 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168184 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Jenkins
2024-07-15Release the lock for getClipboard call to avoid deadlockMike Kaganski
The call stacks that deadlock in my testing: Thread A: CMtaOleClipboard::clipboardChangedNotifierThreadProc() win32u.dll!NtUserMsgWaitForMultipleObjectsEx() user32.dll!MsgWaitForMultipleObjects() vclplug_winlo.dll!`anonymous namespace'::Win32Condition::wait(void * hEvtAbort) Line 92 C++ vclplug_winlo.dll!CMtaOleClipboard::getClipboard(IDataObject * * ppIDataObject) Line 353 C++ vclplug_winlo.dll!CWinClipboard::getIDataObject() Line 158 C++ vclplug_winlo.dll!CDOTransferable::tryToGetIDataObjectIfAbsent() Line 413 C++ vclplug_winlo.dll!CDOTransferable::getClipboardData(CFormatEtc & aFormatEtc) Line 426 C++ vclplug_winlo.dll!CDOTransferable::getTransferData(const com::sun::star::datatransfer::DataFlavor & aFlavor) Line 252 C++ vcllo.dll!TransferableDataHelper::GetAny(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 1484 C++ vcllo.dll!TransferableDataHelper::GetSequence(const com::sun::star::datatransfer::DataFlavor & rFlavor, const rtl::OUString & rDestDoc) Line 2078 C++ vcllo.dll!TransferableDataHelper::InitFormats() Line 1344 C++ vcllo.dll!TransferableDataHelper::TransferableDataHelper(const com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable> & rxTransferable) Line 1156 C++ svtlo.dll!TransferableClipboardListener::changedContents(const com::sun::star::datatransfer::clipboard::ClipboardEvent & rEventObject) Line 52 C++ vclplug_winlo.dll!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::NotifySingleListener<com::sun::star::datatransfer::clipboard::ClipboardEvent>::operator()(const com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboardListener> & listener) Line 275 C++ vclplug_winlo.dll!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::forEach<comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::NotifySingleListener<com::sun::star::datatransfer::clipboard::ClipboardEvent>>(std::unique_lock<std::mutex> & rGuard, const comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::NotifySingleListener<com::sun::star::datatransfer::clipboard::ClipboardEvent> & func) Line 304 C++ vclplug_winlo.dll!comphelper::OInterfaceContainerHelper4<com::sun::star::datatransfer::clipboard::XClipboardListener>::notifyEach<com::sun::star::datatransfer::clipboard::ClipboardEvent>(std::unique_lock<std::mutex> & rGuard, void(com::sun::star::datatransfer::clipboard::XClipboardListener::*)(const com::sun::star::datatransfer::clipboard::ClipboardEvent &) NotificationMethod, const com::sun::star::datatransfer::clipboard::ClipboardEvent & Event) Line 327 C++ vclplug_winlo.dll!CWinClipboard::handleClipboardContentChanged() Line 302 C++ vclplug_winlo.dll!CWinClipboard::onClipboardContentChanged() Line 386 C++ vclplug_winlo.dll!CMtaOleClipboard::clipboardChangedNotifierThreadProc(void * pParam) Line 723 C++ ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 C++ kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() Thread B: CMtaOleClipboard::run() ntdll.dll!NtWaitForAlertByThreadId() ntdll.dll!RtlAcquireSRWLockExclusive() msvcp140d.dll!mtx_do_lock(_Mtx_internal_imp_t * mtx, const _timespec64 * target) Line 93 C++ msvcp140d.dll!_Mtx_lock(_Mtx_internal_imp_t * mtx) Line 165 C++ vclplug_winlo.dll!std::_Mutex_base::lock() Line 56 C++ vclplug_winlo.dll!std::unique_lock<std::mutex>::unique_lock<std::mutex>(std::mutex & _Mtx) Line 149 C++ vclplug_winlo.dll!CWinClipboard::onReleaseDataObject(CXNotifyingDataObject * theCaller) Line 363 C++ vclplug_winlo.dll!CXNotifyingDataObject::Release() Line 77 C++ combase.dll!CStdIdentity::ReleaseCtrlUnk::__l5::<lambda>() Line 1408 C++ combase.dll!ObjectMethodExceptionHandlingAction<void <lambda>(void)>(CStdIdentity::ReleaseCtrlUnk::__l5::void <lambda>(void) action, ObjectMethodExceptionHandlingInfo * pExceptionHandlingInfo, ExceptionHandlingResult * pExceptionHandlingResult, void * __formal) Line 135 C++ combase.dll!CStdIdentity::ReleaseCtrlUnk(unsigned long dwDisconnectType) Line 1411 C++ [Inline Frame] combase.dll!ObjectLibrary::ReferencedPtr<CObjectContext>::operator int ObjectLibrary::Details::BoolStruct::*() Line 1313 C++ combase.dll!CStdMarshal::DisconnectWorker_ReleasesLock(unsigned long dwType, bool logEventIsActive, CObjectContext * explicitServerContext, bool performCallback, CIDObject * pIDDelayRelease) Line 4783 C++ combase.dll!CStdMarshal::Disconnect(unsigned long dwType) Line 4452 C++ [Inline Frame] combase.dll!CStdMarshal::HandlePendingDisconnect(HRESULT) Line 4285 C++ combase.dll!CRemoteUnknown::RemReleaseWorker(unsigned short cInterfaceRefs, tagREMINTERFACEREF * InterfaceRefs, int fTopLevel) Line 1307 C++ rpcrt4.dll!Invoke() rpcrt4.dll!Ndr64StubWorker() rpcrt4.dll!NdrStubCall3() combase.dll!CStdStubBuffer_Invoke(IRpcStubBuffer * This, tagRPCOLEMESSAGE * prpcmsg, IRpcChannelBuffer * pRpcChannelBuffer) Line 1479 C++ [Inline Frame] combase.dll!InvokeStubWithExceptionPolicyAndTracing::__l6::<lambda_c9f3956a20c9da92a64affc24fdd69ec>::operator()() Line 1151 C++ combase.dll!ObjectMethodExceptionHandlingAction<<lambda_c9f3956a20c9da92a64affc24fdd69ec>>(InvokeStubWithExceptionPolicyAndTracing::__l6::<lambda_c9f3956a20c9da92a64affc24fdd69ec> action, ObjectMethodExceptionHandlingInfo * pExceptionHandlingInfo, ExceptionHandlingResult * pExceptionHandlingResult, void *) Line 94 C++ [Inline Frame] combase.dll!InvokeStubWithExceptionPolicyAndTracing(IRpcStubBuffer * pMsg, tagRPCOLEMESSAGE *) Line 1149 C++ combase.dll!DefaultStubInvoke(bool bIsAsyncBeginMethod, IServerCall * pServerCall, IRpcChannelBuffer * pChannel, IRpcStubBuffer * pStub, unsigned long * pdwFault) Line 1218 C++ combase.dll!SyncServerCall::StubInvoke(IRpcChannelBuffer * pChannel, IRpcStubBuffer * pStub, unsigned long * pdwFault) Line 791 C++ [Inline Frame] combase.dll!StubInvoke(tagRPCOLEMESSAGE * pMsg, const _GUID &) Line 1483 C++ combase.dll!ServerCall::ContextInvoke(tagIPIDEntry * ipidEntry) Line 1421 C++ [Inline Frame] combase.dll!DefaultInvokeInApartment(ServerCall *) Line 3257 C++ combase.dll!ReentrantSTAInvokeInApartment(ServerCall * serverCall, tagIPIDEntry * ipidEntry) Line 110 C++ combase.dll!ComInvokeWithLockAndIPID(ServerCall * pServerCall, tagIPIDEntry * pIPIDEntry) Line 2152 C++ combase.dll!ThreadDispatch(ServerCall * pServerCall) Line 1637 C++ combase.dll!ThreadWndProc(HWND__ * window, unsigned int message, unsigned __int64 wparam, __int64 params) Line 720 C++ user32.dll!UserCallWinProcCheckWow() user32.dll!DispatchMessageWorker() [Inline Frame] combase.dll!CCliModalLoop::MyDispatchMessage(tagMSG *) Line 2959 C++ combase.dll!CCliModalLoop::PeekRPCAndDDEMessage() Line 2563 C++ combase.dll!CCliModalLoop::BlockFn(void * * ahEvent, unsigned long cEvents, unsigned long * lpdwSignaled) Line 2055 C++ combase.dll!ModalLoop(CSyncClientCall * pClientCall) Line 169 C++ [Inline Frame] combase.dll!ThreadSendReceive(tagRPCOLEMESSAGE *) Line 7259 C++ [Inline Frame] combase.dll!CSyncClientCall::SwitchAptAndDispatchCall(tagRPCOLEMESSAGE * pMessage) Line 5735 C++ combase.dll!CSyncClientCall::SendReceive2(tagRPCOLEMESSAGE * pMessage, unsigned long * pstatus) Line 5297 C++ combase.dll!SyncClientCallRetryContext::SendReceiveWithRetry(tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus, ClientCall * pClientCall, bool * pbIsAutoRetry) Line 1502 C++ combase.dll!CSyncClientCall::SendReceiveInRetryContext(SyncClientCallRetryContext * pRetryContext, tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus) Line 582 C++ combase.dll!ClassicSTAThreadSendReceive(CSyncClientCall * pClientCall, tagRPCOLEMESSAGE * pMsg, unsigned long * pulStatus) Line 564 C++ combase.dll!CSyncClientCall::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 787 C++ combase.dll!CClientChannel::SendReceive(tagRPCOLEMESSAGE * pMessage, unsigned long * pulStatus) Line 659 C++ combase.dll!NdrExtpProxySendReceive(void * pThis, _MIDL_STUB_MESSAGE * pStubMsg) Line 1989 C++ rpcrt4.dll!NdrpClientCall3() combase.dll!ObjectStublessClient(void * ParamAddress, __int64 * FloatRegisters, long Method) Line 366 C++ combase.dll!ObjectStubless() Line 176 combase.dll!CStdMarshal::RemoteAddRef(tagIPIDEntry * pIPIDEntry, OXIDEntry * pOXIDEntry, unsigned long cStrongNeed, unsigned long cSecureNeed, int fGiveToCaller) Line 8489 C++ [Inline Frame] combase.dll!CStdMarshal::GetNeededRefs(tagSTDOBJREF *) Line 3654 C++ combase.dll!CStdMarshal::ConnectCliIPIDEntry(tagSTDOBJREF * pStd, OXIDEntry * pOXIDEntry, tagIPIDEntry * pEntry) Line 3338 C++ combase.dll!CStdMarshal::MakeCliIPIDEntry(const _GUID & riid, tagSTDOBJREF * pStd, OXIDEntry * pOXIDEntry, tagIPIDEntry * * ppEntry) Line 3108 C++ combase.dll!CStdMarshal::UnmarshalIPID(const _GUID & riid, tagSTDOBJREF * pStd, OXIDEntry * pOXIDEntry, void * * ppv) Line 2621 C++ combase.dll!CStdMarshal::UnmarshalObjRef(tagOBJREF & objref, void * * ppv) Line 2479 C++ combase.dll!UnmarshalSwitch(void * pv) Line 2112 C++ combase.dll!UnmarshalObjRef(tagOBJREF & objref, EffectiveUnmarshalingPolicy policy, void * * ppv, int fBypassActLock, CBaseCall * callMarshalingContext, CStdMarshal * * ppStdMarshal) Line 2261 C++ combase.dll!InternalGetWindowPropInterface2(HWND__ * hWnd, unsigned __int64 dwCookie, int fCallStrongNamedProcesses, const _GUID & iid, void * * ppv, int * pfLocal) Line 285 C++ ole32.dll!UnmarshalFromEndpointProperty(HWND__ * hWnd, int fDragDrop, int fCallStrongNamedProcesses, IUnknown * * ppUnk, int * pfLocal) Line 407 C++ ole32.dll!GetInterfaceFromWindowProp(HWND__ * hWnd, const _GUID & fCallStrongNamedProcesses, int ppunk, IUnknown * *) Line 440 C++ ole32.dll!CClipDataObject::CacheDataPointer() Line 223 C++ ole32.dll!CClipDataObject::QueryInterface(const _GUID & riid, void * * ppvObj) Line 886 C++ [Inline Frame] combase.dll!IUnknown::QueryInterface(INoMarshal * *) Line 138 C++ combase.dll!CoMarshalInterface(IStream * pStm, const _GUID & riid, IUnknown * pUnk, unsigned long dwDestCtx, void * pvDestCtx, unsigned long mshlflags) Line 1133 C++ combase.dll!wCoMarshalInterThreadInterfaceInStream(const _GUID & riid, IUnknown * pUnk, IStream * * ppStm) Line 1046 C++ combase.dll!CoMarshalInterThreadInterfaceInStream(const _GUID & riid, IUnknown * pUnk, IStream * * ppStm) Line 709 C++ vclplug_winlo.dll!MarshalIDataObjectInStream(IDataObject * pIDataObject, IStream * * ppStream) Line 158 C++ vclplug_winlo.dll!CMtaOleClipboard::onGetClipboard(IStream * * ppStream) Line 465 C++ vclplug_winlo.dll!CMtaOleClipboard::mtaOleReqWndProc(HWND__ * hWnd, unsigned int uMsg, unsigned __int64 wParam, __int64 lParam) Line 547 C++ user32.dll!UserCallWinProcCheckWow() user32.dll!DispatchMessageWorker() vclplug_winlo.dll!CMtaOleClipboard::run() Line 656 C++ vclplug_winlo.dll!CMtaOleClipboard::oleThreadProc(void * pParam) Line 673 C++ ucrtbased.dll!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 C++ kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() Thread A locks the mutex, and calls CMtaOleClipboard::getClipboard, which is synchronous; the call is marshaled to Thread B, which eventually tries to release a data object, which requires the mutex. Change-Id: I5ad8847b98ca23ad84c0595a2baad2c13f1e809e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170504 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-15delay parsing of formula in EnhancedCustomShape2dNoel Grandin
We create a bunch of temporary copies of these during layout in writer, and we don't appear to need the equation results at that point. Speeds up display of a complex DOCX file load by 10% Change-Id: Ic5870931caba13cd79b07617d04b70616f06c5b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170498 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-07-15cool#9504 sw: don't invalidate num rules when pasting into a non-num paragraphMiklos Vajna
The bugdoc has ~300 pages of content, most of that is bullets, but otherwise not complex, pasting a trivial string at doc end (which is not a bulleted paragraph) takes a noticeable time: debug:20449:20330: SwLayAction::InternalAction: start debug:20449:20330: SwLayAction::InternalAction: end, took 268 ms Profiling points out that we re-layout the internal document, which is not expected: we just pasted on the first page, causing no layout change on page 2 and later pages. Watching who turns on m_bInvalidContent on the page frames, it can be noticed that SwReader::Read() invalidates all numberings after pasting. Fix the problem by not doing that in case we paste plain text and we know the insertion point is not in a numbering: the invalidation is not useful in this case and fixes the unexpected delay. Other related ideas are 1) don't do the layout for all pages in one go 2) recognize that the bullets need no invalidation, unlike an actual numbering with numbers. Neither of these are done in this commit yet. Change-Id: Id7b2c022b31acb358f42ddd77195db70ae451109 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170499 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-07-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c6956d32c0cfa26e219bd2e32f66d3fe7796ad76 - tdf#162025 Fix param separator of several functions Change-Id: Ib4622836fbdfa5084edf38cd9fb13db815382c6d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170494 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-07-15Update git submodulesBogdan Buzea
* Update helpcontent2 from branch 'master' to 6dccce115b41c89de6b25b6b4fbddd0a34434115 - tdf#161914 Rename "Pen Width" to "Pen Thickness" Change-Id: I15c6106b23e72f6fb0e7b427645eb236172803fe Reviewed-on: https://gerrit.libreoffice.org/c/help/+/170481 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
2024-07-15tdf#125051: rework and improve uitestXisco Fauli
The test still fails if f7936b8ccd0ce9bea3a5e780443e4ae8f35b9da1 "tdf#125051: fix spellchecking on Calc" is reverted. Change the test to avoid having the second dialog prompted when launching the spell dialog. The options dialog part is removed because it's not needed for testing the crash Change-Id: I337376dd9ad0f5454534821d259589a9bd68af35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170495 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-15vcl: Use nNewPos consistentlyMichael Weghorn
Use the `nNewPos` variable for assigning to `mnCurPos` in `ToolBox::MouseButtonDown` as well, rather than `i` which was the loop variable above, and whose value was assigned to `nNewPos` for the case that this code path is entered. Using `nNewPos` consistently makes a bit more obvious that this is the same as in the surrounding lines. Change-Id: I5ce2da04310f21070931549a599248fdcad45317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170489 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-07-15tdf#161871 Revert "Removed Type and Usage Columns from Certificate Chooser"Samuel Mehrbrodt
The commit broke the display of all columns except the first one in all backends except gtk3. Also it's not clear why those columns are deemed superfluous; see discussion in tdf#161871 This reverts commit 9f327102c435887bbae650b3a573f44500b6f534. Change-Id: Idc3496122137f98c23bb7df8e36b17281fc948d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170491 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2024-07-15Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 0e95a8dfb0b499b18834776b911c0b60725c215e - update translations for master/24-8 Change-Id: I959d23423e7f5f6f5cf91533b3ed9888e4b0a999
2024-07-15ITEM: secure HashedItemInstanceManagerArmin Le Grand (allotropia)
This one still used just a hash to feed a unordered_map what is not safe. Changed to unordered_set and added hash and equal operators. Change-Id: I2a426c449536747ad59f8bd8781a7eadceea9183 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170417 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-15tdf#161501 icon choice ctrl: Highlight full entry areaMichael Weghorn
For background and borders/frames drawn to highlight the currently selected/focused/mouse-hovered entry in the icon choice control, use the entry's full area and don't restrict the bottom edge to where the text ends. It's also unclear to me why 1 pixel would be subtracted for the top and right edge when calculating the rect - drop that as well. (There is a line of a pixel or so in between the entries, but since that actually doesn't belong to any of the entries -- clicking there doesn't change the selected entry -- also don't highlight it as part of one of the entries.) This addresses this (preexisting) issue mentioned in [1]: > Maybe for a future patch... but the height from `CalcFocusRect` > is too low. It barely covers the item and leaves gaps with > respect to subsequent items. [1] https://gerrit.libreoffice.org/c/core/+/170341/comment/57dc568d_1c0a8cf2/ Change-Id: I3369401c0bbdb77a054da9f57ac70f30f97c9cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170393 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Tested-by: Jenkins
2024-07-15remove RecalcObjOrdNums in DoTextBoxZOrderCorrectionNoel Grandin
(1) We already do this recalculation automatically using a dirty flag. (2) Add a custom method so we don't trigger that recalculation here Speeds up display of a complex DOCX file load by 10% Change-Id: I2a8c975ba0711172bc3e0c20c0e89f08351b6126 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170431 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-07-15cid#1607843 Use of auto that causes a copyCaolán McNamara
and cid#1555160 Use of auto that causes a copy Change-Id: I2e2056ddbfb2d11d288a5b2df273e8bc049387fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170455 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-15Unused return valueMike Kaganski
Change-Id: Ibe3d508cfb45314fa81a5ee4f85eda7207482274 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170488 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-15cid#1607327 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1554706 COPY_INSTEAD_OF_MOVE cid#1554733 COPY_INSTEAD_OF_MOVE cid#1554736 COPY_INSTEAD_OF_MOVE cid#1554738 COPY_INSTEAD_OF_MOVE cid#1554740 COPY_INSTEAD_OF_MOVE Change-Id: I766cff4ef8eb4256d26f51d7d9dc64442c4bc728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170453 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-15svx: prefix members of SdrUndoObjOrdNumMiklos Vajna
See tdf#94879 for motivation. Change-Id: I0ab21ca5171b5d5b66542dbf7157db0c156e45b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170487 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-07-15Added pyuno demo for key and mouse handlers and listeners.Moritz Duge
Change-Id: I5b2f70061c5eee7a1068ec110d34ddadc5200bff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169584 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2024-07-15tdf#108828 Prevent leaking keys from previous signing sessionsSamuel Mehrbrodt
Usuccessful signing sessions (e.g. abort when password is requested) left their key in the context. On the next try, the former key would also be used to sign. Change-Id: I55b9201df229cae40863a0a19b238029607d1848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170388 Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Tested-by: Jenkins
2024-07-15Resolves tdf#162018 Unexpected loss in focus in the "Manage Changes"Jim Raykowski
window when adding a change in the document (Track changes mode) Change-Id: Iecb49346cfe5d4f447b07ec5451c753c90dddb44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170460 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-07-15tdf#161914 Rename "Pen Width" to "Pen Thickness"Bogdan Buzea
Change-Id: Ic16370a0e583ed74da4c6c3548b9eb2cea9d1b75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170363 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2024-07-14Make extended tooltip translatableMing Hua
Change-Id: Ic626f31c0257a7f70cfeee5d16a3269a7958f01c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170353 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-07-14tdf#148647: make sure to update own content on Win clipboard changeMike Kaganski
Before, only a new call to setContents, or destruction of the data object referenced from CWinClipboard, would force CWinClipboard to clean its m_pCurrentClipContent. A data object could be referenced elsewhere, and so not get destroyed on clipboard change; this kept the value of m_pCurrentClipContent, and all the following calls to getContents would still return that stuck own data object. This change makes CWinClipboard store new own data object pointer into temporary m_pNewOwnClipContent. In onClipboardContentChanged notification, the value is moved to m_pCurrentOwnClipContent. This ensures that following onClipboardContentChanged events will clear m_pCurrentOwnClipContent, preventing stuck clipboard content. Change-Id: Idd0a64a820d79bede9deceba8d5800b7fc61e66b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170459 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-07-14drop these fuzzers to short lengths temporarilyCaolán McNamara
oss-fuzz has got into that annoying state where the original bugs are not reproducible, and probably fixed, but some follow up issues trigger the same problem so the original won't close and its not easy to see the new cases. Change-Id: I8e515c0c5b8eafe40bfda695774ef56ec24948c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-14cid#1607572 silence bogus Copy-paste errorCaolán McNamara
Change-Id: Id8355a033089a47299d76e1743b7da5a1b4a5d5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170454 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-14Revert "boost::unordered_map to std::unordered_map in configmgr::Partial"Stephan Bergmann
This reverts commit 154b2040102d74aeb4c5d0cf07f1bdc90d265d52, which is known broken, as (unlike for boost::unordered_map) there is no guarantee that std::unordered_map works for incomplete value types, and indeed there is build environments that started to fail now with > In file included from /home/libo/src/core/configmgr/source/partial.cxx:23: > In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/set:60: > In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:63: > In file included from /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_algobase.h:64: > /usr/lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_pair.h:218:11: error: field has incomplete type 'configmgr::Partial::Node' > _T2 second; ///< The second member > ^ [...] Change-Id: Ie8d041bcf3d3b1b6aeede73adbaf14676250c4bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170467 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-07-14Try to simplify Windows clipboard lockingMike Kaganski
Having three mutexes for one object is a bit too much. It is impossible to handle it properly. Issues like tdf#148647, that affect many users, but have no reliable reproducer, hint that possibly there is a deadlock somewhere in the code that should clear m_pCurrentClipContent, or maybe something similar. This drops both local mutexes, and uses inherited m_aMutex everywhere to guard accessto all the local data. I hope that this this will make debugging of the problems around the clipboard possible. But it looks invasive, of course. Change-Id: I2311b1b4702f766e3e5e0d104f9b2b2999aa53c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170450 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-07-14cid#1555652 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1555655 COPY_INSTEAD_OF_MOVE cid#1555658 COPY_INSTEAD_OF_MOVE cid#1555665 COPY_INSTEAD_OF_MOVE cid#1555667 COPY_INSTEAD_OF_MOVE cid#1555670 COPY_INSTEAD_OF_MOVE cid#1555675 COPY_INSTEAD_OF_MOVE cid#1555684 COPY_INSTEAD_OF_MOVE cid#1555687 COPY_INSTEAD_OF_MOVE cid#1556539 COPY_INSTEAD_OF_MOVE cid#1556542 COPY_INSTEAD_OF_MOVE cid#1557448 COPY_INSTEAD_OF_MOVE cid#1557449 COPY_INSTEAD_OF_MOVE Change-Id: I3567528e559bca0031c4f5b46801e3130073633b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-14cid#1555646 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I477cb9b74c99b32eb06e054fa38dd3ffa6bb77da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170447 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-14cid#1608181 Double lockCaolán McNamara
Change-Id: Id6121213f11c4ce0c855a0937fd2d7c81946c076 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170446 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-14cid#1608236 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I3f46c1d7e68dbf79ddbc9dc50d2735ebe1727b14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-14cid#1607284 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Iacaf551260e878f39a36adc8b6d0ea142c092f98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170444 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-07-14cid#1608349 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I00f4afb09907b91c4d180a9dd7464226bb327af3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-07-14cid#1608424 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Id56d0bf130e2c0a5935a577b82db6c6edd4c7610 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170442 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-30 16:02:11 +0000