summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-04-18gla11y: Add dependency on .ui filesSamuel Thibault
During the gla11y work, the dependency of UIA rules on the .ui files got lost, this adds it so that modifying a .ui file triggers checking accessibility with gla11y. Change-Id: I62103ca1783c2f532d7647384c1add1b557b37a1 Reviewed-on: https://gerrit.libreoffice.org/53116 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18Keep the still relevant part of external/icu/icu4c-ubsan.patch.1Stephan Bergmann
...which f247f08e370626bbb427acd8f4a400fd875350a3 "Upgrade to ICU 61.1" had removed completely, in error. Change-Id: I7239011561851333cac58e54e4e7d590b8529dbc
2018-04-18vcl: WNT: *really* avoid calling SHAddToRecentDocs() from unit testsMichael Stahl
At least in sw unit tests, AddToRecentDocumentList is apparently called too early so the variable isn't set yet. It's much better to check IsHeadlessMode anyway because that is set in more situations, and if you run soffice --headless you probably don't want the corresponding files to show up in Explorer's Recently list. Change-Id: I8ada3659d05c94d072ba30859090e835a595e9ea Reviewed-on: https://gerrit.libreoffice.org/53100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-18Fix translation domain in a couple of .ui filesAdolfo Jayme Barrientos
Change-Id: I0eb57c1c2e4fe53906ecf9da1d4841bbc250c4e5
2018-04-18tdf#117044 Base crash when attempting to edit a table definitionNoel Grandin
this story started in commit 433fc2214c980abd82fa6240f45e634a53a3c61c (patch) sal_uIntPtr->sal_Int32 in MultiSelection which caused a regression, reported in tdf#116981. I attempted to fix it in commit 235d61890512894e27f4f81e38a325eee3c67b30 Date: Fri Apr 13 17:14:59 2018 +0200 tdf#116981 Base when deleting table column and commit 0973e1f4e727a3204c843398bcb0e6a411b1a02d Date: Mon Apr 16 08:28:16 2018 +0200 follow on for tdf#116981 But my analysis was wrong. To recap, and get it right: Before all this, MultiSelection stored it's values internally as sal_uIntPtr, but returned them as long in FirstSelected(), NextSelected(),and SFX_ENDOFSELECTION was defined to be ULONG_MAX. On 64-bit Linux, sal_uIntPtr is typedefed to sal_uInt64, and ULONG_MAX is 2^64, which means that previously, the SFX_ENDOFSELECTION value was being converted from 2^64 to -1 when it was returned, which was why these loops worked. So convert SFX_ENDOFSELECTION to -1 to match how how the external code wants it to be (and the code frequently uses -1 instead of SFX_ENDOFSELECTION or BROWSER_ENDOFSELECTION) The modification to MultiSelection::Select is necessary because previously, nCurMin and nCurMax would be == ULONG_MAX, and we would, somewhat unintuitively, end up in the // expand on left side? if( nTmpMax < nCurMin ) part of the logic, which would do the right thing, even if a little weirdly. Change-Id: I7c830b0392add394d8c294247f75a2ffe8017c24 Reviewed-on: https://gerrit.libreoffice.org/53022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18tdf#116990 Unwanted line breaks if ODS export to XHTMLAndreas Brandner
Change-Id: I86cc48d74f0572a7ba18beabbaf307bcaa069d38 Reviewed-on: https://gerrit.libreoffice.org/53087 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-04-18convert DelCellCmd to scoped enumNoel Grandin
Change-Id: I4766fc874026f218b33e66944b98562d1ec614d3 Reviewed-on: https://gerrit.libreoffice.org/53088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18vcl: WNT: avoid calling SHAddToRecentDocs() from unit testsMichael Stahl
On Windows 10, Explorer spends ridiculous amounts of CPU with updating its recent documents view while tests are running. Change-Id: I170306a392900fc4b911950e36f13f1af0e405ac Reviewed-on: https://gerrit.libreoffice.org/53058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-18Upgrade to language-subtag-registry-2018-03-30Eike Rathke
Change-Id: I0cc3104cfccebe5d7e3fcafdb71d73a9d8d5e3d8
2018-04-18Upgrade to ICU 61.1Eike Rathke
Change-Id: I89c1c3d13d85decc72576744de2a16d20471d29d Reviewed-on: https://gerrit.libreoffice.org/53064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-04-18Related: tdf#117068 inform salframe that there's a modal dialog runningCaolán McNamara
Change-Id: Ie95fbc1586e11396271fb43e6117f39f4f61cb0e Reviewed-on: https://gerrit.libreoffice.org/53086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-18fix oss-fuzz buildCaolán McNamara
https://github.com/google/oss-fuzz/issues/1335 Change-Id: I7681413d5e45e1e2f1ff62a077a067b11e42b4bb Reviewed-on: https://gerrit.libreoffice.org/53082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-18sw HTML import: use GraphicDescriptor to determine default sizeMiklos Vajna
Rather than the hardcoded HTML_DFLT_IMG_WIDTH / HTML_DFLT_IMG_HEIGHT defines. Change-Id: I4ed2207ce3fdcd247054941d91eb67a679fb370c Reviewed-on: https://gerrit.libreoffice.org/53081 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18avoid error message from configure about clang's header for compiler pluginsLuboš Luňák
The header fails to compile without C++11 with recent Clang, and although configure currently passes the check because the existence of the header is considered to be enough, it still prints a distracting error message about the compile check failing. Change-Id: Icf037114b73122f193629e17a8e2b0e2bca3a990
2018-04-18Fix typoAndrea Gelmini
Change-Id: Ia4733366338ceda7af4ee26914be38798b8c7e16 Reviewed-on: https://gerrit.libreoffice.org/53079 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-18tdf#75398 - Replace hicontrast by Sifrheiko tietze
Change-Id: Idd581cb73d0d32d808177f86beaf50dcc6bf53c1 Reviewed-on: https://gerrit.libreoffice.org/53053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-18swriter: Add missing labellingSamuel Thibault
The page header and footer panels were completely missing labelling The "Custom" label is actually used a a resource, suppress the labelling warning for it. Change-Id: I3ca6b1984fab23478a11e916f26702592a5ee991 Reviewed-on: https://gerrit.libreoffice.org/52948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-18swriter: Add missing labellingSamuel Thibault
The page style panel was completely missing labelling. The "Custom" label is actually used a a resource, suppress the labelling warning for it. Change-Id: I741ddea4a1608f0d7084dda79af2ab59a6fc5812 Reviewed-on: https://gerrit.libreoffice.org/52947 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-18swriter: Add missing labellingSamuel Thibault
The page format panel was completely missing labelling. The "Custom" label is actually used a a resource, suppress the labelling warning for it. Change-Id: I1c026f7a743b5da45f244d2527ab2b66165ccd4a Reviewed-on: https://gerrit.libreoffice.org/52946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-18tdf#94300: Use named gradients | hatches | bitmapsKatarina Behrens
this helps chart sidebar to identify them by name when switching between different kinds of fill types. Also prep work for tdf#113688 Change-Id: I7cb148562cfa50704f27fa3273d93941eb01a7ab Reviewed-on: https://gerrit.libreoffice.org/52961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-04-18Resolves: tdf#117046 messages set after dialog created should affect sizeCaolán McNamara
Change-Id: I03688ec1d869720b4a042602ff1da15727174592 Reviewed-on: https://gerrit.libreoffice.org/53046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-18tdf#116195 swap a compatibility valuePatrick Jaap
There was a minor bug in the compat flag, leading to a regression from commit 8d62b79f168180c6992eb483ec864d473050635f Change-Id: I1e468e665a583ef15b6e474c3adb32f1dcf98f46 Reviewed-on: https://gerrit.libreoffice.org/52674 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-18tdf#42949 Remove unnecessary localization headers of sfx2Gabor Kelemen
Found by searching for the header names and the localization functions: git grep -l -e \<sfx2/sfxresid.hxx\> -e \<sfx2/strings.hrc\> | xargs grep -c -e SfxResId -e GetResString | grep :0$ | grep -v /pch Change-Id: If0571ae4029b5fb2699cdd6ea768d3cd240bdce3 Reviewed-on: https://gerrit.libreoffice.org/53073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-18tdf#42949 Remove unnecessary localization headers of editengGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<editeng/eerdll.hxx\> -e \<editeng/editrids.hrc\> | xargs grep -c EditResId | grep :0$ | grep -v /pch Change-Id: Ic542ceee09352cb52dcdc9780d4cb1890e02f383 Reviewed-on: https://gerrit.libreoffice.org/53062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-18tdf#116420: Windows: Test if a filepath redirects to a WebDAV resourceMike Kaganski
In Windows, filesystem redirectors can map WebDAV resources to UNC paths, or to drive-based "local" paths; so a WebDAV URI of the form "http://WebDADServer/root/directory/File.ext" may be accessed using "\\WebDADServer\root\directory\File.ext" or "Z:\directory\File.ext". When using these paths, failure to create a lockfile aside the opened document should not be considered an error; so this patch checks for this. Regression from commit 6ca3b3648e25ae9d4d2d29a0df83349198ec3f5e. Change-Id: I1de55b66447dc91d22b6d2b5b121de96bf32e4ee Reviewed-on: https://gerrit.libreoffice.org/53070 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-18sw: fix some IWYU warningsMiklos Vajna
Change-Id: Idff219e1c8f18adaa0f445a5469650c7793cae3a Reviewed-on: https://gerrit.libreoffice.org/53066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-18Updated coreStephan Bergmann
Project: help 23665d6b04829ac2b949c88de261c6f7b2de8baa Remove unused sourceMappingURL Caused Source map error: TypeError: NetworkError when attempting to fetch resource. Resource URL: file:///data/sbergman/lo-clang/core/instdir/help/fuse.js Source Map URL: fuse.js.map when loading <file:///.../instdir/help/index.html?swriter/.uno:HelpIndex?Language=en-US&System=UNIX&Version=6.1> in the browser. Change-Id: I5d318fe8c358cedbb961113561edea3b6d4a2ce1 Reviewed-on: https://gerrit.libreoffice.org/53077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-18-Werror=unused-parameterStephan Bergmann
Change-Id: Ibba26b0eb3d85f2da3caafa1b8cc60357de297d5
2018-04-18Find non-set-elements marked as mandatoryStephan Bergmann
Change-Id: I7f75c835339b61ba9e545c13d7e5bb208c12df4c Reviewed-on: https://gerrit.libreoffice.org/53069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-18rename Neu->New in svxNoel Grandin
Change-Id: I77a49d55dd49b0fd41f5335ac30a5484ac130250 Reviewed-on: https://gerrit.libreoffice.org/53050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18Translate::GetReadStringHook() may be nullStephan Bergmann
e.g., during CppunitTest_sc_screenshots Change-Id: I71bd617df629dab57c73252db0e46ab51eee2a18
2018-04-18Revert two last changes to Upgrade tableMike Kaganski
This reverts commits 914f6385d98f8c898102c971a4d5b0eb9f075ef0 and a6045159237419ce8fa49202c672e3895f0ab30a. A investigation required why is the problem with them; meanwhile, they break builds. Change-Id: I713b27dd64e8ac7beb2757c362765b60ce191f8d Reviewed-on: https://gerrit.libreoffice.org/53078 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-18Do use -O1 for Apple Clang older than 9.1.0Tor Lillqvist
Don't want to risk breaking something by using -O2 with an older Clang, even if I don't remember exactly what the issue was when introducing the -O1 in 7b660e1423554928350e1de2cd4cb7eb577a27ec. Change-Id: I2adeb0e8eb85a9b5021fca3d9e1e703cb5604a81 Reviewed-on: https://gerrit.libreoffice.org/53068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-04-18tdf#117021: fix datasource exampleJulien Nabet
Change-Id: I1e4112ab18e76eec4cb11fb4bc3a7cea67e7ae1d Reviewed-on: https://gerrit.libreoffice.org/53065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-18NB Impress tabbed toolbar big updateandreas kainz
Change-Id: I4e0a6e3eb1f945daf2036bc1d009ae96d5a72802 Reviewed-on: https://gerrit.libreoffice.org/53072 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-04-18Resolves: tdf#117068 wrong parent for exception dialogCaolán McNamara
Change-Id: I51e6b32593f2e67585c6c45b0b1daefcf4860e20 Reviewed-on: https://gerrit.libreoffice.org/53067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#117015 EMF+ Fix for displaying EMF+ files where GetDC is usedBartosz Kosiorek
With EMF+ Only mode, still the EMF records could be used for displaying objects, by using Get Device Context (GetDC). Files identified as EMF+ Only can contain both EMF+ records and EMF records. All EMF+ records are used to render the image. The EMF records that are part of the drawing are those preceded by a Get Device Context record. Unfortunately after finishing EMF drawing, the clip region was not reset. As a result records after EMF record was not displayed. With this patch, the issue was fixed by resetting clip region. Change-Id: I998b14e7c3b56a7711ba6a7bec08ec2097e0dfce Reviewed-on: https://gerrit.libreoffice.org/52897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-04-17NB Implementation: sync impress label with writer/calcandreas kainz
Change-Id: I6d87ddc3520c74f776321329e39e7562c93ad6da Reviewed-on: https://gerrit.libreoffice.org/53060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-17grab an early libetonyek-0.1.8 snapshotCaolán McNamara
Change-Id: Ib31a8cb75f4cebcaa974b95097270362b3b26aef Reviewed-on: https://gerrit.libreoffice.org/52689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Resolves: tdf#116928 dispatch hyperlink dialog new doc in idle callbackCaolán McNamara
collect up all the piece of data that the dispatch requires and launch it in an idle. So if a dialog appears its embedded mainloop will not return to body if the deleted SvxHyperlinkNewDocTp Change-Id: Ie978bc552c3b88dc11eae2ec49417cc8bd0f02bc Reviewed-on: https://gerrit.libreoffice.org/53056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#117034 check for runtime version check gtk_menu_popup_at_rectCaolán McNamara
Change-Id: I2386c2d8f7c6754b197df9216eed82e0152a35c8 Reviewed-on: https://gerrit.libreoffice.org/53045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Related: tdf#116928 set specific parent for document warning dialogCaolán McNamara
Change-Id: I827563c16a2ae59c698e1bfa82022a11f5256483 Reviewed-on: https://gerrit.libreoffice.org/53055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Fix typosAndrea Gelmini
Change-Id: I3423511c0d7a13bd28e9a808e0d634148b759643 Reviewed-on: https://gerrit.libreoffice.org/53057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-17More containsPreprocessingConditionalInclusion checking in loplugin:casttovoidStephan Bergmann
...to avoid false positive with --disable-dbgutil in SfxApplication ctor (sfx2/source/appl/app.cxx), which contains bool bOk = InitializeDde(); #ifdef DBG_UTIL ... #else (void)bOk; #endif Change-Id: I4de6322a848a9c6aea3057e4598b2161888dee6a Reviewed-on: https://gerrit.libreoffice.org/53051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-17We don't build for i386 on macOS anywayTor Lillqvist
No no need to patch the Firebird build settings for i386. Change-Id: Ic187ff462325511a9a498e312f54350be7542366 Reviewed-on: https://gerrit.libreoffice.org/53054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-04-17weld DropDownFieldDialogCaolán McNamara
Change-Id: I58ceb44f96d8ae3e3732b85eafd44c4d6eab42aa Reviewed-on: https://gerrit.libreoffice.org/53035 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17tdf#45904 Move _SheetSortDescriptor Java tests to C++Jens Carl
The C++ tests are now located in sheetsortdescriptor2.(hxx|cxx), because this is the latest implementation of the UNO API interface (SheetSortDescriptor2.idl). Change-Id: I5b11a38f6cd0473714c4d57ee92889bfd7605e83 Reviewed-on: https://gerrit.libreoffice.org/52930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-04-17let's just run ResHookProc over everythingCaolán McNamara
Change-Id: I1c675ffbfd4737a6c618c2b4d548e27c1ec295b7 Reviewed-on: https://gerrit.libreoffice.org/53038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-17Updated coreStephan Bergmann
Project: help f4c54d3af32ca4c6d02afff71532dbf10147fd33 Include help2.js not help.js Otherwise, causes a ReferenceError: getParameterByName is not defined when loading <file:///.../instdir/help/index.html?swriter/.uno:HelpIndex?Language=en-US&System=UNIX&Version=6.1> in the browser. Change-Id: I13cdd36e44859a74c9a1b4e3b020fed2f56edda0 Reviewed-on: https://gerrit.libreoffice.org/53048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-17Resolves: tdf#117057 use same style warning as elsewhereCaolán McNamara
Change-Id: I3072c7725d0769c0a4a1974664b1546ca3ee35ad Reviewed-on: https://gerrit.libreoffice.org/53036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-28 07:23:04 +0000