summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-05-17sc: change (char, background) style colors when changing the themeTomaž Vajngerl
This adds a Calc specific ThemeColorChanger, which changes the character and background colors in styles. In addition add the changes that make this possible - support in SvxBrushItem for the ComplexColor, making sure that ComplexColor is properly passed to other items (mainly from color picker),... Change-Id: Id2e98c42bbe195a0f75cc8951ff69f6d7eea6be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151667 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-05-17sw floattable: disable chain UI if the frame is allowed to split alreadyMiklos Vajna
This is similar to d9cd177b9b08d454882dd77ffeb825a184a1b540 (sw floattable: disable UI if the frame is chained already, 2023-05-16), but here the fly is split and we disallow chaining, not the other way around. Change-Id: I637d594d41ba9a80d58bc0bef37627d8104293ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151856 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-17ScriptForge - database.GetRows() tdf#155204 error when no dataJean-Pierre Ledure
The complete expected bheviour is: when there is no data returned by the query, - either GetRows() returns an empty array, (Header := False) - or GetRows() returns an array with a single row containing the column names only (Header := True) In the example given in the bug report, GetRows() gives an unexpected error. Actually the "end-of-file" status is tested with the isAfterLast() indicator. It seems better to rely on the Boolean value returned by the first() and next() methods applied on the resultset. Change-Id: Ibe97dbbcb03d45ebb9184fab2733abe4e04963a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151844 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-05-17Removed more constant concatenationsVojtěch Doležal
Change-Id: I4fce6eeb6652914e1883037b41a2dc3c09a88ada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-17CppunitTest_sw_htmlexport: avoid reqif magic in testReqIfTable2Miklos Vajna
Set the filter options explicitly, rather than inferring it from the test name. Change-Id: Id55d735693be8d87cbc9b7048ef5533a5b7b41d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151849 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-17tdf#138726 LRSpaceItem ooxmlexport12: don't test implementationJustin Luth
To get the desired effect, properties were being spammed as direct formatting. Now that LRSpaceItem has been split, there is no/less need to spam like that. Allows https://gerrit.libreoffice.org/c/core/+/151821 make CppunitTest_sw_ooxmlexport12 CPPUNIT_TEST_NAME=testTdf108493 Change-Id: I7b7f109eacb79737d898da5bcf87162b9fa6529e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151850 Tested-by: Jenkins Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-17Resolves: tdf#153790 Suppress duplicated end part sheet reference, tdf#103890Eike Rathke
Also keep explicitly given sheet reference relative to the same sheet as user wished. Affected only when moving formula cell position like with cut&paste and drag&drop. Change-Id: I6b1da6aea58b88a24567189ef6aa212dab01de49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151845 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-05-17dynamic_cast followed by static_castCaolán McNamara
Change-Id: I2b2105e577184f87723c85ed79533983fdd60405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-16Remove remnant commented code concerning recently dropped "XAccessibleStateSet"Julien Nabet
Change-Id: Ib11e37dbc6bf9bfc7ba8cdf3b5cb28d5a11f31a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151847 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16tdf#155327 Detect default color in WordArtRegina Henschel
It is possible to not set the character color explicitely in a WordArt shape. In such case MS Office uses the scheme color 'tx1' from current active scheme. The import of the character properties does not set this color in the fill properties. The patch adds it, when the character fill properties are converted to shape fill properties. Change-Id: Ic72fd9f55bac1e2874cbf701ffa692ca4fbc9435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151851 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-05-16tdf#155324 sw: layout: try not to MoveFwd onto a page created by page breakMichael Stahl
There is a ToX that is updated; it has about 4 pages worth of entries. When the old entries are deleted, 2 of the pages become empty, and since commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb these pages are deleted. While layouting the new entries, these are moved onto the page following the ToX, which starts with a page break and contains lots of footnotes. Now the footnotes reduce the space on the page available for the ToX entries, and thus after CalcLayout() there are 5 ToX pages instead of 4. Then the page numbers are inserted into the entries, and another layout action deletes one of the ToX pages; now all the page numbers are too large by 1. Some ideas to fix this: 1) ignore a footnote when formatting a frame that is before the footnote anchor frame; similar to commit c79bf7865bff4e88cc201357370d8faeef8e6ad9 2) invalidate the last content on the page when moving forward the footnote container, similar to commit eb85de8e6b61fb3fcb6c03ae0145f7fe5478bccf; this doesn't look easy to do because as it turns out the footnote container is moved in SwLayoutFrame::Cut() 5 function calls inside MoveFwd() while the frame on which MoveFwd() is called is still on the page, so would probably somehow need to be detected in MoveFwd() itself? 3) don't move frames forward onto a page that was created by a page break - instead create a new frame. Let's try 3) for now, only in SwFrame::GetNextSctLeaf(). (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb) Change-Id: I641f586799a5ddb4e2a6ff8e9de784e422ecc214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151711 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-16Remove nonsense OSL_ENSURE()Eike Rathke
Apparently a legacy leftover; it's perfectly valid to remove EDITATTR along with CONTENTS, i.e. in Cut. Change-Id: I10010e1fc98b5e5863d041d72ddf78d499a0ec45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151846 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-05-16Resolves tdf#154787 - Ambiguous item on macOS quick start menuHeiko Tietze
Change-Id: I3f414bfc15feff67eac3dddbe5e3cd7b557ea82d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151832 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-16tdf#63130 flatten the extra ImplMatLine into ImplHomMatrixTemplateNoel Grandin
on modern CPUs, it is more efficient to just store the extra data, and lose the branching code and indirection. Change-Id: I9840c2f5c84f851293fb37466d09155dbef713f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-16simplify ImplMatLine constructorNoel Grandin
Change-Id: I20998c99b46418f29c12cbf43787ccd17dfd75f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151828 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-16Make --with-latest-c++ support future C++26Stephan Bergmann
...as already supported by <https://github.com/llvm/llvm-project/commit/b763d6a4ed4650c74c6846d743156468563b0e31> "Add C++26 compile flags." Change-Id: I0e7b55138222c0f0a81d4aec9a20da7922c51df2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151825 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-05-16xmlsecurity: do not run the test with HAVE_FEATURE_PDFIMPORTXisco Fauli
The test is meant to test PDFiumLibrary Change-Id: Ib99d1aef4857df09fa3e73a9cfdf130c7660619d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151761 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-16tdf#155349 std::move of a std::optional leave behind a set std::optionalCaolán McNamara
unlike std::move of a std::unique_ptr which leaves behind an empty std::unique_ptr so if HasPaintRegion was true before TakePaintRegion it was still true after TakePaintRegion Change-Id: I6569f5ccd8081cbcec42190c474a98c4e28030a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-16Simplify the code by introducing a new functionHossein
There were a lot of repetitions in the code of the function SvxConnectionPage::Reset(). This patch Simplifies this function by introducing SvxConnectionPage::lcl_SetMetricValueAndSave() to do the repetetive instructions. Change-Id: I337ccf2281fd8d1bd9b1948beb6d31b2306eb339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151820 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-16tdf#155179 Improve Solver symbolsBogdan B
Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Change-Id: I608330f175ebf41f282d07752d593661138963b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151623 Tested-by: Jenkins Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-16Removed constant concatenation macros from txtprmap.cxxVojtěch Doležal
Removed concatenation from the macros, because due to them I wasn't able to find anything relevant with grep when searching for them. Change-Id: Ic22d711d9e93bb89b402d141aa1ca3293bba866e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151819 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-16tdf#141440 - Do not delete notes when pasting contentsAndreas Heinisch
Contents include cells with values, datetimes, strings, formulas, outlines, and sparklines. Change-Id: I9acf3a33c7723300d6b85f0abe468db28de6ebcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151759 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-05-16Fix typoAndrea Gelmini
Change-Id: I006c882aacf316dda0ecb3302835ca021d45ecc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151812 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Ibbf9a267bbfba02c119fa1995c6b2ae90f391031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151813 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Id590b13237bc148dac955d6f4d56092f86d1dd16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151817 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Ibb3cbd37e04beed410c61f93f35be51a59bdc10b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151808 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: I77c647c513c4b605917888bd9054385b2f7f7bf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151814 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16sw floattable: disable UI if the frame is chained alreadyMiklos Vajna
TextFrames can be chained and we look at those fly frames as shapes. In this case, we should not offer the "split fly" functionality, which makes sense only when the fly frame is considered as a floating table. The combination of these two features have no use-case and it would just cause trouble when exporting to Word formats. Fix the problem by making SwFramePage::Reset() more strict: it already only allowed fly split for the case when the content was a single table, but now it also requires no chaining. The other way around (split fly -> no chain) still needs doing. Change-Id: I06c240209a3a26519a5df953e22c9ee1b54aed34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151822 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-05-16Fix typoAndrea Gelmini
Change-Id: I126f38c126c3f541d451cdafa074d2b8c0248d05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151815 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: I5701a1fdfe9e4f139049ed6c0de1748ec7c06e07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151816 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: I77c5760a38b07541eaceae765cd0e14eaddb6d11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151818 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Idce8a85c80c21ee4667810ec6f397389077432d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151810 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Related tdf#155070 - Tooltips moved from container to controlsHeiko Tietze
* Save log button disabled if Skia is off to prevent error message Change-Id: Iccd757fb15b347cf9d048115d4b048543814bd99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151764 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Ib9150f390574dc9467335451f42a10749bd915d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151811 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16Fix typoAndrea Gelmini
Change-Id: Id6f8a07f62e5861c4ad37b4537436632243b1a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151809 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-16sw: document SwFormatURL and SwTextINetFormatMiklos Vajna
SwFormatURL is special, it has its won SwTextAttr subclass, instead of going via the usual SwFormatAutoFormat. Change-Id: Ibe06abcb486b6bf6037006e727be4ce750d489a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151806 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-05-16Resolves tdf#155278 - Adjust minimum statusbar height according iconsHeiko Tietze
Change-Id: I7dbcf35f338bfe87702afb45651cd99630efe875 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151768 Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-05-16tdf#63130 make B2DHomMatrix a flat objectNoel Grandin
instead of using COW for its data. This takes the load time from 1m29 to 1m12 Also fix a bug in ImplHomMatrixTemplate::operator= which never triggered before because the usage of o3tl::cow_wrapper means it very seldom gets used. Change-Id: Ib0a7bdddf6c014f583e06d15e8dce5025e67e4a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-16tdf#153789 sifr icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: I9bd81878f931f78ed0b7d73a03cbc89d3d8347c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151797 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-05-16tdf#154956 sw: delete bookmarks at end: fix crashtestingJustin Luth
This fixes LO 7.6 commit 21b1dd42e9a817ae9b68e9e13ea57ce2491940c6 wget https://bugs.documentfoundation.org/attachment.cgi?id=124859 \ -O ~/tdf99692-1.odt ./instdir/program/soffice --headless --convert-to odt ~/tdf99692-1.odt sw/source/core/crsr/pam.cxx:268: void SwPosition::SetContent(sal_Int32): Assertion `nNode.GetNode().GetContentNode() && "only valid to call this if we point to an SwContentNode"' failed. Change-Id: Ic8280bf56f1e7f339fdff3e9591470bc74aa0d5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151639 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-16tdf#79542 xls: applyGroupBox to radiobutton groupsJustin Luth
A group box control links radiobuttons together, and so does a sheet. No matching unit tests were found. make CppunitTest_sc_subsequent_filters_test4 \ CPPUNIT_TEST_NAME=testLegacyOptionButtonGroupBox Change-Id: Ib5b03c68b5218649268f283d11981cc03fe4850a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137838 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-16tdf#144362 doc/x export: different columns mean new sectionJustin Luth
The situation causing this may have become more likely in 7.4.0. I think that tdf#149313 might have caused a regression in the unit test that I found that exhibited the problem, so I am adding another one. make CppunitTest_sw_ooxmlexport9 CPPUNIT_TEST_NAME=testTdf97648_relativeWidth make CppunitTest_sw_ooxmlexport9 CPPUNIT_TEST_NAME=testTdf144362 Change-Id: I8e668ac7bfb01a8704634a3e16243be7298bd1ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151731 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-05-15tdf#140226: use StaticWhichCastMoazAlaa
Change-Id: If5eab003a732264522ff1b1fe55a6a2c876c22db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150794 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-05-15tdf#154782 Fix scrolling in a11y sidebarSamuel Mehrbrodt
Doesn't need its own scroll handler anymore, Sidebar has a generic scroll handler. Change-Id: Ic56d1cfd7cde8ed81bf36f3302a128aa03ff6f27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151769 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-05-15[API CHANGE] Drop unused ToolboxStyle config keyGabor Kelemen
Unused since 2020 commit a0eab90bd1f7fc31978da3f7be0ec86781baf8bc Change-Id: Id03396022d7481ce85356207d468f5b1201df44c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151407 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15[API CHANGE] Drop unused Dictionaries config groupGabor Kelemen
Its use was removed in 2020 by commit acb1c390539730957fb509f18f469fc7f6133082 Change-Id: I48a10ab13de9fcdb1b1c5721a9be648250166f52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151058 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15[API CHANGE] Drop unused config key EmojiFontGabor Kelemen
Its use was removed in 2022 by commit 5f1eb2a12b6e6ee646b5e9536822531ad0bd3259 Change-Id: Ifc7e3f645422a478571aaa9dcbcd9ebe9a811b23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151061 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15[API CHANGE] Drop obsolete group PersonasEntry and set PersonasListGabor Kelemen
Its use was removed in 2020 by commit e1e9e2aa16f08a8fd9e38db706d63e8eceeda8d1 Change-Id: I1271c3a1d0dc9c1b294f9d93753196609a85a245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150988 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-05-15tdf#153789 Colibre icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: I0cbe5df13e49a6bdbdcf7aa93472c24e331b5576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151804 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-05-15tdf#153789 Sukapura icons for Watched Expressions and Call StackRizal Muttaqin
Change-Id: I0445f256680d5a88b99ac777ac7c65aaf507f232 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151803 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2025-01-17 06:56:44 +0000