summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-06-29sc: use ComplexColor for font color (+others) in OOXML exportTomaž Vajngerl
Change-Id: I2544c7ece152323d84faafe1a544e4f89ca466d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152014 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-29oox: convert Excel tint value into LumOff and LumModTomaž Vajngerl
tint value can be converted into LumOff and LumMod values, so we don't need a special Excel case for calculating the final color. Change-Id: I0725c06f9df6a37a309ea5d17b183e4100a228f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153716 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-28tdf#156078: Use TabOverSpacing compat option instead of TabOverflowMike Kaganski
As Justin Luth noted, "TabOverflow is basically always true", and using it basically equal to making the test always true. On the other hand, TabOverSpacing is accurate for the task. Change-Id: I608b200dac0169cbafc935a03452aac9ba0527a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153722 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-28tdf#148416 saveas: preserve loadreadonly with passwordJustin Luth
If a document is set to load readonly, and that setting is password protected, then at least suggest using a password on save-as. Change-Id: I788da43733470e56af988e7c4b9f2cae01573e50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153726 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-28tdf#148416 password dialog: suggest current loadreadonly statusJustin Luth
If a document is set to load readonly, and the user saves with a password, then suggest LoadReadOnly status by pre-populating and displaying the checkbox for that setting Change-Id: I3e848b6f97ed4218d066e8f1790cb8fbea8b208c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153725 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-06-28tdf#107787 Sync FillGradientStepCount and StepCountRegina Henschel
The FillGradientStepCount property of a shape or page background and the StepCount member of the Gradient2 API struct or nStepCount member of the basegfx::BGradient class are used parallel and mixed. Therefore we need to be careful to keep the values in sync as far as possible. Change-Id: I58ab9654ba0106417794fafe68fb296e66cb3bf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153714 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-06-28Fix typoAndrea Gelmini
Change-Id: I21b6a4ae3cac15891a6b50bf975658ac404aefa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153613 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-06-28Fix typoAndrea Gelmini
Change-Id: I4c55e4a263a01fd4fa1d84feb49ac97bed793a59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153710 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-28tdf#156077 sw: layout: call AssertFlyPages() in Init()Michael Stahl
The bugdoc has 3 pages, and there are at-page flys anchored to the 3rd page, and these are not displayed - simply missing from the layout. In LO 6.1, this worked because the layout-cache was read from the file, and 3 pages were created in SwRootFrame::Init() calling InsertCnt_(). But now this creates only 2 pages, and later SwLayAction creates the 2nd page between the existing ones on some MoveFwd(), but despite page nr 2 becoming page nr 3 nothing attaches the at-page flys to the now-page-3. If a document is loaded containing at-page flys, then all pages that have flys anchored to them should be created in SwRootFrame::Init() already. (regression from commit 7e8b4756d95057f069467b34e7849f9354856578) Change-Id: I4792c483a7620efd81211e6ad0d9220152367d68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153720 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28flat-odf-cleanup.py: remove unused user field declsMichael Stahl
Change-Id: I5271f975ee8bae558dc00bcf8ea778a3203bbc18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153719 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 114401853f335d1e85edee8229c4450c575f1f0c - New features of SF_Dialog and SF_DialogControl services (WiP) Change-Id: I5806e7c9cd014bd92e58b2f9aa739a610050ea76 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/153598 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2023-06-28Send writer document background color on theme changeParis Oplopoios
Send the doc background color to the kit on theme change Change-Id: Ic025e542417da004c1c4a2bfd58a858deb4caa58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153715 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-06-28sc: prefix m_* ScViewFunctionSet class membersHenry Castro
.. Signed-off-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153405 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 8276b9593a2a9e3a0d5aaeaadd64369667120303) Change-Id: Ic16ae0fc6580e350444576a087c333d52296ec5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153663 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2023-06-28these TAB_ constants do not need to be in the header fileNoel Grandin
they can be inside the .cxx file Also rename slightly and document. Change-Id: Iffd46e9ed6c02aad597a616ac1c583ae657fab40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-28tdf155903 DOCX export: fix corrupt file with embedded mediaTünde Tóth
Regression from commit bc72514f90d90e1ab3fed8167663e835edf03508 "tdf#53970 PPTX: fix export of embedded media files". Change-Id: I04521227346817d91f720b1f6a77beb7f4a01f83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153619 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2023-06-28Simplify SvxSearchItem::PutValue a bitMike Kaganski
Change-Id: I2cbc5dce800b773e6c20cb3ea6f0e520a3f69db9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153688 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-28tdf#146547 sfx2: preserve modified state from read-only to editableMichael Stahl
SfxViewFrame::ExecReload_Impl() calls DoSaveCompleted() which resets the modified state, but in this case the document wasn't actually saved. Change-Id: I54f6508a652cc42a127bc59058c5b435dd1a25a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153676 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28Move SwXFootnoteText Java tests to C++anfanite396
Change-Id: I7f3477799f532f52993cd0add51185bfd15c7446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153631 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-28Drop i18nutil::SearchOptionsMike Kaganski
It was mostly unused by now, only remained in a couple of function arguments, where callers actually passed SearchOptions2, and where internally it was converted back to SearchOptions2. Change-Id: Ib188ec3bf0de6d1f70a04eb90fb3a577df8b3d98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153687 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-28xmloff: ODF import: adapt generator parsing to 2-digit major versionsMichael Stahl
DocumentInfo currently assumes that a LO version encoded in "BuildId" property has only 1 digit major version, which is now wrong and would start to give incorrect results when major version "30" will be detected as LO_3x. Add the dots as separators into the BuildId because it's not going to work without. Change-Id: I8918afe3642cbefa8488c57658f1505c9a20eddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153649 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-28Related tdf#106556 - Spotlight DF on the main menuHeiko Tietze
Added to the Format menu Change-Id: I9b601aa4b55e9ce5a78fd8306d72baee71fd357f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153641 Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-06-28tdf#156066: Add support for feFlood filterXisco Fauli
Change-Id: I4d01d40edd6fb91555fd734fc8378df1cbd5743a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153684 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-28Resolves: tdf#156067 merge special char dialog/popup logicCaolán McNamara
there was some cut and paste done to create the popup at some point, so put it back together and reuse the "delete recent" etc which is missing from the popup case Change-Id: Idc33d83ea04b46b0255e77bcecf565dc8174e426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153647 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-28Fix typoAndrea Gelmini
Change-Id: I0b4abdb362b86a3e1f622a04411e9f9ea0062295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153674 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-28Fix typoAndrea Gelmini
Change-Id: I41ca7f8c9b998436f0b2810236161697e9f501c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153675 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-28Fix typoAndrea Gelmini
Change-Id: I7e77830bb32c100e3ae5c2d5aaa8fb6ba5f69d4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153673 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-28tdf#156078: also consider TabOverflow for tabs outside of line boundsMike Kaganski
Before commit 29bd00f7628e7a54e69cabcc7e2a1792c24aa55c, TabOverMargin compat option was set for DOCX with any compat mode. After that commit, the unset option disallowed output of content after a tab stop outside of the paragraph indents, even within page margins. SwTabPortion::PreFormat consults TabOverflow when checking if position is outside the frame; so let's consult it also when painting. Change-Id: I05ada0da6cd765c70b7bad1287ccc8c11d9b60ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153672 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-28Simplify a bitMike Kaganski
Change-Id: Iad2564853a2a0d74cd526b1574e421e121fd6986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153644 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-28Header columns can disappear with filtered data in pivot tablesluigiiucci
When we set on a pivot table a filter that filters all the rows, the pivot table showed only the first header columns and computed column, but all the columns headers should still be shown so we can adjust the filter for the column. This fixes this issue. Also add more debug output and prevent a crash when running pivot table tests. Change-Id: I30b4ee72cf8436c4522ab4ba0781462b214816dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151871 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27Fix gpgme build on WindowsMike Kaganski
Commit 97c67afac1ec9351d0a64011a7ddfb7dfa876484 (Update gpgme to 1.20.0, 2023-06-23) defined ssize_t in external/gpgmepp/w32-build-fixes.patch.1. It was done to address the use of ssize_t in src/debug.h, appeared in https://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpgme.git;a=patch;h=7d1159c1e99bb1bae0ab698c85105dcdcb95b7ea This led to build errors like C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win64_dbg\workdir\UnpackedTarball\gpgmepp\src\debug.h(26): error C2371: 'ssize_t': redefinition; different basic types C:\cygwin\home\tdf\lode\jenkins\workspace\lo_tb_master_win64_dbg\workdir\UnpackedTarball\libassuan\src\assuan.h(47): note: see declaration of 'ssize_t' To fix it locally, just revert the problematic patch, until fixed upstream. Change-Id: Ib89496cc08b0ce6d24d5c9e9c7e615c6909d071b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153671 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-06-27remove this SAL_WARNNoel Grandin
has not revealed anything interesting on jenkins Change-Id: I15ebabc171dbb38f440ec607ea05be9b807bdea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-27Fix typoAndrea Gelmini
Change-Id: I8dee1f762a39b21e88609d1d108846623d0b8bc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153207 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-27MCGR: tdf#155479 always propagate SVG-flag for sub-content metafilesArmin Le Grand (allotropia)
For SVG export it is necessary to always propagate the SVG-flag for metafiles in *any* case impDumpToMetaFile is used and a new metafile gets created (aContentMetafile here). This is due to the subContent again may have any combinations of gradients/transparenceGradients that are non-vcl-renderable and need special handling. Change-Id: I7edee8afa81c0b6f3fb0e183d144c50f29c5bb79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153645 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-06-27Import CSV: remove erroneous warningLaurent Balland
If Fixed width is selected, clicking on any option in Other section generates a warning about option not allowed, which is wrong. Only checkboxes in Seprator section are not allowed Change-Id: I3fc6fd6ac870e8c681aae8fd1d033b550d9bc20d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152573 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-06-27related tdf#153993 Embedded text in scientific numbersLaurent Balland
Embedded text was limited to number:number. But scientific notation may require embedded text like 0.000" "000E+00 This change extend ODF format to support embedded text in number:scientific-number also Change-Id: I4e3220b06efbd9228d722bf518e137d7707ccf4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150804 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-06-27Update language-subtag-registry to 2023-05-11Eike Rathke
Change-Id: Ieb1c3eab66c06c8e7b3d9751d9e4548dbd7efc04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153643 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-06-27Move SwXFootnotesSupplier Java tests to C++anfanite396
Change-Id: Ib6b33d33dc813400526b0d641faefbfdeea9fc0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153610 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27tdf#156068: Add support for feOffset filterXisco Fauli
Change-Id: I1b3dea0ee4f9eb2ee7498962b04baaf5ba68855c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153629 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-06-27tdf#145130 Keep existing gradient geometry using sidebarRegina Henschel
When setting the start or end color of a gradient of a slide using the sidebar, the new colors were set to a default gradient instead of using the existing one. Change-Id: I0212d2d88e7eb144334308dedd057958ae0a8287 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153634 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-06-27tdf#54768 sc: fix resizing of cropped images to original sizeTibor Nagy
This is a follow up to commit a4e12cbfc69cfe668fa30756a3c5843e911e22b1 (tdf#155863 sd: fix resizing of cropped images to original size) Change-Id: I923ed8b1df6c6559d527d43e4abe842497c4c28f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153449 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-06-27tdf#156028 sc: use color of the highest value if only one valueTibor Nagy
(in a single cell or the same value repeating in all cells of the data set) on percentile color scale, like other spreadsheets do. This is a follow up to commit 6a059f8d1b0a7a5b64bd272e1e7b8291979bcd56 (tdf#155321 sc: fix color of the highest value on percentile color scale if the highest value occurs multiple times in the data set.) Change-Id: I630df332e403705e8338e3441af093c2de95c280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153577 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2023-06-27Fix typoAndrea Gelmini
Change-Id: I3934967d97ee3841b37882355a5006738679976a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153639 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-06-27loplugin:stringstatic look for more stringsNoel Grandin
that can be initialised at compile-time instead of runtime Change-Id: I08d516fdc13a3a79f93c079f89ac44cbc7a1ed71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-27Update ICU to 73.2Taichi Haradaguchi
Remove external/icu/ubsan.patch.1 that was applied upstream. See https://icu.unicode.org/download/73 Change-Id: Ic2bc450b093f1c0ddb09ebe915a9c3e70d7e0964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153574 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-06-27sc: import and prop. theme color support for cell bordersTomaž Vajngerl
Adds import for theme colors for cell borders and UNO properties for the cell border theme (complex) colors. Change-Id: I9d8dd7e71f74a623f916e19d59964058f43440bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153502 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27add an --enable-cairo-rgba to set the order of pixels for internal cairoCaolán McNamara
Change-Id: Ieab2ef59f63a7722bffea3273d2eeefadef47b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153628 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-06-27tdf#155526 Moving average: remove Insert R2Laurent Balland
Moving average trend line does not R² value. This change remove "Insert R²" from context menu when the trend is of type "Moving average" Change-Id: I729a6421df34859e7176c798a2b68a6f13cfb544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153294 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27sw: simplify SwXTextFrame UNO API testTomaž Vajngerl
make it more inline to Calc UNO API tests Change-Id: I92e3f4f9b7286ea402cc0e869fec24ee9d2c05e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153611 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-06-27lok: only publish MEDIA_SHAPE to selecting viewAshod Nakashian
We now publish the url for the media shape in the LOK_CALLBACK_GRAPHIC_SELECTION message. This has many advantages, most notably that it only sends the URL to the view selecting the media. Also, it is now easier to handle the message as there is no need for both a LOK_CALLBACK_GRAPHIC_SELECTION and a LOK_CALLBACK_MEDIA_SHAPE. However, the latter is still defined as we might still use it at some point. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I8d4b8794d8e590628630f2b0bfbfb5debe02515f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146848 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153009 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153369 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2023-06-27tdf#151548 ContentControls vba: allow search by float #2Justin Luth
I don't know how to figure out where the basic parsing is mishandling the double-specifier of "#", so just hack in a re-attempt to find a control with the name of an unfound index. This should be fine. If it really was specifying an index, then it won't get to this code. If the number is larger than the index and a control exists with that id, then it almost certainly was intended as a name. If by some chance it wasn't, then instead of the code failing, it will actually go ahead with the operation. Since in practical terms this won't happen, just go ahead and fix the likely case of a positive-number-as-a-name control not being found. Change-Id: I2a34184d86b99a50fdc6b806264f1d5e7794ad48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153630 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>