summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-03-11Embind construction of UNO Any enumStephan Bergmann
Change-Id: I1b2167e261f1020b228f8ca2618c7f0009ca1d3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164646 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-11tdf#159373: sc_uicalc: Add unittestXisco Fauli
Change-Id: I30e452534e09aa349a85f0862ed09291506203dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164654 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-11Fix a UITest on WindowsMike Kaganski
No idea why the difference. No idea even if it's specific to OS, or maybe on other factors as well... Change-Id: Ib1816e7fe3b7350504d3de1a78570b3f789a20db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164652 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-11tdf#160095: sw_uiwriter8: Add unittestXisco Fauli
Change-Id: Id7d35511fbbc6a0d11f521bff9ad7469ae068ec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164649 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-11Update git submodulesPierre F
* Update helpcontent2 from branch 'master' to dfdacad1658ed67ef45738653a64750e49244020 - link to *Entering Unicode Characters* Change-Id: I7007bcbfb18f46cb043eb3a8923240460d09cbb7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164617 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-03-11Update git submodulesPierre F
* Update helpcontent2 from branch 'master' to 969dc658744688aa9e1dc64611a327399d078462 - less tautological and more reader friendly wording (tdf#91336) Change-Id: I98516428b87c22c035897965b5f66caeb6c29fb6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164618 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2024-03-11basic : use OUstring literal for XServiceInfo implementationArnaud VERSINI
Change-Id: Ic4501ec887bb3f1249ab4a8da1eae07f6b2a22ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164305 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
2024-03-11tdf#158773 reduce cost of importing binary dataNoel Grandin
no need to pass it via the internal buffer of SequenceOutputStream when we can read it directly Change-Id: I832737d73309449a1f3a26a4b451977a2a580de3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164634 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-11tdf#143148 Update Include Guard usagetbalaj
Updates vbabutton.hxx to use pragma once Change-Id: I55874083ad0cdbc08bedaa71fa7553acfefa3195 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164324 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-11tdf#157664 Drop operator != where respective operator == is definedTuukka Orava
Change-Id: Id0313cbaf399af94df7ced18a8ad55deec53be33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164638 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-11Drop old "SvGlobalName order" compatibility hackMike Kaganski
It was added in commit 7afe74c37ed737f9d7a7c9c77877a0bde6997771 (INTEGRATION: CWS os54 (1.21.10); FILE MERGED, 2005-03-11) for issue #i30510# related to "StampIt". Hopefully now, after almost 20 years, the hack is not needed anymore. Change-Id: Id39765b9d2c51fd487c48ce06382c068bab08959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164459 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-11Disallow closing document during generation of previewMike Kaganski
Using an external (Java) script that opens a document, and then quickly closes it, it may happen that the idle that generates a preview is still active, when the control thread calls XCloseable::close, which destroys still used document. This leads to use-after-free. This uses the close listener in SfxObjectShell, to veto closing document that is still in use by the preview generation code. After completion, when the caller of close() transferred ownership, then the call to close is repeated. Change-Id: I39691f61ad5141d7e8ee54723d5aef87f0bc01dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164632 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-11Use weak reference to SfxObjectShell in SfxEventHint to avoid use-after-freeMike Kaganski
The events may be processed after the shell has been destroyed. This is happening reliably after commit e2bfc34d146806a8f96be0cd2323d716f12cba4e (Reimplement OleComponentNative_Impl to use IGlobalInterfaceTable, 2024-03-11) when controlling LibreOffice from external Java scripts; but obviously, it could happen before as well. Now SotObject inherits from cppu::OWeakObject, instead of SvRefBase. Change-Id: I73a3531499a3068c801c98f40de39bdf8ad90b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164458 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-11Reimplement OleComponentNative_Impl to use IGlobalInterfaceTableMike Kaganski
... to make sure that object methods are called in correct apartment The user-visible problem was, that running a Java code that connects to LibreOffice, and opening a document with an embedded OLE object (it was Word object in a specific case, which needs activation at opening stage, because these objects have OLEMISC_RECOMPOSEONRESIZE flag), using loadComponentFromURL with "OnMainThread" set to true, then closing the document, resulted in a hang after several hundreds iterations. This was caused by Word process, that was started in background to serve the COM calls, wasn't closed properly, and kept all the objects in memory, until OOM. The reason why it wasn't closed was failed call to IOleObject::Close in OleComponent::CloseObject, which returned RPC_E_WRONG_THREAD, because the activation of the OLE object happened in the main thread (because of "OnMainThread"), which is STA, but closing happened in the handler thread (belonging to MTA). Similar problems previously were addressed in commits 2dc3a6c273cb82506842864481d78df7294debbf (framework: allow loading a component on the main thread, 2018-12-20), 6002014ce0a5c9cea22c14b2437b7a508b2c72cb (framework: allow loading a component on the main thread, using XDesktop, 2021-04-28), d5cd62164d32273a25913c93aa04be9f7f3a4073 (embeddedobj: handle getting the visible area on a thread, 2021-05-07). These changes tried different workarounds for the same problem, when a COM object instantiated in one apartment is later manipulated from another, which fails. First two handled the case when the document is loaded from a non-UI thread, and then manipulated with the UI; to handle that, they introduced flags that delegated opening the file to the main (UI) thread. The last change tried to handle the reverse problem of the OLE object instantiated in the main thread was saved in a handler thread, which again failed; the workaround was, again, to try to delegate the second attempt to the main thread. But basically all methods can fail in such circumstations, as shown in this problem's case. The "OnMainThread" flag must be passed to fileopen functions explicitly. Also, the workarounds only work by passing everything to STA, and don't target a case when the calls must be passed from STA to MTA. Since Windows 2000, there is IGlobalInterfaceTable, which goal is to solve this problem. It allows to use an intermediate object, which can transparently delegate all calls to the correct thread. This change re-implements how OLE objects are referenced from OleComponentNative_Impl, using the said IGlobalInterfaceTable. This should hopefully obsolete the previous workarounds, which nevertheless are kept for now. Change-Id: Ia1c590e547ed24a2c7389283aed6cc3d8ea024b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-11Update git submodulesPierre F
* Update helpcontent2 from branch 'master' to a09dfabece27637223b8deadd448c24e2fbb35b0 - href *sort options* + related *sort lists* Change-Id: I67d9718ddeebde28f895a8faa2cda5d2590f88a8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164491 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-03-11tdf#143122 Port HelloTextTableShape example to C++Hossein
Port DevelopersGuide/FirstSteps/HelloTextTableShape Java SDK example to C++ and add a GNU Makefile for the build. Change-Id: I8798406c24ec6c566fb6494f7202f6a2a984a25c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164635 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-11Enable commented part in HelloTextTableShape.javaHossein
Commented code in the HelloTextTableShape.java example demonstrates the use of bookmarks. This part is now enabled. Change-Id: Iace525be0d53b01bed8b5a6a123384a678d1d761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164636 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-11Remove redundant function indirection in SfxHintPosterHassan Sajjad
SfxHintPoster::mLink always pointed to SfxDispatcher::PostMsgHandler and except in ~SfxDispatcher, it was reinitialized to empty i.e. cleared. This extra indirection is now removed. SfxHintPoster was using SvRefBase to persist even after SfxDispatcher was deleted and then deleted itself after SfxHintPoster::Post call was completed. This extra indirection was adding 4-5 frames while debugging. Change-Id: Ibfd6d3aea10ddf45732adc1a9d63a25717a771fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162700 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-10tdf#42982: Improve UNO API error reportingvarshneydevansh
Change-Id: I2eead2d6907cf49d9a8525065d33c3ef43207660 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161779 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-10Update git submodulesAndras Timar
* Update helpcontent2 from branch 'master' to 99537726eca951a450182d7672458afeb2b65e66 - fix Helpex warnings: 'No string specified!' Change-Id: I70ad73b6859cd989e6046c3bd5a76c54c27f416d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/164631 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-03-10basegfx : use OUstring literal for XServiceInfo implementationArnaud VERSINI
Change-Id: I18a17e38897c1feda7fbba330c14a79c9b6d6f93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164306 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
2024-03-10basctl : use OUstring literal for XServiceInfo implementationArnaud VERSINI
Change-Id: Iee7585585b5e01fad4609f37a06d2aeeff492123 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164304 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
2024-03-10avmedia : no need to use constexpr hereArnaud VERSINI
Change-Id: I1b9975841a702d7ad3e05adef3d849c63ddf264a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163009 Tested-by: Jenkins Reviewed-by: Arnaud Versini <arnaud.versini@pm.me>
2024-03-10Adapt CustomTarget_postprocess/check_dynamic_objects to --enable-mergelibs=moreStephan Bergmann
...which, after recent changes, failed now with > [CHK] CustomTarget/postprocess/check_dynamic_objects/check.done > instdir/program/libmergedlo.so has suspicious NEEDED: libgssapi_krb5.so.2 > instdir/program/libmergedlo.so has suspicious NEEDED: libcom_err.so.2 > instdir/program/libmergedlo.so has suspicious NEEDED: libkrb5.so.3 Change-Id: I80de1dd85f06d0e27b73355def68da9df2f6c2cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164606 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-10tdf#158773 avoid Reindex() until we are done renamingNoel Grandin
shaves 10% off load time Change-Id: I93dfb4422a3e470013b6ddc5a9ae9e9868e3ddf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-10inline aSep variableNoel Grandin
Change-Id: Ic547a6f13e7a1a3cade70547d029721ce8054567 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164608 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-10tdf#90242 Navigator: Improve custom shape namingJim Raykowski
This patch makes the Draw/Impress Navigator display the name retrieved by SdrCustomShapeGeometryItem::GetPropertyValueByName("Type") for custom shape objects when the custom shape is unnamed and the Navigator is set to show all objects. For Writer and Calc, this patch makes inserted fontwork custom shape objects be automatically named 'Fontwork N'. Change-Id: Ice34461fe7a4b26d01b2d93e871a956dc55392f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152568 Tested-by: Jenkins Reviewed-by: Stéphane Guillou <stephane.guillou@libreoffice.org> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2024-03-09Support o3tl::iterateCodePoints with both sal_Int32 and std::size_tStephan Bergmann
...and clean up the most gross casting offenses Change-Id: If0d646fb3e73e71a9a2735569395034973563a1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164602 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-09tdf#158773 avoid some OUString constructionNoel Grandin
Change-Id: I42c6b7a8c7b0c0af17a2806c908f5a336ef206d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164599 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-09Enable (and fix) some TODO test codeStephan Bergmann
...now that all the relevant Any getter functionality is available Change-Id: I5824dd50d177506b0450506146df109ded7e20d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164588 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-09Enable CVE tests on Windows by defaultMike Kaganski
Since commit c16969b9bc73fdd77e763299d6aea7b614e203e2 (tdf#84553 Detect and warn of Windows Antivirus., 2020-02-08), it is checked that antivirus is disabled in $SRC_ROOT and $BUILDDIR. This reverts commit a6b2c618cb02168bba950652367f494a1021cf53 (disable cve tests by default on windows, 2014-10-01). Change-Id: I3816e97cfb4559f7647167ed291b75468b03dc4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164612 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-09tdf#158237 Use C++20 contains() instead of find() and end()Sujatro Bhadra
Change-Id: I93e873bd2396c1b95f120ee11478c0cd3a309c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164580 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-09Simplify a bitMike Kaganski
Change-Id: I36b5557a5413e76306ed4a83eaa238422bf59fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164613 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-03-09tdf#145614 Convert #define to constexprSujatro Bhadra
Change-Id: Ibb805a67240b554cb56c5758ba20c081524e990a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164454 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-09Fix typoAndrea Gelmini
Change-Id: Iebc31f3dc1d99406e23ee4b89f12cd78b424826d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164600 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-03-09Fix typoAndrea Gelmini
Change-Id: I1018717588188c71ec634ed7a71d8000bd4e257e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164601 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-03-09tdf#160095: fix crash when using ALT+RETURN twiceJulien Nabet
Change-Id: Idc4c84039115c8d88418246a17e281c26fb49b70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164592 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-03-09tdf#158773 add a set to sd::ShapeListNoel Grandin
because the std::list is atrociously bad at checking if the element already exists when the number of shapes gets large. Shaves 5% off the load time Change-Id: I6b8f972f8ff9559c363c084d91adea88b1267d3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164597 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-09replace unit test font with Liberation SansJustin Luth
since I was getting a build failure on Ubuntu 24.04 warn:vcl.fonts:1268905:1268905: vcl/unx/generic/fontmanager/fontconfig.cxx:1192: PrintFontManager::Substitute: missing font: 'Rockwell' try: Noto Sans instead replaced theme1.xml Rockwell and Franklin fonts with Liberation Sans Change-Id: I365f64c927fcb2211990321e906f757c2d03e893 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164603 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2024-03-08external/skia: Fix a std::sort comparison function's assertion assumptionsStephan Bergmann
At least with a LLVM 19 libc++ in hardening debug mode (where it uses additional invocations of the comparison function passed to std::sort, to verify that the function actually implements a strict weak ordering), chart2_dialogs_test failed with > LO_TEST_LOCALE=en-US > [_RUN_____] Chart2DialogsTest::openAnyDialog > workdir/UnpackedTarball/skia/src/sksl/transform/SkSLFindAndDeclareBuiltinVariables.cpp:112: fatal error: "assert(InterfaceBlockName(*a) != InterfaceBlockName(*b))" apparently because the implementation of std::sort made additional same-arguments calls of operator ()(x, x) that the Skia implementation of the comparison function was not expecting to happen. But the only relevant guarantee that C++20 appears to make for std::sort is that its complexity is O(N log N) comparisons, so any implementation could legitimately do such a "useless" additional same-arguments call of operator ()(x, x) for each of the N elements of the to-be-sorted range. Change-Id: I3a14eb05b5ae9101f37f92e10ecc91a90585de87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-08Embind construction of UNO Any TypeStephan Bergmann
Change-Id: Iac5ac8de7bfb19b90d54edc6f4b791d8c0e98977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164594 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-08Redesign Embind UNO Any constructionStephan Bergmann
...taking a full UNO Type instead of just a UNO Type class (so that it will be able to construct Any containing sequence, enum, struct, exception, and interface, in later steps); moving the Type argument first (as that looks more natural), and renaming from Any to uno_Any (in line with the other uno_Type, uno_Sequence_..., etc.) Change-Id: I154681c4b9187f5f5d037d503652fe7bcd41adcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164593 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-08Directly go via std::u16stringStephan Bergmann
Change-Id: I99d3322afc7876c37a7ace016c1c6af691f28406 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164591 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-08Improve Embind'ing of UNO TypeStephan Bergmann
Change-Id: Id93d7f48dedb362206828b5e3bd946525f95ea77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164590 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-03-08tdf#45904 Remove old SwXFootnoteText Java testLuv Sharma
Change-Id: I04ade7be60083d4bc57b400b7aa82850424e1e9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164407 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-08tdf#158773 do the cheap checks firstNoel Grandin
the HasText() call inside TextProperties::Notify is surprisingly expensive, so only do it when we know we are interested. Shaves 25% off the load time here Change-Id: Iab257add7fd56bf405678944ca8a3482c8f7b142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164596 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-03-08tdf#145614 Convert #define to enumAhmedHamed
Change-Id: I949fb5327032228b7aecfea762e23fdea692ca78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163887 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-03-08tdf#142133: partially revert 576611895e5Xisco Fauli
if 'Internet Link' character style doens't exist then apply the hyperlink style This also reverts 023285158bde72dcd73b965ce205cf8550e7a5e2 "tdf#128504 save DOCX as ODT: don't color not highlighted hyperlinks" which is no longer necessary Change-Id: Id100af5fddb10745af9d56c0ba75cb2366ecbe55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164576 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-03-08tdf#160077 unit test: this file was helpful identifying a "bad fix"Justin Luth
...since I'm walking away from doing any fix at all as it involves layout code for layoutInCell. Following the createGraphicObject route could also benefit from a similar fix as d210667c72ff821b8cb50b386a83ed55d65ae9bf, but placing that code outside of the try/catch will be important because this example exceptions out. However, my first instinct was to put the code in the "obvious spot" and it didn't work, so adding this as a separate unit test. make CppunitTest_sw_ooxmlexport21 \ CPPUNIT_TEST_NAME=testTdf160077_layoutInCellB Change-Id: Ifa6a62d9708d9248e48766b913d54a79cfcb230a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164578 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2024-03-08tdf#158773 reduce size of IndexedStyleSheetsNoel Grandin
we don't need to store SfxStyleFamily::All in the mStyleSheetsByFamily array, the call sites just iterate over the main vector for that case. Change-Id: I17fca2aa59e786d6dee13c884dedb9fde847b979 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-28 21:33:01 +0000