summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-11Clear message in find toolbarJim Raykowski
...when Navigator floating Navigation tool box selection is changed Change-Id: Iab3a17f46dab9f11df9035a4d673aa3b211b639a Reviewed-on: https://gerrit.libreoffice.org/75389 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-07-11Postpone loading of all external references, including INDIRECT()Eike Rathke
... which can be constructed with an arbitrary URI text string not an svExternal* token type, until link updates are allowed. Change-Id: I2ce4de415ff99ace04c083c36c1383d76a4ef40d Reviewed-on: https://gerrit.libreoffice.org/75422 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-07-11Qt5 / KDE5 drop unused configure.ac bug testsJan-Marek Glogowski
These were moved from the kde4 backend but never used. The tested bugs don't exists in Qt5 AFAIK, so just remove them. Change-Id: Ib30c3aee8caf0addd6cf17938f7915a65733e328 Reviewed-on: https://gerrit.libreoffice.org/75428 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2019-07-11ConfigItem: use getTree also inside the RemoveChangesListener() methodTamás Zolnai
This is the only method which accesses the m_xHierarchyAccess member directly (except getTree() method). All other methods are using getTree() to access it. This direct member usage might be a problem when the code is run in fuzzing mode or the constructor is called with ReleaseTree mode. Change-Id: I7b5b91e63ac81d76028a098296fa306f154de53d Reviewed-on: https://gerrit.libreoffice.org/75042 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-07-11Qt5 set default QStyle::State for draw functionsJan-Marek Glogowski
Just a little cleanup for all functions, which already modify the QStyle::State of their QStyleOption* parameter. Change-Id: Ib1fbe3ed3481a17a57ac07f390fafe8a7333f218 Reviewed-on: https://gerrit.libreoffice.org/75418 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11Qt5 correctly draw rectangle frameJan-Marek Glogowski
This bug can be seen with the Writer comments "button" to hide or show comments, where qt5 misses the bottom and right borders. The drawRect from X11SalGraphicsImpl and SvpSalGraphics do this and it fixes the visual glitch. I'm not sure this is needed for drawAlphaRect, as other implementations don't handle drawing borders in these at all. Change-Id: Ic82d499cd8e1bb420a7df14269e86c75e0d30c0b Reviewed-on: https://gerrit.libreoffice.org/75416 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11tdf#126333 use dialog color for "button" highlightJan-Marek Glogowski
This control has many more problems. This is just a minimal fix, so it'll use dialog color for the highlight. In addition it uses the same color for the arrow then for the text. Change-Id: Iaf263087bc09309267b2d165331d710dfc92fc77 Reviewed-on: https://gerrit.libreoffice.org/75419 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11Qt5 fix drawing of the toolbar handleJan-Marek Glogowski
This is visible in Writer, where the 2nd toolbar misses the handle. Change-Id: Iddf3a002c9d75f668c40977cf02671640b38f083 Reviewed-on: https://gerrit.libreoffice.org/75417 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11Correctly position hyperlink focusJan-Marek Glogowski
Handle WB_RIGHT and WB_CENTER (the latter is used in About LO). Change-Id: Ib03b9f7234c573a05eda7b4c0026e3ca7bd34729 Reviewed-on: https://gerrit.libreoffice.org/75414 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-11Restore original value of SID_DOC_READONLY item on cancel or SID_EDITDOCMike Kaganski
Otherwise, SfxObjectShell::DoSaveCompleted later calls SfxMedium::LockOrigFileOnDemand, which sets error state for the medium reopened in read-only mode, as if it were opened in read-write mode. Change-Id: Ib2df62470878ea609552ccc76df84a3fdde30646 Reviewed-on: https://gerrit.libreoffice.org/75413 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-11tdf#126268: first byte is not used for the sign symbolXisco Fauli
This code is just broken, negative numbers and positive numbers above 25 are incorrectly migrated if using decimal. E.g: -1 -> 24,6 26 -> -6527'6 thus, delete it and pass the 8 bytes as they are to lcl_double_dabble. Note: this only fixes the positive numbers, -1 still returns 24,6 Code introduced in 6039d2463b4cc503b963811b3b1471de3291ee09 Change-Id: Id0e249e47a91b274a247fb7e8b71353114149650 Reviewed-on: https://gerrit.libreoffice.org/75375 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-11Deduplicate URL tooltip creationSamuel Mehrbrodt
Change-Id: I94eb40ff4d727029ad764a381df300beee90481c Reviewed-on: https://gerrit.libreoffice.org/75409 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#124299 Redaction Help page Change-Id: Ia85c95ca63e1d11b1aabd2b5cabd3d962c5161cd Reviewed-on: https://gerrit.libreoffice.org/75387 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-07-11tdf#121012 Display "Ctrl-click to follow hyperlink" inside shapes/textfieldsSamuel Mehrbrodt
Change-Id: I8def50f0de20098ebbfd2b0934825a297e1d24d0 Reviewed-on: https://gerrit.libreoffice.org/75408 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11Return constexpr to ErrCode ctorsMike Kaganski
... removed in commit e9c74a075c3c0809b993c017c11d1505bd244dc8. assert should not prevent constexpr since C++14. Change-Id: I5a42a3450689de16011fd594b10f74b1e0726fa6 Reviewed-on: https://gerrit.libreoffice.org/75388 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-11Compare coordinates with toleranceMike Kaganski
The test was excluded from macOS in commit bdad941d7349f330dab2c3d47237bd380d5b7391, because of "hard to smooth out Retina-related rounding roundtrip error". But this is also unreliable e.g. on Windows, where it might fail with "Expected: 3171 Actual: 3170". Use CPPUNIT_ASSERT_DOUBLES_EQUAL with a tolerance (set to 1 for now), and restore testing on macOS. Change-Id: Ie90c89a15e032ff44593433d13af7732eb520cd9 Reviewed-on: https://gerrit.libreoffice.org/75404 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-11Fix typoAndrea Gelmini
Change-Id: If83573ab4b427b84f5c125d1fc2509996ed8bdfc Reviewed-on: https://gerrit.libreoffice.org/75398 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-11Fix typoAndrea Gelmini
Change-Id: I6afd087e1637522f4c99d8162087b1a1b8c02dad Reviewed-on: https://gerrit.libreoffice.org/75400 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-11Fix typoAndrea Gelmini
Change-Id: I23970cd631fba0023e0d4d075d88679622bc29eb Reviewed-on: https://gerrit.libreoffice.org/75399 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-11Fix typoAndrea Gelmini
Change-Id: I4c7508a95f47f97ba1558f8f49b6b952edd19f19 Reviewed-on: https://gerrit.libreoffice.org/75401 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-11Fix a typo in a commentChristophe JAILLET
Fix a typo (s/these/this) and merge some comment lines that are split for no reason. Wording is still not perfect, but is better :) Change-Id: If97b648fb5645f4ec1ecb0c0208467c9eee430b4 Reviewed-on: https://gerrit.libreoffice.org/75383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-11Simplify ThumbnailView::CalculateItemPositions()Christophe JAILLET
There is no need to call 'setPosSizePixel()' twice, once at the beginning of the function just to set the width (in case of changed settings) and once at the end of the function to set the position and the size. The size obviously includes the width. Change-Id: Ie1806fe21eb28af12f1c77ac1494bb970575eff9 Reviewed-on: https://gerrit.libreoffice.org/75382 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-11Rework tdf#115600 Display not found message for Navigate by SelectionJim Raykowski
Fixes not found message being displayed in find bar when a header or footer is deleted and other uses of SwCursorShell::GoNextCursor and SwCursorShell::GoPrevCursor when SwCursorShell::m_pCurrentCursor is not multi selection. Change-Id: Ie71d39e51b05363ad33ba2f912ac36273c38b8b4 Reviewed-on: https://gerrit.libreoffice.org/75386 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-11tdf#98575 Go into text edit mode when clicking on a hyperlinkSamuel Mehrbrodt
without opening the hyperlink Change-Id: I210d28284c9ce283a82edf60e7d39738f4595182 Reviewed-on: https://gerrit.libreoffice.org/75364 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11Use an unused ID for SID_REMOVE_HYPERLINKSamuel Mehrbrodt
Overlooked the comment that 457 is in use Change-Id: Idd13895fbbd82556ffe6f9405c359fa9cf9c80cf Reviewed-on: https://gerrit.libreoffice.org/75363 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11Natvis: add ErrCode visualizerMike Kaganski
Change-Id: I1717145b2ba265b114b1e347b7f88b7ac4684a2a Reviewed-on: https://gerrit.libreoffice.org/75394 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-11Warn when LayoutSize constraints were not respectedSamuel Mehrbrodt
Change-Id: I5145bc4e10928ed456b36617de3345512b7a35d9 Reviewed-on: https://gerrit.libreoffice.org/75351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-11lokdialog: Convert the Paste Special dialog to async exec for swMuhammet Kara
Change-Id: I0c75def6ea09bcb191a8023421b371b49205e712 Reviewed-on: https://gerrit.libreoffice.org/75378 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-07-11tdf#126234 up relative bullet size limit to 400%nd101
The legitimate value for MS Office document bullet relative size is between 0% and 400% But for ODF the value is normally between 0% and 250%. Per ODF 1.2 spec "19.761 text:bullet-relative-size" there is no limit placed on the relative size of the bullet. This change is to make the upper limit match MS Office to address the import issue. UI also changed to reflect the raise Change-Id: Ic4bbef47e86a04b9a6f9f6188326c8b66e034807 Reviewed-on: https://gerrit.libreoffice.org/75189 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-11Fix typoAndrea Gelmini
Change-Id: I414367cd5eb59e99f5ac558b7bb9872847b96a96 Reviewed-on: https://gerrit.libreoffice.org/75371 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-07-11Fix typoAndrea Gelmini
Change-Id: Ib3f29c89be059609baf104b4f59ec55248aa7e75 Reviewed-on: https://gerrit.libreoffice.org/75373 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-07-11sw: fix TransformDialog with args when the shape moves to a different pageMiklos Vajna
When a macro or Online invokes .uno:TransformDialog with arguments, then instead of showing the dialog, we apply the position/size/etc settings to the currently selected shape. This was not working correctly when setting an absolute twips position where the old and the new containing page frame was different. The desktop case drag&drop invokes SwFEShell::EndDrag(), which uses SwFEShell::ChgAnchor() to maintain the invariant that a draw shape position and its anchor is contained within the same page frame. The same was not true when SwDrawBaseShell::Execute() calls SdrEditView::SetGeoAttrToMarked(), so extend that a bit to also update the anchor position. With this, moving down a shape from the 1st page to the 2nd one via the API works and updates the anchor correctly, while in the past the move was only possible within the bounds of the current page frame. (See the "determine and set position" code in SwAnchoredDrawObject that enforces this invariant when the anchor is not updated.) Change-Id: Ia54470f6f3679ddc78a2f0a842f2fca10d20084d Reviewed-on: https://gerrit.libreoffice.org/75359 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-10make tools::Rectangle::SaturatingSetX/Y respect empty stateNoel Grandin
Change-Id: Ifef4c2ff967fdfbe122bca99e55d84e8e6c6a635 Reviewed-on: https://gerrit.libreoffice.org/75343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-10tdf#121528: Firebird stores scale as a negative numberXisco Fauli
Change-Id: Ic301952aeef93d3035b04442e70705d08f45f95d Reviewed-on: https://gerrit.libreoffice.org/75357 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2019-07-10tdf#126316 revert Clipboard to PrimarySelectionJan-Marek Glogowski
Regression from commit ce9795954d39 ("fix crash in header/footer calc dialog"), which replaced some GetPrimarySelection() calls with GetClipboard() calls. This replaces the Window class calls for clipboard with global GetSystem* calls in vcl/transfer.hxx. Not sure if this is the best place, but the crowded Window class is definitly not. Change-Id: Ic5f9e575c1ac5d43df234426c5616eca616dea30 Reviewed-on: https://gerrit.libreoffice.org/75318 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-10Fix typoAndrea Gelmini
Change-Id: Ifca7c0626f9671c1539e7828eb993278574ea10c Reviewed-on: https://gerrit.libreoffice.org/75367 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-10Fix typoAndrea Gelmini
Change-Id: Iec9af47dbc9e2665c05f16e458842d83345accf8 Reviewed-on: https://gerrit.libreoffice.org/75368 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-10Prepare PasteSpecial for Async-ness (sw, basesh.cxx)Muhammet Kara
This change is needed to make the paste special dialog async exec because the current design relies on return values of inner functions/methods while moving on. After this patch, the dialog creation and execution will not be so deep, so that it will be able to be converted to async exec in the usual way. The duplication in SvPasteObjectDialog::PreGetFormat() coming from SvPasteObjectDialog::GetFormat() will go away when the conversion is complete for all modules. It is only temporarily needed. Change-Id: I55e8aee39c41be6035c89f217f90f79720f32196 Reviewed-on: https://gerrit.libreoffice.org/75016 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-07-10slide-sorter: multiple selectionAshod Nakashian
Change-Id: I8624de25b0bb66020002890f33758e52059a24ab Reviewed-on: https://gerrit.libreoffice.org/69610 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73493 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-10Disable (again) part of testBtlrCell on WindowsMike Kaganski
This test fails on my system; the actual values likely depend on DPI scaling, but even with scale set to 100%, it fails. This is strange, considering that the test passes on Windows buildbots. After commit 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be Change-Id: Ia8c2e695ed918c3145dcd472e1da52398c1a8f52 Reviewed-on: https://gerrit.libreoffice.org/75335 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-10nss: upgrade to release 3.45Michael Stahl
Fixes CVE-2019-11729 CVE-2019-11719 CVE-2019-11727, and the less important CVE-2018-12384 and CVE-2018-12404 from intermediate releases. Since NSS 3.44 it's possible to build as static libraries and for iOS; drop the nss-chromium-nss-static.patch and nss-more-static.patch and hope that it works. Drop one hunk from nss.patch that looks fixed upstream. Change-Id: I7f37ac36f7f8dfd49d0bfb4a6185ca49d4f618a3 Reviewed-on: https://gerrit.libreoffice.org/75344 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-10tdf#123591: Firebird: take decimal places into account...Xisco Fauli
when copying values from Calc to Base Change-Id: I5dc645e3e9b153f71f2027a205815aaf83c1d6d3 Reviewed-on: https://gerrit.libreoffice.org/75346 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2019-07-10We don't support building with Windows SDK 7.1AMike Kaganski
... it's already impossible with 6.2; and was only needed prior to 6.0, where Windows XP support was needed. Change-Id: Ia462f0b6566ae35bd68545d2d34d2987ee7907b9 Reviewed-on: https://gerrit.libreoffice.org/75334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-10Fix descriptionSamuel Mehrbrodt
Change-Id: I7ce978c65f20589c5e88875d077267581497e2de Reviewed-on: https://gerrit.libreoffice.org/75341 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-10SmartArt: hide connectors in org chart as they don't work correctlyGrzegorz Araminowicz
Fixing them would require a lot of effort. Changes are needed in data part (connector shapes are not created in group shapes associated with data shapes) and in layout part - routing them differently in all 4 or 5 hierBranch styles, with assistants and without. Change-Id: I48840454b0272dff9ba42db2eb5d65945642459a Reviewed-on: https://gerrit.libreoffice.org/75339 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-10make tools::Rectangle::setY respect empty stateNoel Grandin
and make non-inline so it is easy to disable this for debugging, if need be Change-Id: I6feb94ca2f24246b96757575288c86c0b0c54227 Reviewed-on: https://gerrit.libreoffice.org/75342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-10make tools::Rectangle::setX respect empty stateNoel Grandin
and make non-inline so it is easy to disable this for debugging, if need be Change-Id: I2beae23bbdea36e91e0e367f9a94cbc35be3cd24 Reviewed-on: https://gerrit.libreoffice.org/75337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-10AnnotationWin: Restore lines from annotations to comment anchorJim MacArthur
This changes all the uses of GetTopReplyNote, which were using nullptr to indicate the top reply. Change-Id: Ibb9b5fac5644a5d6d283e8ea2fa80b988ca0693e Reviewed-on: https://gerrit.libreoffice.org/75174 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-10Fix typoAndrea Gelmini
Change-Id: Ic6d27877d757ff1a379e278053630dd5f3d14807 Reviewed-on: https://gerrit.libreoffice.org/75307 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-10Qualify call to std::ceilTimotej Lazar
Without the std:: qualifier, GCC uses the C version of the function, which returns a double instead of float, and compilation fails. Also include <cmath>, where std::ceil is declared. Change-Id: I88cb669fceb5b683d82093b68e8c696d28eaea8e Reviewed-on: https://gerrit.libreoffice.org/75166 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
generated by cgit (git 2.34.1) at 2025-03-24 16:22:00 +0000