summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-30findreplacedialog: Set a11y role of hint text to staticSamuel Thibault
Since this is not a label for another widget, but some text that screen readers should speak. Change-Id: Iddc2840e60c8a55caf2e6581831024e2658e084e Reviewed-on: https://gerrit.libreoffice.org/59668 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-30tdf#101856 Handle properties of nested bookmarksSerge Krot
Change-Id: I1a92d2001e58751c5bbe41f6480f4c46dcc8c9e7 Reviewed-on: https://gerrit.libreoffice.org/59766 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-29KJ: Draw menubar: add icons to shape menusectionRizal Muttaqin
Change-Id: I21c9d1a938266be9dcc6a43c2681a6b98b49e937 Reviewed-on: https://gerrit.libreoffice.org/59723 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-08-29Round fraction if possible, else truncate; tools::Time::GetClock()Eike Rathke
With this also some test cases can be narrowed. Change-Id: Ic754baf135dbd362b80fac1cf080758f46017e01 Reviewed-on: https://gerrit.libreoffice.org/59753 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-29Fix typoAndrea Gelmini
Change-Id: Ice092364268cdae09ad5ac31a922bbde049cfd8f Reviewed-on: https://gerrit.libreoffice.org/59105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Fix typo: s/an other/another/gAndrea Gelmini
Change-Id: Ifd83affcb16209f4134c725640fbd95077c8ab0f Reviewed-on: https://gerrit.libreoffice.org/59099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Fix typosAndrea Gelmini
Change-Id: I6ca53ead2b125618d0aceff05d5fdfa374662799 Reviewed-on: https://gerrit.libreoffice.org/58809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Removed executable permission on simple ASCII filesAndrea Gelmini
Change-Id: I3feef220283d57fd07cff836ddd22937b1b8c77f Reviewed-on: https://gerrit.libreoffice.org/57593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Removed execution flag on pptx fileAndrea Gelmini
Change-Id: I7beaea418a995670d26f1542ef09416410fdb722 Reviewed-on: https://gerrit.libreoffice.org/59466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Removed executable permission on xml fileAndrea Gelmini
Change-Id: Iaf8ca3004c209291a42edf4e6eea7c3631847db1 Reviewed-on: https://gerrit.libreoffice.org/59307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29Removed execution flag on xlsx fileAndrea Gelmini
Change-Id: Iaf82d475825b4794dadad50093839fad319e3ba5 Reviewed-on: https://gerrit.libreoffice.org/59527 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#117058: Simplify calls to Menu::CheckItemArnold Dumas
Change-Id: Ib4cba3af376d8d031d5282a5459eaecc18e3ed9a Reviewed-on: https://gerrit.libreoffice.org/58811 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-08-29tdf#119554 Expand collapsed panel when panel content gets focusJim Raykowski
Change-Id: I1af7a9e93affc5c6e5e3ba90ba335e59a0900d20 Reviewed-on: https://gerrit.libreoffice.org/59737 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#119527 Fix focus hidden by mouse click panel collapseJim Raykowski
Set focus to the clicked panel title Change-Id: I65993a6a2f8e7a9a2bdaa6cf4527d5b163d81409 Reviewed-on: https://gerrit.libreoffice.org/59694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#119461 Fix focus hidden on deck collapseJim Raykowski
Makes Space key behavior the same as mouse click. Focus remains on the tab button when the deck collapses. Makes Enter key never collapses the deck but to open if collapsed and always place focus on the first panel title. Change-Id: Id6d7624e88b421dcfc62f3d0e79986f10c76a65d Reviewed-on: https://gerrit.libreoffice.org/59616 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29tdf#102031 Expand collapsed deck when sidebar docking window gets focusJim Raykowski
SidebarDockingWindow::GetFocus hides focus when deck is in collapsed state so request open deck before setting focus to deck/panel title Change-Id: I7d7f6d940a3722eb02e6356c069c4d9df9642326 Reviewed-on: https://gerrit.libreoffice.org/58712 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29loplugin:useuniqueptr in the sc dialog classesNoel Grandin
Change-Id: I61c9812e1779e0342160f0762afe79d3302304e6 Reviewed-on: https://gerrit.libreoffice.org/59759 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29drop gpgme for oss-fuzzCaolán McNamara
Change-Id: I0ed32f520cf5592ddaf95a849aed16a125b52656 Reviewed-on: https://gerrit.libreoffice.org/59761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-2932-bit Clang trunk (towards Clang 9) still doesn't have __mulodi4Stephan Bergmann
Change-Id: I7579ff88d34c931a51c820b53960a281e6e3678e Reviewed-on: https://gerrit.libreoffice.org/59763 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-29mysqlc: Add library to log areas and put someTamas Bunth
warnings into databasemetadata Change-Id: I4c2841e9174e738fff6b8627f8860588c7838c49 Reviewed-on: https://gerrit.libreoffice.org/59755 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-08-29match preview buffer device mapmode and pixel sizeCaolán McNamara
Change-Id: Ie5ac758b788357e1d54ea3dc5abd233ff9e4abf0 Reviewed-on: https://gerrit.libreoffice.org/59762 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29desktop: improve help blurb for various casesThorsten Behrens
- tdf#109202 fix was missing --convert-images-to example - its not the mimetype, but the filter name that's needed - also add backslash line continuation where example cmd line overflows Change-Id: I80a461eb4a6ae5c9268bc0f888abd43a179c7a68 Reviewed-on: https://gerrit.libreoffice.org/59722 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-29loplugin:useuniqueptr in XclExpDxfNoel Grandin
Change-Id: I32c9ef89b387e6f5700100174700668d9412916b Reviewed-on: https://gerrit.libreoffice.org/59758 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29fix sd_export_ooxml2 fail on Linux-rpm_deb-x86@71-TDF, MASTERJustin Luth
due to rounding differences, it was failing on 32bit linux only. Test name: SdOOXMLExportTest2::testTdf91999_rotateShape equality assertion failed - Expected: 1449000 - Actual : 1448640 Test name: SdOOXMLExportTest2::testTdf114845_rotateShape equality assertion failed - Expected: 3287520 - Actual : 3287160 I also re-added the extra test that had previously failed for a similar reason under Linux64 even. Change-Id: I6c8be5ef1545d48f1e59319c3b3df1d2580e1f95 Reviewed-on: https://gerrit.libreoffice.org/59754 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-08-29More -Werror=redundant-moveStephan Bergmann
...similar to dc06c8f4989fc28d0c31ebd333e53dfe0e0f5f66 "-Werror=redundant-move (GCC 9), take two" Change-Id: I53c181887e254aa3d924c134c77d7d0230717d5c Reviewed-on: https://gerrit.libreoffice.org/59750 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-29loplugin:useuniqueptr in ScDrawTransferObjNoel Grandin
Change-Id: I7a895a88576eabf010caa13353ad5698b4daf4d6 Reviewed-on: https://gerrit.libreoffice.org/59756 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29More -Werror=redundant-moveStephan Bergmann
...similar to dc06c8f4989fc28d0c31ebd333e53dfe0e0f5f66 "-Werror=redundant-move (GCC 9), take two" Change-Id: Idb6b29d6959ff707bab820d150133a954221a29e Reviewed-on: https://gerrit.libreoffice.org/59749 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-29Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29vim-ide-integration: remove no longer needed workaroundMiklos Vajna
Fixes the problem that e.g. this code: OUString str; str += ""; is marked as a compile error, when clang would still work with c++11, but the tree is configured for gnu++17. Change-Id: Id60c0cf4b8c693b534f16ba813cf01a4bad7e560 Reviewed-on: https://gerrit.libreoffice.org/59746 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-29tdf#119232 ww8import: even page means default to start on page 2Justin Luth
I didn't see this mentioned in the sprm documentation, but that is how MS Word seems to implement it. Change-Id: I5b86ecf99a884e768877cdb0e71f43cdb9f2ad76 Reviewed-on: https://gerrit.libreoffice.org/59221 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-29sal: use correct settings path for HaikuKacper Kasper
* Don't lowercase the name. Change-Id: I8addd735bf8ee48256ec53f01063e96e7a4b41cd Reviewed-on: https://gerrit.libreoffice.org/58632 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-08-29Various Haiku improvementsKacper Kasper
* Fix make distro-pack-install. * Remove Xorg dependency. * Remove stack protector workaround. * Update distro-config and enabled features. Change-Id: I273dc8343ad84bd77b86453cc01ff427b50ea0b5 Reviewed-on: https://gerrit.libreoffice.org/58634 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-08-29Fetch xmlsec only if necessaryKacper Kasper
Change-Id: I4c5fe29c539d0f64c6cfede79a832f68feee1205 Reviewed-on: https://gerrit.libreoffice.org/58629 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-08-29Fix stack protector checkKacper Kasper
* "return 0;" is not enough to trigger it. Change-Id: I5a011f664aec30096cd5d26a1f94a0405297b1db Reviewed-on: https://gerrit.libreoffice.org/58437 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-08-29loplugin:constantparam (3)Noel Grandin
Change-Id: Ifc47bb8e096c9a8563021b2fcb44199577740746 Reviewed-on: https://gerrit.libreoffice.org/59747 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29fix android buildNoel Grandin
after commit 37f9fdc11c4e95d6a34cb515a454503256a82c63 replace rtl_allocateMemory with std::malloc just add cstdlib as in include to the compatibility header, so that std::malloc/etc is visible Change-Id: I3f0569434c41f5427a037a3c8d0ff75389169241
2018-08-29Add unit tests for tools::Time::GetClock()Eike Rathke
Change-Id: I0ff755fca2ee193f0f7ad99499ea12000029e674 Reviewed-on: https://gerrit.libreoffice.org/59736 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-08-29tdf#119458 just wakeup Scheduler on active IdleJan-Marek Glogowski
So this almost returns the code to the original state, before I started fixing tdf#116370... a long way. This introduces the new Scheduler::Wakeup() function, which will just queue a Scheduler event in the System event queue unconditionally. This should prevent fdo#73165, which I couldn't reproduce, but just to be sure. More importantly this patch resets the m_bStartOnUnblock when the Idle job actually runs. This run should already determinates if more Idle work needs to be done, and others can still call BeginIdling() to ensure further processing. This also drops the IsBusyDoc() test from UnblockIdling(). We can't really know, if the document is still busy when the Scheduler is finally running, be it by the system timer or Application::Reschedule(). Change-Id: I6cc4a3c48dcaf62b6985c7bc1c95c96697443f3b Reviewed-on: https://gerrit.libreoffice.org/59730 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-29fix android buildNoel Grandin
after commit 37f9fdc11c4e95d6a34cb515a454503256a82c63 replace rtl_allocateMemory with std::malloc Change-Id: Ib565eeb5277a9184f875e67b55040bedbbbdb952
2018-08-29loplugin:constantparam (2)Noel Grandin
Change-Id: I528f22876497f87159e3b9453362ebbfb55b7092
2018-08-29replace rtl_allocateMemory with std::mallocNoel Grandin
where used directly, since rtl_allocateMemory now just calls into std::malloc Change-Id: I59f85bdb7efdf6baa30e8fcd2370c0f8e9c999ad Reviewed-on: https://gerrit.libreoffice.org/59685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29new loplugin:oustringbufferNoel Grandin
look for places where we are appending the temporary result of adding strings together, to an OUStringBuffer, where we could rather call append repeatedly and avoid the temporary creation Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82 Reviewed-on: https://gerrit.libreoffice.org/59708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29remove 1 pixel white band in XRectPreviewCaolán McNamara
Change-Id: I3089f9305b8142e2c78405a4f9ae6a2066e90cfa Reviewed-on: https://gerrit.libreoffice.org/59725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29loplugin:constantparam (1)Noel Grandin
Change-Id: I25077e391ecca1b678062d261a83d88daadf0a58 Reviewed-on: https://gerrit.libreoffice.org/59701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29-Werror=redundant-move (GCC 9), take twoStephan Bergmann
...after 5b62a43349da6fda13fb33e0f1ec477c21daec8f "Revert '-Werror=redundant-move'" to fix the build for GCC 8.1 again. Turns out the std::move can only be dropped if the compiler has a fix for CWG1579. For GCC that's the case starting with GCC 5.1, so the !HAVE_CXX_GWG1579_FIX case can hopefully be removed again soon, see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-July/080588.html> "Compiler baselines (was: [Libreoffice-qa] minutes of ESC call ...)"). Change-Id: I3592cad7fb503db921c37e92831a34785a1054a1 Reviewed-on: https://gerrit.libreoffice.org/59741 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-29Use ConvertSidToStringSidW instead of composing SID string manuallyMike Kaganski
Change-Id: I0dc22130b5dec5eb2250c9625773b6c9720182a9 Reviewed-on: https://gerrit.libreoffice.org/59740 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-29pdfium: replace FPDFTextObj_GetFontName() patch with backportMiklos Vajna
Change-Id: I36d86e7ccca66b09f2f49e401d77deb52fbf742a Reviewed-on: https://gerrit.libreoffice.org/59738 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-29XHTML import: <br></br> is one line breakMiklos Vajna
But only for XHTML, HTML stays unchanged to be in sync with web browsers. Change-Id: I3a1cf6651dab565bafece68963acb112ae715cdd Reviewed-on: https://gerrit.libreoffice.org/59727 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-29chmod -xTor Lillqvist
Change-Id: I6ba581f3665bc2934b8e3af5985ae853d60be39f
2018-08-28Colibre icons: remove convertmenu iconandreas kainz
Change-Id: Id3e167009ad5cc7677930ebfad412600e62f261f Reviewed-on: https://gerrit.libreoffice.org/59681 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>