summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-27backendtest: Test Drawing Bitmap other than 24bpphomeboy445
This test draws bitmap formats other than 24bpp - namely 32bpp and 8bpp greyscale. Change-Id: I1b21214429be08fc7cf1eb086c2ad8946780f481 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119371 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26Add info on icon sizes for themingOlivier Hallot
Information collected from telegram chat by Rizal Mutttaqin, andreas k, samuel_m, quikee. Change-Id: I0d61f6b899b261478b6d40386ac5604aa1a3cfdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121088 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-26remove unused suppressionCaolán McNamara
Change-Id: Icd46ff6b6ff1ccf6be8248482d9f5fbbce073445 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26tdf#143169 - Remove additional row header widthAndreas Heinisch
If the table control has row headings, add the extra row width only at the beginning of each row and not at the end. Otherwise the renderer of the table control adds an additional column with the width of the row header of the table. Change-Id: I0acb67f21d0ad756ed53c56690d3f2deb50de8e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121038 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-26tdf#139660 one of the group needs to be activeCaolán McNamara
in this case using ToolButtons instead of ToggleToolButtons will work ok Change-Id: I806a8fc409ae346dd6734be13d69c4b171e54c08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121121 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26tdf#143148: Use pragma once instead of include guards in compilerplugins4k5h1t
Replace include guards with pragma once in several header files in compilerplugins Change-Id: I9cc586977dc7ade9278d93396c3efcd13acba286 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121089 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-26Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to 230ace24c9acaf135c5748cdda76e7bdfa0a3eda - Add a couple of missing definite articles Change-Id: I5b4c31b0cfc7eac0b82e45bcc8f9407df33a91fe
2021-08-26tdf#144037 Qt5 just close popup with mouse outsideJan-Marek Glogowski
How hard could it be to close a popup window when losing focus or clicking outside of it (AKA tdf#143114 problem 3)? At least with Qt it feels like solving an NP problem... So don't always force-close the popup window if clicked anywhere on it. Seems to be consistent with gen and gtk3. Change-Id: Ia1c231c0b51a55bec2c587feffcf14bb4b4cee55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121093 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-08-26tdf#144008 Qt5/Kf5 create frames in the GUI threadJan-Marek Glogowski
There was a 50% chance my pick would have been correct... ok, just half-true, as in hindsight, I should have preferred the secure variant using RunInMain to start with. I thought I could use some templated class functions to get rid of all the copy and paste, but that looked even more ugly. P.S. if you wonder - like myself - about the code formatting in Qt5Instance::CreateFrame: that if from clang-format. Change-Id: I3a6b0c12c9d71ad8e777ed82526d1515a249832c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121091 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-08-26use max of avg digit or 'average char' width to measure Edit spaceCaolán McNamara
instead of the x-width this is similar to what gtk does Change-Id: I2806939a09b275a3060ddf693e2763238a4e075f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121118 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26tdf#143526 Korean numbering import/export supportDaeHyun Sung
add support for the new NUMBER_LEGAL_KO(korean-legal) numbering format to various import and export filters. fix support for the HANGUL_SYLLABLE_KO(korean-counting) numbering format. Change-Id: I7b7dafe7305da910784ae537e307f9bfd05319a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120509 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-26change some left,top,width,height usage in Skia to x,y,w,hLuboš Luňák
Change-Id: I26e0f1f1c9aef795b040a191ffa9b725280eb63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121080 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-26add back getX()/getY() to tools::RectangleLuboš Luňák
581b2cf7960c48e cleaned up some usage of the class and removed getX()/getY(). But that means that the (probably most) common case of treating rectangles as x,y,w,h now doesn't work, and one has to use either left,top,right,bottom (which doesn't always mentally fit), or the IMO weird left,top,width,height. Change-Id: Ie9516f69af48490635346c76821be9a9eedd686c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121079 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-08-26tdf#144030 Readme reviewRoman Kuznetsov
Change-Id: I1500b2beacb88c0014495d98d8fb79090d7c9486 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121052 Tested-by: Jenkins Reviewed-by: Sophie Gautier <sophi@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-26Correction on cpui flagsdante
Change-Id: I34781d98f614c1d5df97460fc2e7b59be3bb6512 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121090 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-26tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktopRadhey Parekh
Change-Id: I8ccb5e43ac86ff2b8da94bd03e6fa50de0c33741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120961 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-26Avoid OUString::createFromAscii on input containing NUL charactersStephan Bergmann
...as it triggers the "rtl_uString_newFromLiteral - Found embedded \0 character" SAL_WARN in rtl::str::newFromLiteral (called from OUString::createFromAscii via rtl_uString_newFromLiteral) Change-Id: I6013062b961657561d67d8dbbf5b2a45816eed4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121086 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-26Resolves: tdf#144084 if not initialized default to FILEOPEN_SIMPLECaolán McNamara
which is a problem since... commit 43335776cfc18cdc7addf33250cffc886d384186 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue May 11 17:21:47 2021 +0100 gtk[3|4] don't create File Dialog with buttons that need to be removed just create it without the offending buttons in the first place where we create without buttons because its hard, especially since gtk4, to remove unwanted buttons. Change-Id: Ib0337c412fa7e8210d3b1bf3261174c4ffac0a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26tdf#143148: Use pragma once in chart2Baran Aytas
Change-Id: I8ee7542d5be6839f55b3898da8bb275b3d7fe398 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120844 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-26-Werror=maybe-uninitializedStephan Bergmann
Change-Id: I47d3a9327a88a75390f8bb18dfbf632ed97cac7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121084 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-26Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 726aca1551a75da04dfd8815947d904f96d9c37b - tdf#137084 Update Help Help page Change-Id: Ia86826bd87d709bec5acdaf6b0b8800f7aa9b8e1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121085 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-26tdf#125743 sw: fix rendering of graphics bullet with linked imagesMiklos Vajna
Regression from commit d72145f9307c732ced4a546ac1e5093ec7c1a982 (Move BackGraphicURL property & friends to BackGraphic + fixes, 2018-03-01), the problem was that now SvXMLImport::loadGraphicByURL() produces a Graphic that has its type set to GraphicType::Default, but when paintGraphicUsingPrimitivesHelper() consumes this graphic, it expects that the type is either a bitmap or a metafile. Fix the problem by explicitly loading the image when the default-type, origin-url-set case happens: this is rendering, so no problem to load the URL and that will give us the expected graphic type. This is also meant to keep the original problem fixed, since we only load images when painting, not during import. Change-Id: I951bc92d05bb8ec57d2ba6958c47947f8f9b5c78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121082 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-26tdf#118538 Extended tips for regression analysis dialogOlivier Hallot
Change-Id: Ib063540742f8fef44d2848d9cfe5f97deef072cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120971 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-26tdf#135164 add unit testJustin Luth
fixed by tdf#143605, but that was a bit different, so adding a specific docx unit test. Change-Id: I9f5a6b225277f1c1fdbfed7759919b3fd6e5dea5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121008 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-08-26Sifr: tdf#143300 add diagonal borderRizal Muttaqin
Change-Id: Ic01b845489701557d2c87e16c1c697d437fdbf1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120933 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-08-26tdf#114441 Convert use of sal_uLong to better int typesRadhey Parekh
Beacuse EditEngine::GetTextHeight() returns sal_uInt32, this type of int is chosen for the local variables nWidth, nHeight and nTextWidth Change-Id: I9288946b0cb7b9227fe63371840d6bfb84ab829e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120894 Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-26crashtesting: crash on re-export of tdf137357-1.docx to docxCaolán McNamara
#0 SfxPoolItem::Which() const (this=0xffffffffffffffff) at include/svl/poolitem.hxx:148 #1 0x00007fff9d0454a5 in sw::util::GetPoolItems(SfxItemSet const&, std::__debug::map<unsigned short, SfxPoolItem const*, sw::util::ItemSort, std::allocator<std::pair<unsigned short const, SfxPoolItem const*> > >&, bool) (rSet=SfxItemSet of pool 0x5368720 with parent 0x0 and Which ranges: [(1, 55), (153, 153)] = {...}, rItems=std::__debug::map with 0 elements, bExportParentItemSet=false) at sw/source/filter/ww8/writerhelper.cxx:411 #2 0x00007fff9d1ceae4 in MSWordExportBase::OutputItemSet(SfxItemSet const&, bool, bool, unsigned short, bool) (this=0x7fffffff5348, rSet=SfxItemSet of pool 0x5368720 with parent 0x0 and Which ranges: [(1, 55), (153, 153)] = {...}, bPapFormat=false, bChpFormat=true, nScript=1, bExportParentItemSet=false) at sw/source/filter/ww8/ww8atr.cxx:351 #3 0x00007fff9ce92a66 in DocxAttributeOutput::Redline(SwRedlineData const*) (this=0x59e44e0, pRedlineData=0x68110d0) at sw/source/filter/ww8/docxattributeoutput.cxx:3199 starting happening at: commit 5e891c2ee82f2d7566ddb4e15b9c03cecb9fc1f8 Date: Thu Aug 19 11:47:53 2021 +0200 tdf#143939 sw: track format changes of the actual word Change-Id: Idb2b07368233152db519e70627b43847c7392128 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121031 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8bac670cb289d7b8636535c1b1fb2f4fc9f03afe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120965 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26Update language-subtag-registry to 2021-08-06Eike Rathke
Change-Id: I0a2b43f291ef15f0bdacfb33b5396658efd1ea2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121047 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-08-26Remove spurious odk/examples/java/MinimalComponent/BuildMinimalComponent.xmlStephan Bergmann
It had been added together with odk/examples/java/MinimalComponent/Makefile in ff4c86ff37af5136466d49a9fb394974ee62cb0f "Added an example for a minimal UNO component", and it apparently is an Ant build script that shall do the same as the Makefile. However, it is apparently unused: For one, it does not appear to get referenced from anywhere else in the code or to get mentioned at <https://wiki.openoffice.org/wiki/Documentation/DevGuide/OpenOffice.org_Developers_Guide>. And for another, it would apparently only work on Windows (using e.g. "${ODKPATH}/windows/bin/idlc.exe"), but would typically fail even there with something like > > ant -f BuildMinimalComponent.xml > Buildfile: C:\lo\core\instdir\sdk\examples\java\MinimalComponent\BuildMinimalComponent.xml > > init: > > unoidl: > > BUILD FAILED > C:\lo\core\instdir\sdk\examples\java\MinimalComponent\BuildMinimalComponent.xml:35: The directory D:\cvs\api\odk\WINexample.out\misc does not exist due to the hardcoded D:/cvs/api/odk paths. Change-Id: Idd020bcf1a2383295704b208d3ac2be047f270ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121050 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-26tdf#144089: sw: Add UItestXisco Fauli
Change-Id: I6ffa476180a58ba47268b4f4a8bc59f75738be29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121046 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-26update Skia to chrome/m94Luboš Luňák
Updating to m91 or newer required handling the problem with Vulkan crashing, but that's been finally fixed by the previous commit. This Skia version also requires at least freetype-2.8.1, so disable Skia if that's not available (LO's minimum is lower). Additionally patch out Skia's use of TT_SUPPORT_COLRV1, which seems to be an unstable freetype API from the git version and it doesn't even compile with the latest stable 2.9.11 release Change-Id: I4a17effb912468c43fc7cdb69fe453062e4d2447 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120967 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-08-26ofz#35646 Indirect-leakCaolán McNamara
Change-Id: Ie79d9c49b6beef04ab111a63166abc7f093ad36b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121041 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-26There is no --disable-neon configure option any moreTor Lillqvist
Change-Id: I8a3845ae0b811a43830c7bb166cc2092b7e163b1
2021-08-26Fix crash when drawing shapeSamuel Mehrbrodt
Fallout from 75cd2b0fa71c73ae815b80d8e42328024ea63555 Change-Id: I455519126d11bee1b809f9fd9476b2fdd0f1a524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121034 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-08-26tdf#142307 - Upgrade SSE2 sum to AVX512 sum with Neumaier 1dante
This part focuses on allowing it on replacing arrayfunctor By thefault it will try AVX512F (1,17%) If not available will use AVX (94,77%) Use of AVX2 (82,28%) has been avoided even if the code could been more compact Source of hardware statistics: https://store.steampowered.com/hwsurvey Change-Id: Iae737a565379e82c5f84f3fdee6321ac74f59d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115675 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-26CppunitTest_sw_ooxmlexport6: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I3f5dbe43d94eba90a44b39180239e7aed8242b05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121045 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-26backendtest: Intersecting Rectangles Drawing testhomeboy445
This test intends to test the even-odd filling rule by testing if the intersecting rectangles have been filled accordingly to the rule or not. Change-Id: I0fb7f115a25476cc38e8bec5cd02737aea3c0316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119098 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26Missing includeMike Kaganski
Change-Id: Idc533f1849c8be44ed04d3ed823c7f69c12c2d79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120988 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-26vcl: move X11SalInstance::CreateSalBitmap to salinst.cxxTomaž Vajngerl
X11SalInstance::CreateSalBitmap doesn't belong in the salbmp.cxx, but where other implementation of X11SalInstance is. Change-Id: Iffd66d55cec2532dfceb9b4ef8cf8ed30bc34e1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120992 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26backendtest: Text Drawing testhomeboy445
This test revolves around drawing text to a Virtual device and testing if it's rendered at the expected position. Change-Id: Iccfe382103632822befe84d5933d64eacefffa24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118976 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26indexing: move xml parsing into SearchResultLocatorTomaž Vajngerl
Let's keep unneeded complexity out of SwXTextDocument, so move parsing into SearchResultLocator. As a bonus we can now test parsing. Change-Id: I944bfc43e6953523eee19b26b7f483aa401809aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121032 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26vcl: make OutDevState constructor default, no need for destructorChris Sherlock
There is no value of having the OutDevState constructor and destructor being in its own file, so move to header. Also, resetting the variables in the destructor is rather pointless as they are destroyed in the next step anyhow. This removes the need to define an empty destructor. Use C++11 magic to make a default constructor - many thanks to Mike Kaganski for the tip on this one. Change-Id: I9561b311d8752fa12802b5ae8e11123aedabe8be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115460 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26vcl: partial revert of drawmodeChris Sherlock
Partial revert of commit 0901297902c29c041ae944973b369e8247716893: vcl: create drawmode functions The GetBitmap() function will not work, as it doesn't add metafile actions. I have added a unit test to prevent this from occuring in future. Change-Id: I8c895e813f378f85ee47f85c3f867e20925bae2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121039 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-26tdf#144089: Revert "tdf#137737 i18n search: don't expand start/end with ↵Xisco Fauli
regex ^ or $" This reverts commit a511bffd67a9cebfdc878766581ac08c79d7ff51. Reason for revert: See https://gerrit.libreoffice.org/c/core/+/120981 Change-Id: If8a445448976a9963f76623d3d968b8d5e3d74dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120990 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-25Fix corrupted odk/examples/java/ConverterServlet/web.xmlStephan Bergmann
Instead of just adding a license header, 2b4fd2c89a38ccac13c72f2e94501a8702e7da4b "re-base on ALv2 code" had apparently erroneously overwritten this file with the content of the completely unrelated odk/examples/java/MinimalComponent/BuildMinimalComponent.xml. Change-Id: Iee6dcb528dbb444a132c27e7183b3957319882c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121037 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-25tdf#143979: sc_subsequent_export-test2: Add unittestXisco Fauli
Change-Id: I9051187dcb252d800ba4c2f062ff18f0ed022c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121028 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-25tdf#143929: chain XMLTextExportPropertySetMapper to sc's shape exportMike Kaganski
This allows to export editengine columns to ODS. Alternatively, we could re-introduce chaining text attributes in XMLShapeExport ctor, which was commented out in commit d5b1e4827f8e6e0661563ec856cd80d926ba7b58 without explanation; but that would affect export from other modules as well (e.g., SdXMLExport::setSourceDocument sets up respective chaining in sd), so to be on the safe side, I do it only for ScXMLShapeExport. Change-Id: Iafee77b2b57e95031cfe1bbd2d43d7361a3e8469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120958 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-25Fix typo after translation roundOlivier Hallot
Change-Id: I2e88905f38f9fade306de064e84e0863f9eeea71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120918 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-08-25i#114206 sd: unshare shape properties for the same type before insertionMiklos Vajna
Regression from commit 9bd99c08e8662becdd5ac8b47ef6f953c14e65fc (CWS-TOOLING: integrate CWS os128, 2009-06-03), the problem was that the SvxItemPropertySet was both used to store a property map (information about UNO properties) and also as a descriptor for a not yet inserted shape. The above commit improved performance by sharing a single instance of an SvxItemPropertySet for the same shape types: this works for the property map, but doing the same for property values is problematic. In practice, this eliminates the need for a workaround in oox/, the user-visible problem was that loading a document with smartart, then loading a document with group shapes (but without smartart) and saving it would copy information from the first, closed document (!) to the second document. Just removing the oox/ workaround would make make -C oox -sr CppunitTest_oox_drawingml CPPUNIT_TEST_NAME="testGroupShapeSmartArt testTdf131082" fail, unsharing the descriptor piece makes it pass again. Change-Id: Icdff2108ad0da18ce0ade081b1938dd74bc0ae90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120996 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-01-10 09:00:22 +0000