summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-29push/pop mapmode to avoid 'incorrect MapMode?' warningCaolán McNamara
since... commit 644ebf7823c85973e2724cbfcf403cb63b054bfe Date: Tue Jan 28 20:40:15 2020 +0000 weld SmElementsDockingWindow Change-Id: I072f8b9d31be93722930d30b183766b7795f7a26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29desktop: document what doc_iniUnoCommands() doesMiklos Vajna
Change-Id: I961e563d92c6fdb783942de4b295d5d8b1bf2db3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87701 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2020-01-29gtk: make sidebar media panel "play video" workCaolán McNamara
blank impress, insert video, use sidebar media panel to play video, without this chage the video playes in a toplevel window because the size is 0x0 so the widget doesn't get created in the first place Change-Id: I7200423a693fb475dede357071ef10030c5bb790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29tdf#130132, tdf#129393: Add unittestXisco Fauli
Change-Id: Ia613dca3dc8bb1aa2e45e73149932be6ac61f8cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87691 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-29There should be no need for o3tl::make_unsigned hereStephan Bergmann
...to avoid hypothetical warnings when comparing an unsigned value to a signed constant Change-Id: Ife9f0be863443ea06fcd6dd49aba651f49659f02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87690 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29CID 1458016 - fix uninitialised members in AccessibilityIssueTomaž Vajngerl
Change-Id: I826ed2da7743c99606209862075a0ca4f8e9eb62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87685 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-29tdf#129993 broken tables opening LWP fileNoel Grandin
regression from commit e2080e70fe8b085f18e868e46340454720fa94ca new compilerplugin returnbyref The parts that fix this specific bug are in lwprowlayout.cxx and lwprowlayout.cxx, but fix the other parts I messed up but not understanding the semantics of assigning to reference variables. Change-Id: I064cdd108c5b05da6092da0297dc7bcf487c7702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87686 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29make a simple compiler plugin usable in sharedvisitorLuboš Luňák
Change-Id: I9af231277facc661784e44f6ad3eb1a340c76f97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87663 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-29lok: preserve mouse event logic position and use in calcTomaž Vajngerl
When clicking in online Calc any of the charts, shapes (and other objects), sometimes the cell underneath is selected instead. The problem is that the object is not correctly recognised to be hit. From lok we get the mouse event position in logic coordinates, which we usually can just use in writer and impress. In calc however we need the coordinates in pixels, so we transform them before sending the mouse event to calc. Still calc also uses common SdrObjects (chart, shapes,...), which operate in logic coordinates. So in case of SdrObject we need to convert the coordniates back from pixel to logic again, which causes problems because conversion doesn't have access to the displaying conditions on an stateless online client. OTOH we already had the correct logic coordinates, and we can just send them along. This is what this change does. It adds an optional maLogicPosition to MouseEvent, which is filled with logic position if those is known. Change-Id: I26f6466085baf613850b5861e368f22cad7c1d26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87681 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-29Adapt to "[ADT] Make StringRef's std::string conversion operator explicit"Stephan Bergmann
...<https://github.com/llvm/llvm-project/commit/ 777180a32b61070a10dd330b4f038bf24e916af1>. This is just a quick fix to get copmilerplugins buiding again with latest LLVM/Clang trunk. Ideally, we should get rid of as many of those (potentially expensive) conversions from llvm::StringRef to std::string as possible. Change-Id: I18e185e0022a06fd8e3b983a3c4f80e1f3b96746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87682 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29bInterim is always trueCaolán McNamara
Change-Id: Id9f72fdb94a766ef58a44b3653a36f22335b5718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29bInterim is always setCaolán McNamara
Change-Id: I2a84351d98523a2dda7db96a4099837d0e8a8ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87664 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29weld SmElementsDockingWindowCaolán McNamara
Change-Id: Ieeaa1f1e0deb708ec6d3daf261384c61d2ade22b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87659 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29Revert "ofz#20267 Indirect-leak"Caolán McNamara
This reverts commit ae01adf0747496e8c36f8f30fc2c1a4a6ef8275e. Reason for revert: intermittent failures Change-Id: I2212154e2c6ca210a2ff19cf73c0578c146dd46d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87679 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29Add wrongly formatted files to blacklistStephan Bergmann
Change-Id: I5453f58db919faa8799e6fe46201818df17f43f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87673 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29tdf#130237 OOXML chart export: fix incomplete 3D area chartBalazs Varga
by exporting its z-axis properties into <serAx> element. Data series of 3D area charts were “transparent” or incomplete opening with MSO, because we exported z-axis as a category axis. Change-Id: If7d8c15aa738cc44c736cd37d2be30d0eb15538f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87506 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-01-29tdf#42949 Fix IWYU warnings in sw/source/ui/vba/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iafc34cffc3257d785d61f60fc37dc95e5250435c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87308 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-29The next release is 7.0Samuel Mehrbrodt
Change-Id: Id6300035b5aba13cdd3d11035f2e85559e9f1597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87674 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-01-29tdf#128959 DOCX import: fix missing text lines in tablesLászló Németh
Orphan/widow line break settings aren't always ignored by Writer table layout code, in this case, in vertically merged cells, resulting missing paragraph lines. As a workaround for interoperability, disable orphan/widow control in cell paragraphs during the DOCX import to get correct layout in Writer, too. Change-Id: I48fdb0a3bb421fd4df2c729e307a7ef483e3e772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87637 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-29Sort solenv/clang-format/blacklistStephan Bergmann
(lexicographically, by Unicode code point values; to make it easier to add further entries) Change-Id: Ie9c426e74b79cab241695d1ecd58c78704820649 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87672 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-29Resolves: tdf#130130 Insert menu, multiple hotkey never reaches 3rd itemCaolán McNamara
Change-Id: Ica70be71094229a12c16eee1d3ff6960b7e06734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87657 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-29sw: add UI for semi-transparent textMiklos Vajna
Somewhat surprisingly the test passed without the fix, i.e. the uitest operated happily on a hidden widget; so explicitly assert that it's visible. Change-Id: I321c7e0e3cb2d67a07724523c885d50577a116a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87656 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-29tdf#129625 Gray out content types with no contentJim Raykowski
This patch is for Writer Navigator only. Change-Id: I80724a3e24fd38d7b5537e1c923866a914b45898 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87668 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29Fix typoAndrea Gelmini
Change-Id: I27f2c02ff3d4ab277219428be99b1219f1d6e94e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87667 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-28Sifr: Update Gamma icons in Sidebar and Tabbed barrizmut
Change-Id: I34a0bf47ee295feed83b084129d6f6a7045733cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87622 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-01-28“Go to” is two wordsAdolfo Jayme Barrientos
If it’s one word, then it may be interpreted as a noun, but then it doesn’t form an imperative sentence. Change-Id: I848cf8dd629e44e1570d3c9e42b9720240373320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87655 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28lok: create marking overlay object, but add no objects to itMichael Meeks
null mpMarkObjOverlay was used for a number of other reasons. Change-Id: I0681d9c544f0cd3f93e991eb048b97bd58f94787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87409 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-28tdf#128352 stylistic correction of dialog box titleSeth Chaiklin
- Change template Manager to "Set as Default" Change-Id: Ifb34e2621b9795be5eae829b7f84f252cfa74285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28tdf#127112 repair "sticky" levels in Customize numbering style dialogSeth Chaiklin
Change-Id: Ifa841e7b63b28d6e0f84f5cd6b1800481b36425b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87149 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ofz#20366 OOMCaolán McNamara
Change-Id: If658720502739e6ad88c3cf73ac6674e0313a48b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87648 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28ofz#20267 Indirect-leakCaolán McNamara
Change-Id: I32e4d12e83573eaaaf3a393d8a2d5ba10ccb93ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28gtk silence warning about parentless widgetCaolán McNamara
Change-Id: I9aa4b9ba63c5a83e7e27e786e38761721977b33a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28tdf#130122 Make content navigation view collapse uniformJim Raykowski
...for root node of all content types This patch makes content navigation view root collapse to it's immediate child entries. This fixes the current behavior of outline root collapse not collapsing and all other content types collapsing to root. Change-Id: If48b4c9f5f92e7a1843557eec51c516fa42f228f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87316 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-28tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorHakan Bakacak
Change-Id: Ifda9d3a4f05ffa9f611512d5d203e40d67d1c542 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87522 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorOnur Yilmaz
Change-Id: Ie5a381fc5e5b73490ab8b2036ef2a1164e475e8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87557 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorFaruk Demirbaş
Change-Id: I0e792603435b7a1d9fcacf67a694ee8c4cc24a7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87516 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorMesut Çifci
Change-Id: Ic759fd9e741cb2ca305b9bbf3ce71585c6801057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87590 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28unused suppressionCaolán McNamara
Change-Id: I17597240347fe5e8aec40c54bfc693591b796e92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87643 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28update sd pchesCaolán McNamara
Change-Id: If8de411ce76a3ffa15384fac3ce7900b5aefebbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87641 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28the only VclComboBoxNumeric left has a patternCaolán McNamara
so the !pattern case is dead Change-Id: Ib8d8c2fc4d9929cf5b66f389fddc23189448bd47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87639 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28weld AnimationWindowCaolán McNamara
Change-Id: I66bcd02a5fc98fff4d2fb0fcd24d702ff894d536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87638 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-28Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' to c4e6caecb8dd4a8b7f4f97b54eebc48a6987d1f8 - The twentieth major version of LibreOffice will be numbered 7.0 Change-Id: I89bb5ea9ed21faea5bca74b3d1d7ce79817e85ed Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87498 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-01-28Fix typoAndrea Gelmini
Change-Id: I87ffb70c16efe356981e3f0312f9e8fbce9cd04b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87653 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-28dtrans win32: implement support for pasting when the handle type is streamMiklos Vajna
Steps to reproduce the problem: select an image in Word on Windows, copy, paste into Writer -> nothing happens. A workaround is to use paste special, and select the metafile paste, not the bitmap one. The root cause was that clipboard contents on Windows can have different handle types and we only supported the memory and the metafile cases. An alternative fix would be to handle this at a higher level, e.g. TransferableDataHelper::GetBitmapEx() in vcl could fall back to EMF when the bitmap formats fail, but that would not work for other applications that only offer bitmap formats with a stream handle type. Change-Id: Iccaaf33df949ee73185acbd55b61d00a12d210ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87649 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-28avoid compilerplugin's sharedvisitor bailing out prematurelyLuboš Luňák
The simplifyconstruct test can return false from a Visit*() function (thus ending the whole traversal) because anyPluginActive() would return false just because a plugin would be temporarily disabled in Traverse*() because of its PreTraverse*() returning false. Keep a count of temporarily disabled plugins to prevent this. Change-Id: I413d88749257acff2220182d13e8fcd0f7289540 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87636 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-28Use better types for PPDContext::countValuesModified/getModifiedKeyStephan Bergmann
Change-Id: I663216e94fed3ce8f61cef0aeab3cd79f358b7fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87632 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28HAVE_GCC_ATTRIBUTE_WARN_UNUSED should always be true now for Clang/GCCStephan Bergmann
...but for safety, leave the configure.ac check in for some longer. Change-Id: I90cba5812492ba85d7723ff71aba75b7721b9622 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87621 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28elementary: Move wrong placed icons, delete unnessary iconsrizmut
Change-Id: Iead17a1815f502f88994bf21570e4c0db938c258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87620 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-01-28loplugin:unsignedcompare (--enable-cipher-openssl-backend)Stephan Bergmann
Change-Id: Iab5ab11059437a595596e8ba3ec7aa45cec15f0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87617 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28Remove obsolete Clang <= 3.8 __float128 checkStephan Bergmann
According to README.md, for Linux the baseline is Clang 5.0.2, and for macOS and iOS (should this libstdc++ __float128 stuff be relevant for either of them at all) the baseline is Xcode 9.3 which maps to ca. LLVM 5.0.2 according to <https://en.wikipedia.org/wiki/Xcode# Xcode_7.0_-_11.x_(since_Free_On-Device_Development)>. Change-Id: Ibd916cff795998bc63398695be63481cfd02abcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87618 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>