summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-01loplugin:singlevalfieldsNoel Grandin
Change-Id: I8b0ae3ae7e742bf5a5078681a51e8a81d5110a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01tdf#132454 some more improvementsNoel Grandin
Defer moving around the vector by tagging the last bit in the pointer. This takes the undo operation from 10s to 8s on my machine. Also re-organise the fields a little to improve packing. Also add some design notes Change-Id: I38fa9156705c00bb9f64e2fc59ea862eba522942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97424 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: extensionsStephan Bergmann
Change-Id: Ifce7b61cc5bd0901c7ee43712dc236f5aec47edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97560 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: cppuStephan Bergmann
Change-Id: Iac1bd5cb1ff1a1786471b2d8b8a3c500a2e15c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97546 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01avoid costly to-monochrome-bitmap conversion with Skia (tdf#134365)Luboš Luňák
The BitmapEx 1bpp monochrome bitmap mask constructor forces the mask to be 1bpp, which is done in software by BitmapMonochromeFilter. Which with Vulkan leads to fetching all the data from the GPU, usually only to be converted and then pushed back to the GPU. Similarly to MACOSX and iOS, just use AlphaMask, which is just better (8bit is easier to handle and in Skia's case it's also optimized to avoid fetching the data if possible). Change-Id: I5770c2b0c298c1534b7ff56cc905d2d668d3a8df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97525 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01optimize Bitmap::Erase() for Skia by delaying the erase (tdf#134363)Luboš Luňák
Tdf#134363 causes OutputDevice::DrawTransformBitmapExDirect() to create a huge 1bpp bitmap as mask, and Skia code then tries to convert all the bits to a format Skia would understand. Which is wasteful, as SkShader with the color given will do the same task much more efficiently. Change-Id: If0bba16f56fed9c3720be801b25a1e703054ed8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97488 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01remove code duplication for BitmapReadAccess pixel functionsLuboš Luňák
Change-Id: Ib243fea4276cfb86b4fdff8d0c84cea7c4523d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97487 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01avoid Bitmap::Erase() duplicating codeLuboš Luňák
Change-Id: I68d388175355fe1fcf5acc300730e8473fa559fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97486 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01do not use scanline padding for computing vcl bitmap checksumLuboš Luňák
This idea of checksums is still kind of broken (different RGB order or different scaling algorithm make the checksum different between different VCL backends). But at least don't include undefined garbage. Change-Id: Ia03bb960c50d3da51dad9b37de7a4f709d8ee206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97484 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01call InvalidateChecksum() in SkiaSalBitmap()Luboš Luňák
Change-Id: I52b6d9985639a6a81bf9c53bd35487b5c4992988 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97485 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01change n777345.docx to check bitmap content instead of checksumLuboš Luňák
Bitmap checksums are unreliable, they often depend on underlying implementation and whatnot. Change-Id: Ifc13285d6eb7d6d050a1ec26b270e0533eaae8eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97533 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: desktopStephan Bergmann
Change-Id: I1fadfc0fb62df56a890c6cd789435135671349a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97554 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: dbaccessStephan Bergmann
Change-Id: I49932a9d89d2933bebd313d3f1f64af84f0e52cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97552 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: cuiStephan Bergmann
Change-Id: I403229592145d6e126f5a3f4c8b788d2deb70a8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97551 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Upcoming improved loplugin:staticanonymous -> redundantstatic: cpputoolsStephan Bergmann
Change-Id: I301e5008316fcc714b7ce955f8c262a8cbed3f65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97550 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-01Resolves: tdf#85551 OFFSET() NewWidth and NewHeight must be >0 if givenEike Rathke
This also makes it necessary to adjust a test that reused the bug document for a different scenario but checked the result. Change-Id: I80136747445d5029aa5c894270448f002c567e3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97553 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-07-01tdf#134357 we can reduce the min toolbar sidebar widthCaolán McNamara
since, commit 754bea8c6a17889f9d4d23bf98847b6b67253220 Date: Wed Apr 29 15:06:42 2020 +0100 remove the padding around the dropdown button of GtkMenuToolButtons the GtkMenuToolButton aren't as wide anymore so we don't need a min of 5 GtkToolButtons widths for tdf#130197, now the max of either 4 GtkToolButtons or that of 1 GtkToolButtons + 2 GtkMenuToolButton is sufficient Change-Id: I7296805b4b3c0d86ce3d08cadc8c2659104af619 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97544 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-30tdf#134043 DOCX import: new unit tests: ComboBox to DropDownSerge Krot
Change-Id: I513933b508ca531e17271a3cc821a6aef2244868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97531 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30Add Shape mbIsForeground flag and getters and setters for itSarper Akdemir
mbIsForeground is a flag that is set false if a shape is known to not belong to the foreground. It is set to false while shapes are being imported and the shape belongs to the master slide or is a group shape, right now. Change-Id: Id9738fc943f32a1e1a6e1888d179e69fd60bd022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95968 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30adding XShapeToShapeMapSharedPtr getter to ShapeManagerSarper Akdemir
Refactoring XShapeHash in layermanager as XShapeToShapeMap and XShapeHash in targetpropertiescreator as XShapeToNamedValuesMap. This refactoring describes what the types are more clearly and stops violating one define rule in the desired implementation. And adding getter getXShapeToShapeMap to ShapeManager to enable Animation::start() to access Shapes and XShapes of the current slide. Change-Id: I78d510ae43888fd6cf0f037e224b24f91b263b00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95967 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: connectivityStephan Bergmann
Change-Id: I959a520f240faab062ecd4f6e2658d9fc9ce709f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97545 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: comphelperStephan Bergmann
Change-Id: I222ea673a44528cb04847a912cd8da971bb1be3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97542 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: configmgrStephan Bergmann
Change-Id: I85650691056c24d8c2e37ddce2c50a27193b4c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97543 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: chart2Stephan Bergmann
Change-Id: If4e61fdcf1749b2900512ae788422c435ae6af0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97541 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30tdf#134277 sw table: fix lagging shape at page breakBakos Attila
Shapes anchored to characters in table cells didn't follow their cells at page break, resulting lonely shapes at the end of the previous page. Co-authored-by: Attila Bánhegyi (NISZ) Change-Id: I2149ef58696a8f5dc6f41959060d2d57f938d025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97209 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-30Attempt to fix three more cases of just "hoping" that things work rightTor Lillqvist
Change-Id: I81c87740b36beeb1288649712f6415cb6074348f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97416 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97473 Tested-by: Jenkins
2020-06-30Resolves: tdf#131424 separator in TableRef column specifier is validEike Rathke
Even only a separator or any operator single character. Change-Id: I102dd7fd49c1a6a7f1d8c39f4a6139a51dbebe51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97535 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-06-30Resolves tdf#130436: Crash on redaction without DrawMuhammet Kara
Change-Id: Iaa418e9ad5c6e9ba1892cbb428a8a381f52c4246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97458 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-06-30tdf#134390: sc: Add UItestXisco Fauli
Change-Id: I12ab42afbe902a25f93deaa4884280392c705f38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97516 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30tdf#134270 rearrange so we know the final treeview widthCaolán McNamara
so we can unconditionally use the treeview width as the optimized pre-calculated row width hint and then fix up the gen fixed column settings to take account of the auto CHK_BTN mode Change-Id: I2e1eaf4b1121d5e705eb7db3464f123c038db246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30dont (ab-)use typeless GetInfo() interfaceBjoern Michaelsen
Change-Id: I73ab1e0efcb3559dfe37f3f408b3ec4862a408e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97472 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-06-30Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to ba1243452608af3997b42b975895a3e838c767c6 - Advanced Basic libraries brief descriptions Change-Id: I7cdeba9ec039a42eff0072d44e92bf95d78ecd90 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97497 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: basicStephan Bergmann
Change-Id: I1046ee1ea28e19afa51b0e20ee573105ced77535 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97522 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: binaryurpStephan Bergmann
Change-Id: I67340a41005d93d11686ed5f5d49bf6e4938f8c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97523 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30prefer down for main dropdown and right for subdropdownCaolán McNamara
Change-Id: I89d689e0cf2aea246b5fa6b545807d7059e076f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: basctlStephan Bergmann
Change-Id: I316331cee15bbb87ecfbda84f3195759e521df6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97520 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: basegfxStephan Bergmann
Change-Id: I66b7e0fd74c7ce57cd2859e189caadb84be4d541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97521 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Upcoming improved loplugin:staticanonymous -> redundantstatic: accessibilityStephan Bergmann
Change-Id: Ibb44e313924970319c3409323160ca7f5a6d184e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97519 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-30Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f8d5d058a35ca8fe9b6797e45fe703a7d7486ed1 - tdf#133998 Help entries split in middle of sentence Removed <ahelp> tags from Help file, and copy contents to extended tips in dialog file as done in https://gerrit.libreoffice.org/c/core/+/97526 Change-Id: I933b1f89f8f5ea5a43dedbc25ea1de8014f3ea76 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97529 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-30check-missing-unittests: Add date to the output and...Xisco Fauli
check for writer undo and calc interpreter missing tests Change-Id: Ic891f3585eb96eda3c9c6ab4d012cd03d324df54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96436 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30faster conversions from 1bpp mask bitmaps for Skia/GLLuboš Luňák
Tdf#134363 leads to creating a large 1bpp bitmap, and this conversion takes ages. Change-Id: If596d55829698df54f1b205a5f9a5d68cbea40fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97489 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-30tdf#134021: sw: Add unittestXisco Fauli
Change-Id: I789adaf699a857e28416132d253c04128def5984 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97481 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30Fix typoAndrea Gelmini
Change-Id: I9562d74b5b75d6ad6f98e413410d527c7e8d502e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97510 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-06-30tdf#128502: Fix (haha) for a crash with multiple docs open in the iOS appTor Lillqvist
Just a band-aid to avoid a crash. The LibreOfficeKit-related code would need a thorough re-factoring to properly be prepared for multiple open documents. Change-Id: I8c31e2badd747f3086526f89638fa495f4dcf295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97205 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97409 Tested-by: Jenkins
2020-06-30tdf#134414 Variables page doesn't need expandersCaolán McNamara
Change-Id: I5a38e1e8052c96970f9701f776f7675fda5f21c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97479 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30tdf#134404 sw: another subtlety with start/end of section (at-para flys)Michael Stahl
fix this problem by comparing the start/end of the selection instead of the anchor position, which always has an index of 0: 1. new document with image anchored to paragraph 2. insert one letter 3. press Enter 4. Backspace -> Image gone (regression from cc4b5091e739116a7ec83513fa1cd856f0130330) Change-Id: I1219a9f58ce19ea88d697c90c862fe9005318177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97511 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-30Related: tdf#128743 fix unwanted background color of transparent wallpaperMiklos Vajna
With this, the unwanted line at the top of the background image goes away and we can consider re-adding those images again in the future. Change-Id: I36822e84ab38b0b534371f939592f6a270f2d326 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97482 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30Related: tdf#131175 OOXML chart: import data label fill patternGülşah Köse
Change-Id: I2db64489c86e4381167eb13af4ab5118113960d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-30tdf#134243: sw: Add UItestXisco Fauli
Change-Id: I59376419048ddddff3e4fbbd6d3eb7436ee87747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97029 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 74e0455c41e1e6b95c9e8cc34db4b4da0802f30d - Mute l10n on bookamrk hid= Change-Id: I306ece30659e9b9fe1b193f8d6fb3a5161bd8be7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/97461 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-02-16 07:18:02 +0000