summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-09-05Simplify a bit nOldROP management (emfio/wmfreader)Julien Nabet
Change-Id: Ia50f9def88e8435fb5ce3267cbd3fdfcaa72ef4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121646 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-05Sukapura: tdf#144303 add cross cursorRizal Muttaqin
Change-Id: I944fff19d88b77720b363d87f4237503ae609384 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121659 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-09-05vcl: unit tests for Bitmap::Crop() and Bitmap::GetDownsampledBitmap()Chris Sherlock
Bitmap::Crop() test: - If crop rectangle is fully outside of the bitmap, then return false and don't change the bitmap. - If crop rectangle is same size as bitmap, then return false - If crop rectangle is larger than the bitmap, then return false - If crop rectangle partially overlaps the bitmap, return true and crop the bitmap - If crop rectangle is fully within the bitmap, then return true and crop the bitmap Bitmap::GetDownsampledBitmap() tested to check when empty or not. Change-Id: Id2a6f739fdb1961748ce218862e628dfa8512122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121546 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-05Colibre: tdf#133038 remove remaining Catalan locale iconsRizal Muttaqin
Change-Id: I12bcc32ff5500bf565bd076c2db803ff442519fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121660 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-09-04Fix assert in sc/undoblk3Julien Nabet
since: commit 0abf2ac27859f1e91a3d183b81948b1fe8f5aca3 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Sep 16 11:25:25 2020 +0100 AppendContentsIfInRefDoc never passed a null ScDocument* Change-Id: Ia21f8fecdf8a6aea7ea9c6ea4d579c5e53882bbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102982 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Change-Id: Id699c7be3a81b251541f9a46fd3e1149c47f5df9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121642 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-04speed up scanning the LOK queueNoel Grandin
we frequently scan the queue to caolesce events. Most of the time we are scanning based on the event type. So split the queue data into a compact queue that only contains the type, and another queue for the rest of the data. That makes the scanning __much__ more cache-friendly. Change-Id: I92d0b95611cd139cac8532f9297eaabda71d5fe9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119996 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit acf9cf33d53e4bf598ddbdab102bfbd6bb14f8a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121558 Tested-by: Jenkins
2021-09-04inline ScTokenArray into ScFormulaCellGroupNoel Grandin
Change-Id: I3a12566141b3243142c5e30381ac5eb3ba9c493a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04no need to allocate RangeListType with unique_ptrNoel Grandin
Change-Id: I18681749501bb6750912c79b9ff04f5ffc4f0364 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04flatten ScFormulaCellGroupNoel Grandin
Change-Id: Ie33a6de78bd120f143da35ffc26af94178c734c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04duplicate modules/scalc/ui/ttestdialog.ui test in vcl/jsdialog/enabled.cxxJulien Nabet
Change-Id: Ic8e7ebb59cace56fdd8202b7d1c7eec7f62368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121639 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-04cid#1490901 silence Out-of-bounds readCaolán McNamara
Change-Id: I4757413c80f6dc71d40c5c5525c484a54b71f676 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-04Sukapura:^ Superscript, Subscript, Clear Direct Formatting, Font ColorRizal Muttaqin
Change-Id: Id2fb746dd33eb7de24539c7931221c331e47c087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121628 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-09-04dynamic_cast -> static_cast (tdf#130795)Noel Grandin
the dynamic_cast is hot here, and none of these dynamic_casts are necessary, we already assert that they must succeed, so just use static_cast Change-Id: I88ade90431c4da4792c778b5cdab22332ed1c428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04tdf#144289 invert / disable default OpenGL supportJan-Marek Glogowski
... and as a result drop setting a default in SalSvpInstance. This is also more consistent: now you must explicitly implement CreateOpenGLContext() and set "m_bSupportsOpenGL = true". Change-Id: I591580bf134907213b8308e0843c278d2f470ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121632 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-09-04no need to allocate ScMyLabelRange with unique_ptrNoel Grandin
Change-Id: I67b7b865d3c48e31e5efff5151c516ca7c51fd27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04store ScTokenArray by value in SharedFormulaBufferNoel Grandin
Change-Id: Ibff3c2fea3cadc234266953ab15ae5f25c4ac1e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121626 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04no need to allocate ScMyNamedExpression with unique_ptrNoel Grandin
Change-Id: I853aee13d3afc25e7e1ec1aa0d1a41dba7de0fb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121623 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04no need to allocate ScMyImportValidations with unique_ptrNoel Grandin
Change-Id: I1f720b05834f24e395456d4e82cdf772242be7f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121622 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04no need to allocate ScMyLabelRanges with unique_ptrNoel Grandin
Change-Id: I87564621a24737df74ad7475910250fde8dbe4fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121621 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04no need to allocate ScMyNamedExpressions with unique_ptrNoel Grandin
Change-Id: Ib82404230a0da4865c8c83087bca255811a89ed7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04tdf#144193 fix import crashNoel Grandin
regression from commit 426930d0c4bd6f782a04a92e8a36e92cd65e186f speedup dynamic_cast to SwTextFrame Change-Id: If602b7166287edfe9a41ac662f1a0b03f283ca83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121603 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I53383a71b4a362409773f8f1123982e8d2c5a324 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-04Colibre: tdf#142295 clear up unsaved state iconsRizal Muttaqin
Change-Id: I972f73dc35eda328663cdbfe1861110b4f69f8f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121630 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-09-04ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Id576a38ed93b3ac0c3d1e886b65c7c13ced129aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121629 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-04Sukapura: update cell alignment iconsRizal Muttaqin
Change-Id: I25a05a2d11e22ac1df1dcce496277ac0c872931a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121625 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-09-04Sukapura: update checked mark iconsRizal Muttaqin
Change-Id: I6e1f148d6fd1b6a993f6badaa6f1d27e93dac174 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121619 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-09-04use std::vector for fetching DX array dataNoel Grandin
because I'm trying to track down a related heap corruption, and that is much easier if the access to the array is checked by the std::vector debug runtime Change-Id: Ia665f5cebb7f14d88942e88b4b400ad3c28ef5d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04fix comment left behindNoel Grandin
in commit e25ba7dc57229d1cb9794abd1ca23c0d87ebecb3 use a dummy clipboard when running unit tests Change-Id: If5f57d1777dddbd70771299c8e161b33da10711d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121600 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04vcl: Add unit test for SetRefPoint(), IsRefPoint() and GetRefPoint()Chris Sherlock
Change-Id: I4fbc85015326b03fba15daf73176826669a16210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121017 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-04Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to bd31d03c6aa4b3e8422b03b9947f96b36fc30c61 - Fix in Basic macro example Change-Id: Ia73865f59fc5b605853b5c1ff6232349fd186771 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121456 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-03tdf#142458 Set correct ScrolledWindow BorderWidth in the ctorCaolán McNamara
and keep it updated when the relevant properties that affect it change. This avoids the problem that the borderwidth can change during "Paint" (which is something we strongly want to avoid) since... since: commit f39f21d92ec83c3a5062f29dd26214fc83012c06 Date: Thu Nov 19 11:51:13 2020 +0100 tdf#138010 (IV) VclScrolledWindow: Use actual border width hopefully after this we can then double-check to see if we can remove the potential change of BorderWidth during paint. Change-Id: I2ec317d86687fdb75e6323905f6d1c3b8fc655e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03pull duplicate field out of GlyphItemNoel Grandin
we already store it in SalLayoutGlyphsImpl Change-Id: I772c08966572e42789bcede1a148b2b7710f29d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03log PATH length and content when complaining about itCaolán McNamara
Change-Id: I54495044f2bd487eb9315c7a974b9859b26235a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121588 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I6bafceac5ebd1852aaf296abe89b49b74ad884d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03cgm bounding box was originally Point and SizeCaolán McNamara
so keep it like that Change-Id: I0392f283b79174c831d29b1895817cf6ee35ba3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121597 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I95e6cb59a1f379dccd844f05648ba3652f3cb82c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I1bd251165fb428f560a6844951e28109febeee7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I6180ebe39cb5925882071892611dd6237b426fcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121609 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03pack GlyphItem structNoel Grandin
56 bytes -> 48 bytes Change-Id: I30d9763162b701e3d07a153deae3f5e03c290393 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121583 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03rename NeedFallback to AddFallbackRunNoel Grandin
Change-Id: I5d91e7b28075026198444036fbfc220296deac77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03rename NeedFallback to HasFallbackRunNoel Grandin
Change-Id: Iec45f84b330fc4e4a62b352cb007747a19a27bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121578 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03sw: fix crash in SwView::Execute()Miklos Vajna
Crashreport: program/../program/libswlo.so SwView::Execute(SfxRequest&) sw/source/uibase/uiview/view2.cxx:1312 program/libmergedlo.so SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) sfx2/source/control/dispatch.cxx:263 /opt/collaboraoffice6.4/program/libmergedlo.so SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) sfx2/source/control/dispatch.cxx:760 (discriminator 3) /opt/collaboraoffice6.4/program/libmergedlo.so SfxDispatcher::Execute(unsigned short, SfxCallMode, SfxItemSet const*, SfxItemSet const*, unsigned short) sfx2/source/control/dispatch.cxx:819 Change-Id: I2e7b27f458971dbd33971589f71337c59981ee83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121611 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-03tdf#62032 ODT export: handle style:list-level="..." for para stylesMiklos Vajna
ODT import was already working. The spec also says to only take this into account when applying the style, so it seems only the UI remains for the bug to be closed, the rest is done. Change-Id: I27da4dc171b4ced75f143bbcecb3f8c748a26b02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121607 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-09-03remove debugging leftoverNoel Grandin
from commit 8a54339fc83fe9abaaace6f9f374697e6923d684 loplugin:referencecasting look through more clang Types Change-Id: I6a8a4bbce04d6f53d8e02961c0917bb57fb69a9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 9b8c44b49d1f732e51673804c28a8b606596630b - Create guide about Calc macros to format cell borders This patch is a follow-up to a previous revert: https://gerrit.libreoffice.org/c/help/+/121554 This patch uses the correct path for the new file "calc_borders.xhp". Change-Id: I4eb72db1ef8f5d964905be46dcb645dbd4e28e67 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121556 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-09-03tdf#143215 sw: test tracked deletion of empty table rowsLászló Németh
Only the test document was added to the previous fix. Follow-up of commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d "tdf#143215 DOCX import: fix tracked empty row insertion/deletion". Change-Id: If39da56e16e56a9322a35259f5984726abe0da40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121549 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-09-03backendtest: Rectangle on wide surfaces Drawing testhomeboy445
This tests draws a rectangle using all possible drawing methods for drawing a rectangle on a wide surface(1028x1028 and 4096x4096) and check it the usual way. Change-Id: I6fcf9c9b4b150cbe959b8151f327bcdce1b1139a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119464 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I6546ef38c6e84193c00ea5fcac621fdec93e0ab7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121593 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I626eb1847484f7bc6af7eed45b891307718c5263 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121596 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I47934f5a6b34ef0f495098f78c53c088bf5152e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121595 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>