summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-18cid#1448546 Logically dead codeCaolán McNamara
Change-Id: I7013e5ef67ae58c42886a4ba6ea0c9a47074ac8e Reviewed-on: https://gerrit.libreoffice.org/75834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448479 Logically dead codeCaolán McNamara
Change-Id: I1190bd238fad3e5343e83f9c6261d71a44bc6717 Reviewed-on: https://gerrit.libreoffice.org/75831 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448499 less obscure comparison against endCaolán McNamara
Change-Id: I6eda7d9ec8d7781cbea191eb2fd2429722a4823a Reviewed-on: https://gerrit.libreoffice.org/75830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448482 silence Using invalid iteratorCaolán McNamara
Change-Id: I78c5fa16e035cebe71869bfea57ef2741b5b7f58 Reviewed-on: https://gerrit.libreoffice.org/75829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448431 Using invalid iteratorCaolán McNamara
if we are checking itnew against end in the first block, presumably the second block use of itnew needs the same guard Change-Id: Ia8cc45229024e477c00b2356665d5656d36f723b Reviewed-on: https://gerrit.libreoffice.org/75828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448440 silence Dereference null return valueCaolán McNamara
Change-Id: I1dce0d6a40086539cbcadeaf9a669f4640dbc730 Reviewed-on: https://gerrit.libreoffice.org/75817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448534 Use after freeCaolán McNamara
Change-Id: Ibef20405d1ecf00b71ca12e43902ccd65c873ed2 Reviewed-on: https://gerrit.libreoffice.org/75815 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448313 Uninitialized pointer fieldCaolán McNamara
Change-Id: I0e449be3c0ae4cfef88766e189e7255ff45e83f9 Reviewed-on: https://gerrit.libreoffice.org/75800 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#42949 Fix IWYU warnings in include/filterGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9eef923aa2910c376212ef50961a1ed89bf8b105 Reviewed-on: https://gerrit.libreoffice.org/75179 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-18cid#1448529 Use after freeCaolán McNamara
Change-Id: I5bc3a85b7319c52e3b5d1a7e7dffcbe23cdf653c Reviewed-on: https://gerrit.libreoffice.org/75814 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448339 Use after freeCaolán McNamara
Change-Id: I3259e0fe9ebaba819d529af2fdb003ce9a297961 Reviewed-on: https://gerrit.libreoffice.org/75813 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18Resolves: tdf#126448 set activates_default and correct focus settingsCaolán McNamara
Change-Id: Ia857c37b7f5947e7339ba5f80aad54112ff2c3f7 Reviewed-on: https://gerrit.libreoffice.org/75818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#126424 Don't dispose decks before saving their stateSamuel Mehrbrodt
Only dispose them in SidebarController::disposing after the state has been saved. Change-Id: I9e42383e20e2bc0100557b8cb8fbd26b3505f236 Reviewed-on: https://gerrit.libreoffice.org/75719 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-18tdf#101443 Horizontal inset margin of Calc input bar increasedThorsten Wagner
Change-Id: Ic609da4b8b5fae0f556761c4493e490c82a6386d Reviewed-on: https://gerrit.libreoffice.org/74214 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-07-18Revert "tdf#123627 DOCX import: fix relative hyperlinks to documents"László Németh
This reverts commit 217a80fd205c7f61794c863898cb7cfd1a17e78f. Change-Id: Ic6c9c68dff800f0969187bdd46b51f8e71c0c618 Reviewed-on: https://gerrit.libreoffice.org/75825 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-07-18Fix typoAndrea Gelmini
Change-Id: I9843620c378d7c6dbb5696255eb123e0bca9b4bf Reviewed-on: https://gerrit.libreoffice.org/75821 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-18sw: missing SolarMutexGuard in SwXFrame::attach()Michael Stahl
Causes assert in a test i'm adding... Change-Id: I5be24aa9683ec0d31494c0c97270d1d58692f764 Reviewed-on: https://gerrit.libreoffice.org/75796 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-18Fix typoAndrea Gelmini
Change-Id: Iac1e4f3e7ac7f3ea86e31179f2f45e3941abd3a1 Reviewed-on: https://gerrit.libreoffice.org/75822 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-18Fix typoAndrea Gelmini
Change-Id: I28c6478650154b91208f72683485fbf8fd67264b Reviewed-on: https://gerrit.libreoffice.org/75823 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-18Resolves: tdf#126147 relax sanity check and allow truncated tiffsCaolán McNamara
now the start of the row of data must still exist, but the full length of the row doesn't have to exist Change-Id: I5ed8ffef2cab19f040ba789a5d82560ca6847f26 Reviewed-on: https://gerrit.libreoffice.org/75793 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18tdf#126051 sync MINBODY copies to same valueCaolán McNamara
Change-Id: Id41da7b07dcb25e820e5fd20aed595b1170fa204 Reviewed-on: https://gerrit.libreoffice.org/75807 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448253 Use after freeCaolán McNamara
Change-Id: I83f3ef82faafd31f5a1afca9c5ab3f4040c3552b Reviewed-on: https://gerrit.libreoffice.org/75812 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448252 Negative array index readCaolán McNamara
Change-Id: Ia81e2a58e372455531479c98d11a88cd950441df Reviewed-on: https://gerrit.libreoffice.org/75808 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448236 Use after freeCaolán McNamara
Change-Id: Id7a0ad49a8e73a6b12a0f40c4b8f62b1e1d64356 Reviewed-on: https://gerrit.libreoffice.org/75810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448383 Resource leak in objectCaolán McNamara
Change-Id: I07af4d48db887c184be824a2d1939b800f837d4e Reviewed-on: https://gerrit.libreoffice.org/75801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448417 silence Unchecked return value from libraryCaolán McNamara
Change-Id: I61b3a4408942b98e1ef0562b236b96335a8c5867 Reviewed-on: https://gerrit.libreoffice.org/75805 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448511 silence Out-of-bounds accessCaolán McNamara
Change-Id: I11920faa3327bfc74e9bfe8a94864a9caaa9b147 Reviewed-on: https://gerrit.libreoffice.org/75803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1448365 silence Arguments in wrong orderCaolán McNamara
Change-Id: I20a64d73add3636e02e02ea970577c0505e2b5fd Reviewed-on: https://gerrit.libreoffice.org/75804 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1451632 Dereference after null checkCaolán McNamara
Change-Id: I5ee95a9341896b8462235ece933fa70773247c92 Reviewed-on: https://gerrit.libreoffice.org/75802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18cid#1451643 Uninitialized pointer fieldCaolán McNamara
Change-Id: I5bb3087e8ccd0de2e04df9596ddf860de29689fb Reviewed-on: https://gerrit.libreoffice.org/75799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18xmloff: create XMLImportContentImportOasis instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I3b52830ece6fae82af1bc57eb93e3a9ad1eb2aff Reviewed-on: https://gerrit.libreoffice.org/75809 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-18speed up sw_filters_test2Noel Grandin
in dbgutil mode, this takes the test from 2m31 to 1m45 for me. find(), even on a sorted vector, is rather slow in debug mode, and we can avoid one find here Change-Id: I8f82aaf5b8d82a32c78bf7c9df5712c90c68f7fc Reviewed-on: https://gerrit.libreoffice.org/75764 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-18Unify wording: "Open hyperlink" instead of "Follow hyperlink"Samuel Mehrbrodt
Change-Id: If4ffb81537b0f8101af14c45c13bb8d0ea8454d2 Reviewed-on: https://gerrit.libreoffice.org/75781 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-18Fix the awkward grammar of a translatable stringMatthias Seidel
(cherry picked from commit e8d5f4b7d65f1e0d1d161a36f3c9b9c5866d009a) Change-Id: I4d3a55b2d161ad23ccf6c68c0af17f1f99ebea43
2019-07-18Resort pProperties when really needed (cppuhelper)Julien Nabet
so not when pProperties[i-1].Name == pProperties[i].Name and call getConstArray() only if there have been a sort Found when testing tdf#125941 when editing table: $8 = uno::Sequence of length 29 = { {Name = "AutoIncrementCreation", Handle = 49, Type = uno::Type "string", Attributes = 0}, {Name = "CatalogName", Handle = 30, Type = uno::Type "string", Attributes = 0}, {Name = "CatalogName", Handle = 30, Type = uno::Type "string", Attributes = 0}, {Name = "DefaultValue", Handle = 20, Type = uno::Type "string", Attributes = 0}, {Name = "DefaultValue", Handle = 20, Type = uno::Type "string", Attributes = 0}, {Name = "Description", Handle = 19, Type = uno::Type "string", Attributes = 0}, {Name = "Description", Handle = 19, Type = uno::Type "string", Attributes = 0}, ... Change-Id: I645f7d24d552222cf520e346f4505f5a14979a30 Reviewed-on: https://gerrit.libreoffice.org/74124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-18tdf#126453: hide ScInputHandler's tooltips when loosing focusMike Kaganski
Change-Id: I188db03ad9027bcb17a72f7c59d85e611b57bfd0 Reviewed-on: https://gerrit.libreoffice.org/75824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-07-18include supported SIMD intrinsics headers automaticallyTomaž Vajngerl
If we include simdsupport.hxx, this now includes the supported intrinsics headers automatically, so this removes the need to do it ourselves. Change-Id: Icc406316a7e27b7b5fd5905f51664f4fe47e5468 Reviewed-on: https://gerrit.libreoffice.org/75783 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-17No reason to have OSL_FAIL() with a fixed string inside #ifdef DBG_UTILTor Lillqvist
Change-Id: I99cc88031e601fd52c2858813d82f58f84fe8ca4 Reviewed-on: https://gerrit.libreoffice.org/75797 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-07-17vcl: make "Reduce Transparency" parameter tweakableVasily Melenchuk
"Reduce transparency" feature previously was using hardcoded value of 0.25. If current object area to whole printing area ratio exceeds this value, object is being written without any extra transparency layers in order to reduce metafile size. Right now this value can be adjusted in "Expert Configuration". Parameter is called "ReduceTransparencyMinArea". Change-Id: I43d5801a1dff6241de214f7b24425626dc06b4fb Reviewed-on: https://gerrit.libreoffice.org/75471 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-07-17tdf#123020 dbahsql: Support string delimiterTamas Bunth
Support multi-word table names while migrating HSQLDB data. Change-Id: I5129f995ea90a3fdbcbcb844774cf074f3ffddb2 Reviewed-on: https://gerrit.libreoffice.org/75734 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-17Resolves: tdf#126304 resizing the extension manager breaks redrawCaolán McNamara
Change-Id: I1211c90a72048f868ec7ba7a7b6bed452ae8ac4b Reviewed-on: https://gerrit.libreoffice.org/75791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17fix "tdf#119388 calc, slow removing column, improve ScChildrenShapes"Noel Grandin
forgot to add the code to actually update the map, which would be bad for accessibility Change-Id: I5d93dd84649ce27a37c9035622f94fff3237b778 Reviewed-on: https://gerrit.libreoffice.org/75773 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-17Revert "simplify sharedplugin PostTraverse calls"Noel Grandin
This reverts commit ff55ad1aceb10b900254c8ad3629775b7789d60a, Lubos prefers it the way it was. Change-Id: I68edc21c438b6aa2fc819245dd9a3d590af3a278 Reviewed-on: https://gerrit.libreoffice.org/75790 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2019-07-17scrollbar is outside the widget now, not insideCaolán McNamara
Change-Id: Ia92658c7a534928209906b8adfb5f9451b513ff0 Reviewed-on: https://gerrit.libreoffice.org/75786 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17Resolves: tdf#126439 dialog should be modalCaolán McNamara
Change-Id: Ib922be4375533aff69264ee5dc99d521306f93c5 Reviewed-on: https://gerrit.libreoffice.org/75787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17make some plugins used the shared frameworkNoel Grandin
Change-Id: Ie283a4774564f25e0fde8ca35212f92be786d671 Reviewed-on: https://gerrit.libreoffice.org/75785 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-17Fix typoAndrea Gelmini
Change-Id: I3f5b8303ba25334f04707938bda1d274ecd03a81 Reviewed-on: https://gerrit.libreoffice.org/75772 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-17Fix typoAndrea Gelmini
Change-Id: I5c5693629655bd5d6c2ce13489e96893a92fce9e Reviewed-on: https://gerrit.libreoffice.org/75767 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-17Fix typoAndrea Gelmini
Change-Id: Ib5c52f937cbbe3263d39e4778ae29097be7acadc Reviewed-on: https://gerrit.libreoffice.org/75769 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-17Fix typoAndrea Gelmini
Change-Id: I0974986301548cc5cd95dd40403bef0a5a7dd90d Reviewed-on: https://gerrit.libreoffice.org/75770 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>