summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-09remove MID_GRAPHIC_URL and related mappings, implementationTomaž Vajngerl
Change-Id: I752a2f036791720d12fb04b95f53d4127d605c7e Reviewed-on: https://gerrit.libreoffice.org/50979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09sw XHTML export: handle alt text for OLE objectsMiklos Vajna
The XHTML export is now on par with the import wrt OLE objects. Change-Id: I736c1f03b0e3d8b84b8ebe08eb1b1cfa247cefbd Reviewed-on: https://gerrit.libreoffice.org/50966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-09sw: fix some IWYU warningsMiklos Vajna
Change-Id: Idb8ad6cda75b7112280ae71b4340d0187a602794 Reviewed-on: https://gerrit.libreoffice.org/50974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-09Remove warning "No DrawLayer available"Samuel Mehrbrodt
This warning appears very often in unit tests. We have similiar checks all over the place and don't emit a warning either. Change-Id: Ic1667fa51ce39e72c9a940023cc12a72458bd490 Reviewed-on: https://gerrit.libreoffice.org/50968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-09loplugin:redundantfcast look for unnecessary temporariesNoel Grandin
when calling methods that take a const& Change-Id: Idf45dfd9fea0de6fae0b1f89550f2f7fc302aa15 Reviewed-on: https://gerrit.libreoffice.org/50970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09loplugin:constantparam in vclNoel Grandin
Change-Id: I1618280494ff10d884a3285501303c6a74ef3542 Reviewed-on: https://gerrit.libreoffice.org/50951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09drop getColor() method of ColorNoel Grandin
no longer necessary Change-Id: I9e0fcea1134e8c5e27f9effbb5eb79fe5446e33d Reviewed-on: https://gerrit.libreoffice.org/50925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-09tdf#116301: write correct content type for diagramDrawingAron Budea
According to MS-ODRAWXML the correct one is: application/vnd.ms-office.drawingml.diagramDrawing+xml Change-Id: If988ad234742da42634a52bbe176dbb5b763af46 Reviewed-on: https://gerrit.libreoffice.org/50980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-03-09lokdialog: run async for weld dialogsPranav Kant
Change-Id: Ieb06beada435bc47a39295acb5ea2dcef10ca454 Reviewed-on: https://gerrit.libreoffice.org/50874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-03-09svx: convert "ThumbnailGraphicURL" prop. to "ThumbnailGraphic"Tomaž Vajngerl
Change-Id: Id77768e6ad58c8ed7bd35478a8f0cf78ce4b1feb Reviewed-on: https://gerrit.libreoffice.org/50934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-09svx: removing GraphicURL and OWN_ATTR_GRAFURL, fix writerfilterTomaž Vajngerl
Change-Id: I5b84788a324cc68e3c4561e9a7376fcb1cfeeb67 Reviewed-on: https://gerrit.libreoffice.org/50933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-08Fix external/gpgmepp Linux RPATHStephan Bergmann
In other external projects using libtool, we fix that by patching configure, resetting hardcode_libdir_flag_spec[_CXX] at the end of the linux*) case block that sets the Linux-specific value. But here we run autoreconf in ExternalProject_libassuan, so that patch in configure would be overwritten. The relevant code in configure comes from autoconf boilerplate, so we cannot just do the same patch in configure.ac. But we can reset hardcode_libdir_flag_spec sufficiently late in configure.ac so that things still work as intended. Disable tests that would build executabes linking against libgpgme.so, which in turn links against the libassuan and libgpg-error libs, which would no longer be found by the linker because of the dropped -rpath flags. (Alternatives might be to pass in LD_LIBRARY_PATH or to link with --allow-shlib-undefined.) Change-Id: I7e37abf802d213347bd80383b7980d85cf0762d4 Reviewed-on: https://gerrit.libreoffice.org/50960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08color picker behaviour changedCaolán McNamara
since... commit db42098d99bd8648fcd7b6f669e3e5ad4142670a Date: Fri Feb 9 10:47:48 2018 +0200 use VirtualDevice in ColorFieldControl as part of moving use of BitmapWriteAccess inside of vcl/ changing the radiobutton selected used to change the contents of the color picker widget, after that point it got locked to the original contents. Change-Id: I94c730f1868efc388cba7720364bc04a666d4fbd Reviewed-on: https://gerrit.libreoffice.org/50969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-08Improve gpgmepp -> libassuan/libgpg-error lib dependenciesStephan Bergmann
...so that other executables than svidl would benefit, too Change-Id: I208ebbc04189c2f25eace19ef0875349cf63d3f0 Reviewed-on: https://gerrit.libreoffice.org/50963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08svtools: allow writing characters with HtmlWriterMiklos Vajna
The sw HTML image export already uses HtmlWriter, so need to extend this to support XHTML alternate text, writing the character data directly is not an option. Change-Id: Iac3f2b9a3828175a5f1d0fb14ab505f8de389e52 Reviewed-on: https://gerrit.libreoffice.org/50965 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-08sw XHTML export: handle media type for OLE objectsMiklos Vajna
Both native data and replacement graphic. Change-Id: I2f89493e56e9d22a54aa3e4175d8b750c33d98f0 Reviewed-on: https://gerrit.libreoffice.org/50964 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-08loplugin:constantparam in svtools..unotoolsNoel Grandin
Change-Id: I6e72fbe44dcb65ee5162448e9a72e6437d56b044 Reviewed-on: https://gerrit.libreoffice.org/50948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08Fix external/libassuan Linux RPATHStephan Bergmann
In other external projects using libtool, we fix that by patching configure, resetting hardcode_libdir_flag_spec[_CXX] at the end of the linux*) case block that sets the Linux-specific value. But here we run autoreconf in ExternalProject_libassuan, so that patch in configure would be overwritten. The relevant code in configure comes from autoconf boilerplate, so we cannot just do the same patch in configure.ac. But we can reset hardcode_libdir_flag_spec sufficiently late in configure.ac so that things still work as intended. Change-Id: Ic6c6123bcfe8bc2dac87812f919842519374abaa Reviewed-on: https://gerrit.libreoffice.org/50959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08Remove apparently unused external/libgpg-error/disable-rpath-option.patchStephan Bergmann
...which only patched configure.ac not configure, and the latter does not appear to be regenerated from the former in ExternalProject_libgpg-error Change-Id: Id0132ed8fd8ea3a5012e4a2bc309bd5f3983ad11 Reviewed-on: https://gerrit.libreoffice.org/50954 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08sw XHTML export: handle replacement graphic of OLE objectsMiklos Vajna
Replacement image of OLE object in XHTML is <object data="...">, not <img src="...">. Change-Id: I244000099037869590a71bf49dd94fbf34a71e50 Reviewed-on: https://gerrit.libreoffice.org/50955 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-08Make ubsan-suppressions a bit more preciseStephan Bergmann
Change-Id: I9a326da5e7c69fc4c7f21e472c1f1e2c8a260c1b
2018-03-08libgpg-error doesn't need RPATH at allStephan Bergmann
...as it doesn't link against any of our libs Change-Id: Iaf0df9d5dc5eefb976d2041f24b2921cb3e3b1ba Reviewed-on: https://gerrit.libreoffice.org/50953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08tdf#116283 oox customXml: Don't write the Relationship to DOCX files twice.Jan Holesovsky
Change-Id: Id3da40138e86c142707e377aa897df372aacb704 Reviewed-on: https://gerrit.libreoffice.org/50947 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-03-08tdf#115420 WIN clean up WinSalFrames DC handlingJan-Marek Glogowski
We still don't return a SalGraphics object from AcquireGraphics without a valid DC. But internally we keep the WinSalGraphics objects around, so we now have to verify the DC before using it. In the end this also fixes the leak of the threaded SalGraphics of the frame. Change-Id: I267c96c04b7d00cb66a6c84c63d1373ebe0f529f Reviewed-on: https://gerrit.libreoffice.org/50908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-03-08tdf#116264 Show added_buttons by defaultCaolán McNamara
Change-Id: Ia2d299fdc63d3f75ea0cdb9e9b6ca8340a63cd06 Reviewed-on: https://gerrit.libreoffice.org/50935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-08loplugin:unnecessaryoverride (clang-cl)Stephan Bergmann
Change-Id: I96c2e28f14e50eed5b729170cd30fd54f00d89f3 Reviewed-on: https://gerrit.libreoffice.org/50944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08Load arguments in array in the order of the arguments.Winfried Donkers
Change-Id: I1a47018d626848e6d07c7e637ee6e04ff7750ac8 Reviewed-on: https://gerrit.libreoffice.org/50904 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-08loplugin:cstylecast (clang-cl)Stephan Bergmann
Change-Id: Ia9184268ed734bb0cee94c5eb870d3425bc47ac4 Reviewed-on: https://gerrit.libreoffice.org/50942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08loplugin:constantparam ignore some SFX macro generated codeNoel Grandin
Change-Id: Ic5d9a17aeec51d59e26c49bbdf5719e6d8f6486f
2018-03-08loplugin:constantparam in linguistic..sfx2Noel Grandin
Change-Id: I0e8c506df0beb0b05d9c32723876b11b6577280a Reviewed-on: https://gerrit.libreoffice.org/50938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08sw XHTML export: handle native data of OLE objectsMiklos Vajna
Write the native data and refer it from the XHTML stream. Change-Id: I8952ed07108ddc92b1d136bd9af6f21d3ed604f0 Reviewed-on: https://gerrit.libreoffice.org/50941 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-08Change IsIgnoreDiacritics_CTL default to false, tdf#116242 follow-upEike Rathke
And adapt description to reality. Change-Id: Iab35b74f4cbe7dc91fd0570adcc634faba96b5de
2018-03-08Elementary-icons: update outlinemode iconandreas kainz
Change-Id: I6ddedaec1683ce9fd0da07f427612c6e331d0ca3 Reviewed-on: https://gerrit.libreoffice.org/50949 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2018-03-08editeng: remove "GraphicURL" - it was replaced by "GraphicBitmap"Tomaž Vajngerl
Change-Id: I79f9ffd68da2d90da96707c9d6183e6c8a6e74a4 Reviewed-on: https://gerrit.libreoffice.org/50932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-08change RTFDocumentImpl to use Graphic instead of GraphicURLTomaž Vajngerl
Change-Id: I4d2f7dd540651a54e4da3dedf315a61a4f8a75cc Reviewed-on: https://gerrit.libreoffice.org/50924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-08sw: get rid of FN_UNO_GRAPHIC_U_R_L and "GraphicURL" propertyTomaž Vajngerl
Change-Id: I6148016658e5bb46fd4f8765a233a434174791fd Reviewed-on: https://gerrit.libreoffice.org/50922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-08oox: preserve the ContentType of custom filesAshod Nakashian
Generic logic to preserve custom files with their correct ContentType. Standard default file extensions with respective ContentType preserved in [Content_Types].xml. Change-Id: I651ed691e9a4745cd2cb4b3c4d4c5fd7287b66c2 Reviewed-on: https://gerrit.libreoffice.org/50856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-08oox: unit-tests for custom package preservationAshod Nakashian
Change-Id: I69d0d7d6bdc8804d0e56be19cd86a699200fc85f Reviewed-on: https://gerrit.libreoffice.org/50855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-03-08VCL canvas: fix another clipping mistake (related: tdf#115142)Thorsten Behrens
Follow-up to 5d710cf7dda27e78f237211fd92418be4dd1c551 - setupOutDevState() tends to set a clip, better not overwrite that. Change-Id: I52aa7db3ef12e9c2902016460e1bf4914328dc7c Reviewed-on: https://gerrit.libreoffice.org/50920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-08loplugin:constantparam in desktop..i18npoolNoel Grandin
Change-Id: Ie2e1004c1ccc03777a8da9cb1144e89eb28ff313 Reviewed-on: https://gerrit.libreoffice.org/50928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:constantparam in canvas..comphelperNoel Grandin
Change-Id: Ia666cb46c409852a13789389c032f0ce4377c0d5 Reviewed-on: https://gerrit.libreoffice.org/50927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08WIN rename SalFrames SalGraphics pointersJan-Marek Glogowski
This renames mpGraphics => mpLocalGraphics and mpGraphics2 to mpThreadGraphics. Change-Id: I649b956abc9587f1be74872d439fefc5f5b21135 Reviewed-on: https://gerrit.libreoffice.org/50907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-03-08Probably better to comment on these dependenciesStephan Bergmann
...added with f23651ff10da2d4bbbc47d0152b5cc321c29f0d1 "Missing dependencies" Change-Id: I4cd02fc8b242b3a3737305546bf3155425614d65
2018-03-08sw::Ring: simplify '*&x' to just 'x'Miklos Vajna
Change-Id: I75d25c54c0c3e2c913ea0f2f36bdd4fc262fd088 Reviewed-on: https://gerrit.libreoffice.org/50918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-08loplugin:unusedmethodsNoel Grandin
Change-Id: Id6b4edd265cb6bef31c72e2a0a440211d51c7c33 Reviewed-on: https://gerrit.libreoffice.org/50900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08loplugin:unusedfieldsNoel Grandin
Change-Id: Id332557cbe7fb42d3d794612f26aa3ac161548d9 Reviewed-on: https://gerrit.libreoffice.org/50902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08fix mismergeCaolán McNamara
thanks to noel Change-Id: Id8c4fb92899e80bdb923b77ea9dff74961e84ea3 Reviewed-on: https://gerrit.libreoffice.org/50919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08tdf#116157: Always apply Unicode Bidi in editengKhaled Hosny
Similar to commit 270d6db63d933b7350dc8543b9b9ebc2133a116e which fixed the same issue in Writer. Surely having two text engines duplicating the same bugs sounded like a brilliant idea to someone. Change-Id: If85315fb00a2c0be78d502df0bfb9b50d9191368 Reviewed-on: https://gerrit.libreoffice.org/50921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-03-08Use for-range loops in dbaccess (part 3)Julien Nabet
Change-Id: I4cec44ea6366b6a38992e583d6290223d5c469f6 Reviewed-on: https://gerrit.libreoffice.org/50849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-07Missing dependenciesStephan Bergmann
Change-Id: Iabdc81c9df2cc50ec4f4713af42d2fb9c3cc1f43 Reviewed-on: https://gerrit.libreoffice.org/50915 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-02 02:58:27 +0000