summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-03-17tdf#126689 Breeze, elementary, KJ, Sifr, Sukapura: Jump + & Jump - This LevelRizal Muttaqin
Change-Id: I5f361822048720a68ce2b6fc7246cb7cf7c87fa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148983 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-17tdf#152690: Refactor fixBaole Fang
Change-Id: I170eba4968743afbab3cc6aa943706612b3e1a57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149035 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-16Update view options string based on themeParis Oplopoios
Update the view options string based on the theme when tiled rendering, and make sure only the currently active view is updated Change-Id: Ib24111848f2926fe7ae858ca2e18e946d980e83f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148943 Tested-by: Paris Oplopoios <parisoplop@gmail.com> Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-03-16Add uno command that changes the themeParis Oplopoios
Add an uno command that changes the theme to the one specified in the first parameter Change-Id: Ia0fef2ca698415e07f1943cf80ab667fb5c37238 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148942 Tested-by: Jenkins Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
2023-03-16tdf#152690: Fix "!" behavior when it is not the first in a groupBaole Fang
Fix "!" behavior when it is not the first in a group. Add testcases for "!" and Like. Change-Id: Ia76fa26722b6546d08dd8842d83f55bb0c0ea5ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148720 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-16Fix typoAndrea Gelmini
Change-Id: Ic43a5bb4d243b2c4081fcd56130e20ed1c3b43a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149009 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-16cid#1522030 Uninitialized scalar fieldCaolán McNamara
Change-Id: Iaf8ad5edd483da25cad45d91afc27f9cc3aa9040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-16Resolves: tdf#152704 old image remains underneath when new image drawnCaolán McNamara
in this dialog preview widget Change-Id: Id33995d9a9557d235178be0d12cc6b44e146ff4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148997 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-16sw: fix null dereferenceXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/SfxDispatcher::ExecuteList(unsigned%20short,SfxCallMode,std::initializer_list%3CSfxPoolItem%20const%20*%3E,std::initializer_list%3CSfxPoolItem%20const%20*%3E) Change-Id: I7f5471f003798f260d9d015782bd2a798baa22d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148999 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-16Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to a0ef2acc2d24501a7373ab7ba03ddc9473814b54 - one character is found without plus in regular expression reported by Kamil Landa Change-Id: I53f11b8ccd89340d2545e3c26edd8abee8cf5e9a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149005 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-16jsdialog: enabled insert section dialog (writer)Pranam Lashkari
Change-Id: I556973587c2c7f4baab4cf696afe980186e82f6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148930 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit cd428e3e564b9bca0badb5e947f78a6fe3ea39ec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149014 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2023-03-16move setGeometry3D inside chart2::DiagramNoel Grandin
Change-Id: I3825349e3889c45bbb5cbc467dad2f100ccd2298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-16osl::Mutex->std::mutex in CDOTransferableNoel Grandin
Change-Id: I44e9305ec4127f9567fb51ce7bf8c26f17727787 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148974 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-16osl::Mutex->std::mutex in CMtaOleClipboardNoel Grandin
Change-Id: If19fe618de0c316ffa6d74432b03c507b960a891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-16CppunitTest_starmath_export: inherit from UnoApiXmlTestXisco Fauli
Change-Id: Ib84525664ff8456b4eb8e100aaaea2783babaf30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148994 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-16Prepare compilerplugins for C++23 `if consteval`Stephan Bergmann
...for which clang::IfStmt::getCond returns null Change-Id: I8b86a033d52de87dedbdf6d867f2b3d3f57c1b5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148979 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-16CppunitTest_starmath_import: inherit from UnoApiTestXisco Fauli
Change-Id: I77e48dc05c2bd6a36c42e1860a209ed563e71ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148988 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-16CppunitTest_starmath_export: move code to methodXisco Fauli
Change-Id: I460ffc51d82ff8b727813228e93a6e0c95c8569a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148993 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-16tdf#102261: pptx export: implement defTabSz ParaTabStopDefaultDistanceSarper Akdemir
Adds export of ParaTabStopDefaultDistance property into defTabSz. Also adds a unit test that checks pptx roundtrip of the property. Change-Id: I5be9ea88b15e3e8cab25af79488983a71b96dae1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148539 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-16tdf#153704: Make sure the last script segment is also addedKhaled Hosny
Change-Id: Id6381d77cdf05c24a1b557206f530f4e004e8e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148986 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2023-03-16Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 4453c0b2edae4934f87594d5974783c4a1a5ea54 - convert paragraphs with role="heading" & childelements to → h<level> and also drop the language that was changed to implied previously/defaults to en-US unless specified. This change doesn't affect translations, only the content of the paragraph/headings is extracted. done with: perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")/;} s#<paragraph(((\s+($base)){3})|(\s+($base|xml-lang="en-US")){4})>(?<body>.*?)</paragraph>#<h$+{level} $+{id}>$+{body}</h$+{level}>#g' and manually undoing the one that uses <sup>in body that's not valid according to the dtd in the h tags. Change-Id: Ibd4aed3157ed168cd5005161575672a392e59202 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148797 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-16Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 77cb682cd1b004e7247560e60f603a4bb0565b8d - convert plain paragraphs with role="heading" → h<level> i.e. without child elements and also drop the language that was changed to implied in the dtd previously/defaults to en-US unless specified. This change doesn't affect translations, only the content of the paragraph/headings is extracted. done with: perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")/;} s#<paragraph(((\s+($base)){3})|(\s+($base|xml-lang="en-US")){4})>(?<body>[^<]+)</paragraph>#<h$+{level} $+{id}>$+{body}</h$+{level}>#g' (all permutations re order of attributes, and xml-lang="en-US" being optional / implied) Change-Id: I365a2bb983a3969af9390753fce7b7f3597c7b8b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148795 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-16Update git submodulesChristian Lohmaier
* Update helpcontent2 from branch 'master' to 00567a452bb1e270dd2438dcc865359edba56c19 - convert plain paragraphs with role="heading" → h<level> (localize="false") done with perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")|localize="false"/;} s#<paragraph(((\s+($base)){4})|(\s+($base|xml-lang="en-US")){5})>(?<body>[^<]+)</paragraph>#<h$+{level} $+{id} localize="false">$+{body}</h$+{level}>#g' Change-Id: I5d2b1b6326801adb8d000b3353d314d2fc9f322d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148796 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-16update line controls dropdown valueset if style changedCaolán McNamara
e.g. in page style dialog, footnote page, line menubutton, if theme changes from light<->dark while the line dropdown remains open. Use the application settings, and not the current rendercontext settings to get the up to date settings and not the settings at the time the virtual device rendered to was created. Change-Id: I674c94603f15c9035bbd07b4bd7247dcebc3124b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148982 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-16update line controls preview if style changedCaolán McNamara
e.g. in page style dialog, footnote page, line menubutton, if theme changes from light<->dark while the dialog remains open Change-Id: If8ca8b2cf9c4e4d620ce0ea1c92c50accbc8ebcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148981 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-16tdf#102261: pptx import: handle defTabSzSarper Akdemir
Introduce import of defTabSz using ParaTabStopDefaultDistance. Change-Id: Ied59c2bc5d9dfffa6254ef87849c3dbad4c48d07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148059 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-16allow more than DrawingArea to report style updatesCaolán McNamara
Change-Id: I791e4ad45daeeb77ca25e36ae6520168b2ece044 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148980 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-16Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d29743de6f11453152a00222fddf0e4dd12c2c05 - Remove xml-lang from tags, since marked IMPLIED everywhere Change-Id: I899df40cbad5ac86d9a25c448cf9e7d6032c4401 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148987 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-16tdf#154061 Make sure table column attributes size is correctParis Oplopoios
Resize maTableColumnAttributes to match the amount of columns, fixes crash upon undoing a column insertion on a table Change-Id: Iad4b8ac5c38d5d1065d6ef1267ce3f5d3b28afa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-16Related: tdf#154205 skip Invalidating content a11y relations when closing docCaolán McNamara
Change-Id: If6dbc02f1ec22be9f020290572199f89548c76e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-16Related: tdf#154205 avoid use of destroyed ViewShellCaolán McNamara
Change-Id: Ife553269e0cdeb331931a885a3dd4f87c1c3d9bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148940 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-16Remove empty commentStephan Bergmann
...which I had added as part of 0025fa723afb9f6a0d94b9b3185ea14da18f1bd5 "Enable loplugin:unnecessaryparen for integer and Boolean literals", and where I apparently wanted to include a link but forgot to do so (and no longer know what link that would have been) Change-Id: I245725fea80ee0e13d76026656d433d5c42e4c19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148975 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-16Resolves: tdf#153908 scrolling relationships moves the wrong directionCaolán McNamara
Change-Id: Ic49e0c167a020269fa7de58ea9e1ece0b66d57ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148950 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-16Relates tdf#154143 Add source image assets of Tips of The DayRizal Muttaqin
Change-Id: I6e1d881705282c7f7c219a345f61990a20c05cbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148951 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-16tdf#102261: introduce editeng paragraph tab stop default distanceSarper Akdemir
Adds mnDefaultDistance to SvxTabStopItem that if defined will set a paragraph wide tab stop default distance and override the document wide setting. Also makes editeng consider mnDefaultDistance while getting tab stop default distance. Change-Id: I0fa098f874d6b9c91ddbaa2634224ff55cafcc95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148058 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-16Remove false documentationTor Lillqvist
There are no such duplicated constant labels in this file. Change-Id: I6352766834bf832667b5644d7507ec250932492a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148976 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-03-16Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 142696bd75353a8b1fa23c6aae08b0d18e807546 - tdf#153560 adjust heading levels for "Up to level" and "Offset" One content change: A correction to the description of the "Heading" type. Other changes are neutral in relation to translation. * The options in the "Format" section are part of that section, so they should be one level down (h2->h3) in the hierarchy. - remove <xml-lang> Change-Id: I1ee11c3e8c726c2a3ae2985456be40abc75813b8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148962 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2023-03-16tdf#140226: use StaticWhichCast in htmlatr.cxxBayram Çiçek
Change-Id: If7694d45827630ec690004d4fd2c5fbacbc46f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148541 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-16move getCorrectedMissingValueTreatment inside chart2::DiagramNoel Grandin
and also switch to using getFastPropertyValue Change-Id: I0c6617841a364ccb8e1c7b624e1ef6fde28426d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148928 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-16tdf#143148: Use pragma once instead of include guardsUday Sharma
Change-Id: I6898acbf7c6c9de45bbfa6a32202acf302f92caa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146822 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-03-16Adapt loplugin:implicitboolconversion to _G_STR_NONNULLStephan Bergmann
...from glib2-devel-2.76.0-1.fc38.x86_64, causing > libreofficekit/source/gtk/lokdocview.cxx:390:28: error: implicit conversion (IntegralCast) from 'bool' to 'int' [loplugin:implicitboolconversion] > pLOEvent->m_pCommand = g_strdup(pCommand); > ^~~~~~~~~~~~~~~~~~ > /usr/include/glib-2.0/glib/gstrfuncs.h:212:35: note: expanded from macro 'g_strdup' > const char *const __str = _G_STR_NONNULL (___str); \ > ^~~~~~~~~~~~~~~~~~~~~~~ > /usr/include/glib-2.0/glib/gstrfuncs.h:157:34: note: expanded from macro '_G_STR_NONNULL' > #define _G_STR_NONNULL(x) ((x) + !(x)) > ^~~~ Change-Id: Iec20b20992a61fd48155f338a10dc313411448f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148948 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-16xmloff: ODF export: produce alt text and description for MediaShapeMichael Stahl
... and others where it was inexplicably missing (PluginShape, AppletShape, FrameShape). Change-Id: Idf1c44488370a81bc90fb316ab6056994d782a1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148917 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-16tdf#39667 filter,officecfg: PDF export dialog: set initial view to...Michael Stahl
... Outline for PDF/UA. * change the dialog to disable the radio buttons if PDF/UA is enabled * also change the configuration to make Outline the default Change-Id: Iea8c5e0f8560c972dc250859198bea1cb9fc3597 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148883 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-16sw: fix undo comment of FN_DELETE_BOOKMARKSMiklos Vajna
It's bookmarks, not bookmark. One has to dispatch .uno:DeleteBookmarks to see this in action, which does something if the document already contains at least one bookmark. Change-Id: I7678f6bc6a00a95cfd4ecc87e97e8db6d469216d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-16De-static-izing colors in SwViewOptionParis Oplopoios
The view colors in SwViewOption were static which means that two separate views couldn't have different colors Change-Id: Id595b00ba56bdb210ad1a784cf76e99ead0d6014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-16sw floattable, legacy: restrict height when using bottom margin areaMiklos Vajna
The bugdoc was 1 page in Writer, but 2 pages in Word. There the entire 3rd row went to the next page. The problem seems to be that the legacy mode in Word seems to allow going to the bottom margin only in case the height of the floating table still fits the body frame height, while we simply allowed the usage of the bottom margin area unconditionally. Fix this by extending GetFlyAnchorBottom() to explicitly check for the body frame height. Note that this doesn't solve cases where the current height fits the body frame, but the new bottom won't; that still needs fixing in a follow-up commit. Change-Id: Ic55b93e7b53fc45a837c3245c0091f2c93d028aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148944 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-03-16XmlTestTools: factor out common codeXisco Fauli
Change-Id: Ie212c86c6c0ac20878be88d88ade5eb1c989942d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148935 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-03-16tdf#140762 tdf#152671 Make dock win visible before showing popupMichael Weghorn
The fact that the docking window got hidden (in `ImplPreparePopupMode`) and only shown again after starting popup mode for the containing floating window meant that the docking window and its children were still invisible when starting popup mode. Therefore, they would also not be considered/returned as accessible children when listeners are registered for accessible children in winaccessibility's `AccTopWindowListener::AddAllListeners`. As a consequence, no a11y events would be sent when they receive keyboard focus and they would not be announced by the NVDA screen reader. Make them visible again *before* starting popup mode for the floating window. This e.g. makes NVDA announce popups in the toolbar or the Calc autofilter dropdown. Change-Id: I6953e4b491db4708ba30fb98173d13391d6e0461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148933 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-16tdf#153683: Show the used module in --convert-toBaole Fang
Implements getName that returns the module name. When outputs the convert-to message, module name is included. Change-Id: Ic18d8899d160e9c1afa8801dc07120f5ef822d07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148905 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-16use more OUStringLiteral in chart2::ObjectIdentifierNoel Grandin
Change-Id: I9387b6f5f65c030a6ddea47b34927b613533ff26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148913 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>