summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-11-04svx: prefix members of E3dCubeObjMiklos Vajna
See tdf#94879 for motivation. Change-Id: I0e1dcb44cd46fdf40ae21c264017c8fc9ca96b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175980 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-04check stream stateCaolán McNamara
Change-Id: Ic79b14565e4c84cfeb8ce87994ed45fcb45df4a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176005 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04android-viewer translated using WeblateWeblate
Hebrew currently translated at 100.0% (116 of 116 strings) Change-Id: I5a39070be19791e0f85ee32487bcca8a1876a9b8 android-viewer translated using Weblate Interlingua currently translated at 75.8% (88 of 116 strings) Change-Id: Iea0eb23bf7d58d78fd99668a8b057f3d9295a3fc Added translation for android-viewer using Weblate (Tagalog) Change-Id: I2f97dbf569d5eda71dfdd2a62c5563bd7918d43b Co-authored-by: Andy Flagg <libreoffice.tagalog@gmail.com> Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com> Co-authored-by: famese <hmcb2080@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/he/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ia/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175682 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-11-04delete useless parts of GalleryCodec::ReadCaolán McNamara
no point reading this to just to discard it later the only places reading this are just opening, using and close the streams afterwards, so the need to even skip over this data doesn't seem to arise. Change-Id: Ieb2498f458534770c167bbbfb3a4792162238986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-04tdf#143148 use pragma once instead of include guardsRosh
Change-Id: I44df7baf1d5bfdd45647c5b2ed99958d587ff61e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176002 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-04cui: Fix a UI string in a11y check optionsMing Hua
Commit d14e79bf7680db2180e40ba52fc3305a84c586f6 (Correct grammar in strings for A11y, 2024-09-18) fixed many UI strings in the newly introduced a11y check options with correct English grammar, but mistakely changed this string from "heading order" (which means the chapter and section headings) to "table heading order". This commit reverts the change and slightly improved the wording. Change-Id: I2957004d6b82d35841f57a76ca25fbf9b851b9b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175918 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-04Simplify a bitMike Kaganski
Change-Id: If30cac2426fe6de498066dbe9ec8465450d7ce0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176001 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-04feat(json): Allow serializing anySkyler Grey
Previously, as far as I can tell, there was no way to send a Size in a .uno command (as would be needed in, say, '.uno:InsertAVMedia'). We do, however, already have a way to send an `[]any`, and we can use a similar method to allow sending arbitrary types with `any` rather than `[]any`. To use this, the type you really want to send has to be wrapped in any, so for example... { type: "any", value: { type: "com.sun.star.awt.Size", value: { Width: { type: "long", value: 0, }, Height: { type: "long", value: 0, } } } } Change-Id: Ic33594dee955d475d81733adb21950c0458435e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174740 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit cccbf8608f3b76651993bc8576c672367c228fa2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175982 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04feat(lok): Add extra impress export formatsSkyler Grey
Previously we had the ability to export to various formats, but these weren't exposed in a way that LOK could request them. We want to increase the options available for export, so we need to make these available. Change-Id: I1c05aeec8de32929481059bcfd02cac05a46788d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174602 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 541272d3eaa322ccdd1b926add031a39faeccf49) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175981 Tested-by: Jenkins
2024-11-04Drop requirement that there is internal/shared autotext.Caolán McNamara
A user's autotext was not examined unless there existed some internal/shared autotext. There seems to be no particular reason for that, except that internal/shared autotext happens to generally be available. Change-Id: I43a9fe5916d3a0895b175db52758104cc7fd65b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-04merge creating variable and assigning itCaolán McNamara
Change-Id: I1c8533f5adf5ab1db88dc279fc8e9a21c38c66bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175976 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04cid#1606943 Overflowed constantCaolán McNamara
Change-Id: I056e45e19bb3794acbdf7b5c2b4ecb787e52de0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-04cid#1606699 silence Overflowed constantCaolán McNamara
Change-Id: Ib3cac90e56bd00a777871f1b07849fabd7e307a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-04cid#1607290 silence Overflowed constantCaolán McNamara
Change-Id: Ic05b5a64a3be44d8aba4c9ffaf8867a45f2422db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175973 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-11-04new loplugin:staticconstexprNoel Grandin
Change-Id: Ida1996dfffa106bf95fd064e8191b8033b4002f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 883, 893 Change-Id: Ie722bffb7aa8cbdb38a5b1a244f5c5a072c26c8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175263 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 815, 819 Change-Id: I86c8065de5bb83671bcc499bb46b5e5723ec01d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-04Simplify a bitMike Kaganski
Change-Id: I5c6110cc26e8fb20066374dc235677f07e79ce1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175977 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-03tdf#163486: PVS: pointer not released in destructorXisco Fauli
Since commit 7ef3b46fd5bdfb3a87e9b0a840287fdb6ff4734b Author: Gergő Mocsi <gmocsi91@gmail.com> Date: Thu Mar 7 11:57:04 2013 +0100 fdo#35546, implementing 'Create Photo Album' function V773 The 'm_pGraphicFilter' pointer was not released in destructor. A memory leak is possible. Change-Id: Iee1c4f4f3ae5232506563a219ffdec61f74fcff0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175884 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-11-03tdf#145538: Use range based for loopsMelvinYG
Change-Id: I1865d2fab8d29bfbc81b10a9497b47c5c94f1af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175186 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-11-03Related: tdf#163730 Avoid potential deadlockMike Kaganski
Similar to commit 43e5118496ae0c9b8f81a54574874eda7d439dbb (Related: tdf#163730 Avoid deadlock, 2024-11-03). I haven't seen this scenario myself, but seems likely to be possible. Change-Id: Ie6bb69e7ebe12a69e4dabee9103de32611235807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175971 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-03Updated getPackageName2PathMapBarry-Thomas-Paul: Moss
Update getPackageName2PathMap to use ExtensionManager Change-Id: I22c00aeb27913f138da00d304b9f238787459d28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174877 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-03tdf#163486: PVS: parameter is always rewrittenXisco Fauli
Since commit a9a665ed7a3198f4c0f6e521520491353ccfb182 Author: Szymon Kłos <szymon.klos@collabora.com> Date: Tue Jan 5 14:54:52 2021 +0100 pivot table: make partial sum message box async V763 Parameter 'pSrcErrorId' is always rewritten in function body before being used. Change-Id: I51c2d1b0d01563d66e828d3ebfaf61f620992443 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175876 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-03tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 82, 118 Change-Id: Iae91b2079c1c1d5aeb3000495364f3995266cbe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175274 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-03tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 8172, 8405, 8484 Change-Id: I85ff9c6258fc855323c1ee814b981b3453db7651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175275 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-03tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 843, 850 Change-Id: I82df65a66b98e115bebfccc6ca1c9567533bd651 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175267 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-03tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 91, 94 Change-Id: Ie7c803398eb1ce016a2f7a2a71b5d1a283266cc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175237 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-03tdf#143148 Use #pragma once instead of include guardslynn_edem
Change-Id: I3ff0f661a3b4109b79ec13dad4e3472378048ec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175705 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-11-03tdf#161349 writerfilter: only copy page background vml fillJustin Luth
This fixes my 24.8 regression. I had this clause in earlier versions of the patchset, but it moved along with most of the other logic to the initialization of the default page style. However, I certainly need to limit copying the properties of the default page style to ONLY the fill properties here as well. Change-Id: I168f13ebeea3720eba53703210314f069fb87ae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175963 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins
2024-11-02Related: tdf#163730 Avoid deadlockMike Kaganski
Seen locally, with main thread querying clipboard state: vclplug_winlo.dll!std::unique_lock<std::mutex>::unique_lock<std::mutex>(std::mutex & _Mtx) Line 145 vclplug_winlo.dll!CWinClipboard::getContents() Line 109 vcllo.dll!TransferableDataHelper::CreateFromClipboard(const com::sun::star::uno::Reference<com::sun::star::datatransfer::clipboard::XClipboard> & rClipboard) Line 2162 vcllo.dll!TransferableDataHelper::CreateFromSystemClipboard(vcl::Window * pWindow) Line 2188 swlo.dll!SwBaseShell::StateClpbrd(SfxItemSet & rSet) Line 602 swlo.dll!SfxStubSwBaseShellStateClpbrd(SfxShell * pShell, SfxItemSet & rSet) Line 2220 sfxlo.dll!SfxDispatcher::FillState_(const SfxSlotServer & rSvr, SfxItemSet & rState, const SfxSlot * pRealSlot) Line 1726 sfxlo.dll!SfxBindings::Update_Impl(SfxStateCache & rCache) Line 267 sfxlo.dll!SfxBindings::NextJob_Impl(const Timer * pTimer) Line 1280 sfxlo.dll!SfxBindings::NextJob(Timer * pTimer) Line 1225 sfxlo.dll!SfxBindings::LinkStubNextJob(void * instance, Timer * data) Line 1220 vcllo.dll!Link<Timer *,void>::Call(Timer * data) Line 111 vcllo.dll!Timer::Invoke() Line 75 vcllo.dll!Scheduler::CallbackTaskScheduling() Line 509 vcllo.dll!SalTimer::CallCallback() Line 53 vclplug_winlo.dll!WinSalTimer::ImplHandleElapsedTimer() Line 169 vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 525 vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 581 vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 385 vcllo.dll!Application::Yield() Line 473 vcCMtaOleClipboard::runllo.dll!Application::Execute() Line 361 sofficeapp.dll!desktop::Desktop::Main() Line 1679 CMtaOleClipboard::clipboardChangeNotifier thread holding CWinClipboard's mutex in handleClipboardContentChanged, and waiting for the destruction of IDataObject released from m_foreignContent (which was redirected to CMtaOleClipboard::run thread): vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release(IDataObject * ptr) Line 235 vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::~COMReference<IDataObject>() Line 163 vclplug_winlo.dll!CAPNDataObject::~CAPNDataObject() Line 97 vclplug_winlo.dll!CAPNDataObject::`scalar deleting destructor'(unsigned int) vclplug_winlo.dll!CAPNDataObject::Release() Line 137 vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::release(IDataObject * ptr) Line 235 vclplug_winlo.dll!sal::systools::COMReference<IDataObject>::~COMReference<IDataObject>() Line 163 vclplug_winlo.dll!CDOTransferable::~CDOTransferable() vclplug_winlo.dll!CDOTransferable::`scalar deleting destructor'(unsigned int) cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 230 vclplug_winlo.dll!cppu::WeakImplHelper<com::sun::star::datatransfer::XTransferable>::release() Line 115 vclplug_winlo.dll!com::sun::star::uno::Reference<com::sun::star::datatransfer::XTransferable>::clear() Line 234 vclplug_winlo.dll!CWinClipboard::handleClipboardContentChanged() Line 291 vclplug_winlo.dll!CWinClipboard::onClipboardContentChanged() Line 385 vclplug_winlo.dll!CMtaOleClipboard::clipboardChangedNotifierThreadProc(void * pParam) Line 721 and CMtaOleClipboard::run thread waiting for CWinClipboard's mutex in CWinClipboard::onReleaseDataObject: vclplug_winlo.dll!std::_Mutex_base::lock() Line 52 vclplug_winlo.dll!std::unique_lock<std::mutex>::unique_lock<std::mutex>(std::mutex & _Mtx) Line 145 vclplug_winlo.dll!CWinClipboard::onReleaseDataObject(CXNotifyingDataObject & theCaller) Line 362 vclplug_winlo.dll!CXNotifyingDataObject::Release() Line 75 ole32.dll!CClipDataObject::Release() Line 960 combase.dll!... rpcrt4.dll!Invoke() rpcrt4.dll!Ndr64StubWorker(void *,void *,struct _RPC_MESSAGE *,struct _MIDL_SERVER_INFO_ *,long (*const *)(void),struct _MIDL_SYNTAX_INFO *,unsigned long *) rpcrt4.dll!NdrStubCall3() combase.dll!... user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int) user32.dll!DispatchMessageWorker() vclplug_winlo.dll!CMtaOleClipboard::run() Line 655 vclplug_winlo.dll!CMtaOleClipboard::oleThreadProc(void * pParam) Line 673 Caused by changes in commit 2e0664015255ffc0f76a11a9cb254564b34de496 (tdf#148647: make sure to update own content on Win clipboard change, 2024-07-14). Change-Id: I26d35726f3d3f650a2db2ac63709ed820a60fc4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175956 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-02tdf#163738 use insert function instead of for loopChris Gill
In the unit test CppunitTest_xmlsecurity_pdfsigning use std::vector::insert() in place of a for loop. Change-Id: Ib51f0ec6932210befe3c7aad9a6b5c8989bfe839 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175337 Tested-by: Jenkins Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2024-11-02No need to use SAL_THROW_EXTERN_C macro in CXXMike Kaganski
Change-Id: I6eb9f0431a9402479a2d90d5b6f68b611d52a9f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-02use row&column address for autofill preview popupBayram Çiçek
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com> Change-Id: I2206f13210f57db27d962f931ec9b1ced5ec8cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174502 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 2a3053921ee67e305130fc3dee6278c00f737e92) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175917 Tested-by: Jenkins
2024-11-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 02fd40af9c8a62babb4d8549be8af8dcd39f7635 - Tweaks for text function for navigation (3) Change-Id: I6a4246acf9e6ade45e9692a24fb358fc44a90a05 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175955 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-11-02Update git submodulesDione Maddern
* Update helpcontent2 from branch 'master' to e2903bddbdf7d9a4b10aba32a30b48d70e2feb4e - tdf#163053 Add Help page for Comments sidebar panel in Writer Create a new page text/swriter/01/sidebar_comments.xhp to document the Comments sidebar panel feature. In AllLangHelp_swriter.mk - Add new page to repository In text/shared/01/04050000.xhp - Add section and variable tags to allow the page to be easily linked and embedded in other pages. In text/shared/optionen/java.xhp - Add section and variable tags to allow the page to be easily linked and embedded in other pages. Change-Id: I782c6483b07cc1b7d7b3566fe4664927740387af Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175915 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-11-02Simplify a bitMike Kaganski
Change-Id: Ia297a94b9fe06074e06ca573173a9e9c41834240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175954 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-02Simplify a bitMike Kaganski
Change-Id: I2e4635c660a57abefa57b046e3f0da411939cf1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175953 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-11-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 3a67ce44369193e2089a35c5d106d3a115ec03c5 - tdf#137680 About Skia + Added precision on the use of Skia graphic engine vs. system GDI + Added bookmark entries + refactor Change-Id: If47fb8a7f251f70db26c8ba060d0257a28b15dc3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175936 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-11-02Update git submodulesPierre F
* Update helpcontent2 from branch 'master' to 3b6506e4e1b6b4dd41f4e5e8fda8315426c57d9c - tdf#143846 split PROPER REPLACE REPT RIGHT SEARCH ... ... SUBSTITUTE T TEXT TRIM UNICHAR UNICODE UPPER Change-Id: I2ef1a659fbaf481dac1329f86178b8cd9b786ce2 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175912 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-11-02Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 40bbfa8f4fb070b66481068b952755d04854db2c - tdf#145161 Update Help per renamed label, Change image resolution Change-Id: Ie62be5e67652512ea850654e83d5c873c5030cb5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175949 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-02cid#1494598 Uninitialized scalar fieldCaolán McNamara
since: commit d87cf67f8f3346a1e380383917a3a4552fd9248e CommitDate: Wed Oct 23 18:26:07 2024 +0200 tdf#131728 sw inline heading: fix missing/broken DOCX export Change-Id: I15971c085af3ec20a44dd49865a979e974f7572a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-11-02tdf#145538 Use range based for loop in textsh1.cxxAdesola Samuel
Change-Id: I6e902b6947a27fe234d321ed3055dd0f867138a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175940 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-11-02tdf#145538 Range based for loop cannot be used in SfxBroadcaster.cxxAdesola Samuel
The loops in this file cannot be range-based because vectors can change size inside the loop. Change-Id: I0f3d3d768b69bb280962541a237f5ec02874dbdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175866 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-02Fix unchecked dereferenceMike Kaganski
After commit 0c96119895b347f8eb5bb89f393351bd3c02b9f1 ("tdf#159565 prerequisite: make hidden sections have zero-height frames", 2024-02-15). Change-Id: Ie990dcaf519329382b5088f31e6f534445470229 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175944 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-11-02tdf#145161: Change pdf and image compression dialog stringAditya Sahu
Since image/pdf compression does not always reduce image or pdf resolution, change the misleading label from "reduce" to "change" wherever possible. Keep identifiers having "reduce" in their name as is as of now, only change the string values containing "reduce" to "change". Change-Id: I6c4263250faff906d0a16bd1290dc57960161be0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175929 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-02tdf#143148 use pragma once instead of include guardsLeSci-0x1
Change-Id: I8ace16d16c900b6cec8fa454250dcdb1698c0677 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175890 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-02tdf#36709 Add loext:text-indent supporting font-relative unitsJonathan Clark
This change adds an ODF font-relative first-line indent paragraph style attribute as a LibreOffice extension. The corresponding ODF standard change is tracked by OFFICE-4165. This change only implements what is minimally necessary to serialize, deserialize, and check for ODF files containing this attribute. Further changes are necessary. * Added cssLength to schema, which is equivalent to length but also allows ic and em as units. * Added loext:text-indent to schema as a paragraph style attribute. This attribute is equivalent to fo:text-indent, but accepts cssLength instead of length. * Added XML_TYPE_UNIT_MEASURE to the ODF parser, which currently accepts only the font-relative measures and forces fallback in other cases. * Added loext:text-indent to the ODF parser. This attribute accepts font-relative metrics, and will behave as an import-only alias for fo:text-indent in other cases. * Updated SvxFirstLineIndentItem to handle unit-denominated measures. * Added proof-of-concept indentation handler to Writer. This implementation is incomplete and temporary, and will be revised in future changes. Change-Id: I7eb5c7382093cb18a9b0afbf93dacb34ba1d35ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175941 Tested-by: Jenkins Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
2024-11-02tdf#163486: PVS: Identical branchesBogdan Buzea
V1037 Two or more case-branches perform the same actions. Check lines: 2743, 2797 Change-Id: Id998cf92bb6d1540b7498138546618b350e52363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175157 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>
2024-11-02tdf#163486: PVS: Identical branchesBogdan Buzea
Change-Id: I2874ce6a61db592b43cfa5d8de682daa520d51b8 V1037: Two or more case-branches perform the same actions. Check lines: 303, 315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175151 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
2024-11-02tdf#163486: PVS: Identical branchesBogdan Buzea
Change-Id: I65edd548d9ed4fbc5589f354280dbfb90e2a9064 V1037: Two or more case-branches perform the same actions. Check lines: 171, 177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175148 Tested-by: Jenkins Reviewed-by: David Gilbert <freedesktop@treblig.org>