summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-17Remaining loplugin:bufferaddStephan Bergmann
...that had been missing because the plugin didn't implement postRun, so it didn't report anything when run as part of the shared plugin. (But did report the expected warnings when run as a standalone plugin during CompilerTest_compilerplugins_clang.) Most fixes are straightforward. A noteworthy one is PreparedStatement::setBytes in connectivity/source/drivers/postgresql/pq_preparedstatement.cxx: The old preallocation of a 20 character OStringBuffer might have prevented buf.append( reinterpret_cast<char *>(escapedString), len -1 ); from potentially throwing std::bad_alloc, which would have caused escapedString to be leaked. Even though that 20-character preallocation was likely just random junk and not meant to address the potential leak, lets address it now. Change-Id: Ib506332d061684a22a74e5e39e591539fd2c4900 Reviewed-on: https://gerrit.libreoffice.org/80925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17writerfilter: clean up now redundant PROP_LAYOUT_IN_CELLMiklos Vajna
Which is now exactly the same as PROP_FOLLOW_TEXT_FLOW, so no need to set it separately. Change-Id: I32e1e2bdfb8ac46eb6a07f5187f780275d334b2f Reviewed-on: https://gerrit.libreoffice.org/80926 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-17Add Name and Description to group context menuandreas kainz
Change-Id: Icc19b6e3493f1d9e49584c3e2ac99509fae4e02e Reviewed-on: https://gerrit.libreoffice.org/80923 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-17Cache last used number-format-type in interpreter-contextDennis Francis
if in cpu-threaded mode so that we can avoid the unnecessary locked SvNumberFormatter::GetType() calls (Mapping between NF index and NF-type does not change while formula-group-threading is running). Change-Id: I648bc08c885da845f0b09cd57013cc1c23e01a61 Reviewed-on: https://gerrit.libreoffice.org/80848 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2019-10-17move SSE2sum code to separate cxx file...Dennis Francis
and compile it with -arch:SSE2 if Windows. This code however gets called only if cpuid::hasSSE2() is true, so this does not cause problems with machines without SSE2 support. Change-Id: Ice23ac71d4c577b8811b08c74a3ca500a94fdc09 Reviewed-on: https://gerrit.libreoffice.org/80847 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17Reuse pre-allocated ScInterpreter for HandleStuffAfterParallelCalculationDennis Francis
Change-Id: Idf10bb214d6d82370512eeb39ba7786dd9bceb38 Reviewed-on: https://gerrit.libreoffice.org/80846 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17Pre-allocate an ScInterpreter object for each thread...Dennis Francis
and reuse them for interpret'ing all cells under the respective threads. This gives a sizeable win in the execution time especially for long formula-groups. Change-Id: Ib340950f21e863b5b821d20c092214d8bc5012aa Reviewed-on: https://gerrit.libreoffice.org/80845 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17Remove code that is deadStephan Bergmann
...ever since 8f55fe4c6c73f110b1c72903c209399ff2527ea5 "INTEGRATION: CWS help2" dropped p->application and "/" from strBuff. Change-Id: I48aa9271daac4caf23d932741a5c75cb00ad7ee9 Reviewed-on: https://gerrit.libreoffice.org/80924 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17tdf#108350 writerfilter: restore TimesNewRoman as default fontJustin Luth
Followup for LO 5.4 commit 6f2ad89b33d972f9642bb53eeb91f41df3b6b0e6 which set Calibri/11pt as default. That is true if there is no style.xml file, or more specifically if there is no DocDefaults rPrDefault node. But if that node exists, then the age-old defaults are still valid. Earlier in LO 4.3, the default templates changed to use Liberation fonts by default. But in the same vein as using Calibri (and depending on LO to fallback to Carlito), set Word's default Times New Roman font and depend on LO to fallback to Liberation. That will make it better for MSWord users who share the document and who have less likelihood of knowing about Liberation/Carlito. Note that 10pt fontsize was already added to m_pDefaultCharProps earlier, so that part was already reset long ago. Change-Id: I3ba8a529fe95b05fbe2889cf1ebdbabb25963e8b Reviewed-on: https://gerrit.libreoffice.org/80854 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-10-17Don't send false 'INPLACE' messagesSzymon Kłos
Change-Id: I8eb9a77c7e6b9242f18ac5f0634091c88bf40ec0 Reviewed-on: https://gerrit.libreoffice.org/80695 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-16Update git submodulesAndras Timar
* Update translations from branch 'master' - Updated Slovenian translation Change-Id: I7a5c6bd9fc6ac769251aca007b01ad24e11dfd61
2019-10-16Resolves: tdf#127961 Add NBSP to quotation marks for all French except fr-CHEike Rathke
Change-Id: I71e8377bf44c2db5ef291d2990528ec16aaf3b44 Reviewed-on: https://gerrit.libreoffice.org/80909 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-10-16dbmgr.hxx: Drop "extra ';' after member function definition"Michael Weghorn
Change-Id: Ide54e4755624d515aeeacf62591dc59aea667dcf Reviewed-on: https://gerrit.libreoffice.org/80879 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-16Allow building lcms2 with Windows SDK 8.1Mike Kaganski
Change-Id: I81052f7634c7873d893d67deb79ed7bfa6dcbc44 Reviewed-on: https://gerrit.libreoffice.org/80888 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-10-16Related: tdf#124729 log any gtk_gl_area_get_error messagesCaolán McNamara
Change-Id: I5864e5d3132b309d5500c02a8493062abcb25aab Reviewed-on: https://gerrit.libreoffice.org/80886 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-16Removed duplicated includeAndrea Gelmini
Change-Id: I55fdf178bbd185d8852da13757aca627d93526bb Reviewed-on: https://gerrit.libreoffice.org/80911 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-16tdf#112103 DOCX cleanup: don't export redundant table bkground color "auto"Szabolcs Toth
because this is the default value of table cells. Change-Id: I4f45f32f24474f4d9c6bbc91fcd62cb66f008e5d Reviewed-on: https://gerrit.libreoffice.org/80601 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-16SwMergeDescriptor::bCreateSingleFile only affects "FILE" modeMichael Weghorn
As of now, "PRINTER" doesn't support bCreateSingleFile=false any more, s. https://gerrit.libreoffice.org/#/c/80884/ which already updates the README. Change-Id: Ifcff238c3f497afd84279a485f324f0978c4e884 Reviewed-on: https://gerrit.libreoffice.org/80885 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-16Mail merge README: Printing separate files not supportedMichael Weghorn
The combination "PRINTER+false" is not supported, i.e. it's currently not supported to generate individual print jobs for a subset of data records instead of one job per mail merge run. The possibility to do so had been added by commit 138d29aa09417eba4d15ade4c9f4dab2620b6326 ("support fast MM printing in non-single-file mode only for CUPS"), but was removed again by commit dea0abc58c558d3c62e806d06035b1a30420264e ("tdf#93236 Revert "support fast MM printing in...") and commit b6a698b093f78dc90836d502db3d0276f335fbfe ("tdf#95251 MM just allow print as single document"), so update the README accordingly. Change-Id: I83afc1949915434c95bdcb58e1d09dc2c900c500 Reviewed-on: https://gerrit.libreoffice.org/80884 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-16bump product version to 6.4.0.0.alpha1+Christian Lohmaier
Change-Id: I4eaf798b1b43fe8a78d1697d9ebc207ff8ace492
2019-10-16tdf#42316 handle saving to template filtersJan-Marek Glogowski
This extends the filter comparison from commit c3a1c83ff5af ("tdf#42316 preserve macro signature of templates"). The original patch just stripped "_template" from the source filter to find equal document types, which just enables the "template => document" case. This patch also strips the "_template" from the target filter, which fixes the "document or template => template" cases. This also extends the signing save tests: * OTT 1.2 => OTT 1.2 - preserve * ODT 1.2 => OTT 1.2 - preserve * OTT 1.0 => OTT 1.0 - preserve * ODT 1.0 => OTT 1.0 - preserve * OTT 1.0 => OTT 1.2 - drop Change-Id: Ie297258a4d9f9aa4beb25786c6ba240b6f16f49b Reviewed-on: https://gerrit.libreoffice.org/80654 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-16Send 'INPLACE EXIT' on inplace deactivationSzymon Kłos
Change-Id: Ieb44fb356966df0eb92141a5f22f1df13683f6fc Reviewed-on: https://gerrit.libreoffice.org/80694 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-16tdf126796 percent stacked image fixed for colibreandreas kainz
Change-Id: Iad8d37c5d0f9fa10bad426ce2b1fb7e760b2e1fd Reviewed-on: https://gerrit.libreoffice.org/80865 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-16tdf#106843 DOCX: export/import change tracking protectionLászló Németh
Now change tracking protection from Writer or from ODT files is exported to DOCX. In Writer it's always possible to disable change tracking protection without password in File->Properties->Security page-> Record Changes after confirmation. Now Writer uses the same confirmation to remove change tracking protection imported from DOCX, for example clicking on Record Track Changes. Disabled protection removes the export of the grab-bagged change tracking protection, too, to avoid of creating bad DOCX with enabled change tracking protection and disabled Record change tracking. See also commit d416250f4f1766e2d596ea3feef6a94b7adf29f4 "tdf#106843 DOCX: forbid disabling protected Record Changes" Change-Id: Ida4d72c57dbe5450ea22028bbed69d413f5a786d Reviewed-on: https://gerrit.libreoffice.org/80784 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-16loplugin:bufferadd loosen some constraintsNoel Grandin
and extend O*StringView to have a constructor that takes a pointer and a length Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8 Reviewed-on: https://gerrit.libreoffice.org/80872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16overlapping scrollbars when both visibleCaolán McNamara
Change-Id: I75644c526e401ce0bc9a46a66d3d31e90bafb1d6 Reviewed-on: https://gerrit.libreoffice.org/80874 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-16tdf#128156 DOCX import: fix losing redline at page breakLászló Németh
w:framePr of page header doesn't mean real frame conversion, so don't store and lose redlines after it. Regression from commit e8bae67b3dbcc90ace8264b6b1aefaf0ce459aba "tdf#125894: DOCX: import tracked changes in frames". Change-Id: I46cd153cccef4824deca1f64341f2ea6672cdc42 Reviewed-on: https://gerrit.libreoffice.org/80871 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-16use --disable-symbols with Jenkins Win/Mac builds that use dbgutilLuboš Luňák
We want debug builds there, but the debugging symbols for debugger themselves are not actually needed (Linux builds use the debug symbols for printing backtraces when a unittest crashes, but Win/Mac do not). This should save generating the needless debug info (CPU and I/O). Change-Id: I3fc8bdb66e4822838216359b23b8a2dd5f2a0f42 Reviewed-on: https://gerrit.libreoffice.org/80732 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-16use --disable-dependency-tracking for Jenkins buildsLuboš Luňák
They always start with 'make clean' (at least according to the logs), so they are always one-time builds where creating dependencies is not needed. Change-Id: If402fbaa21bd213e3f781985479dd49c266ca511 Reviewed-on: https://gerrit.libreoffice.org/80730 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-16tdf#126796 percent stacked image fixed for breezeandreas kainz
Change-Id: I6687d462de7e21e770220cc1e804a28231b9e38d Reviewed-on: https://gerrit.libreoffice.org/80866 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-16tdf#126060 Handle text camera z rotation while pptx import.Gülşah Köse
Change-Id: Ifa4589fb50affc4c5ffb52288db8533c98ec6dd9 Reviewed-on: https://gerrit.libreoffice.org/80587 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-10-16fix breeze dark theme issue in charts moduleandreas kainz
Change-Id: Idb145235f05a1916199768f4d6ef9fdc47a77084 Reviewed-on: https://gerrit.libreoffice.org/80867 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-16Disable chart doubleclick on mobileSzymon Kłos
To not show any dialog. Change-Id: Ie19df429b927f746d3fc511ab0aa7b489ec1fd18 Reviewed-on: https://gerrit.libreoffice.org/80851 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-16tdf#62955 - Allow searching a name with typing the first letterAndreas Heinisch
Grab focus of the TreeView when the macro chooser is created Change-Id: Idfe3d2435840103eb2fa0ec5d17efce0931cfabd Reviewed-on: https://gerrit.libreoffice.org/80095 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-16swap left/right for RTL scrolling hadjustmentCaolán McNamara
Change-Id: Ia1cb82c5fce09c71f9378690a35355cb6636e6ae Reviewed-on: https://gerrit.libreoffice.org/80858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-16Simplify insertion into stringMike Kaganski
Change-Id: I326422f09d59590533966a2956f5442e1ec694b5 Reviewed-on: https://gerrit.libreoffice.org/80864 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-16convert some Buffer.append to +Noel Grandin
by hand, because I don't feel like teaching this specific idiom to the plugin Change-Id: If400677dac842ca740c4532ed79f6f18f752b730 Reviewed-on: https://gerrit.libreoffice.org/80842 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16writerfilter: sync layout-in-cell vs wrap-though behavior with ww8 importMiklos Vajna
I removed the same check in the WW8 import in commit d630f69d90f15bc652a62648b05ea515de78d16a (Related: tdf#124601 DOC import: improve fLayoutInCell handling, 2019-09-26). There is no reason the DOCX import shouldn't do the same, just for consistency. Change-Id: I9e56a3fcd0b13ba08e347fbc06b0960ac21b372c Reviewed-on: https://gerrit.libreoffice.org/80856 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-16Replace define by constexpr in sft.hxx (vcl)Julien Nabet
+ add required vcl namespace prefix to a call from outside in fontsubset.cxx Change-Id: Ib8d5c2e5a409957221c81b17dafaf3323760e8e5 Reviewed-on: https://gerrit.libreoffice.org/80857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16loplugin:stringadd look through a couple more known-good methodsNoel Grandin
Change-Id: Ifbdb3e41eae665f7dcaf5301aaba2b6e4662cf48 Reviewed-on: https://gerrit.libreoffice.org/80855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16sc: rowcol: migrate the Sc*IteratorNoel Grandin
Change-Id: I1e9a2b769d62ed3293de724ec50664bd8d22003e Reviewed-on: https://gerrit.libreoffice.org/80841 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16Remove a FIXME for win95 in vcl/gdi/printJulien Nabet
Since LO requires Win7 at least Change-Id: I4f4ea9fa3b87b4fae3f4eabbf736c4a2e7db3d8b Reviewed-on: https://gerrit.libreoffice.org/80861 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-15tdf#128148 Add unit testMichael Weghorn
The implementation of 'SwEditShell::ApplyAdvancedClassification' helped to find out how to access the text in the header. Change-Id: If044eea2e7d012ef56c0fff38a17af4aa59fea25 Reviewed-on: https://gerrit.libreoffice.org/80815 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-15tdf#128148 SwDoc::Append: Copy page descs if any has header/footerMichael Weghorn
Don't only check the first SwPageDesc, but also its follows whether they have a header or footer and copy the page styles in this case, since otherwise the header/footer content can be wrong if the first page's page style doesn't have header/footer but a following one does. Change-Id: If5ef76a7faf93ad533976b501f35f171336615c8 Reviewed-on: https://gerrit.libreoffice.org/80814 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-15gandalf now has gcc9 / no devtoolsetChristian Lohmaier
Change-Id: I2e5ded126f99ea7eb79d2db57240203dd3025e67
2019-10-15Improve loplugin:stringadd diagnosticsStephan Bergmann
Change-Id: I8b87c4e56f10417acd538b765b3f8e4cc6e12fb9 Reviewed-on: https://gerrit.libreoffice.org/80844 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-15honour per-widget RTL overrideCaolán McNamara
Change-Id: I29a499d29a3c0fabc594efbd5f966b108659b166 Reviewed-on: https://gerrit.libreoffice.org/80853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15database options page too tallCaolán McNamara
Change-Id: I79ce30e2254980994e64764525efc307c1a79db1 Reviewed-on: https://gerrit.libreoffice.org/80852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15Fix typoAndrea Gelmini
Change-Id: I48a52bd1c7afe83fe02c9651963436b9c5e07ca0 Reviewed-on: https://gerrit.libreoffice.org/80849 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-06-27 04:04:16 +0000