summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-24xmloff: create SchXMLExport_Styles instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ib15016bf08323936818bd9a26049772d3d6922c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92824 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-24loplugin:unusedmethodsNoel Grandin
Change-Id: Ieec5099a8ce9fa3f07e36be244071efc1b101cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92803 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23Image dialog property updateandreas kainz
Change-Id: I6e07b2c26559c501bd8502fef90f50adf089807c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92623 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-23cid#1462476 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ic545f41cfd466fc25bb7121b97d42d26a6a998e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92825 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23cid#1462311 silence Use after freeCaolán McNamara
etc. revert this hunk of commit 11785217594d863efb518aa8b8f2910cdcb9c59d Date: Tue Apr 14 14:55:22 2020 +0200 loplugin:buriedassign in c* just to silence coverity Change-Id: I6d8819a0ab073a56ab46944b170ef4ae3a28e4d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23Related tdf#115399: Reorder code slightlyStephan Bergmann
...in preparation of a forthcoming fix for the issue Change-Id: I6611778dfbc090eb869bf653cf7f61574a81b4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92823 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-23Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLYStephan Bergmann
It looks like an oversight that 904b3d1fceee5827076758ed2a81f80cb73493ca "Up- cast conversion constructor for css::uno::Reference" added it also for external code. Making it LIBO_INTERNAL_ONLY allows to remove workarounds for old MSVC, and may allow to simplify the code further in the future. (Though using std::is_base_of, as suggested in the comment, is not easily possible, as it would cause errors like > include/c++/v1/type_traits:1726:59: error: incomplete type 'com::sun::star::lang::XMultiServiceFactory' used in type trait expression > : public integral_constant<bool, __is_base_of(_Bp, _Dp)> {}; > ^ > include/c++/v1/type_traits:1731:7: note: in instantiation of template class 'std::__1::is_base_of<com::sun::star::beans::XPropertySet, com::sun::star::lang::XMultiServiceFactory>' requested here > = is_base_of<_Bp, _Dp>::value; > ^ > include/com/sun/star/uno/Reference.h:277:18: note: in instantiation of variable template specialization 'std::__1::is_base_of_v<com::sun::star::beans::XPropertySet, com::sun::star::lang::XMultiServiceFactory>' requested here > std::is_base_of_v<interface_type, derived_type> > ^ > ucbhelper/source/provider/getcomponentcontext.cxx:34:9: note: while substituting deduced template arguments into function template 'Reference' [with derived_type = com::sun::star::lang::XMultiServiceFactory] > css::uno::Reference< css::beans::XPropertySet >( > ^ > include/ucbhelper/getcomponentcontext.hxx:29:28: note: forward declaration of 'com::sun::star::lang::XMultiServiceFactory' > namespace lang { class XMultiServiceFactory; } > ^ with incomplete types.) Change-Id: I6da3395df904797cec83c1f6ab24b386527d4cea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92802 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-23Don't call default ctor only to reassign laterMike Kaganski
Change-Id: Ia725652f5124a2288bcca319a35d549c0bc3e351 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92793 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-23use rectangle rather than point+size for debug outputLuboš Luňák
And use SkIRect rather than tools::Rectangle because the latter messes up the size. Change-Id: Iaba609635b63bd65092a9a66f2df5426e40e9d2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92794 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-23LoseFocus incorrectly calling notifyFocusGetCaolán McNamara
looks like a cut and paste error from initial checkin Change-Id: I816ad85c564b0ca31833da17bbe760101ed3231d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23external/clucene: Avoid heap-buffer-overflowStephan Bergmann
...as seen during a --with-lang=ALL build with ASan on Linux: > [XHC] nlpsolver ja > ================================================================= > ==51396==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x62100000ed00 at pc 0x7fe425640f53 bp 0x7ffd6a0cc900 sp 0x7ffd6a0cc8f8 > READ of size 4 at 0x62100000ed00 thread T0 > #0 in lucene::analysis::cjk::CJKTokenizer::next(lucene::analysis::Token*) at workdir/UnpackedTarball/clucene/src/contribs-lib/CLucene/analysis/cjk/CJKAnalyzer.cpp:70:19 > #1 in lucene::index::DocumentsWriter::ThreadState::FieldData::invertField(lucene::document::Field*, lucene::analysis::Analyzer*, int) at workdir/UnpackedTarball/clucene/src/core/CLucene/index/DocumentsWriterThreadState.cpp:901:32 > #2 in lucene::index::DocumentsWriter::ThreadState::FieldData::processField(lucene::analysis::Analyzer*) at workdir/UnpackedTarball/clucene/src/core/CLucene/index/DocumentsWriterThreadState.cpp:798:9 > #3 in lucene::index::DocumentsWriter::ThreadState::processDocument(lucene::analysis::Analyzer*) at workdir/UnpackedTarball/clucene/src/core/CLucene/index/DocumentsWriterThreadState.cpp:557:24 > #4 in lucene::index::DocumentsWriter::updateDocument(lucene::document::Document*, lucene::analysis::Analyzer*, lucene::index::Term*) at workdir/UnpackedTarball/clucene/src/core/CLucene/index/DocumentsWriter.cpp:946:16 > #5 in lucene::index::DocumentsWriter::addDocument(lucene::document::Document*, lucene::analysis::Analyzer*) at workdir/UnpackedTarball/clucene/src/core/CLucene/index/DocumentsWriter.cpp:930:10 > #6 in lucene::index::IndexWriter::addDocument(lucene::document::Document*, lucene::analysis::Analyzer*) at workdir/UnpackedTarball/clucene/src/core/CLucene/index/IndexWriter.cpp:681:28 > #7 in HelpIndexer::indexDocuments() at helpcompiler/source/HelpIndexer.cxx:66:20 > #8 in main at helpcompiler/source/HelpIndexer_main.cxx:79:22 > 0x62100000ed00 is located 0 bytes to the right of 4096-byte region [0x62100000dd00,0x62100000ed00) > allocated by thread T0 here: > #0 in realloc at /data/sbergman/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:164:3 > #1 in lucene::util::StreamBuffer<wchar_t>::setSize(int) at workdir/UnpackedTarball/clucene/src/core/CLucene/util/_streambuffer.h:114:17 > #2 in lucene::util::StreamBuffer<wchar_t>::makeSpace(int) at workdir/UnpackedTarball/clucene/src/core/CLucene/util/_streambuffer.h:150:5 > #3 in lucene::util::BufferedStreamImpl<wchar_t>::setMinBufSize(int) at workdir/UnpackedTarball/clucene/src/core/CLucene/util/_bufferedstream.h:69:16 > #4 in lucene::util::SimpleInputStreamReader::Internal::JStreamsBuffer::JStreamsBuffer(lucene::util::CLStream<signed char>*, int) at workdir/UnpackedTarball/clucene/src/core/CLucene/util/Reader.cpp:375:6 Note that this is not a proper fix, which would need to properly detect surrogate pairs split across buffer boundaries. But for one the comment says "however, gunichartables doesn't seem to classify any of the surrogates as alpha, so they are skipped anyway", and for another the behavior until now was to replace the high surrogate with soemthing that was likely garbage and leave the low surrogate at the start of the next buffer (if any) alone, so leaving both surrogates alone is likely at least no worse behavior. Change-Id: Ib6f6f1bc20ef8efe0418bf2e715783c8555068de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92792 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-23Fix typo ("..." vs. '...' shell quoting)Stephan Bergmann
...introduced with 42f29b7f3f1bedac3fc057edfab985ffb03fd53b "Add --with-latest-c++ to explicitly opt in for -std=c++20/-std:c++latest" Change-Id: Ifa943bfb2d24da2ba0d63d577f42e8ec8a0b8f59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92795 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-23sw html export: fix handling of paragraph alignment in XHTML modeMiklos Vajna
The problem was that the <p align="..."> markup was used, while XHTML prefers the <p style="text-align: ..."> markup. Note that OutHTML_SvxAdjust() is a special case: other paragraph-level pool items would just call the equivalent of OutCSS1_SvxAdjust(). Fix the problem by bringing the paragraph alignment case close to e.g. SvxULSpace handling, which is the m_bNoAlign == true case. On top of this the reqif-xhtml output is then valid out of the box, since IgnorePropertyForReqIF() already filters out not allowed CSS properties. Change-Id: I5fb4314bec172affcd03b1c49b986406a93c2b12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92797 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-04-23tdf#127782 - New Print dialog is too highHeiko Tietze
ScrollWindow behind the tab control Change-Id: I5560f4368f94a45eeb1e3af3bf18df0f305ab3da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92758 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-04-23pass SvxBrushItem around by unique_ptrNoel Grandin
we never create an object that is actually shared, so this is wasted Note1: in IMPL_LINK_NOARG(SwEditRegionDlg, OkHdl, weld::Button&, void) there was a comparison if( aBrush != pRepr->GetBackground() || ... which I removed Note2: In bool SwDoc::GetBoxAttr( const SwCursor& rCursor, std::shared_ptr<SfxPoolItem>& rToFill ) which had a condition else if( rToFill != xBack ) I changed to compare contents Change-Id: Idd769f44917c5ccc7e9f4bfbaddf12f9cd4151cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23Use equal number of leading and trailing context lines in patchTor Lillqvist
Change-Id: I67763a5d612b66f61ed8a60c6331c85cc88f2b85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92789 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-23tdf#132278: sc: Add unittestXisco Fauli
Change-Id: Iaba8917fb18e86c68701b13b0ff26246c3cc8986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92746 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-23Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to e2f2799a2808d4389cedab5f979a5a928d91d815 - tdf#129366 Basic Syntax Diagrams - runtime/compiler Option statements - Sub, Function, Property Get/Let/Set - Dim, ReDim, DimArray - Dim and Redim help pages reviewed and amended accordingly - Sub, Function, Property pages updates in subsequent patches Change-Id: Iee857aa6e17533278bf16917c0b7d32af0e038ea Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92528 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-23Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 5f437431f487467f3bc329aa928abcf8e271b365 - tdf#129366 Basic Byte datatype information - TypeName function - VarType function - syntax diagram fragment update Change-Id: I412e95c9eb8a3b84158b3888025081600030167e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92533 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-23Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 44640598eda121aa83d4e89b874579d90f00e6fb - tdf#36737 Clarify routine arguments initialisation in those contexts: - native LibreOffice Basic - w/ Option Compatible - w/ Option VBASupport 1/0 - Added missing Byte, Boolean datatypes - type declaration caracters fragment conciser layout Change-Id: I53387018223466ef7452d87fb166d5d9e6de0594 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/92540 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-04-23Related tdf#131169: avoid magic numbersJulien Nabet
Change-Id: Ic82f214f22933e3c74b8b0fc4c6a25b19f103fa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92735 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-23tdf#132351 DOCX export: fix character formatting of numberingLászló Németh
with removed ListAutoFormat. Using untouched text portion of paragraph marker, DOCX export restored the changed character formatting of numbering with removed ListAutoFormat (see RES_PARATR_LIST_AUTOFMT in wrtw8nds.cxx). Follow-up of commit e4509d7db7562f7e4ab9366b915ed558291ac3de (tdf#127606 DOCX lists: fix unchangeable formatting) Change-Id: Ie576a204d86694296cb29185a5b130e87a518b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92744 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-04-23Drop Macromedia Flash export filterGabor Kelemen
Flash technology is going to be retired by the end of 2020 by Adobe: https://theblog.adobe.com/adobe-flash-update/ With this ahead doesn't make much sense for LO 7.0 to support exporting presentations and drawings to swf anymore. Change-Id: Ic2c6e95db2f56bcd4eb25abdd0a6748aee9b0e4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92507 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-23Update language-subtag-registry to 2020-04-01Eike Rathke
Change-Id: I89ac10b243ac0babbe0d1bf24a7e0f732fe5a495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92755 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-23avoid Skia xor crash with not-yet-drawn surface (tdf#132335)Luboš Luňák
No content yet, nothing to xor with. Change-Id: I68b44d6051859a61d50c5fbf8e3c63e719a87ca3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92753 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-04-23Use equal number of leading and trailing context lines in patchTor Lillqvist
At least the patch program on macOS seems to require it. Change-Id: I9943134c7fb672226cbde52e35ef78f74f060ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92756 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-04-23make spinbutton demo wide enough to useCaolán McNamara
Change-Id: Ibfd0e27b0b382fb6e0f71bfd4d9555998b03ded5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92754 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23weld ListBoxControlCaolán McNamara
Change-Id: I7f47814a724920f04ce1638b8afa3549ccb6a7c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23weld ComboBoxControlCaolán McNamara
Change-Id: Ifdb76cc61e6270f8a04fec2534dcd29d27e8281f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23remove undocumented ComboboxToolbarController propertiesCaolán McNamara
what documentation for these addons that I can find leads to https://wiki.openoffice.org/wiki/Framework/Article/Generic_UNO_Interfaces_for_complex_toolbar_controls where "SetDropDownLines", "SetBackgroundColor" and "SetTextColor" don't appear, nor are they used in the odk examples, and these are all now problematic properties. originally introduced with commit b8f9b4ad593f046797f1785dc18ed15ba70be2e3 Date: Fri Jul 6 11:23:29 2007 +0000 INTEGRATION: CWS c09tosrc (1.7.92); FILE MERGED 2007/06/25 14:04:31 rt 1.7.92.2: Avoid warning on mac ('aColor' may be used uninitialized in this function). 2007/06/18 15:27:16 cd 1.7.92.1: #i78622# Dropdown button of combobox (complex toolbar controller) must be clicked twice Change-Id: I16e1abb1846f2d7031fe940cc958396f66473ad6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92723 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23Resolves: tdf#132338 combobox 1 character narrower than it used to beCaolán McNamara
Change-Id: I9b24c654a9d209c5d52eebf852b6dca436a782b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92742 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23Fix typoAndrea Gelmini
Change-Id: Id2b8dd8c1d465a438ce6dfc859b007c5bfd98c51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92080 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-23Fix typoAndrea Gelmini
Change-Id: I07f828e8a17de03cf15639df8afa0adf5dcaebba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92246 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-23Fix typosAndrea Gelmini
Change-Id: I6c9fe715c0d188d3970027fcb63c6c039c957fd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92733 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-23Removed duplicated includeAndrea Gelmini
Change-Id: I839d1414bfd4a6d75b1393f006e770c1c9775d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92560 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-23Fix typoAndrea Gelmini
Change-Id: Ia0097a974f5bb5f2bdf626845ae98d347f66fff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92745 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-23loplugin:makeshared in fpickerNoel Grandin
Change-Id: I121b6f6d2e7d3fa17caa4e3b3ac38eea0388507b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92747 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23loplugin:makeshared in linguisticNoel Grandin
Change-Id: Id852ace32903e8bae622be36a7318d0f4f201832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92749 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23Added parameter to FillPageGradient commandPranam Lashkari
Change-Id: Ife435fc25e8e3114e66461af22ac9e0ef8c9d011 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92235 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-23Added parameter to FillPageColor commandPranam Lashkari
Change-Id: I22943815b69eeb7628eb243e0dbc6c8e0ea3487e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92213 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-23resolved: Impress mobile Choosing a different type of shape fill crashesPranam Lashkari
Change-Id: Idd8dbba866b64089055880ffad9b5cbd9b12ca85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92688 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-04-23loplugin:makeshared in dbaccessNoel Grandin
Change-Id: If4208532d2905410a07b846afee46fba2fe1e549 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92748 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23tdf#131936 Correctly detect OOXML variant on importSamuel Mehrbrodt
Change-Id: I29a6b0454bf741ce8ad49078597b3412a83dedb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92278 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-23Sidebar line alignment updateandreas kainz
Change-Id: Icfe5a6337ca4510ea6aaa44823ef623ce6860c18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92663 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-23sd position ad size dialog updateandreas kainz
Change-Id: I7bbfa7999d5b10db48d2c6aa6d66dc04c3891f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92630 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-04-23Add config to disable individual infobarsSamuel Mehrbrodt
In some deployments users want to disable certain infobars to not interfere with their workflows. Also, there are individual users who want to disable certain infobars for various reasons. This could be a generic config setting where you can set a list of Infobar IDs which should be disabled. That however would require knowledge about the internal IDs which are not exposed (and might even change over time). So instead, add a config option for each known infobar where we suspect users might want to turn it off. This list might change over time. Change-Id: I13f0456435b59aafe929a46498de5a8847f138e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92638 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-23Mention that this is the "OOXML Transitional" export filterSamuel Mehrbrodt
Make it clear that this is not "OOXML Strict" Change-Id: I025e982c12e66a3088ce9ee093382df02a88ff9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92375 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-04-23tdf#132278 crash after opening an old fileNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: I7a37631094b91f4859326db054f285daa8dccbb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-23tdf#130058 Import shadow size.Gülşah Köse
Change-Id: Ie1cee377a33567088fb76ea47f0e6fc51d47f0fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92188 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-04-23fix assert in empty complextoolbarcontrols combobox sdk example addonCaolán McNamara
Change-Id: Icf73bb97aa98430c9380e500574b93f248749c62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>