summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-07loplugin:countusersofdefaultparams in basctl..basegfxNoel Grandin
Change-Id: I515acfb9de1f6dff1de94a60055c5b600e5e5241 Reviewed-on: https://gerrit.libreoffice.org/45957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:countusersofdefaultparams in comphelperNoel Grandin
Change-Id: Idb704adbe78a42bf2f2aaf7f6110698d5559e836 Reviewed-on: https://gerrit.libreoffice.org/45936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:countusersofdefaultparams in connectivityNoel Grandin
Change-Id: Ia613257f2de1395c6629c1c37026ed48d4b927c8 Reviewed-on: https://gerrit.libreoffice.org/45854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07tdf#45904 Move _XDataPilotTablesSupplier Java test to C++Jens Carl
Change-Id: Iaea5b7abc0a289035c7a230c0034d2422cc4ae5f Reviewed-on: https://gerrit.libreoffice.org/46001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-07Check if we have status indicatorMike Kaganski
In other methods it's always checked, so presumably it might be absent. In caller sites (like OOXMLFastContextHandler::endOfParagraph), it can't (and shouldn't) be checked. Change-Id: Ia2edf8b121cac15e6454bc6321d76517fcdf110f Reviewed-on: https://gerrit.libreoffice.org/45951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-07tdf#97648 ooxmlimport: horizontal lines have no marginsJustin Luth
Change-Id: I170ab7a742f8e9d8029512592abda9fc54edda18 Reviewed-on: https://gerrit.libreoffice.org/42437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-12-07Use return iterator from erase in swnewtable (sw)Julien Nabet
Change-Id: I748ebeeef41a102feb63c304d4fae64775a3c8e2 Reviewed-on: https://gerrit.libreoffice.org/45998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-07Revert "ofz#4548 infinite regress in GetUsePrinterSettings"Thorsten Behrens
This breaks a unit test: filters-test.cxx:145:Assertion Test name: (anonymous namespace)::LotusWordProTest::test equality assertion failed - Expected: 1 - Actual : 0 This reverts commit d38674f3b5b6c97be5f8822f52301e29d677ed1e.
2017-12-07sc: don't crash on loading commentsThorsten Behrens
Seems filters call ShowNote before a view is set or something. Fixup for 25555c50ad2a57c1b2313f39b8132ac5e80a45fd. Change-Id: I9a69bf28b17cb16df7f1b1d06d9d3168da4a34b5 Reviewed-on: https://gerrit.libreoffice.org/46000 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06ofz#4548 infinite regress in GetUsePrinterSettingsCaolán McNamara
Change-Id: Iebd51c8724eebb942af45f3be24718a7a1278183 Reviewed-on: https://gerrit.libreoffice.org/45991 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06tdf#114122 - Double click in special character dialog inserts a characterMark Vecsernyes
Change-Id: I8f8db851363344091294e2af43aba289ac160d98 Reviewed-on: https://gerrit.libreoffice.org/45952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-06Function LookupAccountSidW takes number of characters, not bytesMike Kaganski
Change-Id: Ie01feea2c5025f64a7888b85cb5de0c8f6c6f5c2 Reviewed-on: https://gerrit.libreoffice.org/45955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-06table of objects crashes on first update with object in documentCaolán McNamara
Change-Id: Ia25a09060f16e5d286dff2bbc3facba5ac68cdc4 Reviewed-on: https://gerrit.libreoffice.org/45971 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06iOS, update to xcode 9.2jan Iversen
Change-Id: Id7962a0e40d2341fbe5f702399478f926c0ef5bf
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06Handle conversion from glibc locale to BCP 47 language tagEike Rathke
The backend's ImplGetLocale() didn't handle variants, so ca_ES@valencia ended up as ca-ES instead of ca-ES-valencia, which made a difference with for example the UI language being set to Default resulting in only ca instead of ca-valencia, which then is also written to /org.openoffice.Setup/L10N/ooLocale during startup and obtained later. This only for the *iX branch, no idea if and what could be adjusted for Windows or MacOSX. Change-Id: I050f6f643571ccdc669fb91b06f3bb516f96e8d5 Reviewed-on: https://gerrit.libreoffice.org/45946 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-06Prevent out-of-bounds access, tdf#114228 relatedEike Rathke
Such document access should be validated, specifically if it's called from accessibility. Change-Id: I67fa14c7fb1bf3885fc009428b981149f3f448fb Reviewed-on: https://gerrit.libreoffice.org/45978 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-06tdf#114228: fix crash when deleting sheet in specific caseJulien Nabet
1. Create a brand new ods file 2. Select L12 (so cursor is obviously on sheet1 L12) 3. Create a brand new sheet (and cursor is on sheet2 A1) 4. Delete sheet2 It crashes with gtk3, see https://bugs.documentfoundation.org/attachment.cgi?id=138199 As indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=114228#c5 the tab number is wrong Reporting cursor management later in ScTabView::SetTabNo prevents from the crash Change-Id: Iea307267d2cdcf1c01f7e72f45b6a68aeef26fa1 Reviewed-on: https://gerrit.libreoffice.org/45911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-06tdf#114262 Respect text+image toolbar styleMaxim Monastirsky
Regression of 67c9d054517fc3b5cbc203c330eedef4b50f0e57 ("fdo#84938: replace TIB_ constants with enum"). Change-Id: Ib90473a80fd491f4a136b4e76864c107a9240990 Reviewed-on: https://gerrit.libreoffice.org/45920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-06Updated coreShinnok
Project: help fb2f695bb4ad8ed6a9eeef0e155526df169796f3 Add option to build en-US too. This case required manual copy of the xhp's and tree. Change-Id: Ibde9e0e70f9d27735cc0b89bab8eeb34d17c5fdc Reviewed-on: https://gerrit.libreoffice.org/45968 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-06ofz: reset sPush and sMainTerm once 'popped'Caolán McNamara
Change-Id: Ib63dd132cb2055b76492f5d53e45c2a86dd8a131 Reviewed-on: https://gerrit.libreoffice.org/45940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06ofz#4539 depth protect mathtype parserCaolán McNamara
Change-Id: I46e12f52d56e7802b676309207904b4d1894d236 Reviewed-on: https://gerrit.libreoffice.org/45928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06tdf#114207 create commands for slide number and slide fieldsYousuf Philips
Change-Id: I5b7cfaf602568d9254dfeafd6afe27b9b0895d37 Reviewed-on: https://gerrit.libreoffice.org/45722 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-06tdf#113343 Floating charmap window must not have a context menuHeiko Tietze
Change-Id: I76c567047b0033ae766ab6c5161c96416e478e8e Reviewed-on: https://gerrit.libreoffice.org/45475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-06xmlsecurity: fix loplugin:salcall warningsMiklos Vajna
Change-Id: Ic2df4e402ce1e855fbf9d9f6d8a37e664d0110c7
2017-12-06tdf#37697 Use object alignment buttons rather than text alignmentYousuf Philips
Change-Id: Ia100a29aefaca81c5282f8077feb319f9d1809cb Reviewed-on: https://gerrit.libreoffice.org/45850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2017-12-06ofz: oom, variation 0 and 1 have one argumentCaolán McNamara
while variation 2 has two arguments Change-Id: Ia2a9bd5e33b589b6e002da78d1a5b45d703565ef Reviewed-on: https://gerrit.libreoffice.org/45926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06Use proper language fallback chain to find installed helpEike Rathke
The previous code first tried the full tag and if not successful a tag up to the first hyphen, which so far was the same as the fallback chain but may differ for more sophisticated language tags in the future. Change-Id: I01dd8618c77c30e92a5fef6d01d0da56f70353f1
2017-12-06tdf#114093 fixing regression when clicking on fieldsBernhard Widl
Change-Id: I6e5c7e644f26ca85a6c55ec5456add46a7b05404 Reviewed-on: https://gerrit.libreoffice.org/45927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06tdf#101014 Keyboard between textboxes - part 2Marina Latini
Fixed the a11y issue in layout AUTOLAYOUT_TITLE_2CONTENT_CONTENT now the selection via keyboard works as requested Change-Id: I034776393c8cca68d5cb3702f12111a057d4134b Reviewed-on: https://gerrit.libreoffice.org/45907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06tdf#109340 Improve performance by reducing matrix multiplicationBartosz Kosiorek
Multiplication of two B2DHomMatrix with operator* is very CPU expensive, because 24 of double-precision floating point multiplication needs to be performed. With this patch I have reduced Multiplication of matrix, by creating combined Scale and Transform matrix at once. It allows to reduce matrix multiplication by one, and improve import time. Change-Id: I85fde6354e458659a0214514c6e05b8e2ee04185 Reviewed-on: https://gerrit.libreoffice.org/45704 Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06unotools: remove not needed UcbStreamHelper inheritanceMiklos Vajna
This class only has static member functions, nothing requires that inheritance. Change-Id: I31db802d0a9dcda01772b1e09a68af770868358d Reviewed-on: https://gerrit.libreoffice.org/45924 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-06Updated coreShinnok
Project: help c09e0355995d329cbd0c60ff7e6008c0f06b45df Merge makelocal and makeonline into single script. Scripts were identical; only difference is whether we pass local yes/no to get_html.sh. Choice is now expressed via first param to makehelp.sh; build local is default. Change-Id: Icbe274fe6d9aeb86c7950aa69daf574e271e3b84 Reviewed-on: https://gerrit.libreoffice.org/45943 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-06Updated coreOlivier Hallot
Project: help 0b1c7e3c53f36b36f304270fd7aa455321dfd8fe tdf#83269 Help page for Calc Data->Form... Change-Id: If182e61aec29a912faa7af8e3d0791d03fcf1aca Reviewed-on: https://gerrit.libreoffice.org/45937 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-06Updated coreOlivier Hallot
Project: help 9891e96d1d95c1921cba16c6339c15cf3613da0d tdf#84675 Undocumented VBA function: MonthName Change-Id: I3fa5e80dd94c281bdfd6e076f55e172c52be9ecb Reviewed-on: https://gerrit.libreoffice.org/45757 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-06assert on export of fdo69698-1.ods to pdfCaolán McNamara
since... commit 3af8a4faf5e20ccae2386052697713da160afb16 Date: Wed Nov 15 13:10:40 2017 +0300 tdf#113861: Less aggressive expansion of chart headers. In this example nAllColCount is 3, nAllRowCount is 5, the columns available are 0, 1, 4 and the rows are 20, 21, 22, 25, 26. So I assume, comparing to the original version, that its not the actual row and column we want, but the index of the row/column into the range provided Change-Id: I568c561a8c5f0b2ee84590293bed8e302d5dda75 Reviewed-on: https://gerrit.libreoffice.org/45811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06lokdialog: Show/Hide floating window on StateChangedType::VisiblePranav Kant
In the earlier approach, other state change events like SetText are emitted which ends up in "else if !IsVisible()" block and tries to close the floating window before it's even registered. Interestingly, this is not the case every time. Anyhow, better safe than sorry. Guard the floating window 'created', 'close' callbacks in a StateChangeType::Visible event. Change-Id: Ib997e11fd4a0f50b8911e9891918112e8ff8ef85
2017-12-06lokdialog: State change events for dialogs uno commandsPranav Kant
Change-Id: I92f60e717cd2a0695c8b86b103076d26c0c22cef
2017-12-06Restore GPG SEInitializer serviceKatarina Behrens
user config now needs it to collect user's private GPG keys Change-Id: Ia4ad4133b621160cf37281750cafa9f3c5c3c231 Reviewed-on: https://gerrit.libreoffice.org/45562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-06Fix indentationSamuel Mehrbrodt
Change-Id: I53a967ab6ad5a6ed89dc807120dd1db540b26a92 Reviewed-on: https://gerrit.libreoffice.org/45894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-06Document SAL_RTL_ENABLED env varSamuel Mehrbrodt
Change-Id: I6242f6028daaa0eb4d14134658e2eb50fd8f8275 Reviewed-on: https://gerrit.libreoffice.org/45932 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-06lokdialog: Window* -> VclPtr<Window>, and a small simplification.Jan Holesovsky
Change-Id: I853e2d6ec2e55c78894a9942aa201763a57fe195 Reviewed-on: https://gerrit.libreoffice.org/45900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-12-06VBA test - iserror function test repair, tdf#114232Zdeněk Crhonek
Change-Id: I924713f360a41fa5b269468fdf771df6a50df44b Reviewed-on: https://gerrit.libreoffice.org/45923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-12-06tdf#114219: Show Edit dialog entry in link sectionXisco Fauli
Change-Id: I35c34d427cc5440994fc16ed7e4d307bc95bc533 Reviewed-on: https://gerrit.libreoffice.org/45817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Gülşah Köse <gulsah.1004@gmail.com>
2017-12-06Better heuristic to only look through implicit copy/move ctorsStephan Bergmann
At least recent libc++ has a std::string ctor overload without a (defaulted) Allocator argument (which otherwise causes creation of a temporary Allocator object and thus a ExprWithCleanups), so in C++17 mode (i.e., with no implicit move CXXConstructExpr -> MaterializeTemporaryExpr -> CXXBindTemporaryExpr chain in the way) CellInfo::toString (sw/source/filter/ww8/WW8TableInfo.cxx) has a ReturnStmt of just > ReturnStmt > `-ImplicitCastExpr 'std::string':'class std::__1::basic_string<char>' <ConstructorConversion> > `-CXXConstructExpr 'std::string':'class std::__1::basic_string<char>' 'void (const char *)' > `-ImplicitCastExpr 'const char *' <NoOp> > `-ImplicitCastExpr 'char *' <ArrayToPointerDecay> > `-DeclRefExpr 'char [256]' lvalue Var 'sBuffer' 'char [256]' that erroneously triggered loplugin:passstuffbyref. Change-Id: I53c8911cb1356560692c003808280a103c399e25 Reviewed-on: https://gerrit.libreoffice.org/45916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06drop clew and opencl for fuzzingCaolán McNamara
Change-Id: I7b09fb91f3d0d77851a84a015fc3e2fedc0153c7
2017-12-06loplugin:countusersofdefaultparams in cuiNoel Grandin
Change-Id: Id3258a664c2ea740419331877f7ce6af5e2559e7 Reviewed-on: https://gerrit.libreoffice.org/45922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-06basic: SfxLibraryContainer: replace maMutexMichael Stahl
... with cppu::BaseMutex, because a member cannot ensure the life cycle guarantees expected by WeakComponentImplHelper. Change-Id: Iaa10c699abf69882d917487740db241ba1455e1c
2017-12-06Related: tdf#105998 except cut and paste as bitmap instead of exportCaolán McNamara
Take a drawing rectangle in draw and cut and paste as bitmap to writer. The hairline border along the very right/bottom edge of the bitmap appear missing. fallback to default handlers which can distort the hairline to be visible Change-Id: Iedb580f65879628839c83e41092745ae7c11267c Reviewed-on: https://gerrit.libreoffice.org/45902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-06coverity#1421089 seems to be really reporting missing move ctors/assignmentsCaolán McNamara
Change-Id: I434eebac395bbb53a0c586a43568f64ec3fb8448
generated by cgit (git 2.34.1) at 2025-01-01 09:59:20 +0000