summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-26gtk[3|4] gtk_widget_get_root returns null when no rootCaolán McNamara
unlike gtk_widget_get_toplevel which returns itself if that is the case Change-Id: If977440265bd8ae2c892ee5d52091ebf16ad03cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: add parent-less widgets to default containerCaolán McNamara
Change-Id: Ia0c06db5a4f1c4ce453c424835d032ebb021f40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116217 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: wrap gtk_buildable_set_name/GtkBuildableIface::set_idCaolán McNamara
Change-Id: Ia19179bc5879218495184dcec80fd96eb375bc00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116209 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: wrap gtk_buildable_get_name/gtk_buildable_get_buildable_idCaolán McNamara
Change-Id: Iadafc7a7b4eb49bd15c22f006955003554cd7079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116208 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26configure: Remove kde5 compatibility optionJan-Marek Glogowski
Change-Id: Idce493e5f5ac045f7e977b4073152c2fe2668b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116111 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-05-26tdf#126541 XLSX import: fix View grid linesAttila Szűcs
It was not possible to enable the disabled grid with View->View grid lines, as intended, because document-level grid visibility was set to the visibility of the actual sheet's grid (which already imported correctly) instead of keeping its default true value. Note: document-level or global grid visibility is unknown for XLSX, but handled by Writer/ODS, see Tools->Options->Calc->View->Grid lines. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Iccab3e2b9f617cdcd678071f73c7c2d6db0bc161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116096 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-26log what page id is missing if this happensCaolán McNamara
Change-Id: Ie279350446ef1892d5bb145e58b9f0d9dba683f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116206 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: "focus" signal is goneCaolán McNamara
its not clear yet if there's another way to do what we want here Change-Id: Id9e54a481ac33038d605b0488315e73fd5b5a310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: reenable NotebookCaolán McNamara
Change-Id: I5342e5ef35f9d270d8ac51c3d696beddc8b67529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26comphelper: fix the "console" use-case of ProfileZoneMiklos Vajna
m_nCreateTime was changed to NS, nEndTime was still MS, comparing the two is not a great idea. Change-Id: I102990838d1e3d543a356b5ad2d3f68ce1d20623 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116210 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-26sw XHTML / reqif export, RTF markup of images: write WMF in \pictMiklos Vajna
Some consumers (e.g. IBM Doors) can only consume the RTF snippet if it's an OLE object and can't deal with plain images. Wrap \pict inside \object and unconditionally use WMF as the RTF-level preview format. The actual \objdata is not yet written. Change-Id: I203fcd8709b25a4dd543047bd804af8181df9940 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116207 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-26don't need always-show-image if there's just an image and no textCaolán McNamara
Change-Id: Ic3a1aad525af39b723e71f579fba40157cb15ac7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: restore ContainerCaolán McNamara
Change-Id: Ide82777fadbee2c644c3a19d418c3683f6ff2c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: strip GtkLinkButton xalignCaolán McNamara
Change-Id: I44065da82f577e226ee1c52f858917a1d825d9ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116200 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26tdf137314 Add margin to CppunitTest assertionsJan-Marek Glogowski
The test had multiple failures on Windows with: oox/qa/unit/vml.cxx(79) : error : Assertion Test name: tdf137314_vml_rotation_unit_fd::TestBody equality assertion failed - Expected: 1490 - Actual : 1491 So add a 1px margin to all value checks. Change-Id: I70298db253299a57cc37eed482c0816d902fbeab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116192 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-26tdf#142467 crash on calling 'getInfoHelper' in final classCaolán McNamara
IPropertyArrayHelper & rInfo = getInfoHelper(); crashes when CandleStickChartType is final for unknown reasons. I see this with gcc-11.1.1-1.fc34.x86_64 in 7-1 locally but also in the fedora libreoffice-7.0.6 built with gcc-10 so this isn't a recent problem. #1 0x00007ffff6f4fe91 in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=this@entry=0x5bdd588, nHandle=nHandle@entry=3) at cppuhelper/source/propshlp.cxx:549 #2 0x00007fffad45e9ff in chart::CandleStickChartType::getSupportedMandatoryRoles() (this=0x5bdd520) at chart2/source/model/template/CandleStickChartType.cxx:219 Change-Id: Ia029162587da1fc00df32866863deb186c7e11bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26tdf#100122: svl_qa_cppunit: Add unittestXisco Fauli
Change-Id: Ie0a7ea6ae08ea96b04019148f80ee94ef22ef1bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116187 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-26tdf#52510: svl_qa_cppunit: Add unittestXisco Fauli
Change-Id: I18a7000104add044ba59381c201cb5aff9fb459d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116184 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-26fix another leak in SwInsTableDlgNoel Grandin
Change-Id: I743a3231ef62e30242e54315bc3d3183f691f13d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix callgrind job by providing dummy privacy-urlChristian Lohmaier
Change-Id: I786c14c19f1ac74e424be869771440c55be08877
2021-05-26Refactor module media item handlingJan-Marek Glogowski
Move common functionality into svx::MediaShellHelpers. Change-Id: I6f5db59bdcff7cad00a64e76f6aad7b8ecb4ffa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116126 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26loplugin:includeform (clang-cl)Jan-Marek Glogowski
Change-Id: I12632b72c8e4e95bef24c8c26bee5887f9695d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116143 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26fix leak in SvxConfigPageNoel Grandin
Change-Id: I6b95d33cfbad455692c8047968a2581fe4610260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in SfxAutoRedactDialogNoel Grandin
Change-Id: I5ebfe5eba77de3380e991ced26f396821613b7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in SwInsTableDlgNoel Grandin
Change-Id: I1d4b4f5098eeec7b0042f3ffd457566ecb3e31de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26gtk4: convert old default invisibility to explicit invisibilityCaolán McNamara
Change-Id: I7aeab1a0857ffdf3990ecf69f5de1f6041fa562e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: reenable TreeViewCaolán McNamara
Change-Id: I9797e789b9af1985b1a78e00e68a23b7fd048d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116175 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26tdf#139915 DOCX import: fix anchored obj position with to-char and TEXT_LINEMiklos Vajna
There were multiple problems here: - commit 8f1a1092d47947847e1d888b0284e8364c663d1f (tdf#97371 DOCX import: fix text covered by shape, 2016-01-28) disabled to-char anchoring for TEXT_LINE (e.g. "alignment top, relative to line") because changing the anchor type of a TextBox could not be changed, but this has been implemented in sw/ in the meantime, so it can be dropped - Now that the anchor type is to-char, we can set the vertical relation to TEXT_LINE, but Word's positive value is "below line", and ours mean "towards the top of the page, from the bottom of the line", so we need to drop the workaround of commit 3303a4c5f21874453e634d84408c50e7a0055a4d (tdf#135153 DOCX import: avoid line-of-text relation with to-para anchoring, 2021-01-18) Once these are in place, we can fix the remaining problem by inverting the vertical position of the shape, which instantly fixes the overlapping textboxes in the bugdoc. Change-Id: I895abb76d3bd3bbe3a84e5c27a77df722b96226a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116182 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-26Fix documentation commentStephan Bergmann
Change-Id: If62135c82d8ab8faba0681302accf8f328e2eb3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116148 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-26fix leak in SvxLineTabDialogNoel Grandin
Change-Id: I4cbf0990fcc8db63f1160f1997d425c5681c47c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116150 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in ScAcceptChgDlgNoel Grandin
Change-Id: I51636d04389c8493377fe906314ef5d8f5c372d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix also the Win64 tinderboxesChristian Lohmaier
they were using manual configuration instead of the distro-configs Change-Id: I82a690986e24e704c66297c9bc4c3d3d1e70b636
2021-05-26Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 96e26682870d3032dc0cccc6ed0a580f22111998 - Fix SF_UI ShowProgressBar description Change-Id: Ib8b0b89511c1bb04acb7e79064ae5c9d8678b71d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115970 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-05-26gtk4: GtkSpinButton has a GtkText not a GtkEntry nowCaolán McNamara
so can't call gtk_entry_set_icon_from_icon_name on it Change-Id: I596a37ec935240b9ed92361e428e398010911b28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26fix leak in BuildMultiPortionNoel Grandin
Change-Id: I267d59bdc8ac2f17d223d0345c4bcb4ea40a8704 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116149 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak of SwCompareLine in CompareDataNoel Grandin
(*) store the SwCompareLine as a vector, SwCompareLine contains a single pointer, no need to allocate separately on heap (*) which means we need to convert SwCompareLine::m_rNode to m_pNode in order that SwCompareLine can have an assignment operator Change-Id: Idafba6f6384f36c9d048169e793db2d50c6d8bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116151 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in SwRedlineAcceptDlgNoel Grandin
Change-Id: I905d394db9339efda77e4f014e795c4f2d5f4584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26configure: merge extra test for $enable_cupsJan-Marek Glogowski
Change-Id: Ic98a6db70355aa24e29590bb9cb1416c15852090 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116144 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26tdf#96061 Unset the highlight propertyGülşah Köse
When we have highlight property on specific part of the text the following texts were highligthing. To prevent this we unset the highlight property when we have not highlight property anymore. Change-Id: I802cde1c784afe47201a9ba4f41827dd0c705035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115800 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-26Fix DISABLE_DYNLOADING unused variableJan-Marek Glogowski
Change-Id: Ie8305364971f324bd834ae6bec851637ca60b9e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26supress leak checking in JavaVMNoel Grandin
Change-Id: I82cb41518524949bbd578778724b92d9ebcecad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116139 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26ofz#34602 missing a componentCaolán McNamara
Change-Id: Ib2f281579af58f536f1291866c9990e8fc9e8cef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116146 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: reenable ImageCaolán McNamara
this is possibly wrong wrt scaling/hidpi, something of a stopgap for now anyway I feel Change-Id: Ia0e4bbdf760d7577c304f489795005f7252eb57b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116131 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26fix jenkins tinderboxes config after 15ab55c092e0b474827abe104b73c5bfab6ef28cChristian Lohmaier
Change-Id: I108536fbcd557ed899e1b6fda2316c9d89249681
2021-05-26tdf#115088 convert UITest to CppunitTestMiklos Vajna
So that when it fails, it's easier to debug because it's in-process. Change-Id: Ia7d12291b25304967a22e546b12803864a713541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116127 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-26tdf#142231 sc odf: fix export of single date filter valueSzabolcs Toth
by export the sting value of the filter condition, if its filter by date. Change-Id: I537fbd43810c78c0834480c9f1a480481aedd742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115775 Tested-by: Balazs Varga <varga.balazs3@nisz.hu> Reviewed-by: Balazs Varga <varga.balazs3@nisz.hu>
2021-05-26Seperate SvxBackgroundColorItem from SvxColorItemGülşah Köse
SvxBackgroundColorItem derivated from SfxPoolItem instead of SvxColorItem. Casting is common usage to control if object is this or not. When we can cast SvxBackgroundColorItem to SvxColorItem we can not seperate them anymore. eg: Char color is a SvxColorItem and char background color is a SvxBackgroundColorItem. They can be hold together and we should understand they are different types. Change-Id: I7b1879a1b00de26c0b8a2d9f8d658aa3aef75ecb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116135 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-05-26Improve error diagnosticStephan Bergmann
Change-Id: I1d7b82da3d0597aa6c5ffb251b9ad08bf464d2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116136 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-26CoreToPixel should take a SwRect argumentNoel Grandin
Change-Id: Idbed2a8fc6b4bc289c3bb0e761931f0b3d672620 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26make SwRect(Rectangle) constructor explicitNoel Grandin
Change-Id: I715aa9499598c483ccf907f829c9ba3540edf216 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116120 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-01 20:19:06 +0000