summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-02-07ofz#55751 check that level is validCaolán McNamara
Change-Id: I971bdcc62fd3775f8f75bf69db41182afc4baefc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146595 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-07sw: document SwFootnoteFrameMiklos Vajna
Similar to the doc model, "footnote" actually means "footnote or endnote" in practice. Change-Id: I89a38ed91bbfb2e1948b5f4393d4929ecfd20e0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146594 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-06Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to b1149d14e24a6611d00ca13d0942d17d617c2620 - (Related tdf#153243) Update help page because of UI label change - update UI label - refactor page - rename German ID Change-Id: I9245d4f297cb3b6c890302b32419010a966c2646 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/146209 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-02-06Revert "optimize ConfigurationProperty::get()"Xisco Fauli
This reverts commit 7df433cdc33b4d6ba38eafad9282d015571433ef and its follow-ups: * b4b63d0c46979ad6b6aae5d6a4ea6672ea248e10 "try to fix some shutdown crashes" * 203ad037ccb9fdebffea4f622229ded90635eb8b "try to fix shutdown crashes in ConfigurationWrapper" since it introduced a crash starting with LibreOffice 7.4 See https://crashreport.libreoffice.org/stats/signature/void%20rtl::str::release%3C_rtl_uString%3E(_rtl_uString*) Later, it was reverted in libreoffice-7-4 branch with df79a29ea20fb698d650be45a48c607f54476dea "Revert "optimize ConfigurationProperty::get()" (7.4 only)" so the crash is no longer reported in that branch. OTOH, Noel tried to fix it in master/libreoffice-7-5 branches with the two commits mentioned above but the crash is still being reported in LibreOffice 7.5 After talking to him, he suggested to revert it all Finally, adapt code to make loplugin:stringviewparam happy with getPropertyValue Change-Id: Id9fa97d2a81a590e53abd027e978d2d6179222b8 Change-Id: Id2e3475c342770be5705a74b9c0b45f45d6be5ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-06ofz: bump sc-rtf and html max lengthsCaolán McNamara
Change-Id: Id2b97538dcc2919b2fb993e8494478a7a444a9a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146568 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-06Fix thinko when to sleepStephan Bergmann
<https://ci.libreoffice.org/job/lo_ubsan/2672/> still failed with the same symptoms that 09c3a0aa13e7c4719a73728c2f9ba1f66cea7572 "A better fix for the stale TreeListEntryUIObject issue" had been supposed to fix. And of course, it is the > xInsert.executeAction("CLICK", tuple()) calls that actually trigger m_aUpdateTimer.Start() in SwChildWinWrapper::ReInitDlg, while the upfront m_aUpdateTimer.SetTimeout(200) in the SwChildWinWrapper ctor by itself is not relevant for the point in time where the timer actually starts (and where the Python code thus has to start waiting, too). Change-Id: I2b4fe7dadd470c62e7d63594a76d258faeac5906 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146588 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-06tdf#147906 Use Math.hypot() for Pythagorean additionYomnasalama
Change-Id: I644947ca22f493bbc805c45334450db8d4b4808b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146137 Tested-by: Hossein <hossein@libreoffice.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2023-02-06Make LOKClipboard available to other modulesSzymon Kłos
LOKClipboard has higher level dependencies (sfx2) so it cannot be moved to the vcl where SystemClibpoard instance is created. - introduce new interface LokClipboard to differentiate from SystemClipboard so we can have vcl's and lok's implementations at the same time - publish LOKClipboard using new interface for other modules by adding component file in desktop module Thanks to that when code calls GetClipboard and we cannot get clipboard assigned to the vcl::Window* (for welded widgets) in GetSystemClipboard correct instance is returned (shared clipboard for current view) so we can access content which was copied before. Previously always a new instance was created (with empty content). test ScTiledRenderingTest::testPasteIntoWrapTextCell was broken add some content to clipboard to simulate more real case and test the content copied Change-Id: I23c0298960a710c498646493f33122b908864cba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126310 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131644 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135198 Tested-by: Jenkins
2023-02-06lok: send status for file export dialogsSzymon Kłos
Change-Id: I21530abc89808beb4c794f912e9453d8552c3b01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146006 Reviewed-by: Ashod Nakashian <ash@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146573 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-02-06tdf#152669 sw: fix missing table borders in the non-Word-table-cell caseMiklos Vajna
A 4x4 table had partially missing inner borders when the page's writing mode was set to vertical, for a newly created document. This went wrong with commit 526c8bdb54eff942d5213030d1455f97720a1ba7 (sw: fix too long inner borders intersecting with outer borders for Word cells, 2022-01-06), which forgot to make changes in SwTabFramePainter::Insert() conditional on bWordTableCell. Fix the problem by making the SwTabFramePainter::Insert() changes conditional, similar to how SwTabFramePainter::FindStylesForLine() already did this. Note how the DocumentSettingId::TABLE_ROW_KEEP compat setting is off for new documents. Change-Id: Ie29d1613251d869e7ae78ea7dab3e75f0e6de229 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146585 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-06lok: formulabar: fix URL fields selectionSzymon Kłos
field is calculated as 1 character by selection getter let's unfold fields and send real length Change-Id: I557f8785a4d2ee6a41c6c95f4551f5e104a58c02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146350 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146574 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-02-06jsdialog: weld all message boxesSzymon Kłos
This fixes regression from: commit 9785cebe4cfdc296143757da6098a74b0252c618 jsdialog: fix validation error dialog in Calc When inserting autofilter without header data - message box should appear Change-Id: Id5d26604a67f43700310cc0f51954b886c9de0f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146495 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146575 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-02-06sw: implement SwFrame::GetPrevFlyLeaf()Miklos Vajna
This is much easier than the "next" case, since here we can nullptr when there is no previous leaf instead of creating one. With this, if the MoveBwd() call in SwContentFrame::MakeAll() is disabled, some simple fly frame can be split across 2 pages if it's positioned in a way that the rectangle of the fly would not fit into the body frame without changing the position, in SW_FORCE_FLY_SPLIT=1 mode. Towards an initial layout for multi-page fly frames. Change-Id: I3b6ba85ad66117b5595a113d688e2fcb97bcf745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146571 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-06sw: prefix members of RangeBorderEnumWrapperMiklos Vajna
Seems this was the last unprefixed class in sw/. See tdf#94879 for motivation. Change-Id: I2adac7932b8a45f2b07f844e5c7bd06eb08a8618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146570 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-06Minor typo fixes and some additional informationTor Lillqvist
Change-Id: Ic0b76ca37dce37f88df62d80495e111c4d50818e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146572 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2023-02-05Related: tdf#150098 sc validation: allowing formulas for validity testBalazs Varga
Clean-up and a little optimization. Change-Id: Ib56d959188912f4b18acb5466ce55bc7b5b4ee4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146391 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-02-05osl::Mutex->std::mutex in sd::framework::FrameworkHelperNoel Grandin
Change-Id: I84d5eb29413b3242386f1ffb1beafa9622985ded Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146558 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-05osl::Mutex->std::atomic in sc::CSVFetchThreadNoel Grandin
Change-Id: I615be595b73f4d55f13f7245b06783f6af03d58a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-05osl::Mutex->std::atomic in sc::ReaderThreadNoel Grandin
Change-Id: I10296bb29fc59475f0e3b13c06da97e703485792 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146556 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-05tdf#143148 Use pragma once instead of include guardsGreg Kelesidis
Change-Id: Iaeabe4e21ffe407684a57e1988a836e7cf85b2a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146560 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-02-04ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: I97fb4edcad3a014b622f1a936adecd634121ad3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-04tdf#153341: try to parse alpha value when copying HTML textJulien Nabet
Change-Id: Ic7240358be19e73f3c3f021e0de9414e3e988aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146546 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-04ofz#55620 TimeoutCaolán McNamara
Change-Id: I3d18e67a39523e508475b5f8586d92373be4f8b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-04Resolves: tdf#153353 formula bar border area bg didn't change on theme changeCaolán McNamara
Change-Id: I720054d540a6352b8248aa59e231878c1832d998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-04vcl: fix online crash in vcl::Window::IsTracking()Aron Budea
Crashreport signature: program/libmergedlo.so vcl::Window::IsTracking() const vcl/source/window/window2.cxx:340 program/libmergedlo.so (anonymous namespace)::LOKPostAsyncEvent(void*, void*) sfx2/source/view/lokhelper.cxx:812 program/libmergedlo.so LokChartHelper::postMouseEvent(int, int, int, int, int, int, double, double) include/rtl/ref.hxx:128 program/libmergedlo.so SfxLokHelper::testInPlaceComponentMouseEventHit(SfxViewShell*, int, int, int, int, int, int, double, double, bool) sfx2/source/view/lokhelper.cxx:980 /program/libswlo.so SwXTextDocument::postMouseEvent(int, int, int, int, int, int) sw/source/uibase/uno/unotxdoc.cxx:3663 program/libmergedlo.so doc_postMouseEvent desktop/source/lib/init.cxx:4831 Change-Id: Iab7d24a901e57dc8af3fb2c77fbea3b4fdad9fb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146483 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146549 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-02-04fix online crash in WIndow::IsTrackingNoel Grandin
/opt/collaboraoffice/program/libmergedlo.so vcl::Window::IsTracking() const /home/collabora/jenkins/workspace/build_core_co-22.05_for_online_snapshot/vcl/source/window/window2.cxx:340 /opt/collaboraoffice/program/libmergedlo.so (anonymous namespace)::LOKPostAsyncEvent(void*, void*) /home/collabora/jenkins/workspace/build_core_co-22.05_for_online_snapshot/sfx2/source/view/lokhelper.cxx:812 /opt/collaboraoffice/program/libmergedlo.so LokChartHelper::postMouseEvent(int, int, int, int, int, int, double, double) /home/collabora/jenkins/workspace/build_core_co-22.05_for_online_snapshot/include/rtl/ref.hxx:128 Change-Id: I204bac7d8f595054abe9b6e8e631c02b26e20361 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146231 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146548 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-02-03tdf#153023 Disable Thousand separator for NatNum12Laurent Balland
Add some helper to get NatNum12 state Modify both Number format dialog and Sidebar Transform CAT_ defines in enum Change-Id: Iaa3127bf07223caac60e409306a1bee2edc37428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145513 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2023-02-03test/a11y: Remove declaration for undefined methodColomban Wendling
getStateName() has been removed and superseded by debugAccessibleStateSet() in 8d8e6c84e512c1a8b33aac75965b84481d1a1d13 but its declaration was still there. Change-Id: I3c7a9dc74b7230cde2fc61a86ca7659e35ba2bdf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-03Avoid UBMike Kaganski
as seen in https://ci.libreoffice.org/job/lo_ubsan/2671/ after commit 333183d9a72d1e2b7ae65145092efec5e357ad14 ("tdf#153304: Add undo entries and set modified in SwXFrame::setProperty*", 2023-02-02): [_RUN_____] testImagePropsCreateUndoAndModifyDoc::TestBody warn:sal.file:4195:4195:sal/osl/unx/file_misc.cxx:401: Invalid directory URL warn:basic:4195:4195:basic/source/uno/namecont.cxx:953: Cannot access extensions! warn:sal.file:4195:4195:sal/osl/unx/file_misc.cxx:401: Invalid directory URL warn:basic:4195:4195:basic/source/uno/namecont.cxx:953: Cannot access extensions! warn:legacy.osl:4195:4195:sw/source/core/text/porfly.cxx:198: CalcFlyPos: Not Found! warn:legacy.osl:4195:4195:sw/source/core/text/txtfrm.cxx:3092: Prepare: Why me? /include/o3tl/strong_int.hxx:143:40: runtime error: signed integer overflow: 2147483647 + 1 cannot be represented in type 'int' #0 0x7f79b14fee7a in o3tl::strong_int<int, Tag_TextFrameIndex> o3tl::operator+<int, Tag_TextFrameIndex>(o3tl::strong_int<int, Tag_TextFrameIndex> const&, o3tl::strong_int<int, Tag_TextFrameIndex> const&) /include/o3tl/strong_int.hxx:143:40 #1 0x7f79b553f7a5 in SwTextFrame::IsIdxInside(o3tl::strong_int<int, Tag_TextFrameIndex>, o3tl::strong_int<int, Tag_TextFrameIndex>) const /sw/source/core/text/txtfrm.cxx:1665:71 #2 0x7f79b559be6a in SwTextFrame::InvalidateRange(SwCharRange const&, long) /sw/source/core/text/txtfrm.cxx:1689:10 #3 0x7f79b5566a79 in SwTextFrame::Prepare(PrepareHint, void const*, bool) /sw/source/core/text/txtfrm.cxx:3093:17 #4 0x7f79b438c1b5 in SwFlyInContentFrame::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/flyincnt.cxx:137:28 #5 0x7f79b17c06e2 in SwModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:322:18 #6 0x7f79b17c09e5 in sw::BroadcastingModify::CallSwClientNotify(SfxHint const&) const /sw/source/core/attr/calbck.cxx:327:15 #7 0x7f79b17be1ef in SwModify::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:313:5 #8 0x7f79b1801e06 in SwFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/format.cxx:314:19 #9 0x7f79b414fa7c in SwFrameFormat::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/layout/atrfrm.cxx:2713:15 #10 0x7f79b17c0f13 in sw::ClientNotifyAttrChg(SwModify&, SwAttrSet const&, SwAttrSet&, SwAttrSet&) /sw/source/core/attr/calbck.cxx:336:13 #11 0x7f79b18090b5 in SwFormat::SetFormatAttr(SfxPoolItem const&) /sw/source/core/attr/format.cxx:520:13 #12 0x7f79b23c2e54 in SwDoc::SetFlyFrameAnchor(SwFrameFormat&, SfxItemSet&, bool) /sw/source/core/doc/docfly.cxx:326:13 #13 0x7f79b23cac22 in lcl_SetFlyFrameAttr(SwDoc&, signed char (SwDoc::*)(SwFrameFormat&, SfxItemSet&, bool), SwFrameFormat&, SfxItemSet&) /sw/source/core/doc/docfly.cxx:451:17 #14 0x7f79b23ca43d in SwDoc::SetFlyFrameAttr(SwFrameFormat&, SfxItemSet&) /sw/source/core/doc/docfly.cxx:560:23 #15 0x7f79b64818d2 in SwXFrame::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) /sw/source/core/unocore/unoframe.cxx:1921:36 #16 0x7f79d562de12 in testImagePropsCreateUndoAndModifyDoc::TestBody() /sw/qa/core/undo/undo.cxx:136:13 ... See https://gerrit.libreoffice.org/c/core/+/146484/7#message-8ce5de47f17cc701fc58b932e80b1de8469053bf Hope it makes sense. Change-Id: Id5c86ed4c093993557a24e00b3288ccdfa4de2ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146542 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-03Fix misuse of TagDecl::hasDefinitionStephan Bergmann
...that started to cause false > In file included from svl/source/items/itemiter.cxx:20: > include/svl/itemiter.hxx:25:1: error: SfxPoolItem subclass SfxPoolItem declares new fields, but does not override operator== [loplugin:sfxpoolitem] > class SfxPoolItem; > ^~~~~~~~~~~~~~~~~ etc. now as a side effect of <https://github.com/llvm/llvm-project/commit/b6121432da79c4b3d21f191864ff6c583e2e62eb> "[C++20] Fix a crash with modules." Change-Id: Ibbf7a7c840ecea2605d6ea76afd04a2c2720e54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146544 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-03Avoid clang-cl -Werror,-WparenthesesStephan Bergmann
(assuming 9274d41bd72c5310491d81c6d8d938e44ed9d223 "tdf#148085 get a more readable hyperlink color under windows dark mode" didn't introduce a = vs. == typo) Change-Id: Ifd72029836726a804bcb0e3b5441aa7943705a76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146543 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-03lok: fix query language statusHenry Castro
The Calc and Impress return language status as a SfxStringItem, but Writer is a SfxListStringItem. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I88f77288e422a8f80473f0e33257078cfaa704b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145675 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146479 Tested-by: Jenkins
2023-02-03lok: add function getDocLanguagesHenry Castro
If the spell checker is disabled to use a remote spelling feature, the getLanguages function is obsolete. In order to not break stable functions, introduce the getDocLanguages for the remote spelling feature. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ic210f31eddd3208b29d073ff35ba4fa2d98ea772 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145363 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit bb0c63cc73998a0f67ae4c3e59acea3827a6e11c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146399 Tested-by: Jenkins
2023-02-03Related tdf#153272: add some missing properties in SwSearchPropertiesJulien Nabet
RES_PARATR_ORPHANS RES_PARATR_WIDOWS Change-Id: Ied760289e1ef8d60602991e5cdc0c743a31fd236 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146435 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-03Fix typoAndrea Gelmini
Change-Id: I4b12b8a82ef88947e3ed27298dbbd3305a60717c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146541 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-03Fix typoAndrea Gelmini
Change-Id: I48064f95fec07b414bd2addf0d65e2066aa1b42b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146540 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-03tdf#56696 - Sort recent document list according to current LibO moduleAndreas Heinisch
Change-Id: I246dc9538e011b8981bea04963995559d2b43cc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146456 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-02-03sw: avoid unwanted initial content in split/follow fly framesMiklos Vajna
If the fly on the first gets split, SwFrame::GetNextFlyLeaf() will create a follow fly frame. Don't fill this one with content, we'll instead want to move some of the content of the master here. (Which is not yet working.) InsertCnt() is called *really* early, so we can't check if this frame has a master -- just pass a bool around instead. This fixes the unwanted first paragraph in the follow fly frame at least. (The one that fits the master already.) Towards an initial layout for multi-page fly frames. Change-Id: If364fdaf7595fbc5addbc6b3b3b0092e958c5380 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146539 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-02-03tdf#153078: Revert "tdf#141684 fix disappearance of icons in Groupedbar and ↵Xisco Fauli
Groupedbar compact UI" This reverts commit 801e6272dc299d4468ec094ce11b66494eb5018b. Revert it for now, until a better solution for tdf#141684 is found Change-Id: I6c9fd7fb12149b67fe572d64cf00e6a3ec98611f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146504 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-02-03Use raw string literal in opencl to keep PMD static analyser happyIlmari Lauhakangas
Change-Id: Ibf2bd12b79c6e7c7eae59fc516e75c1bda971a7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146502 Tested-by: Jenkins Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2023-02-03sw layout xml dump: extract SwTable::dumpAsXml() from SwTableNodeMiklos Vajna
The idea is that each class only dumps itself & what it owns, otherwise the same info is dumped multiple times. Change-Id: Ib21bd2d31aa0d70d58b2b8aa453e0ede788c7144 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146511 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-02-03tdf#153246 VML export write adj attribute for FontworkRegina Henschel
The fix for tdf#153296 has introduced correct shapetype markup for Fontwork shapes so that handles are moveable in Word. But the actual adjustment value of the handle was not exported. This patch adds the missing 'adj' attribute to the <v:shape> element. The fix is restricted to the preset Fontwork types because for other shapetypes the VML export is not yet suitable in regard to handles. Change-Id: I7ecda9e63d50ab7d8c1fda3e09f7383546ddaf5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146537 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-02-02capture output of package command and add to log on errorChristian Lohmaier
creating packages failed here and the logs aren't all that helpful without the output of the command that failed. Reason it failed was that macOS thought that a volume with the same name was already mounted (but that didn't show up in Finder). With the output of the command easy to solve by just rebooting to fix that bogus state, but with only "command failed" you question what is different about that specific language, why would packaging that single language fail, … Change-Id: I1f46263f9ec9c9374da5afaa58f6c9939b6a1488 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145239 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-02-02Update the reference rdbs to libreoffice-7.5.0.3Stephan Bergmann
.../master/instdir/sdk/bin/unoidl-read --published \ .../libreoffice-7.5.0.3/instdir/program/types.rdb \ >.../master/udkapi/type_reference/udkapi.idl .../master/instdir/sdk/bin/unoidl-read --published \ .../libreoffice-7.5.0.3/instdir/program/types.rdb \ .../libreoffice-7.5.0.3/instdir/program/types/offapi.rdb \ >.../master/offapi/type_reference/offapi.idl * plus manual fixup by re-applying offapi/type_reference/offapi.idl part of b706b04110d9305b319689a5577746fac3e0e4c3 "[API CHANGE] offapi: clean up these index services IDL files" Change-Id: I5ac92f36f3952d335822c487d81efd3e9f38cd8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146510 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-02Remove redundant attributes that were added to published XLinguPropertiesStephan Bergmann
...by 57d79744c77eef96b4c2bd3b16e0a04317ffcf9e "tdf#136306 offapi linguistic: add options to disable rule-based compounding". See <https://lists.freedesktop.org/archives/libreoffice/2023-January/089784.html> "Re: Request for [API CHANGE] in spell checking: add new options to disable rule-based compounding" for details. (And I want to get offapi/type_reference/offapi.idl back into a clean state before updating the reference rdbs, which I want to do now that LO 7.5.0 has been released, so I'm taking over here.) Change-Id: I75d0ccdfdf644421e22c95de5db3267e8872a09d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146505 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-02A better fix for the stale TreeListEntryUIObject issueStephan Bergmann
...that hits UITest_writer_tests7 UITEST_TEST_NAME=tdf135938.tdf135938.test_tdf135938_cross_reference_update as discussed in the commit message of 51a2e1a3963aae3228c9ddf78d0039c7c063393c "Let executeAction always ProcessEventsToIdle". And while that ProcessEventsToIdle may be a general UITest stability improvement, it turned out that it did not actually fix this test_tdf135938_cross_reference_update issue, which I still kept seeing occasionally with my local ASan/UBSan build. On closer inspection, it was the m_aUpdateTimer timer used by SwChildWinWrapper causing the issue, whose expiration is not forced by the added ProcessEventsToIdle. So lets add a hacky sleep to the Python test code, to hopefully make sure that the timer has expired, and any SvTreeListEntries are stable, by the time the Python code initiates the creation of any TreeListEntryUIObjects that reference those SvTreeListEntries. Change-Id: I9f3c7293d55dffdc910879142d471a299f60a8e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146508 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-02-02tdf#130782 tdf#153203 writerfilter,sw: DOCX import/export of a11yMichael Stahl
... related attributes name/title/description on Chart embedded objects. DomainMapper first needs to apply the properties to an SdrOLE2Obj, then later copy it to SwXEmbeddedObject. Change-Id: Id766be1eedf348caf22640ab6c177d81a0971749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146494 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-02tdf#153258 VML import improve WordArt detectionRegina Henschel
There exists WordArt types whose internal name do not start with 'fontwork', e.g. mso_sptTextDeflateInflateDeflate has 'mso-spt167'. The fix uses the MSO_SPT enum directly. Change-Id: Idb32b3ef9957bef5d948e1d86507d71fef006e91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146503 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2023-02-02tdf#153304: Add undo entries and set modified in SwXFrame::setProperty*Mike Kaganski
Similar to SwDoc::SetFlyFrameAttr; the latter should only set modified state on actual changes. Change-Id: I66982e68fa9132fda132d811f7a48b4461645df4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146484 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-02-02use mnemonic-widget instead of label-for+labelled-byCaolán McNamara
then the a11y relation is implied without the need for explicit extra annotation use more standard spacing values and spacing pattern too Change-Id: Ifeea7fbe89bc093aac1b9f16e49b80bfa6a9af9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-05 23:51:49 +0000