summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-21tdf#111894: fix leak memory with PaletteManager (take 2)Julien Nabet
Thanks to Maxim Monastirsky for the suggestion! Change-Id: I6ab799848f80f785fd24905c0a540885c41afb86 Reviewed-on: https://gerrit.libreoffice.org/42494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-21writerperfect: add initial UITest_writerperfect_epubexportMiklos Vajna
Fails when EPUBExportDialog::VersionSelectHdl() does not take the version from the VCL widget. Change-Id: I8f77643ffbd7766ecec7bc2e148259765ab635b8 Reviewed-on: https://gerrit.libreoffice.org/42600 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-21Map from GetLastError() to HRESULTStephan Bergmann
clang-cl reported "error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare]" Change-Id: I568f03bd863ba63e30143483d9573042f3506de7 Reviewed-on: https://gerrit.libreoffice.org/42597 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-21tdf#112501: Pivot table: popupbuttons are placed on wrong cellsTamás Zolnai
...imported from XLS Change-Id: I45bc4a0182e6a62471bc02ac1bca31f9735e6566 Reviewed-on: https://gerrit.libreoffice.org/42508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-21License date updateMarina Latini
Updated the copyright date from 2014 to 2017 Change-Id: I9d2e6502c97bfa732ab636c9d47221a55d3cde56 Reviewed-on: https://gerrit.libreoffice.org/42547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-09-21Related tdf#112423: avoid crash when calling procedure twice (dbaccess)Julien Nabet
Since SbaTableQueryBrowser::implSelect returns a bool to indicate if everything is ok, should return false when we entered in a catch Change-Id: I9ae3ff3bf082278edb16a9b91701d6cf457e7179 Reviewed-on: https://gerrit.libreoffice.org/42564 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-21Ignore AquaBlinker on Scheduler shutdownJan-Marek Glogowski
Change-Id: If107d2ac01b7be91be34ff753b52f307a6e10f58
2017-09-21More naming errors. There are no "Descriptions" in the SDBCX module,Damjan Jovanovic
there are only "Descriptors". Patch by: me (cherry picked from commit ccc4532f9ed95f4460941e2762ae3250d37805f5) Change-Id: Ifd4f34c7b1ba64b449222dc864a38df80f4c6727 Reviewed-on: https://gerrit.libreoffice.org/42535 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21ofz#3454 Floating-point-exceptionCaolán McNamara
Change-Id: I2432bff8e1c102b83f0b7aff1303a03539ce0350 Reviewed-on: https://gerrit.libreoffice.org/42580 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I8bdf8a4c04256ad665960dd6f0d71d032156a34b
2017-09-21loplugin:flatten in connectivity..desktopNoel Grandin
Change-Id: Iff59d3049ba40b4338ef8eec67d08a96b0834d2b Reviewed-on: https://gerrit.libreoffice.org/42578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21loplugin:flatten in editeng..extensionsNoel Grandin
Change-Id: I2b68f5640471ea827c09af1b5a319fb526a53b4b Reviewed-on: https://gerrit.libreoffice.org/42579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21loplugin:flatten in basctl..configmgrNoel Grandin
Change-Id: I674cad57ce30a885e126d3bcc921f8fcb53dc36d Reviewed-on: https://gerrit.libreoffice.org/42577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21More missing GetSelectEntryPos -> GetSelectedEntryPosStephan Bergmann
Change-Id: I89d1dfd2468691fce03a8525b3fa7209bf859293
2017-09-21ofz#3445 exception thrown through XMLImpRubyContext_Impl dtorCaolán McNamara
#0 in __cxa_throw () at /lib64/libstdc++.so.6 #1 in SwXFootnote::createTextCursorByRange(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (this=0xa21ef0, xTextPosition=uno::Reference to (SwXTextRange *) 0xa18cd8) at core/sw/source/core/unocore/unoftn.cxx:459 #2 in XMLImpRubyContext_Impl::~XMLImpRubyContext_Impl() (this=0xa18bf0, __in_chrg=<optimized out>) core/xmloff/source/text/txtparai.cxx:641 #3 in XMLImpRubyContext_Impl::~XMLImpRubyContext_Impl() (this=0xa18bf0, __in_chrg=<optimized out>) core/xmloff/source/text/txtparai.cxx:646 #4 in cppu::OWeakObject::release() (this=0xa18bf0) at core/cppuhelper/source/weak.cxx:232 Change-Id: I071dc65751724f96b2386dea4f26a6ef476f4ef6 Reviewed-on: https://gerrit.libreoffice.org/42551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21More missing GetSelectEntryPos -> GetSelectedEntryPosStephan Bergmann
Change-Id: I0c59eac4d0bca2d0a086b9e319dcb50bc6a15b8e
2017-09-21EPUB export: add uno command to bypass options dialogMiklos Vajna
Similarly how this is possible with PDF. The toolbar button is hidden by default in Writer, though. Change-Id: Iaf3b61ac2160578f7eaabd194ce8932792575c29 Reviewed-on: https://gerrit.libreoffice.org/42554 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-21bump hunspell to 1.6.2Caolán McNamara
Change-Id: I91d4d58f2b8ba69067de1d08476a8cebbb780535 Reviewed-on: https://gerrit.libreoffice.org/42555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21Updated coreOlivier Hallot
Project: help c25389900adcc9915010b1867aa37e691ea05a62 tdf#108090 Clarify array separators in help pages Change-Id: I60ddea24020d5775a373b1a06b1bdfa8f33d3c5d Reviewed-on: https://gerrit.libreoffice.org/42571 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-21Updated coreAdolfo Jayme Barrientos
Project: help aaf3eadc2accd171b57f13d013f9adf526651171 Helponline: Override the “normalizer” rule messing with line height Otherwise, the body text looks cramped. Change-Id: I4bf6a8b714a243c5de333f46c4249e1c51060f50 Reviewed-on: https://gerrit.libreoffice.org/42222 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-21Missing GetSelectEntryPos -> GetSelectedEntryPosStephan Bergmann
Change-Id: I353f64553ed5968e504d6f0c2a11131df8e2fc56
2017-09-21iOS, change bridges to 64bit and reducejan Iversen
Changed __i386 to not __arm64 iOS either compiles for arm64 (production) or x86_64 (simulator) add common parts to cpp2uno and uno2cpp Change-Id: I059f3cc23bb658d6d53dbf2bf4aa6634eeac9662
2017-09-21fix 'make solenv' test failure on clang-3.8Noel Grandin
clang-3.8 and clang trunk differ in how they represent ranged-for which leads to a test failure Change-Id: Ia8965802260fdc946d3a705c6fef82d98eeb8230
2017-09-21Fix creation of array cloneStephan Bergmann
The original code caused ClassCastException when the return value of toArray() was actually of type Object[] instead of Statement[]. Change-Id: I6cd451404b7bd22a9a0c3490b6982cc38e79d1b2
2017-09-21blank doesn't take any effect anymore. remove it from android's fonts.confChristian Lohmaier
Change-Id: I387ceac08ec5f78686cacd90f897c7c12758ae5d
2017-09-21Clean up construction of one non-ASCII-literal OUStringStephan Bergmann
...in preparation of a change coming there soon Change-Id: I8861dbd47d0e514cd1c5dc0bb978724ae687f01c
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Workaround static Task destruction errorJan-Marek Glogowski
A task has to get the SchedulerLock to remove itself from the Scheduler list. This doesn't work, if the Task is static, as the static Scheduler might be destroyed earlier. In this case we fail with the following backtrace: #0 SchedulerMutex::acquire #1 Task::~Task #2 __run_exit_handlers Thanks to Michael Stahl to catching this backtrace. As a workaround this marks static tasks, so they ignore the SchedulerMutex in the destructor, We also mark all scheduled Tasks as "static" in DeInitScheduler, as their cleanup was already done. In the end all Tasks should be removed from static objects. Change-Id: I38be3206378b9449193efaccbc96896ac8de9478 Reviewed-on: https://gerrit.libreoffice.org/42574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-21xmlsecurity: hold SignatureCreatorImpl by rtl::ReferenceMiklos Vajna
Not going via UNO means explicit interface casting can be avoided. Change-Id: I4fa2db810cade787913bca222530405d8d2eb6a9 Reviewed-on: https://gerrit.libreoffice.org/42573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-21attempt to fix android buildNoel Grandin
Change-Id: Ie3eede03b90db272d70e7cb383c7a69d9db0f2ae
2017-09-21nothing to see here, move alongCaolán McNamara
Change-Id: I1dc03bb80562c4234e8a44bca0253dd3041a5151
2017-09-21loplugin:unusedfields, fix var taking refNoel Grandin
Change-Id: I0ea1f0c7488c140fca9f64de326c6ac588ece925
2017-09-21Fix a typo in the XServiceInfo implementationDamjan Jovanovic
for main/connectivity/source/sdbcx/VIndexColumn.cxx. It's implementation/service names are com.sun.star.sdbcx.VIndexColumn and com.sun.star.sdbcx.IndexColumn, not com.sun.star.sdbcx.VIndex and com.sun.star.sdbcx.Index. Patch by: me (cherry picked from commit d2f0e14de2a52180ed84c0402e47a0de16589203) Change-Id: Ie8a8bead7f7b5dd2c655603a7355bc0b2678ef7e Reviewed-on: https://gerrit.libreoffice.org/42534 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21ofz#2881 avoid oomCaolán McNamara
Change-Id: I1fa816bac5563503b9a4cc142bf3ec5d35ef0fbd Reviewed-on: https://gerrit.libreoffice.org/42536 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21add fods fuzzerCaolán McNamara
Change-Id: I3cc5a0d8bb24dd33b63ed82866a4acfb7a2dd043 Reviewed-on: https://gerrit.libreoffice.org/42459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21ScXMLImport dtor deleted pSolarMutex before SvXMLImport dtor is calledCaolán McNamara
so if there are still ScXMLDatabaseRangesContext on the import stack, i.e. exception thrown during ScXMLDatabaseRanges import, then stuff crashes ================================================================= ==23249==ERROR: AddressSanitizer: heap-use-after-free READ of size 8 at 0x6020001c3190 thread T0 SolarMutexGuard::~SolarMutexGuard() /src/libreoffice/include/vcl/svapp.hxx:1420:9 ScXMLImport::UnlockSolarMutex() /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:1916:13 ScXMLDatabaseRangesContext::~ScXMLDatabaseRangesContext() /src/libreoffice/sc/source/filter/xml/xmldrani.cxx:64:19 ScXMLDatabaseRangesContext::~ScXMLDatabaseRangesContext() /src/libreoffice/sc/source/filter/xml/xmldrani.cxx:63:1 destroy /usr/local/bin/../include/c++/v1/memory:1838:64 __destroy<rtl::Reference<SvXMLImportContext> > /usr/local/bin/../include/c++/v1/memory:1706 destroy<rtl::Reference<SvXMLImportContext> > /usr/local/bin/../include/c++/v1/memory:1574 std::__1::deque<rtl::Reference<SvXMLImportContext>, std::__1::allocator<rtl::Reference<SvXMLImportContext> > >::pop_back() /usr/local/bin/../include/c++/v1/deque:2604 pop /usr/local/bin/../include/c++/v1/stack:212:19 SvXMLImport::~SvXMLImport() /src/libreoffice/xmloff/source/core/xmlimp.cxx:418 ScXMLImport::~ScXMLImport() /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:769:1 freed by thread T0 here: #0 0x6164a0 in operator delete(void*) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:126 #1 0x6254e3 in ScXMLImport::~ScXMLImport() /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:787:5 #2 0x6259cc in ScXMLImport::~ScXMLImport() /src/libreoffice/sc/source/filter/xml/xmlimprt.cxx:769:1 Change-Id: Ia72284f99e2e2efe4f1f9e57b1483c0f1333274d Reviewed-on: https://gerrit.libreoffice.org/42502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21restore zero init of mpGroupLevel membersCaolán McNamara
since... commit 19b34f615c04555f27978e2823ba735a9c9f882e Date: Fri Jul 7 15:58:40 2017 +0200 loplugin:useuniqueptr in filter originally - mpGroupLevel = new sal_uInt32[CGM_OUTACT_MAX_GROUP_LEVEL] (); and turn this into a tidy member init list Change-Id: Ic3f012b348cfa4f4f30da678fd6bfc172d22e693 Reviewed-on: https://gerrit.libreoffice.org/42465 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21ofz#2869 avoid oom with bmp rle imagesCaolán McNamara
and to the sanity checks on remaining data size *after* the seek to the offset, which requires moving the read of the palette to remain before that seek Change-Id: I687a79fb3f109556c1a7aaa9423f77a1eb98a3cf Reviewed-on: https://gerrit.libreoffice.org/42461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21TSCP: add advanced classification dialogTomaž Vajngerl
This adds a advanced classification dialog, which enables the user to manually construct a header/footer message from classification properties in cases where the user needs more control. All the text is inserted as fields into the end document and can be changed by changing the document properties. The simple classification still functions as it did before, which is what most users will want to use in this case. The BAF policy has been extended with new xml extension elements: - loext:Marking - loext:IntellectualPropertyPart - loext:IntellectualPropertyPartNumber They are used to fill the values in the advanced classification dialog. Change-Id: Ie2d638d69b8a9b0799cff9c2b785eb789f8af1d5 Reviewed-on: https://gerrit.libreoffice.org/42474 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-09-21lint-ui: Error when label contains a colonSamuel Mehrbrodt
Change-Id: I6c71db450fdd41c83e4b4b3e6dff9719a42ef2d8 Reviewed-on: https://gerrit.libreoffice.org/42520 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21WaE: -Wunused-variableTor Lillqvist
Change-Id: I6bcc39cd749f8cdbe550b94346c5cb8fd9f67097
2017-09-21update calc notebookbar styles drop down and context-EditCell fixandreas kainz
Change-Id: Iaa3242120f250fb75946c8c3c448364a54203db8 Reviewed-on: https://gerrit.libreoffice.org/42342 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-21tdf#105000, related tdf#80196: Make new color names translatableGabor Kelemen
by moving the percentage to the end of the color names. Otherwise the code handling these would need more complexity. Change-Id: I6d200f3b705606406ee7f00c71ecb3f0944d1223 Reviewed-on: https://gerrit.libreoffice.org/42570 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-21show icons in impress menubar -> viewandreas kainz
Change-Id: I2281df33c914094a797b9e2f05feab0adacc5724 Reviewed-on: https://gerrit.libreoffice.org/42506 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-09-21tdf#99784 OSX run GUI stuff in the main threadJan-Marek Glogowski
The extension manager starts dialogs from its own thread. But the OSX backend currently doesn't defer these calls to the main thread. This implements the deference by running the called function in the main thread, using a code ^Block, and returning the result via a SalYieldMutex member. Change-Id: Id8977991e3eda91da27c23d8021e028d4f4cefe5 Reviewed-on: https://gerrit.libreoffice.org/42448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-21clang-tidy modernize-use-equals-default in basctlJochen Nitschke
to find unneeded explicit defined or default able copy assignments and copy constructors. Remove the default destructor if it's not needed. Change-Id: I8c53a8622a53398889397132ec1f464e996ac49d Reviewed-on: https://gerrit.libreoffice.org/42525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21inline lcl_ObjConnected and lcl_InHeaderOrFooterBjoern Michaelsen
- lcl_ObjConnected repeatedly fetched an invariant: pRoot - lcl_InHeaderOrFooter just checked for FLY_AT_PAGE, which was never the case in the one client of the function Change-Id: I38aa54d3d51f7dcdee015588a9043824a7703c5c Reviewed-on: https://gerrit.libreoffice.org/42509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-20tdf#112005 xmloff: ODF export: export embedded object text *first*Michael Stahl
... before adding any attributes, so that the attributes don't erroneously get added to the paragraph element. Also fix the problem that if you set "ODF format version" to 1.1 or 1.2, export asserts in SvXMLNamespaceMap::GetQNameByKey() because the "loext" namespace isn't registered, and creates an invalid <p> element. Change-Id: I637f9d3ff746d877ced480e35ef53f4545a06a4b
2017-09-20Pass --with-macosx-version-min-required into external/curlStephan Bergmann
...which wants to take it from CFLAGS, otherwise defaults to 10.8 Change-Id: I1b086ee8abba1e4b46c67b6b4fe6a05c4ef7a3d8
generated by cgit (git 2.34.1) at 2025-02-05 21:13:59 +0000