summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-10loplugin:indentation in svtoolsNoel Grandin
Change-Id: I5535acdf828f78d69ba8f6b4c990f9139ed3319b Reviewed-on: https://gerrit.libreoffice.org/67566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-10loplugin:indentation in soltools..svlNoel Grandin
Change-Id: I270a12cdb68920b8fa23b82dd933724e30334485 Reviewed-on: https://gerrit.libreoffice.org/67565 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-10tdf#39593 use existing find() to reduce copypasteArkadiy Illarionov
Change-Id: Id6280424627a3bbcb484d61cee2f2003aa1ca9b6 Reviewed-on: https://gerrit.libreoffice.org/67604 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-10fix commentRene Engelhard
LDAP support is mainly for ldapbe (LDAP configuration backend), the libpq one is just a by-product... so "in Base" is wrong Change-Id: I342e579b5a832f6a4722499da3f0f1c35f4c0a5d
2019-02-10Fix typoAndrea Gelmini
Change-Id: Ibaf2bf3fe9bf45fbfc864399222e08761407564a Reviewed-on: https://gerrit.libreoffice.org/67598 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-10Make LDAP support optionalAndrew Udvare
Change-Id: Ifbd3903494a81e7b155bf6468f6ca2c50b3370a4 Reviewed-on: https://gerrit.libreoffice.org/65958 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-10KJ & elementary: Add missing format text in Draw, elementary: update shape ↵Rizal Muttaqin
manipulation etc Change-Id: I6f360477f9024dd0796b8a2b74185104f5d3c299 Reviewed-on: https://gerrit.libreoffice.org/67599 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-02-09loplugin:indentation in sfx2..slideshowNoel Grandin
Change-Id: I3bd23a8f6237d0887a4782b6179a413dd2f03e02 Reviewed-on: https://gerrit.libreoffice.org/67564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in sdNoel Grandin
Change-Id: I8ce307b8c467ac1e3f19faca1df15a079bc14169 Reviewed-on: https://gerrit.libreoffice.org/67563 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in scNoel Grandin
Change-Id: Ieafabbafde456edba5adbe1fd587c32f04aedb98 Reviewed-on: https://gerrit.libreoffice.org/67562 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09Simplify containers iterations in sc/qa/unitArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I07835481988be3b1524ece8320c3952179cf022f Reviewed-on: https://gerrit.libreoffice.org/67590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09Simplify containers iterations in sc/source/core/data/[b-d].cxxArkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: Ifb3c6a2fdcd32122a6fd371191b058117015c3ed Reviewed-on: https://gerrit.libreoffice.org/67588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09weld SvxSearchAttributeDialogCaolán McNamara
Change-Id: Ib929afd143cd02b49f87ae6d910500354197e826 Reviewed-on: https://gerrit.libreoffice.org/67572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-09weld SvxEditDictionaryDialogCaolán McNamara
Change-Id: Ia35ef42a570353e26a8969a322b04768a4ac042f Reviewed-on: https://gerrit.libreoffice.org/67553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-09loplugin:indentation in registry..saxNoel Grandin
Change-Id: I4b877751818febaec8e64018335dca691a476a43 Reviewed-on: https://gerrit.libreoffice.org/67561 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in oox..packageNoel Grandin
Change-Id: Ie50a1ad6e27786ccdaae2ba1ae96f5682c4a38f6 Reviewed-on: https://gerrit.libreoffice.org/67560 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in jvmfwk..lotuswordproNoel Grandin
Change-Id: I1af665f4c6d34d8514dd23bb7a3eba700ce3ddbc Reviewed-on: https://gerrit.libreoffice.org/67559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in helpcompiler..ioNoel Grandin
Change-Id: Ia3f05662cc9542feeac3096d29e9dec6d1858620 Reviewed-on: https://gerrit.libreoffice.org/67558 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in frameworkNoel Grandin
Change-Id: I9d0ef502eb812499b0372436083f673bb19ff578 Reviewed-on: https://gerrit.libreoffice.org/67557 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in forms..fpickerNoel Grandin
Change-Id: If01379c43519cc1dbcf8dfaefde545fbe7e24fc2 Reviewed-on: https://gerrit.libreoffice.org/67556 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09loplugin:indentation in filterNoel Grandin
Change-Id: If0574f34effb82bf718958692a44fd422b71abd4 Reviewed-on: https://gerrit.libreoffice.org/67555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-09move and extend primitive2dxmldump to drawinglayerTomaž Vajngerl
Also needs extending the XmlWriter to output double numbers as the attribute content. Change-Id: Ie749ea990d856c8c90092ed8153c24efda99c444 Reviewed-on: https://gerrit.libreoffice.org/67573 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-09Use PngImageReader for loading the icons from the icon-themesTomaž Vajngerl
Change-Id: Id48c7707fd6c0ef72a41b102048be5749d5c4858 Reviewed-on: https://gerrit.libreoffice.org/67578 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-09add PngImageFilter that uses libpng for PNG loadingTomaž Vajngerl
This adds loading of PNG images that uses libpng instead of our own solution. It always loaded the image as either RGB or RGBA image and if the source PNG is using something else, libpng converts to either RGB or RGBA. In addition this adds tests for loading of various PNG files to make sure the resulting bitmaps are using pixel data as expected. (especially needed to check the RGBA bitmaps) Change-Id: I194321caf76c2ec2365bb6075c79c5e84983658a Reviewed-on: https://gerrit.libreoffice.org/67571 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-09more terse string output for BitmapColorTomaž Vajngerl
Change-Id: Ia8ef9bcf10b2a2312f9f1c09afa8124a63822d1c Reviewed-on: https://gerrit.libreoffice.org/67570 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-09Fix typoAndrea Gelmini
Change-Id: I72fafb21ac51de7537622b5265af266073cdb293 Reviewed-on: https://gerrit.libreoffice.org/67576 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-09Resolves: tdf#123122 category is just one bit, date+time is two bits setEike Rathke
DATE|TIME != DATE ... Regression from commit e85966450b770e1169f113183ce1a9a9f4dcc507 CommitDate: Wed Oct 3 12:08:55 2018 +0200 Related: tdf#119613 tdf#118127 suppress duplicated builtins, rework All cat Change-Id: If500dbeae00805f04f61586730479901b27d3901 Reviewed-on: https://gerrit.libreoffice.org/67554 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-02-08remove obsolete image handling description from READMETomaž Vajngerl
Change-Id: I94023bc1a8eb1b6d31416292eccf220ba1c29efc Reviewed-on: https://gerrit.libreoffice.org/67569 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-08getToken+comparison+copy ==> startsWithMatteo Casalin
Change-Id: I3d243cecc21b0364b2ceac1f64cbfa1764c3ddf1 Reviewed-on: https://gerrit.libreoffice.org/66938 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08Avoid index for single getToken callMatteo Casalin
Change-Id: I4b7dfd024369258efb84ec8d1c1cd16f4a7aa730 Reviewed-on: https://gerrit.libreoffice.org/66944 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08Initialize some OUString with proper valueMatteo Casalin
Change-Id: I2f5676e9973d476aa709f9dfb4a903b09edaafeb Reviewed-on: https://gerrit.libreoffice.org/67336 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08Replace always true condition with a more likely oneMatteo Casalin
indexOf is always lower than string length since "not found" is encoded as -1. Original code works correctly anyway since the "not found" case lead to copying the whole string, although this copy is completely unnecessary. Change-Id: Ic5dd995dd0c3f974c77b5bf209ad5e994b044385 Reviewed-on: https://gerrit.libreoffice.org/67320 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08Use indexed getToken()Matteo Casalin
Change-Id: I3c1df346c56bfbd6e885b5ddb78ac3162a8bc32e Reviewed-on: https://gerrit.libreoffice.org/67327 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08Use indexed getToken()Matteo Casalin
Change-Id: I1fa06283b3c1857c81ec320b98db857a42e91bca Reviewed-on: https://gerrit.libreoffice.org/67333 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08Use indexed getToken()Matteo Casalin
Change-Id: I7ba78cc8ecf7d2ecface0e69dcacc9bae869c7e6 Reviewed-on: https://gerrit.libreoffice.org/67335 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08Use indexed getToken()Matteo Casalin
Change-Id: I8ab1c2956739c9b63de807176ca0e3a640d3961f Reviewed-on: https://gerrit.libreoffice.org/67325 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08uitest for sc Chart - format Data series dialogZdeněk Crhonek
Change-Id: I94ff22fa79c3b147bb4ea6e1976e79c08527cc39 Reviewed-on: https://gerrit.libreoffice.org/67549 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-02-08tdf#120703 PVS: fix conditionMike Kaganski
V560 A part of conditional expression is always false: nY == nStartRow. Change-Id: I2d1a809400d48889780ce320be740648f8d9b97f Reviewed-on: https://gerrit.libreoffice.org/67541 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-02-08The gcc3_linux_aarch64 bridge needs to call __cxa_current_exception_type, tooStephan Bergmann
...or else mapException would extract garbage from the fake exception->exceptionType std::type_info* when catching via cppu::getCaughtException the rethrown exception thrown via std::rethrow_exception in Test::testgetCaughtException in cppuhelper/qa/misc/test_misc.cxx. 6ddecf61ecada646fbd6f8809270d47289727e8a "fillUnoException not working on std::rethrow_exception exceptions" had adapted the other relevant bridges/source/cpp_uno/gcc3_*/ cases but missed the gcc3_linux_aarch64 one. Change-Id: I5a2afb11ad4abf851169bd3fd8ae647cc81c2fcd Reviewed-on: https://gerrit.libreoffice.org/67542 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-08oox smartart, cycle matrix: handle left/bottom constraint in composite algoMiklos Vajna
The bugdoc has 3 shapes in the "outer" circle which have a position where either x or y is not 0. But these are defined using constraints talking about the right or bottom edge of the shape. Map that to top/left, given that we already know the shape size. Change-Id: If7ccc2fb642046eb53b48c8b2c2b2c6b023ba9e8 Reviewed-on: https://gerrit.libreoffice.org/67544 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-08Sifr icon: update icon themeandreas kainz
Change-Id: Id432035aba9ea443a1f4afcd54e39a8f3b0939cf Reviewed-on: https://gerrit.libreoffice.org/67543 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-08loplugin:indentation in editeng..extensionsNoel Grandin
Change-Id: If7d7c400fb5d24e48b6cd02b364a8ac7fa23505d Reviewed-on: https://gerrit.libreoffice.org/67538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-08loplugin:indentation in connectivityNoel Grandin
Change-Id: I6619fcdd84a23aae975dcaa7315c7f229c63c4f1 Reviewed-on: https://gerrit.libreoffice.org/67535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-08loplugin:indentation in dbaccess..drawinglayerNoel Grandin
Change-Id: I05de6c01e827e596c9802c04964f43508dfd4d64 Reviewed-on: https://gerrit.libreoffice.org/67537 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-08loplugin:indentation in cppu..cuiNoel Grandin
Change-Id: If625e5bf38ca8e1f12686038c7c9be8d0303b6f6 Reviewed-on: https://gerrit.libreoffice.org/67536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-08o3tl::make_unique -> std::make_unique in tools..xmloffGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Ib3201f865d43f372007cdf381c7e244e9cbeae26 Reviewed-on: https://gerrit.libreoffice.org/67474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-08weld AddDataItemDialogCaolán McNamara
Change-Id: I579d6d555b0f01df22e6f97912712a9ec2bf69a6 Reviewed-on: https://gerrit.libreoffice.org/67532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-08weld AddSubmissionDialogCaolán McNamara
Change-Id: Ib56b22743ef6b9eb849291f9d8eba02450e3fc68 Reviewed-on: https://gerrit.libreoffice.org/67531 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-08drop propagate naturalCaolán McNamara
rather than have version specific behaviour Change-Id: I75866a45859f93d290f79c63b586fee2a19816f3 Reviewed-on: https://gerrit.libreoffice.org/67529 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-08weld AddConditionDialogCaolán McNamara
Change-Id: Ib685ea89b31c1f000bc2276e3362ba059f997422 Reviewed-on: https://gerrit.libreoffice.org/67521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>