summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-12-01sw: simplify SwTextNode::GetAttr()Michael Stahl
Change-Id: I78d32031ebc42d749dbc750b7127983810bbfb1d
2018-12-01sw: SwTextNode::GetAttr() inconsistencyMichael Stahl
If there are hints, the aFormatSet.Differentiate(rSet) will cause the pre-existing items in the parameter rSet to win, whereas without hints the SwContentNode::GetAttr() calls rSet.Set() which clears everything. It looks like WW8Export::WriteFootnoteBegin() was sort of relying on this; presumably it wants the pCFormat to win over node's items but hints on the position to win over pCFormat. Well that's what it currently gets anyway, so try to preserve that. The other use in SwUnoCursorHelper::SetPropertyValues() looks like an oversight. Change-Id: I80e18e040413fcf26f6f77844ed731de31a464d2
2018-12-01sw_redlinehide_4a: the SwTextNode item set contains XATTR_FILL tooMichael Stahl
... so handle them as well in SwTextFrame::SwClientNotify(). Change-Id: Ifa8bf8f44bcd08a64dc36939bad58efefbd7af55
2018-12-01tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScCellsObj. Change-Id: If721582a36ef5a82fba20d4ec7e0806d1d0524d9 Reviewed-on: https://gerrit.libreoffice.org/64365 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01Correct class nameJens Carl
Change-Id: I76b440e72a80f20d05af477a38e9695cb17cb979 Reviewed-on: https://gerrit.libreoffice.org/64354 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01sw: new unit tests for editing text in bookmarksSerge Krot
Change-Id: Ia7b49c0ae685f6a18e9d372a689643422f1f6a04 Reviewed-on: https://gerrit.libreoffice.org/64189 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-01Option to turn off WebDAV file lockingKatarina Behrens
Locking files on WebDAV shares was implemented in tdf#82744, in particular: commit 26e6d4b05ab444e6a7529ffcac7fbe592fc94833 tdf#82744: fix WebDAV lock/unlock behaviour - part 1 commit bc9a8ddbb7081f79e915c841e56fd1c40f0df6f9 tdf#82744: fix WebDAV lock/unlock behaviour - part 2 commit b4576f3da4d90139fc5140962d13cb91dab98797 tdf#82744: fix WebDAV lock/unlock behaviour - part 3 commit fed2984281a85a5a2f308841ec810f218c75f2ab tdf#82744: fix WebDAV lock/unlock behaviour - part 4 Before that, files on WebDAV shares were accessed w/o locking since the beginning of [OOo] time. This option allows to revert to the old behaviour i.e. non-locking WebDAV access. For concurrent read-write WebDAV access by multiple users it is recommended to keep UseWebDAVFileLocking at default value (true) Change-Id: Id92177631d4854d6c7bf412164acbd9740db9592 Reviewed-on: https://gerrit.libreoffice.org/64116 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-12-01Enable XElementAccess test casesJens Carl
The class XElementAccess was missing the macro OOO_DLLPUBLIC_TEST, and so it wasn't possible to use these test cases. Change-Id: I358bb840c6088ea25b60ee57b8c69f31ab71ddbb Reviewed-on: https://gerrit.libreoffice.org/64363 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01Fix typosAndrea Gelmini
Change-Id: Ie85b3a61ded8c6fd7a1f8c463912062669b3719b Reviewed-on: https://gerrit.libreoffice.org/64357 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-12-01oox smartart, accent process: adjust size of connector from constraintsMiklos Vajna
The constraints explicitly said that the width should be larger than the height, but it was the opposite as constraints were not parsed. Unfortunately it would be too brave for globally start handling all constraints which lack a forName, so add a switch to opt in for this, and use that with the conn algorithm. All clients should migrate to bRequireForName=true at some stage, though. Change-Id: I24ae79b141c0f7a11e4d19f141759fc1dd2169b0 Reviewed-on: https://gerrit.libreoffice.org/64350 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-12-01Unit test for leading and trailing group separator charactersEike Rathke
Change-Id: I10ff8b59ba707d5795338ff5e9037473d31337bc Reviewed-on: https://gerrit.libreoffice.org/64361 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-01KJ & elementary: tdf#121581 change Organize Dialogs to Organize Macros; add ↵Rizal Muttaqin
Insert Layer Change-Id: I25bded0e5c1340ca61c747b0125825ed13a9150f Reviewed-on: https://gerrit.libreoffice.org/64349 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2018-12-01A leading or trailing group separator character is not a group separatorEike Rathke
Also a group separator character followed by a non-digit is not. Change-Id: Id57e43fe7692706c5532fb05ad394224265c2750 Reviewed-on: https://gerrit.libreoffice.org/64358 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-12-01oox smartart, accent process: handle connector shape between pairsMiklos Vajna
The shape was created, but we literally tried to create a "conn" type, while that has to be resolved to the relevant arrow type based on the context. This means now arrows show up between the parent-child pairs (but their size is not yet correct). Change-Id: I82594e46579e4ef723093e1dd0ba31bfcbbec4a0 Reviewed-on: https://gerrit.libreoffice.org/64348 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-30i#32345 Support a matrix of rank argument for LARGE()/SMALL()Takeshi Abe
This is a followup of e22ab5e6f6b0ea49231ca454a567133996306116. Change-Id: I7052e113173204f7cfcd40622f52c5d4e14b3aa9 Reviewed-on: https://gerrit.libreoffice.org/64139 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-30[API CHANGE] Resolves: tdf#42518 new KParseTokens::GROUP_SEPARATOR_IN_NUMBEREike Rathke
Default unset bit now does not accept/skip group separators in numbers. See .idl description comment for why this is incompatible and how. This actually uncovered a "bug" (or at least unexpected) in the Math parser that parsed "0," as one entity instead of "0" followed by ",". As obtaining the text form appends a blank after each entity the sw/qa/extras/rtfexport/rtfexport.cxx testMathEqarray() testcase had to be adapted. Change-Id: I2b605742ab3d8a9bb81ad6880faf050535dc80fa Reviewed-on: https://gerrit.libreoffice.org/64270 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-30tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java tests to C++ for ScCellsObj. Change-Id: I3ec78142db7cfa924bf5663ca44cca80b6a0e556 Reviewed-on: https://gerrit.libreoffice.org/64315 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-30Give CPPUNIT_ASSERT_MESSAGE a more meaningful messageJens Carl
Change-Id: Ia83a4403243a2b2ab98c2b0e6a28213ce6fe1269 Reviewed-on: https://gerrit.libreoffice.org/64314 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-30Mention this file is outdatedTor Lillqvist
Change-Id: Iacd5323ee1db9be294556f3d7344eab00b27095b
2018-11-30No ios/generated folder is created any longerTor Lillqvist
The generated files for iOS are now in workdir/CustomTarget/ios. Change-Id: Idee3902eaabf21aa7dacb971ad81f4e2c7df3b5b
2018-11-30add uitest fr bug tdf#121263Zdeněk Crhonek
Change-Id: I138e097c65bac9fb37d9b08b444cc5cb9627a4d8 Reviewed-on: https://gerrit.libreoffice.org/64260 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-30Make some loplugin:implicitboolconversion code use TypeCheckStephan Bergmann
Change-Id: If675d629784894573085122beadc6abc3e67f457 Reviewed-on: https://gerrit.libreoffice.org/64335 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-30KDE5: fix build with Qt-5.6Aleksei Nikiforov
Change-Id: Ic4aef6b22d5b9c7262a534e26363c8f8cef99859 Reviewed-on: https://gerrit.libreoffice.org/64321 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-30remove unused enum DataSourceDialogPagesNoel Grandin
Change-Id: If990d5f8cb2eca7fa6ffd21f2f8db17ba4385df6 Reviewed-on: https://gerrit.libreoffice.org/64319 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30Specify label mnemonic widgetsMike Kaganski
Fixes: sc/uiconfig/scalc/ui/conditionalentry.ui: WARNING: 'GtkLabel' 'Label_minimum' does not specify what it labels within 'interface' sc/uiconfig/scalc/ui/conditionalentry.ui: WARNING: 'GtkLabel' 'Label_maximum' does not specify what it labels within 'interface' after commit b907fe59a819aaba75518dc1534eb71d9e378b74 Change-Id: Iff3340cd17fd6c31970fd2d01b49c55e60680978 Reviewed-on: https://gerrit.libreoffice.org/64325 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-30tdf#114113: handle quoted sheet namesMike Kaganski
Change-Id: I569903fc06448fe6ee7f948488319b6b1f1f8fbb Reviewed-on: https://gerrit.libreoffice.org/64334 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-30loplugin:unusedmethodsNoel Grandin
Change-Id: Id0d68d659fa06a8230ed0d927b85b6b504525d1e Reviewed-on: https://gerrit.libreoffice.org/64328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30tdf#119824 fix undo/redo of overlapping redlinesLászló Németh
Overlapping redlines (introduced by the commit 9dbf817fe5c5253fba0831aefa17575ae0ba3af1 "handle scope of w:pPrChange and w:rPrChange properly" for showing tracked DOCX paragraph formatting) resulted losing of tracked deletion, ie. reappearing deleted content using Redo (reported after fixing the broken non-visible change tracking with overlapping redlines in commit 694a6389e84d5b416cde6dde2d5eaa589a0a6493 "tdf#119019 DOCX track changes: fix invisible delete and insert"). Change-Id: I63fde7e89afde99cff242968d34cc70455c5c3c2 Reviewed-on: https://gerrit.libreoffice.org/64218 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-11-30loplugin:unusedfieldsNoel Grandin
Change-Id: Ib3c797584493763773fd44fc3e8ac8b70ab0c221 Reviewed-on: https://gerrit.libreoffice.org/64326 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30loplugin:singlevalfieldsNoel Grandin
Change-Id: I70dc861573fd1b3d799c88aa2a6d9a3eda0e2a43 Reviewed-on: https://gerrit.libreoffice.org/64327 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30remove unused EditStatusFlags::CRSRLEFTPARANoel Grandin
Change-Id: I385069328ef862f1928d436260db2f2bc13c70d6 Reviewed-on: https://gerrit.libreoffice.org/64318 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30remove unused IconChoiceFlags::StartEditTimerInMouseUpNoel Grandin
Change-Id: I157f455880095a0ee8a609028838b399eb26238a Reviewed-on: https://gerrit.libreoffice.org/64320 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30tdf#42949 Fix IWYU warnings in sc/source/ui/*/hxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I3a945828b4c74be7747850e3e0eab2f4adeb67fd Reviewed-on: https://gerrit.libreoffice.org/64140 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-30tdf#121435 OOXML export: fixing linestyle export in chartsAdam Kovacs
Fixing linestyle export of chart wall (plot area) and chart page. Change-Id: Id5265110352d393d9c3e01ff55cea0770d4e0cef Reviewed-on: https://gerrit.libreoffice.org/63418 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-11-30remove unused HeaderBarItemBits enum valuesNoel Grandin
Change-Id: I84752cb9d683cb22c96d91cc54d7c4dc474603fc Reviewed-on: https://gerrit.libreoffice.org/64269 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30starmath: create XMLOasisSettingsImporter instances with an uno constructorMiklos Vajna
Change-Id: I92c8991baf10fde574d06ab0870bbb26a7632e65 Reviewed-on: https://gerrit.libreoffice.org/64284 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-30loplugin:unusedenumconstants ignore common patternNoel Grandin
Ignore a common pattern that does not introduce any new information, merely removes information. Change-Id: I37da352c9295ec12b9dac7aad4b4792a6d726b0d Reviewed-on: https://gerrit.libreoffice.org/64255 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30Remove obsolete _MSC_VER checksStephan Bergmann
...after 206b8c4ae320d7d8614f21800d8f77fa29f8f5ff "On Windows, check for at least Visual Studio 2017 version 15.7" Change-Id: I38ee86e1649bbdc828a7e328f2dbbac0dc163c8a Reviewed-on: https://gerrit.libreoffice.org/64250 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-30Revert "Revert "Notebookbar:Disabled appearence of context toolbars""Mike Kaganski
This reverts commit 9a6169529eb687190531225bfe9fef850325ee9e now that proper fix for both tdf#121591 and tdf#119945 is pushed - see commit 0a36be3fee1b4f1b47b55a64668b6aa99896ab24. Change-Id: Ia44510d427e0626a5f566210247db8848653f8e2 Reviewed-on: https://gerrit.libreoffice.org/64279 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-30Fix typoAndrea Gelmini
Change-Id: I028e5462e9785bac77a98d09f0bf91b4da67e477 Reviewed-on: https://gerrit.libreoffice.org/64263 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-30tdf#93005, tdf#100611, remove the incomplete ODC export featureMarkus Mohrhard
Change-Id: I96a3882cd412ea5d993971df7e20b1fd8da73642 Reviewed-on: https://gerrit.libreoffice.org/64283 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-30tdf#121282, tdf#121279, set text properties also on complex data labelsMarkus Mohrhard
Change-Id: I2304b6050b786b6e4a9a8a968d7a4846d9da8be8 Reviewed-on: https://gerrit.libreoffice.org/64306 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-30weld OfaAutocorrReplacePageCaolán McNamara
Change-Id: I143792cfe123942d44b2e39cb1910a5127b2f592 Reviewed-on: https://gerrit.libreoffice.org/64254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-29related tdf#42915, pass NaN through date transformationMarkus Mohrhard
Many places in chart2 use NaN to mean no available value. Not propagating NaN through the helper disables all this functionality. Change-Id: I37f966007b5b7cc16778c5c6903710fbd144631b Reviewed-on: https://gerrit.libreoffice.org/64266 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29tdf#42915, NaN in a date axis can destroy the whole chartMarkus Mohrhard
The NaN value forces the scaling of the axis to be based on years and introduces gaps in the rendering. Change-Id: I78219be289d76edb53b5672209e1c031ab62def9 Reviewed-on: https://gerrit.libreoffice.org/64267 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#115663 Syntax highlight in BASIC code examples Use prism.js to highlight BASIC code in help pages See README.prism.js.txt for details added normalize-whitespaces plugin to remove extra 1st line cleaned some useless css class Change-Id: I6dde4d217a29f485199ced462b896ee1b500fba0 Reviewed-on: https://gerrit.libreoffice.org/64252 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-29Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' - Help pages for VBA Enum statement Change-Id: I4f382453334aa964115d30d7e11e7d202d63a230 Reviewed-on: https://gerrit.libreoffice.org/64202 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-29Rename files for class ObjectCatalogtagezi
Change-Id: I51bb2e9e49d9922a9624a2123dbeb1a820255b90 Reviewed-on: https://gerrit.libreoffice.org/64153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-29Update git submodulesEike Rathke
* Update helpcontent2 from branch 'master' - Occurrence number as REGEX() 4th argument, tdf#113977 tdf#121084 Change-Id: I42be8bbc4e7c11e09cb66bf12f164c4fc565b54b Reviewed-on: https://gerrit.libreoffice.org/64276 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-11-29drop unused VclAbstractRefreshableDialogCaolán McNamara
Change-Id: I11ce3235ee95d7c6e8b1832579d097c7b044ae52 Reviewed-on: https://gerrit.libreoffice.org/64217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>