summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-24widget theme: add additional settings to the theme definitionTomaž Vajngerl
Change-Id: Ib50ebadf73979068d3595f09de113aa8745eccb9 Reviewed-on: https://gerrit.libreoffice.org/83591 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-24cppcheck: performing init in init list (sc/scripting/sd)Julien Nabet
Change-Id: I8bd4c1b7b551a96ecd5a2b50fbfdf225567175f6 Reviewed-on: https://gerrit.libreoffice.org/83621 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-24cppcheck: performing init in init list (oox, package, sal, sax)Julien Nabet
Change-Id: I77e28f02516ab25ff6680970dc13d52cfa90eac1 Reviewed-on: https://gerrit.libreoffice.org/83620 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-24cppcheck: performing init in init list (hwpfilter, i., l.)Julien Nabet
Change-Id: Idf5b7be45d48076fbe191fbf1a2fa63c6da71902 Reviewed-on: https://gerrit.libreoffice.org/83617 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-24cppcheck: performing init in init list (filter/fpicker/framework)Julien Nabet
Change-Id: I7b602d17949f75c32dfe87acb92498111812ac32 Reviewed-on: https://gerrit.libreoffice.org/83612 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-24tdf#128976: properly calculate default value when writing XLSMike Kaganski
XLS stores default column width as 16-bit unsigned integer in the range from 0 to 255 inclusive ([MS-XLS] 2.4.89 DefColWidth), unlike in OOXML where any floating-point value is valid. Additionally, some correction is used, introduced in commit 555d702903fb0857122024e1ab78a72d122d3f16 (basis of empirical formula in XclTools::GetXclDefColWidthCorrection is unclear). So in XLS, when the default is calculated, we need to take into account if the resulting stored value will actually represent our calculated value. If not, then just ignore the calculated value, and use arbitrary 8 as the default. With that, following IsDefWidth will correctly check if passed width is represented by the stored default or not. All widths that can't be represented as integral count chars in DefColWidth will have fUserSet set in corresponding ColInfo records, thus correctly keeping widths. Change-Id: Iedcc5583c861f5b18a422a9b279c48cff729cbc5 Reviewed-on: https://gerrit.libreoffice.org/83613 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-24Resolves: tdf#128940 use a normal MenuButtonCaolán McNamara
instead of a split toolbar item Change-Id: I2e706d1a3255dca7a51d323a2bcf750f28b8fd1e Reviewed-on: https://gerrit.libreoffice.org/83581 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-24cppcheck: performing init in init list (dbaccess/desktop/dtrans/e.)Julien Nabet
Change-Id: I7909df04a550a4fa843a70d20b5192231c3f175e Reviewed-on: https://gerrit.libreoffice.org/83600 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-24lok: Chart context menu: Disable menu items which are not available.Tamás Zolnai
Change-Id: Id7487c581759389e66ca513381d6706f3ae49980 Reviewed-on: https://gerrit.libreoffice.org/83605 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24lok: Chart context menu: Replace tunneled context menu with JS context menu.Tamás Zolnai
Change-Id: I36db90887bff86036093ce0732db6fc6c76e79f6 Reviewed-on: https://gerrit.libreoffice.org/83604 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24Fix some loplugin error.Tamás Zolnai
Change-Id: I22c1efbacc5b2d35d49f8183929b6177bf91e93d Reviewed-on: https://gerrit.libreoffice.org/83602 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24SpellingPopup: Create separate SID for Ignore / IgnoreAll / suggestion.Tamás Zolnai
Change-Id: I20f41f511ea38f960f081f92bc36e095f7752d28 Reviewed-on: https://gerrit.libreoffice.org/83599 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24SpellingPopup: lok: Replace the tunneled context menu.Tamás Zolnai
Send the menu structure instead using LOK_CALLBACK_CONTEXT_MENU. We need to set commands for menu items to make fillPopupMenu() method work. We also need to check whether there is any selection during execution of menu items. In case of LO core execution the suspicious text is selected, however in case of LO online, there is no selection. Change-Id: Id696ee9976d11f6b57e23a3bcc5b483a1d486639 Reviewed-on: https://gerrit.libreoffice.org/83598 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24Dispatch: Make fillPopupMenu() method accessible from other modules.Tamás Zolnai
No functional change. Change-Id: Ifaa6ff038277ef5702ac38d90c7461d664b0aee4 Reviewed-on: https://gerrit.libreoffice.org/83597 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24SpellingPopup: lok: Hide unusable items for onlineTamás Zolnai
MN_EXPLANATION_LINK is some link, but it's exectued internally, which means the the link would be executed on the serves side and not on the client's browser. m_nCorrectMenuId is a sub menu which allows to specify new autocorrect rules. Since m_nAddId is also disabled, I expect that extending the dictionaries / autocorrect rule might be a problem for online. Change-Id: Id6e8ed078f90a4f25a335a3ab5ec0e3056db648d Reviewed-on: https://gerrit.libreoffice.org/83596 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-24Fix e6ab01ce532d1db01579b70bd476b2f643522bf9Julien Nabet
+ fix: /home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/connectivity/source/drivers/mork/MStatement.cxx:64:6: error: no need to explicitly init an instance of 'std::unique_ptr<connectivity::OSQLParseNode>' with nullptr, just use default constructor [loplugin:simplifyconstruct] ,m_pParseTree(nullptr) ^~~~~~~~~~~~~~~~~~~~~ from another patch to calm down clang Jenkins Change-Id: Ia8304b7baedbce760a6e01ea154c5ff3cd19cbd4 Reviewed-on: https://gerrit.libreoffice.org/83595 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-24Fix 'is' operator for comparisonJens Carl
The 'is' operator should not be used for comparison on some types of literals. In CPython this works by accident and CPython 3.8 introduced a SyntaxWarning (see https://bugs.python.org/issue34850). Change-Id: I5cb7470132b26d87848c2bdc382b05477eb56afb Reviewed-on: https://gerrit.libreoffice.org/83032 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-11-24cppcheck: fix 2 funcArgOrderDifferentJulien Nabet
1) sd/source/filter/ppt/pptin.cxx Function 'ProcessObj' argument order different: declaration 'rSt, rData, rClientData, rTextRect, pObj' definition 'rSt, rObjData, rData, rTextRect, pRet' 2) connectivity/source/drivers/mysqlc/mysqlc_prepared_resultset.cxx Function 'OPreparedResultSet' argument order different: declaration 'rConn, pStmt, pMyStmt' definition 'rConn, pPrepared, pStmt' Change-Id: I83f8427ee15c3025676c39f262c2e9881cdd33ae Reviewed-on: https://gerrit.libreoffice.org/83593 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-24cppcheck: performing init in init list (sot/svl/svtools/svx)Julien Nabet
order had been changed in svx/source/sidebar/paragraph/ParaLineSpacingControl.hxx so initialization list was fine Indeed mpActLineDistFld depends on mpLineDistAtMetricBox Change-Id: I974e68892fe7ab900774bbe912c51ec56ba4ee43 Reviewed-on: https://gerrit.libreoffice.org/83577 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-23emfio: extra loggingChris Sherlock
For emfio I believe we need more logging, so I am gradually adding this. I decided to log the EMR_COMMENT_PUBLIC record subtypes EMR_COMMENT_BEGINGROUP and EMR_COMMENT_ENDGROUP. I honestly don't know what these actually do, but they are specified in [MS-EMF] 2.3.3.4.1 and 2.3.3.4.2. Later on, we will need to look into handling EMR_COMMENT_MULTIFORMATS so we can display things with EPS data. We should also probably look into handling EMR_COMMENT_WINDOWS_METAFILE later on also. Change-Id: I7c3ba3cfd7f51a6cff2c7a47a48dde12240d0382 Reviewed-on: https://gerrit.libreoffice.org/83407 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-11-23cppcheck: performing init in init list (comphelper/connectivity/cppu/cui)Julien Nabet
Change-Id: I786c2c10e8b37b48adf6d619c0fa6a905de1bf7f Reviewed-on: https://gerrit.libreoffice.org/83584 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-23cppcheck: performing init in init list (sfx2/slideshow/stoc/store)Julien Nabet
Change-Id: Iddbd3256aabe9552472b55d3d9b88a3769698de9 Reviewed-on: https://gerrit.libreoffice.org/83576 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-23SpellingPopup: Convert suggestion menu items to use slot ID.Tamás Zolnai
Change-Id: Icf1f50d04ab5e7ba467d68613f4101a3fe48589b (cherry picked from commit c2f58bc25cedf8a13a978b52a5bf012809fc38ed) Reviewed-on: https://gerrit.libreoffice.org/83590 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: Remove m_aSuggestions member variableTamás Zolnai
We don't need it after the construction. The text is stored by the menu item. Change-Id: I54b0392b4564e76d405824bb297e6f993a24a5fb (cherry picked from commit dc842a4af87ae5f1edd6112ca4f2ff2ac25f5a50) Reviewed-on: https://gerrit.libreoffice.org/83589 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID (spelling).Tamás Zolnai
When the popup is in spelling mode. "IgnoreAll_Spelling" rule triggers this method. Change-Id: Ia1e1877f8501beff29f09bc33621c8f03008b7e8 Reviewed-on: https://gerrit.libreoffice.org/83588 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID (grammar).Tamás Zolnai
When the popup is in grammar mode. "IgnoreAll_Grammar" rule triggers this method. When openning the spelling popup we have the suspicious text selected, so we don't need the mouse position to apply the changes. I updated GetGrammarCorrection() method accordingly. Change-Id: Iaf86544ea5f7dbc4afa2889772a5a38c5fd5707e Reviewed-on: https://gerrit.libreoffice.org/83587 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23tdf#128932 Disable spellcheck while converting shape to bitmapSamuel Mehrbrodt
To not have red underline in the resulting bitmap Change-Id: I5d6ae5767df8e8caf295955bdc0e5a5b6b79d45d Reviewed-on: https://gerrit.libreoffice.org/83404 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-23SpellingPopup: Convert "Ignore" menu item to use a slot ID.Tamás Zolnai
Introduced a new slot id SID_APPLY_SPELLING, which can be used to apply any spelling / grammar related changes (e.g. ignore, ignore all, replace with suggestion, add to dictionary). In this commit, only the simple ignore is implemented. Change-Id: I06ab84efeb955cc02ce3ff531bd8b5c20ddced9e Reviewed-on: https://gerrit.libreoffice.org/83583 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: Move setting UPN_IS_GRAMMAR_INTERACTIVE to the constructor.Tamás Zolnai
Change-Id: Ief5470e0a61f0ca40549ab6d3768c795c3f04510 Reviewed-on: https://gerrit.libreoffice.org/83580 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: lok: Also hide the add menuTamás Zolnai
Change-Id: Ic6b10d579fe1fb0afe5e80244e84ed456dc6cc87 Reviewed-on: https://gerrit.libreoffice.org/83579 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: Remove unused variablesTamás Zolnai
Change-Id: I3cb3b128ec54f82381bf6f0c17401a5d5fb58a96 Reviewed-on: https://gerrit.libreoffice.org/83578 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: Convert selection language items to use slot idTamás Zolnai
Change-Id: I10a89d7efa957e6b94e793158983c5acf623e511 Reviewed-on: https://gerrit.libreoffice.org/83575 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: Convert paragraph language items to use slot idTamás Zolnai
Change-Id: I36df4777b408f9defd883d49413847152f6b496f Reviewed-on: https://gerrit.libreoffice.org/83573 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23SpellingPopup: Convert char dialog related items to use slot idTamás Zolnai
After this change we can make sw_CharDialog() a local function. Change-Id: I34b15fccaed07b5d89f63a69da8c870fff0e9b14 Reviewed-on: https://gerrit.libreoffice.org/83571 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-23Property Get/Let Basic StatementLibreOfficiant
My very first Basic TestCase: Assistance/mentoring is welcome Change-Id: I6399fdb603051792d698695fe659e5a12a0c8396 Reviewed-on: https://gerrit.libreoffice.org/83553 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2019-11-23cppcheck: performing initialization in initialization list (sfx2/doctemplates)Julien Nabet
Change-Id: If62a52c2669f5bd5d60f380c087fbe04b2458226 Reviewed-on: https://gerrit.libreoffice.org/83551 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-23cppcheck: performing initialization in initialization list (sfx2/doctempl)Julien Nabet
Change-Id: I91f077fc6c3e74ea1c0470a562e3d762ab3b1439 Reviewed-on: https://gerrit.libreoffice.org/83550 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-23uitest for bug tdf#91217Zdeněk Crhonek
Change-Id: I0322a3bc821850d5f15aeb690ba80ff7b8129140 Reviewed-on: https://gerrit.libreoffice.org/83546 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-23OfaTreeOptionsDialog::LoadModule: Use range-based forMichael Weghorn
Change-Id: I2b191dd55dcd9e085b2cde6bacd1e2e3c963fafa Reviewed-on: https://gerrit.libreoffice.org/83489 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-23tdf#97926: Update @since tagsXisco Fauli
Since it was backported to libreoffice-6-4 Change-Id: I832c252678b132c743f868688abbe702eb1293b2 Reviewed-on: https://gerrit.libreoffice.org/83512 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2019-11-23treeopt.cxx: Simplify 'ModuleMap' handlingMichael Weghorn
Use 'OUString' instead of 'const char*' for 'ModuleToGroupNameMap_Impl.m_pModule', and simplify the iteration using range-based for. Change-Id: I1756bc6ac8b163a68b79d6900738362db010d8a9 Reviewed-on: https://gerrit.libreoffice.org/83488 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-23Use const OUString instead of const char[]Michael Weghorn
'SvtViewOptions::GetUserItem' and 'SvtViewOptions::SetUserItem' take a 'const OUString&' param anyway. Change-Id: Icdc4c578516c9fe1307b64eecdf3270142b4e823 Reviewed-on: https://gerrit.libreoffice.org/83487 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-23Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix div position for Online Help The condition was masking the div. Now the condition mask the contents Change-Id: I270e20f3ae17a16d4425698f24e674763320fade Reviewed-on: https://gerrit.libreoffice.org/83540 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-23Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - Improve the help for old Fontwork The old Fontwork functionality continues to be very useful. Some see it as even more useful than the new Fontwork. I changed the text to make it more understandable what it is all about. Change-Id: I05f073a7cdb23d5aa1470fd7a19386f444010d7e Reviewed-on: https://gerrit.libreoffice.org/81961 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-22GCC trunk towards GCC 9 still emits a bogus -Wstringop-truncationJulien Nabet
Change-Id: I14ff82099107302f5e99f22735c37901f68934e9 Reviewed-on: https://gerrit.libreoffice.org/83537 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-22Fix typoAndrea Gelmini
Change-Id: Ibf2e90ff53f201d7b1f279c11eb8238eb403c05e Reviewed-on: https://gerrit.libreoffice.org/83533 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-22wrong delete signal idCaolán McNamara
Change-Id: I4aecd3c8f5d40c3256d2d2816a79f8809db6cedb Reviewed-on: https://gerrit.libreoffice.org/83518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22tdf#128952 Set the position of shape for 180 deg.Gülşah Köse
If the rotation value is 180, 540, 900... degree with mirror pShape->GetRotateAngle() returns 0. In that control 0 means no rotation but that is not true. For that cases (180, 540, 900) after the angle conversition GetRotateAngle() returns 0. We should recalculate the position for 0 too. Change-Id: I14e981235b2d6cd8382d4c9e151bccd2e73a3fd9 Reviewed-on: https://gerrit.libreoffice.org/83468 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-11-22tdf#121740 cache font data to speed up PPT loadNoel Grandin
takes the load time from 24s to 21s for me. The cache was determined experimentally for this document. Change-Id: I34c78d1ff99cb8e72b274a201ded61d23e66941a Reviewed-on: https://gerrit.libreoffice.org/83470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-22make some classes module-privateNoel Grandin
Change-Id: If7303a082e06f6937fca911c578a40475546cda2 Reviewed-on: https://gerrit.libreoffice.org/83442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-12-26 05:13:19 +0000