summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-03-29basegfx: add convenience access. and creator to B2DHomMatrixTomaž Vajngerl
In SVG, CSS, HTML Canvas it is usual to define a matrix with a,b,c,d,e,f attributes, where the values correcpond to the following: [a,c,e] [b,d,f] [0,0,1] This change adds accessors and creator to B2DHomMatrix, so it is easier to deal with other matrices that are defined like that. Change-Id: I6927513b1a70ad5eb70d7fe14a00de4a767f176a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91310 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29add convenience accessors to Matrix.hxxTomaž Vajngerl
Change-Id: Ifaaff3b1526aed111725a46c6cc64c189909a904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91309 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29basegfx: export B2DRange operator*=Tomaž Vajngerl
Change-Id: Ia2e72e6650b14d5d024b65b1261876885cf1b05a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91308 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-29Fix is_typed_flags for SvxNumRuleFlags (editeng)Julien Nabet
Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=2b1f0d31c34464bdece4eea158097b3e4923cf5f author Tamás Zolnai <tamas.zolnai@collabora.com> 2017-11-11 18:17:52 +0100 committer Tamás Zolnai <tamas.zolnai@collabora.com> 2017-11-11 20:44:48 +0100 commit 2b1f0d31c34464bdece4eea158097b3e4923cf5f (patch) tree 66fff19490e124a00321590eb5a5ba00ab149714 parent 019e6ae7be38176978943d95fa3b586830e1b3b1 (diff) tdf#111738: Duplicated numbering alignment option on numbering dialog Change-Id: I65defa76c3b325f1cf4d33482216f2663bbb82b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for EEControlBits (editeng)Julien Nabet
Change-Id: I40b719f58e7c41e33ce68cde217161924de6e3cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91285 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for RegAccessMode (registry)Julien Nabet
Change-Id: I5b58d10eea35652bb201d6153e413ca1aee3c4ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91307 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for SvxMSDffHandleFlags (svx/EnhancedCustomShapeGeom)Julien Nabet
Change-Id: I8947a7b11a67397fdca36fb5087c2c1306b76b1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91315 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for ConfigItemMode (unotools/configitem)Julien Nabet
Since DelayedUpdate removed with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=67ff7348756ec88d09fc00e6d284ba5b579e9b33 author Noel Grandin <noel.grandin@collabora.co.uk> 2018-12-06 10:05:06 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> 2018-12-07 10:35:44 +0100 commit 67ff7348756ec88d09fc00e6d284ba5b579e9b33 (patch) tree d9bc9015abadce440e6637e280286e04e9ba062a parent 1e6cc2c8564e86465594f6651490f529dafb3aaf (diff) remove unused ConfigItemMode::DelayedUpdate unused ever since commit c1758889cbd5e8e4afb1044425c908715eb3e1cd Date: Fri Nov 11 22:48:37 2011 +0100 Heavily simplified utl::ConfigManager. and rename ConfigItemMode::ImmediateUpdate to NONE, since it doesn't mean that anymore Change-Id: I3f5e5a63cbbc12f15a4af104fc6e007cdf10cab3 Change-Id: Idc4c4f0a90bfce26483f2f4d66b47c263bcb5954 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91316 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Fix is_typed_flags for SfxShellFeature (sfx2/shell)Julien Nabet
Since remove of FormTBMoreControls (0x800) https://cgit.freedesktop.org/libreoffice/core/commit/?id=00f96e88a7c6feea98d446e82a2718c5aae6256c author Roman Kuznetsov <antilibreoffice@gmail.com> 2019-03-13 19:18:49 +0100 committer Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> 2019-03-14 08:52:29 +0100 commit 00f96e88a7c6feea98d446e82a2718c5aae6256c (patch) tree 9bff711b6e7b70ede72cd6a9f913a72ac237981e parent c196d70337f6b755cfc4c34beda05554c6fab114 (diff) tdf#112411 Remove all that remains of the More controls toolbars Change-Id: I90bb25b2033374498d4e3306651c4b4024154739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91313 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-29Enable Writer Navigator content tree tooltips for Gtk3Jim Raykowski
Change-Id: I7a8b1e9007b7913c05205c6f01b43fc8d60ae07d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91269 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-03-28Fix is_typed_flags for MessBoxStyle (dbaccess)Julien Nabet
Change-Id: Ic788677b540588ddddae963a3fc983879cd77c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91282 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-28Fix is_typed_flags for BrowseMode (compilerplugins)Julien Nabet
Change-Id: Ia6fecc08b2ee66b3e831f2c6289575ca98976783 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91281 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-28tdf#131618 MailMerge: Don't require DataSourceName if ResultSet providedOleg Shchelykalnov
Allows to use ResultSet instead of DataSourceName and DataCommand options. Change-Id: I654cdf3bc850ab1c1a29837e8aabdee410b30439 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-28tdf#80635 ww8import:2 take float table RIGHT to inlined tableJustin Luth
Since SW has problems with floating tables, any unnecessarily floated tables are converted to inline. However, the positioning of the tables is mostly lost. So the choice is either to refuse to inline a strangely positioned table or else to transfer the positioning onto the inlined table. Transferring is easier said than done. But for right-aligned tables, hopefully it is easy to copy that without causing trouble. I didn't find any real-world examples in existing unit tests or bug reports, so I made up my own complicated one using both right margin and BIDI. Change-Id: I855ae62531b5930cbc9a3272c3a7228dd7b0df53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91272 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-03-28svdpdf: move Matrix to basegfx just to get it separatedTomaž Vajngerl
Change-Id: I9d887dc7a2836b90151ef352b47a9b9ad3b6f12b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91280 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-28Fix is_typed_flags for EConfigurationModesJulien Nabet
LazyWrite = 4 dropped with cb2550750386f51ef7a46a8a664a4ab9de614f8d Change-Id: Ie14e7c34c681288dec8ff53c77485ab642c1c29b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-28Fix is_typed_flags for SCAFlagsJulien Nabet
Since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=0c2d51e0daf2ce5e18af915ec40ec3196db8ab88 author Noel Grandin <noel@peralex.com> 2016-05-12 14:32:30 +0200 committer Noel Grandin <noel@peralex.com> 2016-05-12 14:33:35 +0200 commit 0c2d51e0daf2ce5e18af915ec40ec3196db8ab88 (patch) tree 720d61287f718a66747e31a156b0c98eb2d3e24e parent aba06d6f8d69632559ca9a74320fcd048855a3a3 (diff) Convert SCA flags to scoped enum Change-Id: I7bb5b33819cada9410e725d0c45cc7ea10fde1a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91279 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-28sw lok: add uno command for submenus in Spellchecking popup.Tamás Zolnai
Change-Id: I1c7591379ecbce0099ed7d969e5dc83831e322b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91227 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-03-28Breeze & Colibre: Fix for tdf#131636 to Bg & to Fg iconsRizal Muttaqin
Change-Id: I7236f5725d12779f7105cc666bee1a4ebe957daa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91274 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-28tdf#80635 ww8import:1 take float table CENTER to inlined tableJustin Luth
Since SW has problems with floating tables, any unnecessarily floated tables are converted to inline. However, the positioning of the tables is mostly lost. So the choice is either to refuse to inline a strangely positioned table or else to transfer the positioning onto the inlined table. Transferring is easier said than done. But for centered tables, it is easy to copy that. Change-Id: I8a6deaa63c45277c30ffa12613c8ed125a45d607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91188 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-03-28tdf#131576: fix "Field information" in table wizard, step 2Julien Nabet
Change-Id: I8a0dfa9f483f32bc5858e628ff4bb9cb79c9c6a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91236 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-03-28Sukapura:Fix for tdf#131636: icons for to Background and to ForegroundRizal Muttaqin
Change-Id: I953b27cab5d1a78c2ca08a5d8adbc0138264699a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91271 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-27pdfium: make breaking of PDF graphic work againTomaž Vajngerl
Changing PDF to use VectorGraphicData deleted the calls which triggered the breaking of the PDF. This change makes breaking work again. Change-Id: I1d817f1556e37fcbcc3d2850b690eb0810676fa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91234 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-27spreadsheetml2ooo.xsl was not well formed xmlCaolán McNamara
broken by... commit 6909838e2966b3fd3c2de6b6db70d952cd8b3114 Date: Thu Apr 25 18:08:33 2019 +0200 Fix typo Change-Id: I40ee245faa75c885d76299ddee79fdaca9d0d715 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91233 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-03-27graphic: sPdfDataCache is not used anymoreTomaž Vajngerl
Change-Id: I3fd13784c80dc3308f751594830ee08761e8d8c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91235 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-03-27no need to special case 0Caolán McNamara
and the impress animation pane show the need to not special case 0 in the effect list Change-Id: I806365df1a77b58b8d4f474d945f7a7e50c53757 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91231 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27Resolves: tdf#131096 Handle argument error and propagateEike Rathke
For etsPIAdd and etsPIMult also check if the fPILevel parameter was actually specified (explicitly or missing/omitted) and do not pop the 3rd parameter if not. GetDoubleWithDefault() can't handle that as apparently was erroneously assumed. Use IllegalArgument error instead of IllegalParameter in most cases (the parameter is fine but the argument value is not). Actually propagate ScETSForecastCalculation::mnErrorValue if set as PushMatrix() does not, on purpose. Change-Id: Ia2db5b0a7a388f0f40b73c6a4f66debbedec41e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91232 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-27tdf#131622 android: Extract native libs againMichael Weghorn
Commit 66518ead516e90d606e87c6ce58ec11fea6d172e ("use extractNativeLibs="false" for less disk usage and faster installation", 2017-08-31) had set 'extractNativeLibs="false"' in Android's manifest for the debug build case, which prevented the shared native libraries from being extracted on the device. However, while e.g. liblo-native-code.so can be handled just fine when it is in the APK in uncompressed form, the NSS library tries to load modules at runtime by using an explicit path to the module (like '/data/user/0/org.libreoffice/lib/libnssckbi.so'; due to 'LO_LIB_DIR=file://$APP_DATA_DIR/lib/' set in fundamentalrc (as defined in build.gradle)), but the library was no longer there, so NSS initalization failed (s. 'nsscrypto_initialize'). As a result, Android Viewer was unable to open encrypted/password-protected files. Therefore, extract the libs again for the debug case as well to make that work again. (Release mode still had 'extractNativeLibs="true"' anyway.) Side note 1: According to [1], it should in general also be possible to use 'dlopen()' for dynamic libraries inside zip files (like the APK): > Note that in API level 23 and above dlopen(3) will > open a library from any zip file, not just your APK. > Just give dlopen(3) a path of the form > "my_zip_file.zip!/libs/libstuff.so". As with APKs, > the library must be page-aligned and stored uncompressed > for this to work. In any case, if that approach were to be taken, that would need some closer look to make it work, e.g. how to retrieve the actual location of the APK file, how to treat the different architecturs, whether that works for all supported Android versions,... Side note 2: To debug into the NSS library, temporarily avoiding stripping the debug information as follows helped: --- a/android/Bootstrap/Makefile.shared +++ b/android/Bootstrap/Makefile.shared @@ -68,7 +68,7 @@ $(SODEST)/liblo-native-code.so : $(OBJLOCAL)/liblo-native-code.so $(SODEST)/nss-libraries : mkdir -p $(SODEST) - $(foreach lib,$(NSSLIBS),$(STRIP) -o $(SODEST)/lib$(lib).so $(INSTDIR)/$(LIBO_LIB_FOLDER)/lib$(lib).so;) + $(foreach lib,$(NSSLIBS),cp $(INSTDIR)/$(LIBO_LIB_FOLDER)/lib$(lib).so $(SODEST)/lib$(lib).so;) $(SODEST)/libc++_shared.so : $(ANDROID_NDK_HOME)/sources/cxx-stl/llvm-libc++/libs/$(ANDROID_APP_ABI)/libc++_shared.so cp $< $@ [1] https://github.com/aosp-mirror/platform_bionic/blob/master/android-changes-for-ndk-developers.md#opening-shared-libraries-directly-from-an-apk Change-Id: I7631e4a1e5e3d7b3b589ba09d62b52dc5c55836c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91229 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-27tdf#131622 android: Handle password callback for non-editing case, tooMichael Weghorn
'CALLBACK_DOCUMENT_PASSWORD' needs to be handled when opening a password-protected file, so don't ignore it for the plain viewer case. This makes a password prompt appear as expected when trying to open a password-protected (encrypted) file with Android Viewer, regardless of whether the experimental editing option is enabled or not. Change-Id: Ib7e969a53a484df3e2c7be1a0df4c81a48668045 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91228 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-27tdf#131399 Update java settings after slight java version changeilhan
Under linux, the version is now also checked for changes at startup of libreoffice. Change-Id: I572f718cf5afc83a70d98a6897f1d3d6877644f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91037 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-27tdf#131084 Revert "Drop checking for user extensions w/ the same ID on every ↵Michael Stahl
synchronization" This reverts commit 675295d7e18c1505835893e51a853a5b4ce37ed6. Beyond the user-installed extension problem in tdf#131084 this also breaks bundled dictionaries in instdir/share/extensions, which aren't loaded any more. This is masked by fall-back code that loads dicts from /usr/share on Linux so more noticeable on Windows. Maybe it would be possible to do this only once on user profile creation but i don't know much about extension stuff... Rene points out that Debian packages can install bundled extensions after the user-profile is created so that wouldn't work either. Change-Id: I9f0071c2441a4cf967f8981ef3a3e064197b88aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91226 Tested-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-27sw: DOCX export: ignore linked image with invalid URLMichael Stahl
Word 2013 refuses to open DOCX files with image urls that contain %5C (encoded '\') in path or query (fragment is not a problem). Just don't export such images, they won't work anyway. Change-Id: Iae918791beb8532e76b4f29d49eba6fe0eda8aa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91204 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-03-27tdf#131553: Add unittestXisco Fauli
Change-Id: If43a23f6947ecd70f815dfdc6b9adf2f7af0e84f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91225 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-27tdf#129095 Chart view: fix missing inner chart areaBalazs Varga
If the inner chart area has RelativeSize, always create the plot area with that setting. Regression from commit: 739ed2c29f49ea5e83bcd1352b2644c2e2d09f7b (tdf#115630 tdf#88922 Chart: fix custom legend position and size) Change-Id: I9265843c5d0d148c6a392e440b5d3b0c4ccf0e54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90708 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-27tdf#131380: Add unittestXisco Fauli
Change-Id: I9111c82919b9e30200fbb265143e072f7f3b3363 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91205 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-03-27fix LOGFONTA/GetObjectW() mismatch and remove Skia HFONT hack (tdf#131426)Luboš Luňák
The GetObjectA/W() functions are type-unsafe, and since we #undef GetObject I accidentally used GetObjectW() with LOGFONT that was LOGFONTA. This caused the font name to be broken, which made Skia use a different font. This means that Skia doesn't actually need the HFONT passing hack. Change-Id: I67b8d18fef6a92f8839b1652e051da96d01c3a4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91202 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-27remove one more usage of the all make targetLuboš Luňák
I missed this one in a58e086ededb8442938e81f971dfae36ef7eb076. Change-Id: Ifdce3fad87f07c6c5cc64043bfa76829090804b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91198 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-27tdf#130476 - take into account trailing data type charactersAndreas Heinisch
For hex/octal literals take into account trailing suffix types from GetSuffixType in basic/source/comp/scanner.cxx. The suffix type $ (String) is not allowed for numeric values or hex/octal literals and leads to a syntax error (ERRCODE_BASIC_SYNTAX) during compile time. Change-Id: Id6c4bbf1296361879f7dec461a48bbdc5c683338 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90978 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-03-27cid#1460978 silence various Unchecked return valueCaolán McNamara
and cid#1460976 Unchecked return value cid#1460972 Unchecked return value cid#1460971 Unchecked return value cid#1460970 Unchecked return value cid#1460968 Unchecked return value Change-Id: If32ce2d87c90d5d160aeac0f7a9b86f1c96d7bda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27cid#1460975 Unchecked return valueCaolán McNamara
Change-Id: I37fbce514318609d3b6c99a11070e43e2a03ee03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91194 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27revert the gyp-based nss build changesLuboš Luňák
https://lists.freedesktop.org/archives/libreoffice/2020-March/084769.html etc. This reverts commit c76fdcf1cfa1242e66b50ebe80d6eac1baae37a9. This reverts commit 10f52ab4d27263439d59f55f40e88ad2fde0cf71. This reverts commit eac806e8dcd9ee6439ac8695978ff6b62cc6b8d2. This reverts commit d591a682e46ff352f06a61c024ef661dd17f4ea4. This reverts commit 12235d3390a7fc5146bf65f9d6166034b8a048ee. This reverts commit 23245f723fb29262b8543d6447d1b0bb69cb50fb. This reverts commit 91658b402b66b67c785687d5b3a76e3183fe76bf. This reverts commit 5feadfad0cc3be2680213d2e5f6f786b2f4cc74f. This reverts commit fecca49c309fc723c524f12fa671114b316a5562. This reverts commit c6a9454e744289cf2004b42b3c90854b2db8382b. This reverts commit a1a62a70411cb6041b5930ead08280d5e1e7b5f9. This reverts commit 8512f4ca090c85477a6670438aeefe7fdfcf8a98. This reverts commit 532ffb7a297d55b495141ce33692df5d9917b54f. Change-Id: Iaa48d692bea2ca2468cdd5f8ad26ad91c0c31dde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91199 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-27add text alignment support to treeview entriesCaolán McNamara
Change-Id: I3ebbaf7b722ad9b6f2b8fadb443053ea816d1643 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91147 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27cid#1460977 Unchecked return valueCaolán McNamara
Change-Id: I8399df5aabae57df79c5e45a9b85fead482cde8e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27cid#1460973 Explicit null dereferencedCaolán McNamara
Change-Id: Ibdeae2e76cda7cf13cb5f3db998462c1ada7bb96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27cid#1460974 Unchecked return valueCaolán McNamara
Change-Id: Ie5b9d9d074ec19ab6f8b08cd9959680677925cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27selecting multiple slides and using "print..." doesn't set selection as rangeCaolán McNamara
start impress, copy the default slide a few times, select more than one slide and use "print..." "slides" is selected, but just the first selected slide is shown in the range since... commit 76e22667625ce8d16dfaa8617a199b774e987a70 Date: Thu Jun 14 23:29:34 2018 -0300 Configures page range in print dialog where aPageRange = aBuf.getStr() was removed, but if that line is removed then the surrounding loop of "for (auto pPage: *pPageSelection)" just accumulates text in the OUStringBuffer to then discard it and no longer makes sense perhaps this was an oversight rather than a planned change. Change-Id: I39e76c70714ee39d189016179fb1d13a71ec74ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90994 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27KJ: Add light shadow to many multiple line iconsRizal Muttaqin
- Update RTL support - Update Subscript & Superscript icons - Update Clear Direct Formatting icons Change-Id: I3910f3ed084bccf6619c06f54e71d55ca89db4b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91189 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-03-27cid#1460969 Uninitialized scalar fieldCaolán McNamara
multiple ctor's strikes again Change-Id: Ieaae6d5c9e76a3ade17289ce7d1bdffad1168cc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91191 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27these methods can take a const argumentCaolán McNamara
Change-Id: I0ec68d40dcc34075c72c0d60d3a4b6e8262a8e0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91152 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-27clean-up SdPdfFilter implementationTomaž Vajngerl
Change-Id: I17f76ac8eaf8781deef076ca99c21bab7b62569e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91156 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-09 03:02:28 +0000