summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-09Fix typo in wordml2000_drawJulien Nabet
Change-Id: I95d32b1e9b6058b35566d629a813a9f9a64e7e4e Reviewed-on: https://gerrit.libreoffice.org/46137 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-09Fix typosAndrea Gelmini
Change-Id: I21d0277a010e589b1e3aa91be55cb515fa3bdc4d Reviewed-on: https://gerrit.libreoffice.org/46129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-09tango sd layout icon optimizationandreas kainz
Change-Id: Ib348ae7ffe0692a717d586451edbf732dafd58a2 Reviewed-on: https://gerrit.libreoffice.org/46131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-12-09Name it what it is, the format category for the sidebarEike Rathke
Change-Id: Ice6bbfc5f9412ba2d7bce7fb63782a12b48304a1
2017-12-09Rip out already masked out css::util::NumberFormat::DEFINED in casesEike Rathke
Change-Id: Ic769a755fba5cf89596509098ec6dff4fc011598
2017-12-08GetCurrentNumberFormatType() mask out the user defined bitEike Rathke
SvNumberformat::GetType() includes css::util::NumberFormat::DEFINED whereas SvNumberFormatter::GetType() does not. For the type determination we don't need the user defined bit, or even don't want it to be a different type. Change-Id: I713eeb25af01110a0f27bc0c082a7483efdf55db
2017-12-08SvNumberFormatter::GetType() constEike Rathke
Change-Id: Id5392ec8996d157ac1be21cb24f0ab7fff18df27
2017-12-08cppcheck: fix some reportsJulien Nabet
variableScope reports in comphelper/drawinglayer/editeng +filter/framework/l10ntools Change-Id: I4575428773e8b9b3efedabb44fdcd6d8175ac46a Reviewed-on: https://gerrit.libreoffice.org/46116 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-08We already have the type, use itEike Rathke
Change-Id: I77e968e91d6ba44df8a70453f90d11249845a7b3
2017-12-08Build fix: forward-decl rtl::OUStringEike Rathke
Change-Id: Ib871438c9e52c533106a6a0270de54b359a11741
2017-12-08Build fixSzymon Kłos
Change-Id: I33db5c70b579aa65c9659e9ddddad77a5ec12ecc Reviewed-on: https://gerrit.libreoffice.org/46127 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-08A "standard" format does not necessarily mean the General formatEike Rathke
Actually there can be up to three and most times are at least two (short,medium[,long]) of which usually the medium default is General. Change-Id: Iab853fbaa2db3dca488ee40f63271ccd55b6b517
2017-12-08tdf#114243 sot: catch exceptions in SotStorage::GetFormatID()Michael Stahl
This function returns an error code so it might as well convert exceptions to that for the benefit of clients like lcl_ReadSections(). Change-Id: Iccf21bf64ee81b66dd9b9902b9b952fa48a318e5
2017-12-08bridges: [loplugin:includeform] gcc3_linux_intelMichael Stahl
Change-Id: I0a60521e893990af63d723871edcbc564b135074
2017-12-08vcl: Rectangle does not name a typeMichael Stahl
Change-Id: Ia90b67d80383856f0b277a86117ced3732a2ac24
2017-12-08Avoid iterating over selected cells' attribute rangesEike Rathke
Change-Id: Ieb233f6e952dfea0461976c3a7ea9df862f72969
2017-12-08Call GetItemState() only once per WhichID loopEike Rathke
Change-Id: Ic14015692bc934f06fb8371216ae5e3e1afe5afd
2017-12-08valgrind: some more html parser leaksCaolán McNamara
Change-Id: If8a1481ccc71616331d890b15712aafd4bc731ff Reviewed-on: https://gerrit.libreoffice.org/46105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08we only check for the presense of m_pCnts, not use itCaolán McNamara
Change-Id: I298a188cc236c5f6bbc1d3be04630fce03ca62d4 Reviewed-on: https://gerrit.libreoffice.org/46103 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08New --enable-compiler-plugins=debug modeStephan Bergmann
...to enable debug-only code in the plugins. Some situations in the plugin code should never happen, yet must not by default report errors or trigger assertions, as some newly written LO code could trigger them nevertheless (in which case the plugin code will likely need to be adapted, to cater for these presumed-impossible situations). Such code can now be included in the plugins behind an if(isDebugMode()) guard, and can explicitly be enabled with --enable-compiler-plugins=debug. I deliberately made this a runtime rather than a compile time option (using some #ifdef guards in the plugin code, say), as it IMO keeps the code more readable, and also allows overridding COMPILER_PLUGINS_DEBUG=... on the make command line. Change-Id: Iea4f0c2783ad968a0de097fa710b3be1a248de73 Reviewed-on: https://gerrit.libreoffice.org/46096 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-08Slightly change state method logic, tdf#86085 follow-upEike Rathke
It is unnecessary to obtain the SvNumberformat, we already have the type information of the selection, so use that if the item state is not DONTCARE. Also, SfxRequest::Done() needs to be called in the excute method to flag the slot execution as not cancelled. Change-Id: I2fbb8df9b8233fc45552540b996bc6b45a16cbc2
2017-12-09Use ImplIsFloatingWindow instead of dynamic_castPranav Kant
Change-Id: I09f351ae5d8d1b5c1a405d7aa8082be6014268b3
2017-12-09lokdialog: Move lok cursor invalidation callbacks to vcl::CursorPranav Kant
Change-Id: I5cbb845259b6802fb2a0776f8d8f19f9680115ad
2017-12-09lokdialog: Open floating window on InitShow onlyPranav Kant
Okay, my bad. InitShow happens after Visible. And InitShow also does some layouting. Emitting the created callback on InitShow means sending more accurate sizes, etc. The different in sizes is 0 for combo boxes, but significant for custom controls like color picker, etc. So emit created callback on InitShow to keep custom controls working. Change-Id: I40b6a18b917dff0eebcfd4c273f3399f3bdc7456
2017-12-08tdf#45904 Move _XDatabaseRanges Java tests to C++Jens Carl
Change-Id: Iee6753fd60fefc1ecd17ba8fe0acef58f17d64e6 Reviewed-on: https://gerrit.libreoffice.org/46076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08tdf#114308 Export Watermark size as isSzymon Kłos
* refactoring * removed size hack * export/import "trim" attribute * DOC: export set of parameters to fit shape & frame Change-Id: Ib00654626ae1e10ac5110d22eada7528e03357e7 Reviewed-on: https://gerrit.libreoffice.org/46036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-12-08tdf#71737 xmloff: ODF 1.2 doesn't allow hyperlinks in ...Michael Stahl
... text:illustration-index-entry-template, so store these elements only in ODF 1.2 extended, and in loext namespace. Change-Id: Icf919e91114f5c9aed2adc3f5359b9df61eb3433 Reviewed-on: https://gerrit.libreoffice.org/46088 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-08tdf#86085 add slot for toggling thousands separatorJim Raykowski
In preparation of adding a button to the toolbar. Change-Id: Icd97f828def1aacbb92297e8e74bdd2310c4d0f8 Reviewed-on: https://gerrit.libreoffice.org/45731 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-12-08use afl html_tags as htmlfuzzer dictionaryCaolán McNamara
Change-Id: I5374c497f9d8f1a0616e123b503d2f9b642edc33 Reviewed-on: https://gerrit.libreoffice.org/46104 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08ofz: fix mem leakCaolán McNamara
Change-Id: I295e52723297b257dcfe532108471702631ca5f5 Reviewed-on: https://gerrit.libreoffice.org/46093 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08sw lok: enable Page Header/FooterHenry Castro
Change-Id: I5e0d080c53079069a086f06c2a314b6372bf6391 Reviewed-on: https://gerrit.libreoffice.org/39782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-08Fix isSalCallFunction so it also works on WindowsStephan Bergmann
...where FunctionDecl::getReturnTypeSourceRange returns an invalid range because it fails to take AttributedTypeLoc (as caused by SAL_CALL -> __cdecl) into account. Change-Id: I7835dfca7b890ba1bfdb99adaad78a627b6e0e17 Reviewed-on: https://gerrit.libreoffice.org/45909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-08fix for empty paragraphsTamas Bunth
Change-Id: I0a7432059d5e6f680d4fe2e3cac0f12062533511 Reviewed-on: https://gerrit.libreoffice.org/46100 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-12-08svx: fix loplugin:staticaccess warningsMiklos Vajna
Change-Id: I489709b4eecb9f275e0e329c7bd3c5685f9398dd
2017-12-08svx: fix loplugin:staticmethods warningsMiklos Vajna
Change-Id: I1b9a0a01f88e8faf6a8973848598b77dee10a14d
2017-12-08valgrind: leak with abi2107-1.htmlCaolán McNamara
Change-Id: I86d833a26cb50d65e3ec0f46175e9e6da003944b Reviewed-on: https://gerrit.libreoffice.org/46087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08sccomp: CppunitTest_sccomp_swarmsolvertest fails w/ 32-bit ASANMichael Stahl
Result values look way off, let's just disable it. Change-Id: Ibc473d238a4f3f4f98de59b5f228948b7b64bebd
2017-12-08GetMarkableObjCount() is only compared against 1Matteo Casalin
Change-Id: I390b260fe481c7db73a065dd271c78a5df188ccc
2017-12-08Remove unneeded data memberMatteo Casalin
Change-Id: I9d007f67e5f6024b1eaea10669a915ffd33d7c29
2017-12-08Data members to enumsMatteo Casalin
After 1d852b32d7ad89b2317c04958060f366f8922ca4 these data members were initialized only in constructor and never changed afterwards, behaving de-facto as constants. Convert them to an enum and take the chance to change their type from sal_uIntPtr to size_t. Change-Id: Ief33b7d3cfd3e181837f77c5b8a51812e314121d
2017-12-08tdf#41650 DOCX export: split para on section breakTamas Bunth
Given two pages with entirely different style (resp. not plausible for a single section) and a paragraph which starts on the first page and has a follow on the second. Those page styles are represented in doc/docx structure with sections. Doc/Docx does not support having a paragraph in more than one sections. Workaround is to split the paragraph into more paragraphs and put the section break in between. Change-Id: I4014c45f97e18132470d0d0647bce84831b2460a Reviewed-on: https://gerrit.libreoffice.org/45666 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-12-08Adapt description to realityEike Rathke
Change-Id: I24133fb6c52bd7500037364120cb11d1b1f099c2
2017-12-08init m_pDocShCaolán McNamara
Change-Id: I1966a204be2d5f9d6a3dddd4153c2ded88a4211a
2017-12-08Fix segfault when ScDBDocFunc::AddDBRange is called ...Jens Carl
multiple time with same name. ScDBCollection::NamedDBs::insert() use an unique_ptr to hold ScDBData* and if the insert isn't a success we don't have clean up with delete. Change-Id: I9b24834ea2e2dfd67b07438e6c4789ad0c01b888 Reviewed-on: https://gerrit.libreoffice.org/46075 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-08fix fuzzer buildCaolán McNamara
Change-Id: I87933b78126ffbf29999f4d17b212df21560bdbd Reviewed-on: https://gerrit.libreoffice.org/46080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08crashtesting: crash on import of ooo33887.sxwCaolán McNamara
since commit a172f854b6e1d61bf0fe0fe4efc3058bb7a760bf Date: Sun Dec 3 21:00:37 2017 +0100 tdf#74693: Footnotes text appearing above footnote separator line When invalidate a footnoteframe, invalidate also the lower textframe, so it will be recalculated before text rendering. Change-Id: I95aec5e86bc53126de71bdebe7fbfada955be9c9 Reviewed-on: https://gerrit.libreoffice.org/46085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08sw: remove no longer building debug code in txtedtMiklos Vajna
Change-Id: Id80731a843fae93e752d2da4cec4a82f4c14333b Reviewed-on: https://gerrit.libreoffice.org/46073 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-08tdf#71737: save allows links in illustration index, but load doesn'tCaolán McNamara
since illustration index links were initially implemented by commit 2c10d784deb86501b5488044a61d9fc2efc6321a Date: Tue Jul 16 15:49:44 2013 +0200 fdo#39904, n#825976: implement hyperlinks for Illustrations index (cherry picked from commit 8bb2c7f1556c10508c8ac451c579539ccf5dacfb) Change-Id: I679fb9c40cd5dc55a5d546ef7c533faf9de2e483 Reviewed-on: https://gerrit.libreoffice.org/45967 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-12-08sc lok: 1 view has 1 clipboard to transfer dataHenry Castro
In tiled rendering case, each view copy and paste the contents of the clipboard associated with the view Change-Id: Ic7b0d38ce4741af8c2053926ffd5172ab81aaaf5 Reviewed-on: https://gerrit.libreoffice.org/41113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-08Revert "gpg4libre: make gpgme-w32spawn available also for unit test"Thorsten Behrens
This reverts commit e235dbcb4b2999f5a3f9f42dc723ac7510053a63.