summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-06-29gbuild: recognize newfangled screen TERM=screen.xterm-256colorMichael Stahl
Seems to have changed from Fedora 23, where it was just "screen", to 24. Change-Id: I9078c337093d12d62e9afe10b1f02aaf346d4b43 (cherry picked from commit 4dcba01d97b72db35885c505e647425059740a4c) Reviewed-on: https://gerrit.libreoffice.org/26766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29tdf#100641 correct OOXML function name is EFFECT instead of EFFECTIVEEike Rathke
(cherry picked from commit ed5bcef57b678cb92c68bf842a72e50f4dd1e2ea) accept EFFECTIVE as EFFECT in OOXML import (cherry picked from commit f3f89f4f3180b0fd63c5290c665894c6a27f2ae2) 18a914972d69a37e9dcf5b18ffbea9177004dad7 Change-Id: Ieb7484afe210e378efd43ba3a181cd90d29619b9 Reviewed-on: https://gerrit.libreoffice.org/26704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29external/firebird: Adapt to GCC 6Stephan Bergmann
...which switched defaults from C++03 to C++14, so causes some errors now. Curiously, the throw(std::bad_alloc) vs. throw-anything mismatch between the global operator new replacements and the standard headers is OK for GCC only when there is no further declaration in between the standard header and the replacmenet definition. Change-Id: Ib54727fecf4ad07426b811a9cc04b08ea80e59dc (cherry picked from commit 3179e8f7e6ce550bbe766ed730e68b0374944dd5) Reviewed-on: https://gerrit.libreoffice.org/26768 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-29tdf#100222: Show the dialog just once even if both toggles were changedTor Lillqvist
Change-Id: If6058d68f80ebc3e235f0a681cfe3240985e2429 Reviewed-on: https://gerrit.libreoffice.org/26697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-06-29tdf#75387: Don't case-fold strings for formula group calculationsTor Lillqvist
There should be no need for it as far as I see. Possibly it made some sense back when we thought we could use OpenCL for operators and functions that are supposed to ignore the case of strings they handle. But we hopefully should never try to use OpenCL for string data nowadays anyway. And actually, the case-folding ended up affecting strings handled by the so-called software interpreter. For the tdf#75387, the sample sheet worked fine when OpenCL was enabled. Change-Id: I1c170ebf09551fea0964f394cdb3c65079672257 (cherry picked from commit f948dce856d51704e1962553198015dbebb6e527) Reviewed-on: https://gerrit.libreoffice.org/26746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-29tdf#96540 dragging between sheets can change the current cursor positionCaolán McNamara
so the at position at time of drop may not be that at the start of the drag. So set the current cursor position to ScTransferObj when the drag starts and retrieve it later Related to: commit ac3b66057ba677903b6de354317417b267be0fa0 Author: Kohei Yoshida <kyoshida@novell.com> Date: Thu Sep 16 11:09:29 2010 +0200 calc-selection-fixed-cursor.diff: Migrated n#502717, i#21869, i#97093, when making selection, don't move the cursor position and commit c433fa0639ccf5caeb0c128c8a3794322e2a1c81 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Fri Jul 6 02:04:44 2012 +0200 adjust the calculation of the cursor pos if ALT is used, fdo#48869 Change-Id: I6316717c860d999270aa7f0fb50af5f6dfc7efd7 I haven't used SetSourceCursorPos everywhere a ScTransferObj is created, just where its created through a drag event Change-Id: I50c36b4a2ba45426edebc1f1dfa5e262db3c5d03 Reviewed-on: https://gerrit.libreoffice.org/26512 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit f9b46bbd2446a6c9a0aaab31016536bda4a77294) Reviewed-on: https://gerrit.libreoffice.org/26538 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-06-28Resolves: tdf#100303 Report crashes on close of conditional formatting dialogCaolán McNamara
Condition multiply inherits so the Builder::disposeBuilder call was missed and prenotify occurs during ::dispose when there is no m_pConditionPlayground anymore, so m_pConditionPlayground == 0 where pPlaygroundCandidate is 0 passes, so a random widget gets cast to somethings its not, hence the bad cast exception Change-Id: I6d081dd55df1a68ab893294858e1ab0054d5e049 (cherry picked from commit 547e4b3a80708600edbc3f5669b4428877b5a951) Reviewed-on: https://gerrit.libreoffice.org/26569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-28tdf#98515: Bail out early if kernel would have ridiculously many parametersTor Lillqvist
The Right Thing to do would be to compare the accumulated kernel parameter size against the CL_DEVICE_MAX_PARAMETER_SIZE of the device, but let's just do this sanity check for now. Bail out if the kernel would have more than 50 parameters. Calculating the accumulated kernel parameter size would be more complicated and I don't want to touch this code more than necessary. The kernel compilation will fail anyway if the size of parameters exceeds the limit and this sanity check is just to make us bail out a bit earlier. In tdf#98515 the slowness seems to indeed be caused by the OpenCL code generation , and there the number of parameters was 999, so this sanity check does fix the slow loading issue (I checked). (cherry picked from commit a48aefcae40663b63005d49a04fc7b89a473d613) Change-Id: Iead6dfb94ec8e7b2968ffed9423f0f9522a10ce9 Reviewed-on: https://gerrit.libreoffice.org/26703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-27tdf#100495 sw: Exchange Database shouldn't delete the created odb fileMichael Stahl
(regression from f01f31201f9b26b3071ab25f9a5a3a0311ff7423) Change-Id: Ie5b83a82711229bda045b7ef7a9167cfd873f616 (cherry picked from commit 5a042dad2779eefc76269e14b888bd84df590aac) Reviewed-on: https://gerrit.libreoffice.org/26723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-27tdf#100105 sw: RTF export: fix empty hyperlinksMichael Stahl
For empty hyperlinks the EndURL() is called immediately after StartURL() Due to the way the various buffers are written, the group closing braces are written before the groups are opened, which is rather invalid. Using the m_aRun buffer instead of m_aStyles appears to fix the problem. (regression from b8907bf3d3b37c686a414ffbbd2d732348aab5b9) (cherry picked from commit b4855bd63c05096df1a2da339133f243bb30d902) Reviewed-on: https://gerrit.libreoffice.org/26336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 744bd590fd2c39638e8df41a569cb2cc376e7450) Change-Id: I6910e1afa0ee262ae0496cf1d3aa83ae3e537ad0 Reviewed-on: https://gerrit.libreoffice.org/26699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-26tdf#100411 start the flush timer when batching (PostBatchDraw)Tomaž Vajngerl
When we batch a draw command we need to start the flush timer (if not already started) as otherwise it could happen that we won't flush the offscreen texture at the correct time or at all. This fixes a problem with drawing of pop-up "help" text. (cherry picked from commit e1296e295e7d4f1104d2c90b1f51d52251358bea) Change-Id: I6afcf173c3ac517ed0612cd413d95e28c19faa81 Reviewed-on: https://gerrit.libreoffice.org/26630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-26tdf#100222: Inform user that a restart is needed after toggling OpenCL useTor Lillqvist
(cherry picked from commit c7c27b9b191291cf36e4940aef3e3e7371855797) Change-Id: Ic33cb02440276bc0601c86f2c9eab7d74a6b9874 Reviewed-on: https://gerrit.libreoffice.org/26611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-24package: fix exception handling in DeflateThread (related tdf#91807)Michael Stahl
In the bugdoc of tdf#91807 there are at least 49 corrupt zip streams that raise exceptions in the DeflateThreads. Because the maximum allowed number of threads happens to be 48, this results in an infinite loop in ZipOutputStream::reduceScheduledThreadsToGivenNumberOrLess(). (regression from 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14) In case an exception is thrown, don't re-throw it immediately, which might cause trouble such as leaking all of the ZipOutputEntry instances in m_aEntries. (cherry picked from commit 8d8b9b80b114b94b20b0bf1438d80e925b49e3bf) sfx2: exception on storage commit is an error (related: tdf#91807) For no good or obvious reason, SfxMedium::StorageCommit_Impl() swallows embed::UseBackupException if there is a pTempFile, which (as the comment claims) is "always now". This results in the temp file actually being copied to the user-visible file and the SaveAs "succeeding", when it clearly did not. Also move the exception throwing to the end of ZipOutputStream::finish() to avoid more memory leaks. (cherry picked from commit 9084c11fb472f2024e609770ce922c911227e7a8) Change-Id: I448cc43291754ef20adfa6b65916282fcc365a11 Reviewed-on: https://gerrit.libreoffice.org/26618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-23Resolves: tdf#100460 queryContentCells doesn't count annotations...Caolán McNamara
since commit c06dbbe7594c2a0b5a5b19f8e183d9c421e6e094 Author: Markus Mohrhard <markus.mohrhard@googlemail.com> Date: Thu Feb 23 23:36:49 2012 +0100 remove mpNote from ScBaseCell (cherry picked from commit 83f977c7f40d1a5fb975b8ce7c9958c992dba3f1) Related: tdf#100460 GetNotesInRange doesn't count last cell in range e.g. open document from tdf#100460 and select select A20:A21 and right click and there is a hide comment entry. Shrink the selection to just A20 (which has the comment in it) and the right click menu has no hide comment entry in it. std::for_each(it, itEnd means it < itEnd but here we want the rows indicated by nStartRow <= nEndRow so we need to increment itEnd by one to get the right range (cherry picked from commit 84dc0157df9cb173ec74da2bd27507329efc3816) Change-Id: I281a207e26aec8886b1f46b9279e1135b61586da 48e8c0748f520671e09f04b16961bf9729960317 Reviewed-on: https://gerrit.libreoffice.org/26614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-23VclPtr: svtools error message dialog doesn't disposeCaolán McNamara
Change-Id: I83640cc60d5e0239d228c749c32f896df5e2d9f2 (cherry picked from commit d531743ca34232aedc0b437a9ff5807dea8d51ed) Reviewed-on: https://gerrit.libreoffice.org/26588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-06-23tdf#100451 convert texture buffer to 1-bit and 4-bit palette bufferTomaž Vajngerl
OpenGL doesn't support palettes so when the texture is created, the bitmap buffer is converted to 24-bit RGB. This works nice for showing the bitmaps on screen. The problem arises when we want to read the bitmap buffer back (like in a PDF export) as we have to convert that back to 1-bit or 4-bit palette bitmap buffer. For 4-bit this was not implemented yet, on the other hand for 1-bit it was implemented but it didn't take palette into account so the bitmap was not correct (inverted). This commit introduces a ScanlineWriter which handles writing RGB colors to 1-bit and 4-bit palette scanlines. The class sets up the masks and shifts needed to place the color information at the correct place in a byte. It also automatically converts a RGB to palette index. Change-Id: Ie66ca8cecff40c1252072ba95196ef65ba787f4c Reviewed-on: https://gerrit.libreoffice.org/26532 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/26534 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-06-23framework: avoid excessive queryDispatch callsThorsten Behrens
Make better use of the css::frame::XInterceptorInfo interface, to avoid calling queryDispatch() pointlessly on interfaces that have explicitely opted out. Since that already broadcasts which urls we're interested in - so just don't bother calling entries who are not matching. Change-Id: Id5e780568fd60c38f4cee4ee800d747d65a31dae Reviewed-on: https://gerrit.libreoffice.org/25214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 27b6cdb5ab5af33dbba561923c8db81e144c88b9) Reviewed-on: https://gerrit.libreoffice.org/26358 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-22Resolves: tdf#96251 address wizard crash when run from start centerCaolán McNamara
Change-Id: I20de1fbdd3ca609a1818dfe8f81ba66b1cb15281 (cherry picked from commit d6665da4eae15cf21eecaf048d1c9eb7381b3b99) (cherry picked from commit 1cf6c67f629dd21a0fbcd223ef0dcdfabd4b6a9f) Reviewed-on: https://gerrit.libreoffice.org/26408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-22Resolves: tdf#90579 swap_single_to_multi_blocks is brokenCaolán McNamara
when there is associated data in the src. Its copies those pointers into the block that will appear in the destination. Then can destroy the source block, which deletes the contents of those pointers, and then inserts the new block which has dangling pointers to the deleted data. https://gitlab.com/mdds/mdds/merge_requests/2 (cherry picked from commit 9ec54e92407cd632c4e38317f914edd557835a86) (cherry picked from commit 6114072a59cfff36218aea70e1b52fa4c3ba64b4) Change-Id: Id9614d95652c8032b03cb5748a284917043d8d21 Reviewed-on: https://gerrit.libreoffice.org/26429 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-06-21update creditsChristian Lohmaier
Change-Id: I98c62533785a72b88044fb36bda3edd010aa6bb9 (cherry picked from commit 614d20645065cab2467b7419707a1eda69992cdd)
2016-06-21tdf#100455 check for minimal dconf versionDavid Tardon
Change-Id: I8e164bb4afc221cefd93d519569cdefa4486349f (cherry picked from commit 461e91ca91186c1ed23316127fffe4230e3aacd2) Reviewed-on: https://gerrit.libreoffice.org/26539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-20tdf#98955 hardware_concurrency not ideal for thread poolsAshod Nakashian
A new static member getPreferredConcurrency added to comphelper::ThreadPool to return a configurable max number of threads. By default the new function returns the hardware_concurrency value provided by std::thread. When MAX_CONCURRENCY envar is defined, the return value is limited to whatever is set there. Three call-sites that used std::thread::hardware_concurrency have been replaced with getPreferredConcurrency. Unittests added to cover the functionality of the new member. Unittests are capped to 4 threads. Reviewed-on: https://gerrit.libreoffice.org/26254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 60e75fb276778459f6055360646d879b8c615d83) Change-Id: I3332e393a88a5ed436316fa712ed920a4b37f4af Reviewed-on: https://gerrit.libreoffice.org/26394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-20rhbz#1343752 fix view status in menuDavid Tardon
... after commit 229fc164dc1773484b74eca016863cf68860e81b . Change-Id: Ibfbbb86c81527f008b8e1cbe9d8ca3174a944931 (cherry picked from commit c4c7fe98b0f05329edf7930ff92b44892d4724e6) Reviewed-on: https://gerrit.libreoffice.org/26500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-20cppuhelper: fix use-after-free race in OWeakConnectionPointMichael Stahl
OWeakObject::m_pWeakConnectionPoint is returned from OWeakObject::queryAdapter(), and stored in OWeakRefListener::m_xWeakConnectionPoint. This is cleared in OWeakRefListener::dispose(), called from OWeakConnectionPoint::dispose(), called from OWeakObject::disposeWeakConnectionPoint(), but it can happen that another thread is in WeakReferenceHelper::get() and has copied m_xWeakConnectionPoint onto the stack before the OWeakObject is released and deleted, then calls OWeakConnectionPoint::queryAdapted() after it is released, accessing the dead m_pObject. (cherry picked from commit 131e604073f89e6c1dd54be88b94b7befd881f2e) Change-Id: I7782e6fb7e07f5a48cf7064115217376714ba8e8 Reviewed-on: https://gerrit.libreoffice.org/26441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-17Resolves: tdf#82532 parent mutex dtored before child dtor uses itCaolán McNamara
Mutex belonged to DisposeListenerGridBridge which inherits from FmXDisposeListener, FmXDisposeListener dtor accesses a reference to the parent mutex in its dtor, but the mutex has been destroyed at this point. Move the mutex from parent to child. FWIW these classes are on the candidate list to merge. (cherry picked from commit e841ed93d6c6d817be1f7fdc18ff971325c861cc) (cherry picked from commit 1c0d1199fe02666de0d162f071ce7e6e812a23df) Change-Id: Ic639eaed97c2b0625c368ed249f09920af37f94e Reviewed-on: https://gerrit.libreoffice.org/26382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-17sw: speed up the navigatorMichael Stahl
The call to SwTextBoxHelper::findTextBoxes() in SwDoc::GetFlyNum() made this so unbelievably slow that in a dbgutil build opening the navigator on the bugdoc of tdf#94212 the UI freezes because getting all the fly frames takes longer than the 1 second timeout. Lets's not retrieve the flys one by one but instead all at once, which makes it usable again. Change-Id: Ic41c1648a82dcc3f758ae1b08bac6058f541f25e (cherry picked from commit 5593d9e1422cbf8a122fa612713a832274d30559) Reviewed-on: https://gerrit.libreoffice.org/26428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-17cppuhelper: WeakReference isn't thread-safeMichael Stahl
... but its documentation claims that it is, which is partially misleading, so fix both the documentation and the data race in WeakReferenceHelper::clear(). This actually crashed in clear() in the multi-threaded ZipPackage code on exporting the bugdoc from tdf#94212, presumably because clear() races against OWeakRefListener::dispose(). (cherry picked from commit debe788bcf3ec258b6b95df3db1f7bfeba881be1) Change-Id: I85665c11b8157e90d15e8263758e24e66efeb86c Reviewed-on: https://gerrit.libreoffice.org/26427 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-06-17tdf#100453 – bin/unpack-sources needs to be executableChristian Lohmaier
otherwise building from source-tarballs fails when it tries to extract fetched submodule tarballs Change-Id: I75bcd6821e244ca2a3375ec2916ee7c38ec9844e (cherry picked from commit 10f112376b5767aacef99aff239c87b17ac38d27)
2016-06-17tdf#79198 START CENTER: Close button doesn't reappear after being clickedAkshay Deep
Change-Id: I23e3aed71eec85e8b8f0aceac125809fd56be4d5 Reviewed-on: https://gerrit.libreoffice.org/26399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 27bd030aa033565dfdff56c298c797c80cee5160) Reviewed-on: https://gerrit.libreoffice.org/26416
2016-06-16crashreport: 644837b5-c445-4779-a75d-dd69fc2e3a6fCaolán McNamara
drop hint of previous window to get mouse wheel event when that window is disposed in order to drop any references to it immediately that happens to avoid anything else lingering too late move the VclPtr into ImplSVData alongside the rest of the things like this so we can remove the static VclPtr which itself replaced a relatively harmless static Window* (cherry picked from commit bdfccfde308f0267965933a8273e6e9201a2c67c) (cherry picked from commit 35205c6e3e2f85d9b7db935689ec949c98e7e431) Change-Id: I1e172071b711b6e4ded9a813ee3de730d3dfdf38 Reviewed-on: https://gerrit.libreoffice.org/26337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-16tdf#100275 sw: fix target node of bookmark copyMichael Stahl
Replaces the defensive programming band-aid of 5c1a1d1c66aff497702abc20df5832fa348f1008 with a real fix. The problem is that lcl_NonCopyCount() has some special case code to ignore the first node in the target document, which erroneously is executed for every bookmark, which results in the 2 bookmarks in the bugdoc being created with nDelCount 1 and 2 so they land on the same node, which is not allowed for cross-reference marks. Extract the adjustment into a separate function that is called once. (regression from 689962feae2054f965a7378c3408b0ccfad2bbd5) (cherry picked from commit bc387975b11d87868884ec770a2a42a4f7092b5f) Change-Id: Ie14c650f7fdb259c13cb9048226da30971d2ab3c Reviewed-on: https://gerrit.libreoffice.org/26291 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-16tdf#97501: crash in SwDBManager fixedOliver Specht
copy the connections to a temp container and iterate that because disposing connections changes the data source params container Change-Id: I06c59a19a6bcf97a541b32481d1d2a63f5c34032 Reviewed-on: https://gerrit.libreoffice.org/22027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de> (cherry picked from commit 4426c20cf308f3bf7a2d3b33f9996687113c22e3) Reviewed-on: https://gerrit.libreoffice.org/26304 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-15/org.openoffice.Office.Writer/FormLetter/MailingOutput/Format is xs:intStephan Bergmann
...i.e., sal_Int32. Regression introduced with ba9acdf799bf556c8a20b1dc27eb116e23d481db "convert TXTFORMAT constants to scoped enum". (The problem with storing a sal_uInt8 in an Any is that sal_uInt8 == sal_Bool, so actually a Boolean Any is constructed---and configmgr will throw an exception when trying to set that value for the "Format" prop. The problem with extracting a sal_uInt8 from a sal_Int32 Any with getValue/static_cast is that it doesn't even read (only) the low order bits, but on big endian machines reads the high order bits.) This is a backported version of 25a60d19d56a4bdb4f1b6ef27d842f90617fcff8 "/org.openoffice.Office.Writer/FormLetter/MailingOutput/Format is xs:int" which uses o3tl::doAccess newly introduced on master. Change-Id: I654da713bbf78b3215de7a09056a5172fc204258 Reviewed-on: https://gerrit.libreoffice.org/26285 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit abca482aebeb01d516816b543a07edc1dd178240) Reviewed-on: https://gerrit.libreoffice.org/26286 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-14update creditsChristian Lohmaier
Change-Id: Ie4c9f67d07d81c0724c206c3a309dd5ec68fb963 (cherry picked from commit 962b0aca0ee38e25364c6e2dee5267c213d8fc39)
2016-06-14Updated coreChristian Lohmaier
Project: translations 05976795240823d58b9f15bcbf6c84015338880d update translations for 5.1.4 rc2 and force-fix errors using pocheck Change-Id: I4574c1b2e1e4a0dbd1bb8c36cdbef009644d54fa
2016-06-14Resolves: tdf#90419 diminish precision error in Series FillEike Rathke
There may be more elegant ways to accomplish this, go and find one.. Change-Id: Iceaa0783db9cf3d3e1aa20f075fe7e0618a1feb6 (cherry picked from commit e89c0e4fb783bd36d5f5fea154ee8608e542dae4) Reviewed-on: https://gerrit.libreoffice.org/26220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-06-14tdf#100342 fix order of weekdays in NETWORKDAYSWinfried Donkers
For the definition of working/weekend days, ODFF1.2 uses 0..6 for Sunday..Saturday. NETWORKDAYS used ISO ordering (Monday..Sunday), but now complies with ODFF1.2. Change-Id: I169433adfac5d66af979181c328658040d7ab77f Reviewed-on: https://gerrit.libreoffice.org/26246 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit d81fa4eb3a8960c1a1280fdd07bafa29de8290d2) Reviewed-on: https://gerrit.libreoffice.org/26270
2016-06-14check ExternalSingleRef token for svDouble typeEike Rathke
... before accessing GetDouble(). Else convert the string. The new assert() introduced in FormulaToken::GetDouble() virtual dummy was hit by loading gnome334723-1.sxc Change-Id: I144b0cabee3aac44d206d76a83b1c4d81ab4a02e (cherry picked from commit 243f19a1878d52a4074b59041dc3bc57ab84e417) Reviewed-on: https://gerrit.libreoffice.org/26261 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14tdf#96887 vcl: stop using periodic timers on WNTMichael Stahl
Every time the periodic timer fires, it does a PostMessage() to the main thread. The main thread will only process the first message and discard the rest anyway, but with a short enough timer and other threads hogging the SolarMutex it's possible that the message queue overflows and other PostMessage calls fail with ERROR_NOT_ENOUGH_QUOTA. Try to avoid the problem by having the WinSalTimer always be a one-shot timer; when it fires and the main thread processes the posted message, it is restarted with the new due time. This requires creating a new TimerQueueTimer because ChangeTimerQueueTimer only works on periodic timers. Change-Id: I816bd3fa5fbfbea4f26be8ff680a1c916618d3f9 Reviewed-on: https://gerrit.libreoffice.org/24024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/26257 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-06-14tdf#96887 enhance SolarMutex AcquireWithWait for WindowsArmin Le Grand
Currently the Windows-specific method ImplSalYieldMutexAcquireWithWait() uses a messaging mechanism to learn about the SolarMutex being free again. This is not reliable when the MessageQueue overflows (MS allows 10000 messages per queue). It is more safe to use MsgWaitForMultipleObjects. This also allows to not only wait for the SolarMutex to be freed, but also to detect when SendMessage() is used which needs to lead to a reschedule to not block current Window handling. Change-Id: Id317dda62aaa1fe7677d8d28929e6936e5a22705 Reviewed-on: https://gerrit.libreoffice.org/23921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-on: https://gerrit.libreoffice.org/26256 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-14Resolves: tdf#92478 avoid crash on using scanner on windows x64Caolán McNamara
which appears to correspond to backtrace http://crashreport.libreoffice.org/stats/crash_details/ad46ef89-6b98-44f9-b060-ccb25015269d (prevents the crash only, does not enable scanning on x64) Change-Id: Ic5a4b66028db6ba4aea08baf5bf4a672f71745a0 Reviewed-on: https://gerrit.libreoffice.org/26197 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 7c983445656e1f1942cf2d7398a77342004ed168) Reviewed-on: https://gerrit.libreoffice.org/26248 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-14tdf#83455 Remove color-inverted line images from SifrAdolfo Jayme Barrientos
Change-Id: I3cee31526c0789e059730f303250eae0e79bf166 (cherry picked from commit ffac8e3a483c84de2961784fceac2b21aa39a18c) Reviewed-on: https://gerrit.libreoffice.org/26214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-14Resolves: tdf#100272 row ally index is ROW_INVALIDCaolán McNamara
which is < 0 so bad things happen, consider ROW_INVALID/COL_INVALID before looking for a11y child at that index (cherry picked from commit 0f32ba56a1e775e8ecd6c827ebd48f7f2fb51c81) (cherry picked from commit 652026f0e2f9c323229151e854ad6591791e098e) Change-Id: I16a9d86879e1a894c63932705c056268e98db7aa Reviewed-on: https://gerrit.libreoffice.org/26186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-13Place help button on the left in dialogOlivier Hallot
The New folder dialog, that is opened by the Template Manager dialog has now the help button on the left. Change-Id: Iabc55a031247e1ea33887dffc929dde17549f8fb Reviewed-on: https://gerrit.libreoffice.org/23740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 82d14b4f9c086c48214445b8e49fdd748e13c05f) The label of this dialog can grow very long… … so place it above its associated entry. Change-Id: I8fce05bef2cb6ea4589caed60f9384fb42170234 (cherry picked from commit 72cbcf97fadd46a6895797beb37aaa379e015855) Reviewed-on: https://gerrit.libreoffice.org/26212 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-06-11tdf#99795 drawAlphaBitmap should scale the bitmap if necessaryTomaž Vajngerl
drawAlphaBitmap didn't use a high quality scaler for scaling the texture but used the default scaling method in OpenGL (either GL_NEAREST or GL_LINEAR, whichever is defined when texture is created) which are low quality scalers - especially when downscaling textures. Change-Id: I6236b2ee92b9e5044b176a40a444027072b09b58 (cherry picked from commit 19baa61e1d7b140b9e24717f7080617ab3d324d4) Reviewed-on: https://gerrit.libreoffice.org/26100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2016-06-11Related: tdf#99446 cairo text + xrender bodgeCaolán McNamara
(cherry picked from commit 1d18db339242a535d956b7e944ad1488fd2b4fd8) Change-Id: I926881bcfa4911f3d7f4899711be44a2f6d82026 Reviewed-on: https://gerrit.libreoffice.org/26087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-11Resolves: tdf#93135 can't resize shape with "resize shape to fit text"Caolán McNamara
These are regressions from... commit 4a847bb4a2002d7f8f5854b7276ac67d369bdd3b Date: Sun Aug 2 21:20:48 2015 +0200 tdf#93079: "resize shape to fit text" state can't be disabled Wrong copy-paste and commit b2bae9b940fc34d2eecd7839e3cba1f41d111e87 Date: Thu Apr 9 23:38:47 2015 +0200 Related tdf#34467: Fit to Frame for text boxes is broken Wrong Copy-paste Its turns out that there is *no* SDRATTR_TEXT_AUTOGROWSIZE property. Only a SDRATTR_TEXT_AUTOGROWHEIGHT property e.g. see CustomShapeProperties::UpdateTextFrameStatus of svx/source/sdr/properties/customshapeproperties.cxx "change TextFrame flag when bResizeShapeToFitText changes (which is mapped on the item SDRATTR_TEXT_AUTOGROWHEIGHT for custom shapes, argh)" So the inconsistency between getting the itemstate of SDRATTR_TEXT_AUTOGROWSIZE and then setting/getting SDRATTR_TEXT_AUTOGROWHEIGHT is better resolved by getting the itemstate of SDRATTR_TEXT_AUTOGROWHEIGHT will have a follow up patch to remove SDRATTR_TEXT_AUTOGROWSIZE to show its not used by anything Change-Id: I8b8abde17c15761c621815ed2be62d6a8a5cd69a (cherry picked from commit d1df071c3fc452817746a8daa13000d2df667aba) (cherry picked from commit 65d1e5294c9f0d9300dbb92f6670cdcafa8a1ac2) Reviewed-on: https://gerrit.libreoffice.org/26089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-11Resolves: rhbz#1343766 a11y queries during dispose trigger combobox crashesCaolán McNamara
Change-Id: I29863ca95e64ccd31795f78c29c89ff35009d718 (cherry picked from commit f120abb446bf3f5230ed06a3b148654dde36bb94) (cherry picked from commit f7b0cbf1df98a1c42fe25cfdbd9977fba78347c8) Reviewed-on: https://gerrit.libreoffice.org/26057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-11Resolves: tdf#100285 EASTERSUNDAY() check valid year between 1583 and 9956Eike Rathke
Change-Id: I4b25f1eb8e3cf0236b69607bb9ab9b4c57ae918a (cherry picked from commit 2c08ec226e771de10c8863b7f1cda016fea442d2) Reviewed-on: https://gerrit.libreoffice.org/26109 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-11Resolves: tdf#100181 quickstart crashes immediately without QuickstarterCaolán McNamara
Change-Id: I0257651b3841dea596077cfacbf7d69a20b04252 Reviewed-on: https://gerrit.libreoffice.org/26134 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit dfb2a8deab1324047a4ed81a131a1ef3552c3e8e) (cherry picked from commit dd02cca2e64b061ddd5003ad0485dcbfae7f5ddf) Reviewed-on: https://gerrit.libreoffice.org/26149 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
generated by cgit (git 2.34.1) at 2025-02-13 00:56:41 +0000