summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-10svx: Kill non-existent external pszStandardTakeshi Abe
which was gone at cbcfda9b2079ea4ef83b2a42828408b5f70f7692. Change-Id: I37dea6c6696b03443bad255b68e78eaf3ff0dae5 Reviewed-on: https://gerrit.libreoffice.org/39746 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10simplify strip types from Sequence, related tdf#108782Jochen Nitschke
Change-Id: I504d7d118d30a310bbb0199de8b9fd58f2bcaaa6 Reviewed-on: https://gerrit.libreoffice.org/39751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10sw: prefix members of SwDrawViewMiklos Vajna
Change-Id: I8d18efcc609dfc2d5154bfae8799f3517bc3e48f Reviewed-on: https://gerrit.libreoffice.org/39738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-10sd: fix unitialized "pItem" pointer in SlideBackground::SlideBackgroundMarkus Mohrhard
/sd/source/ui/sidebar/SlideBackground.cxx:176:17: runtime error: downcast of misaligned address 0x00009cf8cd67 for type 'const SvxSizeItem', which requires 8 byte alignment (regression from fba28df77d7e98663d1cf77ac206f8799fce4108) Change-Id: I822efe57f35c851b6f63e1e5489ab2448a19963d Reviewed-on: https://gerrit.libreoffice.org/39753 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-10Use const (I)FormulaToken* where possibleEike Rathke
Actually only the SvTreeList::InsertEntry() needs a non-const void* Change-Id: I63eb05ba63264efd63bfa287f0ab0bf2840b4414
2017-07-10loplugin:useuniqueptr in vclNoel Grandin
Change-Id: Ieece2f9728755a8ae91275535eaa39319eea274e Reviewed-on: https://gerrit.libreoffice.org/39740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10loplugin:useuniqueptr in hwpfilterNoel Grandin
Change-Id: Id271fdb59cb0dedf2f180879d2116d11e45d68b3 Reviewed-on: https://gerrit.libreoffice.org/39739 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10lok: sc: missing invalidation on pasting text and deleting a cellMarco Cecchetti
In the desktop case we invalidate up to the right side of the visible area, however in the tiled rendering case we need to take care to invalidate also cached tiles. Change-Id: I7290ff35c155fab6bda3ce8b5d9c765624507052 Reviewed-on: https://gerrit.libreoffice.org/39728 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10Remove useless method OCommonAccessibleText::getTextArnaud Versini
Change-Id: I4ee2df05ffceaea9d22ec7e2f78dc6e13061b5ef Reviewed-on: https://gerrit.libreoffice.org/39714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10loplugin:useuniqueptr in filterNoel Grandin
Change-Id: Ie64ba38d607733b457d66ed1b9af84303c676e13 Reviewed-on: https://gerrit.libreoffice.org/39695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10tdf#108852: Put signature infobar into the right frameKatarina Behrens
and thus avoid crash when user clicks 'show signatures' button in a window where signature bar shouldn't even be Change-Id: I5eba8d1ddd8c76dd10acedfa03d732df586748de Reviewed-on: https://gerrit.libreoffice.org/39699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-09Added margin feature to the Draw's SideBarpv2k
Change-Id: I53b5430d1563fcceae29418fd5907ac42ea856e7 Reviewed-on: https://gerrit.libreoffice.org/37626 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-09Slightly different approach to tdf#106679Katarina Behrens
cowardly avoiding use of DrawViewShell in constructor Change-Id: Ib40406d439403d0e2de270827bf5c2f06cfb18c2 Reviewed-on: https://gerrit.libreoffice.org/39368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-10osl: w32/pipe.cxx fPipeAvailable -> bPipeAvailableChris Sherlock
Change-Id: I2e57e9413f98de9a6d240c3c61c85fd7bd435498
2017-07-10osl: followup - m_NamedObject never INVALID_HANDLE_VALUEChris Sherlock
Change-Id: Ia4517b01a39c02619ccae73e4c182ac8d7e6e22c
2017-07-10Followup: m_NamedObject never INVALID_HANDLE_VALUE, must be nullptrChris Sherlock
Change-Id: I6837937945749a0f44e4e50aae1267edb37921d7
2017-07-10osl: CreateMutexW returns NULL on failure, not INVALID_HANDLE_VALUEChris Sherlock
Fun fact - CreateFileW returns INVALID_HANDLE_VALUE (-1_) because the 16-bit functions OPenFile, _lopen and _lcreat return -1, so the Win32 API function CreateFile function also returned INVALID_HANDLE_VALUE to ease porting Win16 code to Win32. CreateMutexW, on the other hand, had no corresponding function in 16-bit Windows so it returns NULL on failure. cf. https://blogs.msdn.microsoft.com/oldnewthing/20040302-00/?p=40443 Raymond Chen is a gem who explains clearly why Win32 code is so idiosyncratic. Change-Id: I7888d46b048e5674ad776c8ac8070a1e57aa37a6
2017-07-09C++11 replace std::remove_copy_if with std::copy_ifJochen Nitschke
remove_copy_if copies entries for which predicate returns false. since C++11 there is copy_if which copies entries for which predicate returns true. Change-Id: I3ade82f13d27364e2cd35f4286b18128f52f8a5b Reviewed-on: https://gerrit.libreoffice.org/39727 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-07-09Updated coreAdolfo Jayme Barrientos
Project: help adc9f8c1cd429d2b3aea19efc8f5e7010a951240 Hyphenate compound adjective Change-Id: I9114f0017335dff30a3273a55a4ac1610dcb1511
2017-07-09cppcheck: uselessCallsRemoveJochen Nitschke
std::remove returns a past the end iterator which should be used for the reallocation. This makes the code more robust. Previously it only worked if there was exactly one value with type XGeneratedResultSet in the Sequence. Change-Id: Ia2db1252ba8fe682dbc55d9722eaa62ed596e297 Reviewed-on: https://gerrit.libreoffice.org/39724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-09add test for non-ascii gnumeric file names, tdf#107827Markus Mohrhard
Change-Id: Ib530567df9cb487951d8dbf1b7824f78a7d150d9 Reviewed-on: https://gerrit.libreoffice.org/37581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-09tdf#79304 - Handle CrossedOutItems in HTML export.Sean Stangl
Change-Id: I766fedb34737a1a7815693bf496fa08c08f492b1 Reviewed-on: https://gerrit.libreoffice.org/39719 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-08accessbility: Don't double lock mutexes in VCLXAccessibleEdit.Arnaud Versini
Also simplify this class. Change-Id: I7abccd19287101918a6d9b4636ce2faecf169123 Reviewed-on: https://gerrit.libreoffice.org/39446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-08Add a way to resize ScDBDataJaskaran Singh
Change-Id: I6e0e1a7f58873c012e0e8015ed69da38a32a44f4 Reviewed-on: https://gerrit.libreoffice.org/39323 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-08tdf#45904 Move Java XSheetAnnotationShapeSupplier test to C++Jens Carl
Change-Id: I5a3d64fd255fb8fd1f1caba572bc00a5399a6519 Reviewed-on: https://gerrit.libreoffice.org/39550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-08tdf#108973 writerfilter: allow textboxes to be in the backgroundJustin Luth
Word appears to use negative z-indexes to indicate behind-text zordering and positive numbers for in-front placement. This was added for shapes in LO4.3, now applying to textboxes also. Change-Id: I3b06fb231329f151ca978f3a68b4d4e89bc28515 Reviewed-on: https://gerrit.libreoffice.org/39671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-07-08Related tdf#108925: Use 5% steps for relative size number fieldTamás Zolnai
Change-Id: Ieb89a2e69ae44fe1cfbe99e843239cf25e97463a Reviewed-on: https://gerrit.libreoffice.org/39712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-08tdf#108544 edit in window (XLSX inside DOCX)Szymon Kłos
Change-Id: If1dd46643dc2ae9cc74ba94038609ae3445a416c Reviewed-on: https://gerrit.libreoffice.org/39706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-07-08tdf#108545 show an icon (DOCX inside DOCX)Szymon Kłos
If DrawAspect is equal "Icon", show an icon not document preview Document is opened in the separate window, not in-place. Change-Id: I3a8d81e7340b29d247f8ac440c06b0420bb65644 Reviewed-on: https://gerrit.libreoffice.org/39440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-07-08osl: followup to 7c6ccc42 for w32/unx file.cxxChris Sherlock
As pointed out by sberg, either the issue is a programming error that needs an assert, or the issue is unusual and should just generated a warning, but never both. Change-Id: I07ae1e99597cd6c342791aa268b2240db987ae91 Reviewed-on: https://gerrit.libreoffice.org/39514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-07-07No language driver in header for dBASEIII/PlusJulien Nabet
See http://dbase.free.fr/tlcharge/structure%20tables.pdf Change-Id: I68df30f73d2556a217f30d80d1d55ec93bca1564 Reviewed-on: https://gerrit.libreoffice.org/39710 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-07-07comphelper : Simplify guards in OAccessibleContextHelper.Arnaud Versini
Change-Id: Iabc7293370c7a8b3fdccb00d6e1cdbfac4c46992 Reviewed-on: https://gerrit.libreoffice.org/39445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-07remove nullptr checks on STL search result iteratorsJochen Nitschke
results are in the range of first_iterator to last_iterator. If one of those is nullptr the algorithm would fail anyway. This removes some impossible checks in sw/source/core/unocore/unochart.cxx: SwChartDataProvider::detectArguments. A sorted range still holds the same values and has the same length as the original range. Replacing raw pointers eases reading this code. Change-Id: If96bd11e9167488346a57e9e08507ac42338d3cd Reviewed-on: https://gerrit.libreoffice.org/39683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-07tdf#43157 - osl: convert OSL_ASSERT in unx/file_misc.cxxChris Sherlock
Change-Id: I99e3f1e1fe2f51c6c3891a6e508b468ec068cae0 Reviewed-on: https://gerrit.libreoffice.org/39539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-07osl: unx osl_getDirectoryItem() cleanupChris Sherlock
Whitespacing made consistent in function, and switch to more conventional nullptr testing style. Change-Id: I70921e9f79e8e0ebf4a74b84f73313aed033ec5b Reviewed-on: https://gerrit.libreoffice.org/39538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-07osl: unx osl_getNextDirectoryItem() cleanupChris Sherlock
I could not easily tell on first reading this function if Directory was a pointer or not (it is), so changed name to pDirectory). The signature was too long, so fixed this, whitespacing was inconsistent so small change there. Also converted to more contentional testing of nullptr. Change-Id: Ia8b1d33a4a4fbe3e050d63116997ef57a28d73b3 Reviewed-on: https://gerrit.libreoffice.org/39537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-07osl: osl_closeDirectory cleanupChris Sherlock
When I was reading this code, it wasn't entirely clear to me without looking at the typedef of oslDirectory whether I was dealing with a variable or a pointer, so I have changed this to pDirectory. I also made a small tweak to the whitespace to help readability. I also changed from explicit comparison to nullptr to the more conventional style. Change-Id: I4e9a69575733ab71a175d14a30c1976e6771ed5b Reviewed-on: https://gerrit.libreoffice.org/39536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-07tdf#108821 - fix for overflow of variables on opening huge filesMohammed Abdul Azeem
This should fix the issue, as well as restrict available to return only non-negative values. Change-Id: I198e226e945b9bd79dec32b1686c20e2a8dfaf3e Reviewed-on: https://gerrit.libreoffice.org/39665 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-07tdf#108925: Too small bullet size confuses the userTamás Zolnai
Add a constraint for bullet relative size to avoid too small bullets which are hardly recognizable. Use the same 25% lower limit what MSO uses. Change-Id: Id956ecf3ec831c569188b944be58da03bf30a55e Reviewed-on: https://gerrit.libreoffice.org/39696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-07xmloff: Updated XMLTextListBlockContext to insert elements before NumRulesVarun Dhall
Change-Id: If81d55aef96af4b764b62dc53a1986b5f0739d1e Reviewed-on: https://gerrit.libreoffice.org/39698 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-07sot: fix loplugin:unnecessaryparen warningMiklos Vajna
Change-Id: Ia022f6cb1e9c91c9aa49025e54699a5c7718fc75
2017-07-07rhbz#739252 sw: fix crash on split tables inside nested sectionsMiklos Vajna
Commit b5e0a143308e976b4165ff6181f4dccc3db0bd31 (tdf#108524 sw: attempt to split section frames inside table cells, take two, 2017-07-03) checked for tables in SwFrame::GetNextSctLeaf() when it considered looking up the next "follow" cell frame. But this is too general, in practice it is only necessary to look for follow cell frames in case the frame in question is in a table, but not in a table-in-section. This at the same time avoids a crash with tables inside nested sections, as it happens in the bugdoc. Change-Id: If648cb477be5492c7158f89934435ca7021a6a63 Reviewed-on: https://gerrit.libreoffice.org/39692 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-07vcl: adapt README to VCL_DEBUG_DISABLE_PDFCOMPRESSION changesMichael Stahl
No longer need to compile with dbglevel=3 since 4dfa3161896a0e045da3b5cf656ebd8f40044a46 Change-Id: I2dbc7ccd07abd191701c93534241ffd4dfef9df1
2017-07-07vcl: clean up all #if OSL_DEBUG_LEVEL checks in pdfwriter_impl.cxxMichael Stahl
Half of these were around SAL_INFO which does its own checking of OSL_DEBUG_LEVEL anyway, and the other half can check at runtime the g_bDebugDisableCompression variable like PDFWriterImpl::MARK() already does since commit 49968942a62f6feb6db4dcf385ddee925a57b497. Change-Id: Ic688eb643bde9253375e14e2e2233ece8dc7c18b
2017-07-07Resolves: rhbz#1467512 mask not created as 1 bit depthCaolán McNamara
Change-Id: Ib5bdd594efd41eb881dfc4e2454b72e4739ffd56 Reviewed-on: https://gerrit.libreoffice.org/39693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-07sw: convert SwTextAnnotationField OSL_ENSUREs to assert() and simplifyMichael Stahl
Change-Id: Ica69cd4527f36edd7480d897a28ff814ecbe97a9
2017-07-07sw: WW8 import: avoid inserting annotation mark without SwPostItFieldMichael Stahl
SwFltControlStack::SetAttrInDoc() will insert a RES_FLTR_ANNOTATIONMARK without checking that there is actually a SwPostItField at that position, which triggers the assertion "<AnnotationMark::InitDoc(..)> - annotation field missing!" in AnnotationMark::InitDoc(). This happens when loading "crash-7.doc" which has a different kind of field - a SwPageNameField - at that position. In the WW8 filter, the SwPostItField is inserted in Read_And(), the AnnotationMark in Read_AtnBook(), which look quite orthogonal. Since it doesn't look like a valid document model to have the AnnotationMark without its field, avoid inserting it in the filter. Change-Id: I960d346601522b1a4d8644e538cde174763e99ff
2017-07-07re-add some gdb BigPtrArray pretty printingNoel Grandin
After commit c6902761d797253cda8b3f71f102c66108585e24 "Revert "use std::vector in BigPtrArray"" <mst_> noelgrandin: you reverted both gdb changes but only one sw change? <noelgrandin> mst_, I thought your gdb change only appliled to the std::vector? <mst_> noelgrandin: there was another std::something or other change there, one was mvInfo and the other mvData <noelgrandin> mst_, sigh, will fix that Change-Id: I3059d29b1a559eb3077f5d713be011e15e887ee0
2017-07-07simplify ooxmlw14export codeNoel Grandin
no need to do c_str() everywhere, when we can just work with OString's Change-Id: I4c9e80200c7c4d36abc541ab47b3f3cf1b42e2fb
generated by cgit (git 2.34.1) at 2025-02-02 16:27:23 +0000