summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-10-08cid#1620559 silence Using invalid iteratorCaolán McNamara
Change-Id: Iccfd99bf517630947abf76464b7e19f274377082 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174681 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-08cid#1632259 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1632258 COPY_INSTEAD_OF_MOVE cid#1632257 COPY_INSTEAD_OF_MOVE cid#1632256 COPY_INSTEAD_OF_MOVE cid#1632255 COPY_INSTEAD_OF_MOVE cid#1632254 COPY_INSTEAD_OF_MOVE cid#1632253 COPY_INSTEAD_OF_MOVE cid#1632252 COPY_INSTEAD_OF_MOVE cid#1632251 COPY_INSTEAD_OF_MOVE cid#1632250 COPY_INSTEAD_OF_MOVE cid#1632249 COPY_INSTEAD_OF_MOVE cid#1632248 COPY_INSTEAD_OF_MOVE cid#1632247 COPY_INSTEAD_OF_MOVE cid#1632246 COPY_INSTEAD_OF_MOVE cid#1632245 COPY_INSTEAD_OF_MOVE cid#1632244 COPY_INSTEAD_OF_MOVE cid#1632243 COPY_INSTEAD_OF_MOVE cid#1632242 COPY_INSTEAD_OF_MOVE cid#1632241 COPY_INSTEAD_OF_MOVE cid#1632240 COPY_INSTEAD_OF_MOVE cid#1632239 COPY_INSTEAD_OF_MOVE cid#1632238 COPY_INSTEAD_OF_MOVE cid#1632237 COPY_INSTEAD_OF_MOVE cid#1632236 COPY_INSTEAD_OF_MOVE cid#1632235 COPY_INSTEAD_OF_MOVE cid#1632234 COPY_INSTEAD_OF_MOVE cid#1632233 COPY_INSTEAD_OF_MOVE cid#1632232 COPY_INSTEAD_OF_MOVE cid#1632231 COPY_INSTEAD_OF_MOVE cid#1558073 COPY_INSTEAD_OF_MOVE cid#1557945 COPY_INSTEAD_OF_MOVE cid#1557916 COPY_INSTEAD_OF_MOVE cid#1557898 COPY_INSTEAD_OF_MOVE cid#1557808 COPY_INSTEAD_OF_MOVE Change-Id: Ibf417c154255fe3b0598127df5b5805ed543c8d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174660 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-08an exit on a failed hwpfilter import is an atypical solutionCaolán McNamara
Change-Id: Iefe31df20ca3e7e91175e00d1f15ff6c851ec536 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174659 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-08cid#1632260 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: Ia9012f78b5ea0acb29cfd50807b5ca09331261e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174658 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-08Resolves: tdf#163275 crash in async dialog use after freeCaolán McNamara
since: commit b39c6082aa975ed8e5696c3dc24c3025ed07bbb6 CommitDate: Wed Jan 31 10:33:48 2024 +0100 Implement Async AutoCorrectQuery Dialogs for Formula Check in calc Change-Id: Ie184f72cfa858ed1fc6d9eb5205dea985767eec5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-08RegisterAnswer is never passed nullCaolán McNamara
Change-Id: I3d724c5ea77865de9850a655aaa23c9633b68d22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174643 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-08unoxml: port testXNamedNodeMap_AttributesMap from java to c++Xisco Fauli
Change-Id: I1a37c7a63622d38cd8d9148589ba999901453611 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174612 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-08cid#1608272 Overflowed constantNoel Grandin
Change-Id: I280718f38900752d2c5090b0a25d7883a6062117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174620 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-08cid#1607133 Overflowed constantNoel Grandin
Change-Id: I63d1ca446491b8b376bb54e410b3d9edc543a734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174619 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-08avoid PDF export crash when ReadWithPossibleFixup falls back to PdfiumJustin Luth
Unfortunately, I failed to create a clean-room example, even when I pasted some binary garbage at the end of the file. Somehow I was getting a sanitized version from getAsStream. In any case, this prevents crashing with the two examples I have, although there are still significant problems somewhere because the export just results in empty pages... The problem is that reading again with the Pdfium-fixed version gets mixed in with the original read results, and things get pretty garbled. Probably m_rElements and everything needs to be cleared before tokenizing the fixup-version. Change-Id: I01daefa23b8f92e2849d71bca269ba2b476199da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174648 Reviewed-by: Justin Luth <jluth@mail.com> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-08cid#1607401 Data race conditionNoel Grandin
coverity seems to be having trouble seeing through the function pointers and cid#1607619 Data race condition Change-Id: I94692f124dd82b58be6aee41b49cb309f66b213d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174641 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-08tdf#163344: improve Converter::convertDurationMike Kaganski
Let it use the same calculation as ImpSvNumberInputScan::GetTimeRef. Decreases rounding errors. Change-Id: I6474a1a5913d78c236adc511389c4abcebed2de6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174650 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-08update to skia m118Noel Grandin
The following patch appears to be upstreamed now 0001-AvoidCombiningExtrememelyLargeMeshes.patch.1 Add a patch to deal with a clang issue that only shows up when building for 32-bit Windows. The issue is reported upstream, but there is only a workaround so far, no fix. Change-Id: I1c50019a2afe39d245c6b02243789752e84445a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-08Use snprintf to output full double precision of expected/actual valuesMike Kaganski
OUString::number rounds to 15 significant digits, unfortunately; so where in a fix for tdf#163344 it was needed to output something like result: 0.60416666666666663, expected: 0.60416666666666674 it used to print result: 0.604166666666667, expected: 0.604166666666667 Change-Id: I099d91ce4ac05358a119c63a5b1e481107aa7343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174651 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-07Emscripten: Silence -Wlimited-postlink-optimizationsStephan Bergmann
...when building with --enable-optimized --enable-symbols --enable-werror, > em++: error: running limited binaryen optimizations because DWARF info requested (or indirectly required) [-Wlimited-postlink-optimizations] [-Werror] > make[3]: *** [Makefile:506: spellout] Error 1 > make[2]: *** [Makefile:366: all] Error 2 > make[1]: *** [external/libnumbertext/ExternalProject_libnumbertext.mk:25: core/workdir/ExternalProject/libnumbertext/build] Error 1 etc. Change-Id: I62ff0a750d62d6bc50de670623e872beddfb4809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174642 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-10-07lok: slideshow: export animations tree as json: some improvementsMarco Cecchetti
A wide set of smil elements and attributes is exported in json format. Change-Id: I900e3b1032417b62ae3144c14bcd466358a103e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172550 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174586 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-07tdf#163295: XMLFilterDetect: make sure to only detect own typesMike Kaganski
Since commit 872dba61a1a45dceb4ffb662f6da61fb67d750e5 (INTEGRATION: CWS xmlfilter01 (1.1.2.3.2.1.16); FILE MERGED, 2003-04-04), XMLFilterDetect service uses Clipboardformat field in filterdetect. Thus, it detects any file starting with "<?xml" and having string "pwi" as "writer_PocketWord_File", because writer_PocketWord_File.xcu has the text "doctype:pwi" as the value of its ClipboardFormat. The problem is: since commit 1e6e891016ae926868de493ab0e29871a2d06b95 (restore PocketWord filter, this time backed by libwps, 2020-09-27), this format is not handled by XMLFilterDetect service. So the filter mis-detects some else filter's data, which then isn't accepted there. This change makes the code of FilterDetect::detect to make sure that it only processes its own data, checking DetectService property, too. I didn't remove the ClipboardFormat property value from the mentioned XCU, because (1) I don't know if it may be used by other code; and (2) because it allows to have the sensible unit test. Change-Id: I02fafe8df10f64640305d45cf1461b0a37552630 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174607 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-07ScriptForge Fix tdf#163219 With blocksJean-Pierre Ledure
Reference: https://bugs.documentfoundation.org/show_bug.cgi?id=163219#c7 Everywhere the With block variable is defined or redefined inside the With block, the Basic code has been reviewed. Found in SFDatabases/SF_Database.xba/SetTransactionMode() SFDocuments/SF_Document.xba/Styles() ScriptForge/SF_Dictionary.xba/ImportFromPropertyValues() ScriptForge/SF_UI.xba/SetStatusBar() ScriptForge/SF_UI.xba/ShowProgressBar() Most changes consist in isolating the With block variable before the With block itself. No functional change. This solution is a workaround for the bug. IT DOES NOT SOLVE THE ROOT CAUSE. Change-Id: I48af29d3d9c8b1e36ef5a85c8cfe28f9639ae483 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174560 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2024-10-07slideshow: enable comb transitionJaviya Vivekkumar Dineshbhai
Change-Id: Iac0c07f83904055a30c65e4133443772246d9502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171422 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-10-07allow creating rich content comments via .uno:InsertAnnotation argsCaolán McNamara
Change-Id: I186f5955cad88c1d0d6cae66a7eb0a7845bb73a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-07configure: Clean up kf5/kf6 version checksMichael Weghorn
* Drop redundant "minor version >= 0" check * For kf6, require version >= 6.0, i.e. drop support for older pre-release development versions Change-Id: Idffbc8eef513887727f6b256cb47a770294435bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174587 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-07tdf#130857 qt a11y weld: Handle "accepts-tab" text view propertyMichael Weghorn
Evaluate the "accepts-tab" GtkTextView property [1] and set the `tabChangesFocus` QPlainTextEdit property based on that, so tab moves focus to the next control when "accepts-tab" is set to false in a "GtkTextView" object in a .ui file, like the ones where this property was newly set in previous commit Change-Id: I4bbecfc3f967b83768319e68ea3fb1f89b4c5014 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Oct 7 08:10:56 2024 +0200 a11y: Leave accessible description text view on simple tab key (They're not yet supported by QtInstanceBuilder yet, but once they are, that will work as expected.) [1] https://docs.gtk.org/gtk3/property.TextView.accepts-tab.html [2] https://doc.qt.io/qt-6/qplaintextedit.html#tabChangesFocus-prop Change-Id: Ib1d33f37016a2601aa9ab9c370c9076dbae5bed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174570 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-07a11y: Leave accessible description text view on simple tab keyMichael Weghorn
Set the "accepts-tab" property to false for the GtkTextView where an accessible description can be set, so pressing the tab key moves focus to the next field in the dialog, instead of inserting a literal tab character. This simplifies using the dialog when using the keyboard only. For the VCL and GTK implementations, pressing Ctrl+Tab would previously be needed to move focus, which is less intuitive. Setting the property does not technically prevent inserting tabs, they could still be inserted by copy-pasting text containing tabs; just pressing the tab key while the text view has focus won't insert them any more. (I can't think of any reason to use actual tab characters in the accessible description, however.) Do this for the .ui files used for the following 2 scenarios: * select QR code object in Writer, open context menu, select "Alt Text" context menu entry * select an image in Writer, open context menu, select "Options" context menu entry, go to the "Options" tab page Change-Id: I4bbecfc3f967b83768319e68ea3fb1f89b4c5014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174569 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-07fix skia m117 sha valueNoel Grandin
so I messed up and uploaded skia m117 twice. But now there are two copies of skia m117 in various CDN caches, with different sha256 output (no idea how that happened). So upload a THIRD COPY with a new name, and then I can fix the sha256 value in download.lst in a way that doesn't break the build for someone. Change-Id: I297ff4d9fa3a0edd902c85f2d674950945249a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174590 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-07configure.ac: support cross-compiling with KDE 6Đoàn Trần Công Danh
Those KDE version check can be moved into compile-time. This change will also reduce the time to check when native compiling, too, since we don't need to run the just-built binaries. Change-Id: I0d60ade17b1ab5aaf4f729e39aba1345f088e6b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174512 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-07vcl: use correct var prefixes in BitmapScaleConvolutionFilterChris Sherlock
Change-Id: Idca191a21ef63a707d9c5230dad8c97552757c06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173206 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-07tdf#163219: only create local With variable for function resultsMike Kaganski
The problem is, that having a local variable referring the same value as the original expression 'foo' is not the same as referencing 'foo' itself. After 'foo' is re-assigned, the local variable still refers to the original value, not the new one. It seems impossible to implement the reference using existing codegen primitives, to imitate the true reference to 'foo', not to its value. If we implement it by changing the runtime, the bytecode won't work identically in older versions; if we introduce a new bytecode, that would be an incompatible change. As a workaround, only create the local With variable, when the block variable is created using some function (as much as known by parser). I think that there would be cases when this would still not work as intended: an example is a property implemented using getter function; the parser would likely treat the property as a variable, and avoid creation of the local variable; and the getter would be called every time a dot access will happen (which was the essence of tdf#132064). However, this seems a better alternative to the bug fixed here. Change-Id: I50bf679762fd2e73f215a000fa0ab60fd6ae7453 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174564 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-07cid#1606613 Overflowed constantNoel Grandin
Change-Id: I5340d46ef1264236c63bfd058e44dd984be2793c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-07cid#1606611 Data race conditionNoel Grandin
and cid#1607663 Data race condition cid#1606843 Data race condition cid#1608340 Check of thread-shared field evades lock acquisition Change-Id: I97b82d4302ead6b96ae19c15502c427952df2ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-07svx: prefix members of SvxNumberingPreviewMiklos Vajna
See tdf#94879 for motivation. Change-Id: I75e86d37a88ce9c71c0c8886bf782666d23fd6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174568 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-10-06clarify this a littleCaolán McNamara
Change-Id: I75625dfefdfb9bb159235c1be5536d5f27739365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06crashtesting: avoid null deref on failure of cairo_image_surface_createCaolán McNamara
seen since: commit 1acd37a671b9d3633a7d31a0b60478815fbc685f CommitDate: Mon Sep 23 14:12:04 2024 +0200 CairoSDPR: Activate globally to check builds/tests Change-Id: If3068b436eb57b48b048d30538b71563f38735d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06flatten SwCollectTableLineBoxes::GetBoxOfPosCaolán McNamara
Change-Id: I3a7908456ebd29f5c5bf1ad1e7dc593abce4928c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06Update to skia m116Noel Grandin
The sort comparison patch seems to have been upstreamed. Lots of patches needed to be redone. Followed the skia release notes in replacing calls to SkCanvas::flush and SkSurface::flushAndSubmit. Change-Id: I13179565b95cc0720b4548cd4baecc5adacc7133 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174554 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-06increase fuzzing max lengthsCaolán McNamara
Change-Id: Ia1f1abfece4667baad4036d9bedb36d07e8212ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174565 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06writer2latex is long goneCaolán McNamara
since: commit c5ae3e6de97f1341ea236680af3f4a1b5698796c CommitDate: Thu Apr 23 11:44:51 2009 +0000 CWS-TOOLING: integrate CWS native241correct_DEV300 2009-04-06 15:56:56 +0200 rene r270566 : autoconf 2009-04-06 15:56:02 +0200 rene r270565 : remove writer2latex Change-Id: I638a4369b9718e99446521bc8d0c45e480e145ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174562 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06cid#1608598 silence Overflowed constantCaolán McNamara
and cid#1607946 Overflowed constant cid#1608526 Overflowed integer argument cid#1608611 Overflowed integer argument Change-Id: Iec21df2f3d7dc8fba3872c6a70466ae12026a49d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174557 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-06cid#1608393 silence Overflowed constantCaolán McNamara
this code seems to be duplicated in sw/source/core/unocore/XMLRangeHelper.cxx too Change-Id: Ib41edfa33a72f32dff1f6720e6b0f356e9773f18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174556 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06cid#1608265 Overflowed constantCaolán McNamara
Change-Id: I5221c986ee0292a59ef66325185a97fa08a40fc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174555 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06Simplify assignment of NothingMike Kaganski
In commits f3f46b5fe729876d128f63f7ab158954ab6657d7 (tdf#132064: make With statement only evaluate its argument once, 2024-04-18) and 40d0e6f4c4ca31f6525b4c84924f2330a166182c (tdf#162962: always create a local "Nothing" for the "WITH" variable, 2024-09-16), I used hacks to emulate the global Nothing. This change implements it properly, I think, It makes sure to use the RTL's Nothing; this saves compile-time checks, strings in pool, and makes code cleaner. Change-Id: I3d007c5aa187e9aa61c1c369511be969b8cf57f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174553 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2024-10-06cid#1608177 silence Overflowed constantCaolán McNamara
Change-Id: Ibd8620bdca333e78addad9efc5a340cbe6e2a6bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174540 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06cid#1608417 silence deliberate documented Infinite loopCaolán McNamara
see: testtools/README.md Change-Id: Ie32624cc7c9262aff5666bc43b828158f0777259 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06cid#1608418 Overflowed constantCaolán McNamara
since: commit 45435a680be065e44eba385bb2523b27b77fb451 CommitDate: Mon Mar 25 15:54:01 2024 +0100 tdf#126573 Add Excel2021 array function SORT to Calc Change-Id: I7b019b1d34528eadd03c8ef8e87118189b0390aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174538 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-06Fix typoAndrea Gelmini
Change-Id: I0e3779d845e48fe0ea5d91284f8701f34f9cd48e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174535 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-10-05increase max rtf len allowedCaolán McNamara
Change-Id: Ifae0795de882d833865ba973cf8098c8b59b8eb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174541 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-05use ConvertStringToHTML for the URL tooCaolán McNamara
Change-Id: Iee10356c6311c4ac791dc59081ca2a208d3c0710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-05cid#1608381 Data race conditionCaolán McNamara
Change-Id: I85d110e0465429a52a8286747ae9da3e271255c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174537 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-05cid#1607727 silence Overflowed constantCaolán McNamara
Change-Id: I0bbd29231158379c9c7986033ce052b7f149ddc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174536 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-05add a 'simple-html' export to editengCaolán McNamara
currently justs supports hyperlinks and nothing else over plain text. puts each paragraph in a separate div Change-Id: I645d28e0bb6ed13e930e1555753846d10ecf5dd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174388 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174504 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-05tdf#85976 change labels as suggested in comment 73 on the ticketSahil Gautam
1) On first call, "by column" was selected although that is the less common case. > now by row is selected by default 2) The meaning of "Orientation" is not really clear. Suggestion: Compare: rows columns > changed as suggested 3) The purpose of "Items" is unclear. > renamed "Items" to "Records" 4) Help page does not exist. > help page patch has been merged 5) If a database range is selected, the dialog does not consider the property "Contains column labels" of the database range. > didn't quite get this one; require some help to reproduce 6) It is not usual to use "Okay", but other dialogs have it named "OK". > changed as suggested. 7) Command has no extended tip. > Added TooltipLabel ``` <prop oor:name="TooltipLabel" oor:type="xs:string"> <value xml:lang="en-US">Remove or select duplicate records from the selection</value> </prop> ``` Change-Id: I9579af68b396cddeca608dc077af3b468191942b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174201 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2025-01-11 04:56:41 +0000