summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-04-11make EditPosition::Clone return std::unique_ptrNoel Grandin
Change-Id: Ie1f987f58fd7be8067dba47e47300dd97a01a393 Reviewed-on: https://gerrit.libreoffice.org/52714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11Fix variable in error stringMike Kaganski
Change-Id: Ia6118f03b8e83c2726df955d89bfdc8da5764992 Reviewed-on: https://gerrit.libreoffice.org/52717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-11Use SdrObject& in lcl_ConvertSdrOle2ObjsToSdrGrafObjsArmin Le Grand
Change-Id: I5ea185ca66091e40153f18637b8b6f9634f5d1da Reviewed-on: https://gerrit.libreoffice.org/52683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-11ofz#7468 catch ras filter exceptionsCaolán McNamara
Change-Id: I544c367e26e6f03bf7e8cd2ed9224dc743bb31a0 Reviewed-on: https://gerrit.libreoffice.org/52694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-11coverity#1434185 Operands don't affect resultCaolán McNamara
Revert "ofz#7366 Integer overflow" This reverts commit 1f28de7e26cb9b12d74b743333dab72e08f53bec. Change-Id: I0117a29924d9f549ae19c5d802c83a2ee406b2a6 Reviewed-on: https://gerrit.libreoffice.org/52710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-11external/firebird: Avoid -fsanitize=nonnull-attributeStephan Bergmann
...that hits at least during the build of firebird with also ASan enabled (support for which will be committed shortly): > [...]/workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql -q -i [...]/workdir/UnpackedTarball/firebird/src/dbs/metadata.sql > workdir/UnpackedTarball/firebird/src/jrd/btr.cpp:5394:19: runtime error: null pointer passed as argument 2, which is declared to never be null > /usr/include/string.h:43:28: note: nonnull attribute specified here > #0 in insert_node(Jrd::thread_db*, Jrd::win*, Jrd::index_insertion*, Jrd::temporary_key*, RecordNumber*, unsigned int*, unsigned int*) at workdir/UnpackedTarball/firebird/src/jrd/btr.cpp:5394:2 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1ae2914) > #1 in add_node(Jrd::thread_db*, Jrd::win*, Jrd::index_insertion*, Jrd::temporary_key*, RecordNumber*, unsigned int*, unsigned int*) at workdir/UnpackedTarball/firebird/src/jrd/btr.cpp:2279:24 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1ac5a92) > #2 in BTR_insert(Jrd::thread_db*, Jrd::win*, Jrd::index_insertion*) at workdir/UnpackedTarball/firebird/src/jrd/btr.cpp:1008:21 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1ac29b5) > #3 in insert_key(Jrd::thread_db*, Jrd::jrd_rel*, Jrd::Record*, Jrd::jrd_tra*, Jrd::win*, Jrd::index_insertion*, Jrd::IndexErrorContext&) at workdir/UnpackedTarball/firebird/src/jrd/idx.cpp:1475:2 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1c62e01) > #4 in IDX_store(Jrd::thread_db*, Jrd::record_param*, Jrd::jrd_tra*) at workdir/UnpackedTarball/firebird/src/jrd/idx.cpp:1018:22 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1c661a2) > #5 in Jrd::StoreNode::store(Jrd::thread_db*, Jrd::jrd_req*, Jrd::StmtNode::WhichTrigger) const at workdir/UnpackedTarball/firebird/src/dsql/StmtNodes.cpp:7005:5 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x21c0c96) > #6 in Jrd::StoreNode::execute(Jrd::thread_db*, Jrd::jrd_req*, Jrd::StmtNode::ExeState*) const at workdir/UnpackedTarball/firebird/src/dsql/StmtNodes.cpp:6942:13 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x21bf955) > #7 in EXE_looper(Jrd::thread_db*, Jrd::jrd_req*, Jrd::StmtNode const*) at workdir/UnpackedTarball/firebird/src/jrd/exe.cpp:1292:17 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x157f798) > #8 in looper_seh(Jrd::thread_db*, Jrd::jrd_req*, Jrd::StmtNode const*) at workdir/UnpackedTarball/firebird/src/jrd/exe.cpp:1426:2 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x15834fc) > #9 in execute_looper(Jrd::thread_db*, Jrd::jrd_req*, Jrd::jrd_tra*, Jrd::StmtNode const*, Jrd::jrd_req::req_s) at workdir/UnpackedTarball/firebird/src/jrd/exe.cpp:1023:2 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x15740c3) > #10 in EXE_send(Jrd::thread_db*, Jrd::jrd_req*, unsigned short, unsigned int, unsigned char const*) at workdir/UnpackedTarball/firebird/src/jrd/exe.cpp:833:2 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1579392) > #11 in add_index_set(Jrd::thread_db*) at workdir/UnpackedTarball/firebird/temp/Debug/jrd/ini.cpp:2251:3 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1efb0c2) > #12 in INI_format(char const*, char const*) at workdir/UnpackedTarball/firebird/temp/Debug/jrd/ini.cpp:1563:2 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1eef3bd) > #13 in Jrd::JProvider::createDatabase(Firebird::CheckStatusWrapper*, char const*, unsigned int, unsigned char const*) at workdir/UnpackedTarball/firebird/src/jrd/jrd.cpp:2691:4 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x1864267) > #14 in Firebird::IProviderBaseImpl<Jrd::JProvider, Firebird::CheckStatusWrapper, Firebird::IPluginBaseImpl<Jrd::JProvider, Firebird::CheckStatusWrapper, Firebird::Inherit<Firebird::IReferenceCountedImpl<Jrd::JProvider, Firebird::CheckStatusWrapper, Firebird::Inherit<Firebird::IVersionedImpl<Jrd::JProvider, Firebird::CheckStatusWrapper, Firebird::Inherit<Firebird::IProvider> > > > > > >::cloopcreateDatabaseDispatcher(Firebird::IProvider*, Firebird::IStatus*, char const*, unsigned int, unsigned char const*) at workdir/UnpackedTarball/firebird/src/include/firebird/IdlFbInterfaces.h:9010:44 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/plugins/libEngine12.so +0x16eefb6) > #15 in Firebird::IAttachment* Firebird::IProvider::createDatabase<Firebird::CheckStatusWrapper>(Firebird::CheckStatusWrapper*, char const*, unsigned int, unsigned char const*) at workdir/UnpackedTarball/firebird/src/include/firebird/IdlFbInterfaces.h:2034:23 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2 +0x49cc5d) > #16 in Why::Dispatcher::attachOrCreateDatabase(Firebird::CheckStatusWrapper*, bool, char const*, unsigned int, unsigned char const*) at workdir/UnpackedTarball/firebird/src/yvalve/why.cpp:5681:15 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2 +0x44d0ad) > #17 in Why::Dispatcher::createDatabase(Firebird::CheckStatusWrapper*, char const*, unsigned int, unsigned char const*) at workdir/UnpackedTarball/firebird/src/yvalve/why.cpp:5606:9 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2 +0x44e4d4) > #18 in PREPARSE_execute(Firebird::CheckStatusWrapper*, Why::YAttachment**, unsigned short, char const*, bool*, unsigned short) at workdir/UnpackedTarball/firebird/src/yvalve/preparse.cpp:288:26 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2 +0x56e738) > #19 in Why::UtilInterface::executeCreateDatabase(Firebird::CheckStatusWrapper*, unsigned int, char const*, unsigned int, unsigned char*) at workdir/UnpackedTarball/firebird/src/yvalve/utl.cpp:587:8 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2 +0x5ee78f) > #20 in Firebird::IUtilBaseImpl<Why::UtilInterface, Firebird::CheckStatusWrapper, Firebird::IVersionedImpl<Why::UtilInterface, Firebird::CheckStatusWrapper, Firebird::Inherit<Firebird::IUtil> > >::cloopexecuteCreateDatabaseDispatcher(Firebird::IUtil*, Firebird::IStatus*, unsigned int, char const*, unsigned int, unsigned char*) at workdir/UnpackedTarball/firebird/src/include/firebird/IdlFbInterfaces.h:12375:44 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/lib/libfbclient.so.2 +0x60ed0b) > #21 in Firebird::IAttachment* Firebird::IUtil::executeCreateDatabase<Firebird::CheckStatusWrapper>(Firebird::CheckStatusWrapper*, unsigned int, char const*, unsigned int, unsigned char*) at workdir/UnpackedTarball/firebird/src/include/firebird/IdlFbInterfaces.h:3504:23 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql +0x603d95) > #22 in create_db(char const*, char*) at workdir/UnpackedTarball/firebird/temp/Debug/isql/isql.cpp:5314:38 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql +0x5aee53) > #23 in frontend(char const*) at workdir/UnpackedTarball/firebird/temp/Debug/isql/isql.cpp:6152:10 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql +0x59b585) > #24 in get_statement(char*, unsigned long, char const*) at workdir/UnpackedTarball/firebird/temp/Debug/isql/isql.cpp:7019:9 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql +0x596084) > #25 in do_isql() at workdir/UnpackedTarball/firebird/temp/Debug/isql/isql.cpp:5481:9 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql +0x57ba26) > #26 in ISQL_main(int, char**) at workdir/UnpackedTarball/firebird/temp/Debug/isql/isql.cpp:1693:3 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql +0x575ecc) > #27 in main at workdir/UnpackedTarball/firebird/temp/Debug/isql/isql.cpp:1599:9 (workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql +0x575149) > #28 in __libc_start_main at /usr/src/debug/glibc-2.26-146-gd300041c53/csu/../csu/libc-start.c:308 (/lib64/libc.so.6 +0x20f29) > #29 in _start at <null> (workdir/UnpackedTarball/firebird/gen/Debug/firebird/bin/isql +0x423219) Change-Id: Iebff0484a792b711769f46c4823f806e9f9b2935 Reviewed-on: https://gerrit.libreoffice.org/52704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-11writerperfect: fix whitespaceMiklos Vajna
Be consistent with surrounding code. Change-Id: I86eb3a663a54a63c850ada229ea24d9c770365df Reviewed-on: https://gerrit.libreoffice.org/52708 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-11tdf#42949 Remove unnecessary localization headers from frameworkGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<fwkresid.hxx\> -e \<strings.hrc\> framework/ | xargs grep -c FwkResId | grep :0$ | grep -v /pch Change-Id: I026d78b5d1400c66705bd717eca9ed95e8c75366 Reviewed-on: https://gerrit.libreoffice.org/52597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-11tdf#108608 more Draw text editing responsiveness fixesNoel Grandin
Turns out Windows is rather slow at at calculating glyph outlines (compared to Linux), I'm guessing it does no caching at all, so just add our own little cache. I tried to use o3tl::lru_map here, but it crashes under MSVC2015. Change-Id: I78d2a787ec8f734fa821f41f13236771efa1c8d4 Reviewed-on: https://gerrit.libreoffice.org/52623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11weld GotoLineDialogCaolán McNamara
Change-Id: Ibf040e9b48a5545550e1ee830852a75ca82262e7 Reviewed-on: https://gerrit.libreoffice.org/52695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-11new loplugin:unusedvariablemoreNoel Grandin
collection of heuristics to look for local variables that are never read from i.e. do not contribute to the surrounding logic This is an expensive plugin, since it walks up the parent tree, so it is off by default. Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06 Reviewed-on: https://gerrit.libreoffice.org/52450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11toolkit: Recover missing service names for ControlModelContainerBaseTakeshi Abe
namely: com.sun.star.awt.UnoControlProgressBarModel com.sun.star.awt.UnoControlScrollBarModel com.sun.star.awt.UnoControlFixedLineModel com.sun.star.awt.UnoControlRoadmapModel They seems accidentally dropped at 45fe77164c90cf15b78cd8b99adc043e2dd26be1. Change-Id: Iebd72cadc9eb9bdcb80f9b8c11f6e5e40bdb50a2 Reviewed-on: https://gerrit.libreoffice.org/52673 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-11sd: update tooltips on hyperlink hoverVasily Melenchuk
Show "Ctrl-click to open..." or "Click to open..." depending on security options. Change-Id: I93024a894967ddd378cc436efffb22302f6034d7 Reviewed-on: https://gerrit.libreoffice.org/52672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-11sw: prefix members of HTMLAttrContextMiklos Vajna
Change-Id: Ia0d35c17dc63fa4bcf1b5ebc2b1989a539017c41 Reviewed-on: https://gerrit.libreoffice.org/52692 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-11Removed duplicated includeAndrea Gelmini
Change-Id: I8850f20679c330c17b15f964ca7cf320126618af Reviewed-on: https://gerrit.libreoffice.org/52282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-04-11Fix building with DBG_ANIM_LOG definedAron Budea
Partial regression from 6ca16a4cad999dbb0296ea64db2263a26e52f36c Change-Id: Ie9eded8673131e19428411e430951feaf33218bb Reviewed-on: https://gerrit.libreoffice.org/52701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11pass EditTextObject around using std::unique_ptrNoel Grandin
Change-Id: I71f4529c2e02fd0ac2561191e4cb35e18e206037 Reviewed-on: https://gerrit.libreoffice.org/52682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11Fix typosAndrea Gelmini
Change-Id: I7fd04d0e09fcbf6d9f2a5ec617f23e08f7bc5fa3 Reviewed-on: https://gerrit.libreoffice.org/52697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-10tdf#116890: make unique column names in prepared statementJulien Nabet
...like we do resultset. Thanks to Lionel for this solution Change-Id: I44f307cd6bddf76716d7c73b8783070abe43bdf3 Reviewed-on: https://gerrit.libreoffice.org/52662 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-10sw lok: followup commit for change about scrolling to visible cursorTamás Zolnai
Revert small part of this commit: 83b7bfc0efefb3c77e5c59553320e98539250c62 Thanks Jan Holesovsky to catching it. Change-Id: I885c9f3da622052685d1e46f6358783fc7f8cb9a Reviewed-on: https://gerrit.libreoffice.org/52684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-10vlookup - optimize SC_EQUAL and NOT_EQUAL.Michael Meeks
Also don't accept partial matches ie. CONTAINS != EQUAL, for VLOOKUP even if document option "search criteria =, <> for whole cells" is turned off. This also adds a new spreadsheet test file vlookup2.fods with the option "search criteria =,<> for whole cells" turned off, with VLOOKUP test cases that ensures that partial matches are not accepted. Change-Id: Ib1f4781b216431546c3fd6967f22518e86abf36b Reviewed-on: https://gerrit.libreoffice.org/52589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-04-10Resolves: tdf#116813 Height/Width swappedCaolán McNamara
Change-Id: I9b41a4b65fda895ed73fa346fb0b8e13df010706 Reviewed-on: https://gerrit.libreoffice.org/52688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-10weld SpacingDialogCaolán McNamara
Change-Id: Ida9077b19ad78001c632796257651e4314a9a538 Reviewed-on: https://gerrit.libreoffice.org/52676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-10tdf#116925 sw: consider fill styles of shape for in-textbox auto colorMiklos Vajna
Automatic color is determined in SwDrawTextInfo::ApplyAutoColor(), but it uses this function to determine the background color. Be consistent and consider the same background in both the shape-with-editeng-text and shape-with-sw-text cases. Change-Id: I52249a908193765bc128789d96187af334c1017c Reviewed-on: https://gerrit.libreoffice.org/52687 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-10dbaccess: fix --without-java buildMiklos Vajna
Change-Id: I9c1ac64745301deda1501806534f13c1527a33b3 Reviewed-on: https://gerrit.libreoffice.org/52670 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-10Updated coreChristian Lohmaier
Project: help 9bce1e3e0fffe38f701b7452e4e3c7564ea10469 fix validation errors Change-Id: I0288d52b4420b2be76a136cbd34b1fee87f1cf71 Reviewed-on: https://gerrit.libreoffice.org/52686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-04-10Revert "32bit Linux tests fail"Stephan Bergmann
This reverts commit 2935287ea18847f9e142a35ade785ff9f510d495, now that 4544713d3ae7a83d45047b65bf7ba520b3e8762e "Adapt remaining cpp_uno bridges to #i114635#" should fix the underyling issue. Change-Id: I60c185f724721f251e7e52087c5183cf985c3c4d Reviewed-on: https://gerrit.libreoffice.org/52671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-10Make NotifyDocumentEvent use SdDrawDocument& instead of ptrArmin Le Grand
Change-Id: I00f83da44d2f07fe570f9ce6c0f506e4204a5ef9 Reviewed-on: https://gerrit.libreoffice.org/52633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-10put the loplugin output files in the workdirNoel Grandin
so that the next time I accidentally leave one turned on, and commit it, the buildbots will clean up naturally the next time they run 'make clean' Change-Id: Ia09dea9c272c322c7e2773c5458cb54aceb50dd1
2018-04-10add GtkMenuButton supportCaolán McNamara
Change-Id: Id5cda4775e405ed708de09ee1332cd84461b265d Reviewed-on: https://gerrit.libreoffice.org/52669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-10darn, unusedfields loplugin was left enabledNoel Grandin
Change-Id: I343262e0c61e9ecde5395f13732c212197e7fd03
2018-04-10Adapt remaining cpp_uno bridges to #i114635#Stephan Bergmann
..."C++ UNO bridge should convert non-UNO exceptions into RuntimeException" (<https://bz.apache.org/ooo/show_bug.cgi?id=114635>), see <https://lists.freedesktop.org/archives/libreoffice/2018-April/079985.html> "Re: CppunitTest_sw_filters_test failing on x86 Linux, std::exception -> uno::RuntimeException". (The msvc_win32_{intel,x86-64} versions already handle non-UNO exceptions in their msc{i,x}_filterCppException functions, in a different way.) Change-Id: Ie359affed6831d16be0de3e3ff065484e28bd9c3 Reviewed-on: https://gerrit.libreoffice.org/52665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-10crashtesting: failure on loading ooo38880-1.docCaolán McNamara
ever since commit e0bc1ab9d8fd9247c60324f596faafd7e42540f4 Date: Mon Oct 4 16:54:47 2004 +0000 INTEGRATION: CWS mav09 (1.42.58); FILE MERGED SdrOle2Obj::SetObjRef calls mpImpl->mxObjRef.Clear(); so SdrOle2Obj::Disconnect_Impl cannot removeobj the object from the olecache, i.e. if ( mpImpl->mxObjRef.is() && mpImpl->mxLightClient.is() ) ... GetSdrGlobalData().GetOLEObjCache().RemoveObj(this); ... so the object remains in the cache and later on is dereferenced with the usual sad results. So, this band-aid ensures that if we get to the dtor and are still in the cache we get removed. Change-Id: Icf519e4db3eadf1c0d9acb7751dbea9cc04ca382 Reviewed-on: https://gerrit.libreoffice.org/52667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-10Updated coreGabor Kelemen
Project: help fbf5957db266aac2defee013a79be1ffc6ca9a04 Fix missing bookmarks on MS Office compatibility page Change-Id: I33711b69218bec6d080c07c93d0f2357bab0ce70 Reviewed-on: https://gerrit.libreoffice.org/52660 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-10xmloff: fix leak in XMLPropertySetMapperEntry_ImplMichael Stahl
The XMLNamedBoolPropertyHdl should be owned by OControlPropertyHandlerFactory like all the other handlers created in that function. Thanks to Julien Nabet for pointing out the problem. Change-Id: Id474b2fdb84ca74f686d0c888fbedbee623c31bb Reviewed-on: https://gerrit.libreoffice.org/52666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-10loplugin:useuniqueptr in ScDrawTransferObjNoel Grandin
Change-Id: I0de14f370f81b6b1e37cb7c9e517d4e9b857ab83 Reviewed-on: https://gerrit.libreoffice.org/52644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10Remove dead HSQLDB driverTamas Bunth
Change-Id: Id4cfb69079f0150c9cca2626c16df7fab441d916 Reviewed-on: https://gerrit.libreoffice.org/52611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-04-10tdf#116555 filter: make sure default extension for HTML is not .xhtmlMiklos Vajna
Since by default we don't write XHTML markup in the sw HTML export. Change-Id: Ifbf9850652d7838582725be391b2fd1a062495e5 Reviewed-on: https://gerrit.libreoffice.org/52663 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-10loplugin:unusedfield improvementsNoel Grandin
improve the read-only check to ignore reads from fields that are guarded by a boolean check, something like: if (field) field.foo(); this produces some false positives at the moment because I'm not correctly handling the else block, but also some useful new dead code. Change-Id: Id21fa1a56c171d09d979769b978b6eef14e8b695 Reviewed-on: https://gerrit.libreoffice.org/52664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10Colibre icons: add help iconsandreas kainz
Change-Id: I421f10f19647888e508c6487271e29d5ab543e0b Reviewed-on: https://gerrit.libreoffice.org/52659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-10weld SmFontSizeDialogCaolán McNamara
and give it a parent via SfxRequest::GetFrameWeld Change-Id: I126c300ce4b3f477fd927efbcc83b1a6d315f594 Reviewed-on: https://gerrit.libreoffice.org/52637 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-10tdf#42949 Remove unnecessary localization headers from desktopGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<dp_shared.hxx\> -e \<strings.hrc\> desktop | xargs grep -c DpResId | grep :0$ | grep -v /pch Change-Id: I6608eb94c7572040ae20ce8a3926f3a522ee66bd Reviewed-on: https://gerrit.libreoffice.org/52593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-10tdf#115623: invoke openPageSpan / closePageSpanMark Hung
* For paragraphs or tables whose styles specify style:master-page-name, it indicate starting a new page style and should invoke openPageSpan / closePageSapn properly. * closePageSpan at the end of text body is invoked. Change-Id: Ic85157c9b1a43c94a027b464ad9105e9072afcf7 Reviewed-on: https://gerrit.libreoffice.org/52082 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-10fix bug in SwSpellDialogChildWindow::FindNextDrawTextError_ImplNoel Grandin
looks like a regression from commit de60fd06b84bc1aa080ef209b0eeb36914bd8b32 Date: Fri Dec 17 09:02:23 2010 +0100 CWS swlayoutrefactoring: #i115510#: first step to clean up the SwClient mess Change-Id: Ifc1d3e3f87b4b0d48fc5f311086bb5404b0aa1fb Reviewed-on: https://gerrit.libreoffice.org/52614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10loplugin:unusedmethodsNoel Grandin
Change-Id: I6f976ba8f792d2cee34859e9258798351eed8b1d Reviewed-on: https://gerrit.libreoffice.org/52636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10loplugin:useuniqueptr in ScAccessibleSpreadsheetNoel Grandin
Change-Id: Ia3df85292aba5a506a60b2ae5345e4e78c676c93 Reviewed-on: https://gerrit.libreoffice.org/52650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10loplugin:useuniqueptr in DataStreamNoel Grandin
Change-Id: I05a22f05a7d41aa06539e05a1969f9520cc3ab31 Reviewed-on: https://gerrit.libreoffice.org/52649 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10loplugin:useuniqueptr in ScAccessiblePreviewCellTextDataNoel Grandin
Change-Id: I06e211f69cafd88080680a22919f1c16eef2aaa9 Reviewed-on: https://gerrit.libreoffice.org/52648 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10loplugin:useuniqueptr in ScAccessibleEditObjectTextDataNoel Grandin
Change-Id: I72305ce2f235efb42055f71fe2ee3c59ba99c9d3 Reviewed-on: https://gerrit.libreoffice.org/52647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10loplugin:useuniqueptr in DocShell_ImplNoel Grandin
Change-Id: I171dbce9ad9790e887a6618812eadfb746dee42f Reviewed-on: https://gerrit.libreoffice.org/52646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-17 00:18:43 +0000