summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-08Simplify setting Kashida width on WindowsKhaled Hosny
This should also make sure we are getting it from the current font, which the old, convoluted way does not seem to guarantee. Change-Id: If0a4cf18e472b1489115eeb7b1b2bdbb5f13abb0 Reviewed-on: https://gerrit.libreoffice.org/32595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-08tdf#90290 use custom asserter in ucalc_sort.cxxkerem
Change-Id: Ie6123113e270e75e942716dda0ed4da71b2a2afc Reviewed-on: https://gerrit.libreoffice.org/32824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-08Rename css::packages::ContentInfo to just ZipContentInfo.Kohei Yoshida
And use std::unique_ptr not rtl::Reference. This is not a UNO object anyway... Change-Id: If43da4f7e0f478b9ad8d62e5f43f04f035c31717 Reviewed-on: https://gerrit.libreoffice.org/32828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-08Clean up and annotate the code a bit.Kohei Yoshida
Change-Id: I5f0c6130e5cf21f93bb1309f7bf148bd40b3821d Reviewed-on: https://gerrit.libreoffice.org/32827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-07Reduce scope by removing unnecessary else clauses.Kohei Yoshida
This makes the code a bit easier to follow. Change-Id: Ia55d963c97b33dd8462e6084adc4820856e126bf Reviewed-on: https://gerrit.libreoffice.org/32825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-07default copy ctor and assignment operator are good enoughCaolán McNamara
and block default move equivalents Change-Id: Ib8a1050803446c2e099f66602fae0465bd8165cf
2017-01-07coverity#1358841 Explicit null dereferencedCaolán McNamara
Change-Id: I1c4cff09a7c549e9a14886c1460a7e2c2c74f757
2017-01-07coverity#735796 Explicit null dereferencedCaolán McNamara
Change-Id: I7468fd9637421b8b854217c19969f94e9ab0cab4
2017-01-07coverity#705098 Explicit null dereferencedCaolán McNamara
Change-Id: Icf32bbe9ce259048219ba88aa7e4dc51592f7cb5
2017-01-07coverity#705097 Explicit null dereferencedCaolán McNamara
Change-Id: I0c2163f91b86d2b48b7bc58b173438d2aa11377d
2017-01-07forward decl of Graphic needed hereCaolán McNamara
Change-Id: I81a4bb99ffa41531323e5a5b3473f54dd0cb8910
2017-01-07coverity#704593 Dereference after null checkCaolán McNamara
Change-Id: I5426cb2e8ca1e8fd2e9f38419ffe6d6e148a7cba
2017-01-07coverity#440749 Explicit null dereferencedCaolán McNamara
Change-Id: I0927e51d0cdb53b5bd20d4f1cf567cbfb4b377da
2017-01-07Update call-catcher readme.Michael Meeks
Change-Id: I777f05a66038ada8aff9a65637475b56ebbf5ad9
2017-01-07come up with a conservative max compression ratio for gifsCaolán McNamara
Change-Id: I01bc452a0bcc003bf9b7b65d9a2a49b6c1acebc1
2017-01-07Updated coreGabor Kelemen
Project: help e8d93437e93da580ecb9d46a441b8610900c4f32 Drop 'Network Identity' page The corresponding feature was removed in 2012 with 098be920e012a3ae133d23cffdb161a0816d29c4 Change-Id: I40168499dc3d7a9cf8ba308b942bd46445e608fe Reviewed-on: https://gerrit.libreoffice.org/32801 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-01-07Updated coreGabor Kelemen
Project: help fd44cddea40406cbdde5621e0e25c6c6be3e9955 test-hid-vs-ui: Fix bookmarks and ahelps to floatingelements.ui From one of ['source/text/smath/01/03090200.xhp', 'source/text/smath/01/03090400.xhp'], we did not find file starmath/uiconfig/smath/ui/floatingelements.ui. From one of ['source/text/smath/01/03090700.xhp', 'source/text/smath/01/03090500.xhp', 'source/text/smath/01/03090800.xhp', 'source/text/smath/01/03090300.xhp', 'source/text/smath/01/03090600.xhp', 'source/text/smath/01/03090100.xhp'], we did not find file smath/uiconfig/ui/floatingelements.ui. File was dropped in 3dfe2fc394ca1e168e800ffcc3ac0f69b4eeb173 Change-Id: I896778156c41755cc1d979e75018e1b9b5806d5b Reviewed-on: https://gerrit.libreoffice.org/32799 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com>
2017-01-07accessibility: simplify CharacterAttributesHelper.Arnaud Versini
Change-Id: I62063745e704c941fdce306228ebbe3522c3b438 Reviewed-on: https://gerrit.libreoffice.org/32738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-07use proper message passingBjoern Michaelsen
Change-Id: I5655dd4c07769d3c9832a3e7246e750cd2f1908d Reviewed-on: https://gerrit.libreoffice.org/32806 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-01-07Typo: Postion->PortionJulien Nabet
Found thanks to Buovjaga Change-Id: I8859cbec896c4019a5137d801f753ad87287a369 Reviewed-on: https://gerrit.libreoffice.org/32809 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-07Typo: Acess->AccessJulien Nabet
Found thanks to Buovjaga Change-Id: I73e36f50a1fd393859ba775ab084a488047864a3 Reviewed-on: https://gerrit.libreoffice.org/32810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-07Typo: Postion->PositionJulien Nabet
Found thanks to Buovjaga Change-Id: Iacf09325cdb58e0dbdcc9bf0570b2e02ed275132 Reviewed-on: https://gerrit.libreoffice.org/32808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-07Clean up stale merge modulesDavid Ostrovsky
Change-Id: I2489238d5295650a3c51581a037185440f641005 Reviewed-on: https://gerrit.libreoffice.org/32797 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-07Typo: isColunnNameDuplicate->isColumnNameDuplicateJulien Nabet
Found thanks to Buovjaga Change-Id: I9c52c2c5fa7c92e2b9d99fbbb9d02439993397b0 Reviewed-on: https://gerrit.libreoffice.org/32807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-07add PERCENTRANK, PERCENTRANK.INC, PERCENTRANK.EXC test caseZdeněk Crhonek
Change-Id: Id997b198c830669937be0cf995455ac03f1c4a9b Reviewed-on: https://gerrit.libreoffice.org/32795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-07lok: refill font list if emptyHenry Castro
After preinit stage the font list is empty when creating documents. Reviewed-on: https://gerrit.libreoffice.org/32108 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Conflicts: sd/source/ui/docshell/docshel4.cxx svtools/source/control/ctrltool.cxx Change-Id: Ia6938d521626f4b4022f0f993e77c017e4932415 Reviewed-on: https://gerrit.libreoffice.org/32796 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-01-07coverity#1398369 Unchecked dynamic_castCaolán McNamara
Change-Id: I33b5a2343eb7701a478c8d039d818e679471d4c0
2017-01-07dynamic cast followed by static castCaolán McNamara
Change-Id: I425692130bd7ef6b8a9ebce3592c1976fa44dafc
2017-01-07coverity#1398371 Useless callCaolán McNamara
Change-Id: I3614bb162cec889ee102e0284b6a3a33a98df470
2017-01-06Localize return value of EditBrowseBoxTableCell::getAccessibleNameMuhammet Kara
Change-Id: I040c1b9b8680a366819254e1d44b80115a339bbf Reviewed-on: https://gerrit.libreoffice.org/32441 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-01-06tdf#105009 sw: fix a11y crash when removing drawing objectMichael Stahl
SwFrame::RemoveDrawObj() calls SwAnchoredObject::ChgAnchorFrame(0) so the SwAnchoredDrawObj has no anchor frame later when SwAccessibleMap::InvalidateCursorPosition() asks for the parent. (regression from 76c549eb01dcb7b5bf28a271ce00e386f3d388ba) Change-Id: Id55cb5fc41a4e37e863498265d1565e1621d508e
2017-01-06remove obsolete MOZ_ZIP_* variablesMichael Stahl
Change-Id: Ie83ff9e50534536326c78de1b6b717fe18b6dae1
2017-01-06Drop macros that are used only onceKhaled Hosny
Change-Id: Ib75c0db614448f5297de9924335e2ee9f71f3a3f Reviewed-on: https://gerrit.libreoffice.org/32766 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-06add the locale info to the crashreporter metadataMarkus Mohrhard
We have a few crashes that seem locale dependent. Especially the font related problems. Change-Id: I0cc977413dc2328ea705c96c2d4048e4f3c58bbc Reviewed-on: https://gerrit.libreoffice.org/32764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-06oss-fuzz: make max sane bitmap allocation smallerCaolán McNamara
Change-Id: I0b924f615ed4652ce605c12d2d2e9ca2ad2befbf
2017-01-06Related: tdf#105150 PPT import: handle mso_fillBackground fill type of shapesMiklos Vajna
Equivalent OOXML markup is <p:sp useBgFill="1">. For now only handle the case when the slide doesn't have an explicit background, and assume that in that case we can default to white solid fill. This partially restores the code removed in 6137b5f72f5ec491ea6bd6631a65484fa24d2973 (coverity#735432 Logically dead code, 2014-03-25), so that ProcessData::aBackgroundColoredObjects is actually read. Change-Id: I9e7a9a41965db50638e9d9d1b2361af9fd7a98ca
2017-01-06recognize the broken "Err:xxx" written by 5.2 and earlier, tdf#105024 relatedEike Rathke
... and handle same as "#ERRxxx!" if present. Change-Id: I1ebb31d628b080c52b450a8fe624c20e9e1188b7
2017-01-06read single error constant formula as such, tdf#105024 relatedEike Rathke
... without creating a token so when writing again no leading '=' is prepended, with which we can enable 5.2 to read such thing correctly, and when re-reading in 5.3 it also doesn't lead to a "real" formula. Change-Id: I26fbd20536436b49b781e2bbb5bba1dc6bafbb37
2017-01-06check length of string as this can be called untokenized, tdf#105024 relatedEike Rathke
i.e. during import of ODFF Change-Id: I7f5419d393f89d8a84efca7444e8dde3a3e9199f
2017-01-06tdf#105151 - be more conservative about EndTracking / Tracking calls.Michael Meeks
We really shouldn't be emitting these into widgets after they are disposed - it serves only to confuse things. Restore behaviour to how it was before the VclPtr change for this. Change-Id: Ife666929f8aac0e4431a5e43970769692c11888c Reviewed-on: https://gerrit.libreoffice.org/32785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-01-06New loplugin:charrightshiftStephan Bergmann
Change-Id: Ib645fb11004bc0fe05c9c416ae72b0ae56c23a15
2017-01-06tdf#105150 PPTX import: try harder to handle <p:sp useBgFill="1">Miklos Vajna
The bugdoc has two shapes. The red rectangle is supposed to be covered by the other shape, but it wasn't as the fill style was set to none. The reason for that was we ignored useBgFill, unless the slide had an explicit fill style. Assume that in that case a white solid fill is the default. Change-Id: Iea20e216e44e13db68887f285c10bc1a8feacf0a Reviewed-on: https://gerrit.libreoffice.org/32786 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06Resolves: tdf#105061 Only one text box shown in case of 'between'Caolán McNamara
non-layout ScCondFormatList widget not responding to layout child change Change-Id: I7edd4fc54de9e71fb86b47a9b182bfc22fa4af25
2017-01-06breakpad: document how to read mini-dumps locallyMichael Stahl
Change-Id: I888930079fc93c609769ac31a025c410b9adad96
2017-01-06out of bounds string accessEike Rathke
Change-Id: Iecbe24f90cefe34a447cd52a44967a4b09b4394b
2017-01-06tdf#105143 DOCX import: enable DoNotCaptureDrawObjsOnPage layout compat optionMiklos Vajna
Because that's what Word does to show only part of the shape in the bugdoc. Change-Id: Ic5cb84cace9237671d71eda0c64e9dadfe244cb9 Reviewed-on: https://gerrit.libreoffice.org/32782 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-06use same logic in both CreatesCaolán McNamara
Change-Id: I49dab360c5f93e40f5a6e91fbe721935d795472c
2017-01-06unixODBC: revert nonsensical trival change 622bb4bcMichael Stahl
There is no point to trivial cleanups in external headers. Change-Id: I9cb7ba135655e1426dcafd3a621ab4eaa7da1011
2017-01-06bSilent is unusedStephan Bergmann
...ever since c25ec0608a167bcf1d891043f02273761c351701 "initial import" Change-Id: Iccee867aa9722ced2f66d4d8b8911c5e191502c2
2017-01-06lsan+wmffuzzer shows a circular reference leading to a leakCaolán McNamara
graphic gets a context set on it which has a shallow copy of the graphic in it. ==37==ERROR: LeakSanitizer: detected memory leaks Indirect leak of 1024 byte(s) in 1 object(s) allocated from: #0 0x6170b0 in operator new[](unsigned long) /src/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:84 #1 0x91361b in BitmapPalette::BitmapPalette(unsigned short) /src/libreoffice/include/vcl/salbtype.hxx:467:56 #2 0x9029f0 in GIFReader::GIFReader(SvStream&) /src/libreoffice/vcl/source/filter/igif/gifread.cxx:114:7 #3 0x91648d in std::__1::__libcpp_compressed_pair_imp<std::__1::allocator<GIFReader>, GIFReader, 1u>::__libcpp_compressed_pair_imp<std::__1::allocator<GIFReader>&, SvStream&, 0ul, 0ul>(std::__1::piecewise_construct_t, std::__1::tuple<std::__1::allocator<GIFReader>&>, std::__1::tuple<SvStream&>, std::__1::__tuple_indices<0ul>, std::__1::__tuple_indices<0ul>) /usr/local/bin/../include/c++/v1/memory:2173:15 #4 0x91648d in std::__1::__compressed_pair<std::__1::allocator<GIFReader>, GIFReader>::__compressed_pair<std::__1::allocator<GIFReader>&, SvStream&>(std::__1::piecewise_construct_t, std::__1::tuple<std::__1::allocator<GIFReader>&>, std::__1::tuple<SvStream&>) /usr/local/bin/../include/c++/v1/memory:2330 #5 0x91648d in std::__1::__shared_ptr_emplace<GIFReader, std::__1::allocator<GIFReader> >::__shared_ptr_emplace<SvStream&>(std::__1::allocator<GIFReader>, SvStream&) /usr/local/bin/../include/c++/v1/memory:3827 #6 0x91648d in std::__1::shared_ptr<GIFReader> std::__1::shared_ptr<GIFReader>::make_shared<SvStream&>(SvStream&) /usr/local/bin/../include/c++/v1/memory:4443 #7 0x91284b in _ZNSt3__111make_sharedI9GIFReaderJR8SvStreamEEENS_9enable_ifIXntsr8is_arrayIT_EE5valueENS_10shared_ptrIS5_EEE4typeEDpOT0_ /usr/local/bin/../include/c++/v1/memory:4807:12 #8 0x91284b in ImportGIF(SvStream&, Graphic&) /src/libreoffice/vcl/source/filter/igif/gifread.cxx:889 #9 0x61c85c in LLVMFuzzerTestOneInput /src/libreoffice/vcl/workben/giffuzzer.cxx:18:11 #10 0x575ef58 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:546:13 #11 0x575fcb4 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long) /src/libfuzzer/FuzzerLoop.cpp:497:3 #12 0x577e43a in fuzzer::Fuzzer::RunOne(std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&) /src/libfuzzer/FuzzerInternal.h:119:41 #13 0x575e5ad in fuzzer::Fuzzer::ShuffleAndMinimize(std::__1::vector<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> >, std::__1::allocator<std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > > >*) /src/libfuzzer/FuzzerLoop.cpp:476:30 #14 0x5708588 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/libfuzzer/FuzzerDriver.cpp:534:6 #15 0x56fb3c8 in main /src/libfuzzer/FuzzerMain.cpp:20:10 #16 0x7fb5f13da82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f) Change-Id: I1384f4ced094e79a27e7d15b569c88f129cd115a
generated by cgit (git 2.34.1) at 2025-01-01 19:30:17 +0000