summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-21add TreeView header supportCaolán McNamara
Change-Id: If3dd296e962b08120e07c35065bc18441691b7fd Reviewed-on: https://gerrit.libreoffice.org/63730 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21weld writer char style dialogCaolán McNamara
Change-Id: Iaa61260e3d59dad782b32304aabe4e2d25069559 Reviewed-on: https://gerrit.libreoffice.org/63716 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21weld writer parastyle dialogCaolán McNamara
Change-Id: Id377af704ad9b0df90d6a494cc738fa2f62e4525 Reviewed-on: https://gerrit.libreoffice.org/61218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21weld SwCondCollPageCaolán McNamara
and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21oox smartart, accent process: handle multiple runs from a data pointMiklos Vajna
Multiple paragraphs indeed are impossible for those containers, but multiple runs can happen. Change-Id: I47a2f72cae4cbb822f31a5b7cd0169a663e2a6a8 Reviewed-on: https://gerrit.libreoffice.org/63732 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-21oox smartart, accent process: fix overlapping shape pairsMiklos Vajna
Linear algorithm had an idea how to take width from constrains, but that was unused for embedded child algorithms. Change-Id: If4c497e053ea0d134a1ffc529f1d233ec4fc50db Reviewed-on: https://gerrit.libreoffice.org/63725 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-21processing treeview entries in the wrong orderCaolán McNamara
Change-Id: Ica2240750273996a84ebcf0b8c089aedbbc6c913 Reviewed-on: https://gerrit.libreoffice.org/63711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21Resolves: tdf#121547 do normal dialog layout firstCaolán McNamara
then, if still too small, re-layout with the bigger size Change-Id: I1425e7a55dced4bd93e365a38383eda07fb16d16 Reviewed-on: https://gerrit.libreoffice.org/63706 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21Linkage::ModuleLinkage was only introduced in Clang 5Stephan Bergmann
Change-Id: Ib27908cba00ca120b3bd2ea1dc291c29120a27a4 Reviewed-on: https://gerrit.libreoffice.org/63705 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-21Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Help files: http -> https + some more conservative changes Change-Id: I4176d10e185e88217455a72e7e6b5910ff970b0f Reviewed-on: https://gerrit.libreoffice.org/63215 Tested-by: Jenkins Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Help files: http -> https + some more conservative changes Change-Id: I7b4bffc78fce6fe764a1746c060a403cb1b934eb Reviewed-on: https://gerrit.libreoffice.org/63217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Help files: http -> https + some more conservative changes Change-Id: If73a98d6296081843830f44b75f80657f25a97a9 Reviewed-on: https://gerrit.libreoffice.org/63216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21Update git submodulesSophia Schröder
* Update helpcontent2 from branch 'master' - Help files: http -> https + some more conservative changes Change-Id: Ib905881e92c64deb2f8b22be6dbded8b53d5f8ba Reviewed-on: https://gerrit.libreoffice.org/63197 Tested-by: Jenkins Reviewed-by: Sophie Gautier <gautier.sophie@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21filter: restore null entry at the end of msfilter services listMiklos Vajna
Regression from 0c3e10b8407996b822331c56201ade515245f373 (Replace macro IMPLEMENTATION_ENTRY used once (filter), 2018-11-18). Change-Id: I6138fc44ddeb33cf2e3f1d37faaf01fdd17c9949 Reviewed-on: https://gerrit.libreoffice.org/63696 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-11-21improve function-local statics in forms..reportdesignNoel Grandin
Change-Id: I285e2e75c8d9cad35445c89f00ef68b155806ea2 Reviewed-on: https://gerrit.libreoffice.org/63703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21loplugin:redundantfcast improvementsNoel Grandin
check for calls to constructors, and extend the list of types we check for unnecessary temporary creation Change-Id: Ia2c1f202b41ed6866779fff5343c821128033eec Reviewed-on: https://gerrit.libreoffice.org/63472 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21improve function-local statics in basic..cuiNoel Grandin
Change-Id: If737e8478f6f1c8fffb060ce132d80e0f07ef8ee Reviewed-on: https://gerrit.libreoffice.org/63701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21ofz#11472 Integer-overflowCaolán McNamara
Change-Id: I4776e416071e94468868847420c17d752d39c081 Reviewed-on: https://gerrit.libreoffice.org/63695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-21tdf#121540 crash deleting a form from form navigatorNoel Grandin
regression from commit eec9f6c8b928de38dd9e683f46bfab00f3243048 Date: Mon Jun 4 15:01:43 2018 +0200 loplugin:useuniqueptr in FmEntryDataList and rename the method to make the it's operation clearer Change-Id: Ife366f02c3d8907c397345d825ef7d1721d8930c Reviewed-on: https://gerrit.libreoffice.org/63694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21loplugin, remove unnecessary filtering in post-processingNoel Grandin
removing things that point to the same source location is only really necessary for the method-based analyses, the other's dont need it, and it can hide stuff we are interested in Change-Id: Ib5c3b4c2ed4011c158a199fcd08096285976b831
2018-11-21tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-21tdf#120711 fix paragraph join with change trackingLászló Németh
a DOC import regression caused by "tdf#119571 change tracking: show layout changes at paragraph join" (commit 1bbbe57dfc0b43d6b5444798d77dcdf5e4e76e49) Change-Id: Id9c1efd4f4133a5b1860f33182312f95f5459da0 Reviewed-on: https://gerrit.libreoffice.org/63680 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-11-21tdf#117108: do not show the master view button after updating the sidebarXisco Fauli
Change-Id: I3e6af9c2a555599e4aa288b8d6e99b43b09d35a6 Reviewed-on: https://gerrit.libreoffice.org/63570 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-21Fix getColumnRows function declarationJan-Marek Glogowski
regression from commit 457aba546f43 ("fix some dodgy static vars in connectivity"). Change-Id: I0ab2162d4fa1b09b537c149c4af0f64a2252b64e
2018-11-21Simplify containers iterations in svx/source/[a-e]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7a24407f9e8f38b4903a643210ca4511372d91f2 Reviewed-on: https://gerrit.libreoffice.org/63687 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21connectivity Writer driver: make ProviderRequest members privateMiklos Vajna
And two more trivial readability cleanups. Change-Id: Ie79d9afbdc79260821c27c3f62be3e4635f40395 Reviewed-on: https://gerrit.libreoffice.org/63677 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-21tdf#112536 related: make soffice.bin a proper console application on WinMike Kaganski
Being a GUI application on Windows (with related flag in the executable header - see https://blogs.msdn.microsoft.com/oldnewthing/20090101-00/?p=19643/), OS would detect the subsystem before launching the application, and won't attach the parent console or redirected output handles from it to the application. Also, different hacks to reattach the GUI application to the console later are unreliable on different Windows versions, and work improperly (the output goes to the console after the launch command has already returned, which is wrong in batch files). This makes it extremily difficult to do CLI operations with LibreOffice on Windows, with error codes/warnings/messages/output missing or going to wrong consoles. Making an executable for CUI subsystem, on the other hand, makes Windows to allocate a console before starting it when the program is run by itself. This makes the console window to appear on screen unconditionally, even if it's hidden later when the program has started. This flashing is undesirable. But we use a wrapper executable on Windows, called soffice.exe, which is what actually launched by user, and which runs soffice.bin. This allows us to make soffice.bin the proper console application, and thus make it capable to behave properly in CLI scenarios, while avoid the console flashing when run from the soffice.exe (which would suppress the console creation using DETACHED_PROCESS creation flag to CreateProcessW). Also creating a new wrapper for console (soffice.com) allows to use command lines which omit explicit executable extension (no ".bin"), like this: "C:\Program Files\LibreOffice\program\soffice" --help which allows to continue using multiple available help resources unchanged, since .com extension is tried prior to .exe by Windows' cmd.exe. Change-Id: I089d0f30f860da6cfc781b4383f6598a08a4d238 Reviewed-on: https://gerrit.libreoffice.org/63572 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-21fix some dodgy static vars in connectivityNoel Grandin
no good reason for these to be static, and likely they will cause trouble if this code is ever touched from multiple threads at the same time Change-Id: I3f29d3795bd1a059a75d0d1ab64b25478fd60121 Reviewed-on: https://gerrit.libreoffice.org/63662 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-21uitest for bug tdf#91726Zdeněk Crhonek
Change-Id: I12dadaccf660cafb85f0a6e00d891f1dfd941ab0 Reviewed-on: https://gerrit.libreoffice.org/63684 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-21tdf#121401 calc keyboard navigation all notebookbarsandreas kainz
Change-Id: I45ad8e210954714ed97442ab899de489d64ecf0c Reviewed-on: https://gerrit.libreoffice.org/63691 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-21add test for tdf108022Markus Mohrhard
Change-Id: I00868938738e30afc2b212c01ed36d5223401ceb Reviewed-on: https://gerrit.libreoffice.org/63683 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-21Fix headless build on LinuxThorsten Behrens
Conditional-compile some OpenGL-ness that crept in Change-Id: I8d12f34db3b4875470a0d81e9ef6a1654153b206 Reviewed-on: https://gerrit.libreoffice.org/63676 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-21Bin obsolete headerJens Carl
Change-Id: I78a231024d90d36494cbd8e363da98fd3b420095 Reviewed-on: https://gerrit.libreoffice.org/63685 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20tdf#45904 Move XEnumeration Java tests to C++Jens Carl
Move XEnumeration Java tests to C++ for ScIndexEnumeration_TableChartsEnumeration. Change-Id: Ibbfcf9ec92c3bae4d6add044d2e62472f32d801e Reviewed-on: https://gerrit.libreoffice.org/63678 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-11-20Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - tdf#119415 Add placeholder text for index filter Change-Id: If7a0a863eb6b8bb95a5b6236f4f3d490739810a1 Reviewed-on: https://gerrit.libreoffice.org/63672 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-20tdf#121401 writer keyboard navigation all notebookbarsandreas kainz
Change-Id: I66b384e57e3e6845bacfad34c5de1b6e5b437311 Reviewed-on: https://gerrit.libreoffice.org/63661 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-20coverity#1441469 silence Dereference null return valueCaolán McNamara
and coverity#1441468 Uninitialized pointer field coverity#1441470 Uninitialized pointer field coverity#1441467 Unchecked return value Change-Id: I485fb0b5a83838a3c4913a74b5ea3ae70b4f6bd1 Reviewed-on: https://gerrit.libreoffice.org/63663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-20Fix a copypaste errorMike Kaganski
Has been like this since commit 2d1ef8aa2493f044fa543c72b40bd8c8394d8d71 Change-Id: Idf0e05246f625befb4872e743b490a5594d24f8f Reviewed-on: https://gerrit.libreoffice.org/63548 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-20sw reqif-xhtml export: write graphic of OLE object at OLE1 levelMiklos Vajna
[MS-OLEDS] 2.2.5 EmbeddedObject actually has a last Presentation field, and we didn't write it so far. Luckily all the info can be extracted from the OLE2 container, so we can roundtrip the OLE1 wrapper around OLE2 nicely. Change-Id: I8d4922428dd5beeaae8b6cd4da0575db7014e4a2 Reviewed-on: https://gerrit.libreoffice.org/63667 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-20Tidy up the --help text to properly fit into standard 80-ch terminalMike Kaganski
Change-Id: I5b7f503e32c10b5a844817c040ab0dde27bf48f7 Reviewed-on: https://gerrit.libreoffice.org/63666 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-20Don’t split HarfBuzz runs for Japanese textKhaled Hosny
Change-Id: Ib1b632690ae8491732d893788c9b09ced8e49933 Reviewed-on: https://gerrit.libreoffice.org/63668 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-11-20tdf#115319 fix Hungarian article before letter iLászló Németh
in words, for example “az Ipsum”, not “a Ipsum”. This bug was reported by Gellért Gyuris. Complete commit 1037e3759bf178b52d16c12a811717f94ab9950a (tdf#115319 references with Hungarian articles) Change-Id: If930feb11a0308246d2512f0093bcacdc8675d0b Reviewed-on: https://gerrit.libreoffice.org/63637 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-11-20tdf#121490 Hide item Standard (Viewing Mode) toolbar from menuRoman Kuznetsov
Change-Id: I9e3a071b9b5792a627a3c5b478ba16f0de386487 Reviewed-on: https://gerrit.libreoffice.org/63630 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-11-20tdf#121538 index 1 never existedCaolán McNamara
Change-Id: I8493685ceab81a2bd07a3fc75b371a0f679695fb Reviewed-on: https://gerrit.libreoffice.org/63651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-20Revert "Fix NSS parallel build"Jan-Marek Glogowski
For whatever reason this now fails on Windows for multiple users (including myself). Doesn't look like an easy fix is possible, so this is reverted until I find some more time to look into it (or give up on it). This reverts commit baf0d6d65da8314d718380bb5750ccd29f3d9a08. Change-Id: I432637131ba8ac8be614496bd6da0e157372ae94 Reviewed-on: https://gerrit.libreoffice.org/63664 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-20Set CppunitTest-related env vars only during CppunitTestStephan Bergmann
...and not for every target's recipe, once solenv/gbuild/CppunitTest.mk is included Change-Id: I710160def23fae5f93c5a67ab25e03fdaa008e00 Reviewed-on: https://gerrit.libreoffice.org/63655 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-20Removed executable permission on odt fileAndrea Gelmini
Change-Id: Icece4e008b653ce334808e3bee968792c4c9e99c Reviewed-on: https://gerrit.libreoffice.org/63646 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-20clean up HelpLocaleStringNoel Grandin
to make it easier to read. And fix the last two fall back cases, where it was assigning a different value to aLocaleStr than it was returning, which means that it would return a different value on the second invocation. Change-Id: I6cac1ddd23b0a6a9e4ae8a0b9e7d94c0d877de39 Reviewed-on: https://gerrit.libreoffice.org/63642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-20tdf#121537 Add testSamuel Mehrbrodt
Change-Id: Ifdf46dc79f9b3e2b5ab4c9635619a9d7f598affc Reviewed-on: https://gerrit.libreoffice.org/63654 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-20Actually run CheckXTitle testsSamuel Mehrbrodt
@Test annotation was missing Change-Id: I9e58026e5e131b18e35ab81d7927905316b58f11 Reviewed-on: https://gerrit.libreoffice.org/63653 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>