summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-06-30update creditsChristian Lohmaier
Change-Id: I0295600d528facb0411981a68c1c8a4224bf1dc5 (cherry picked from commit c49378d1233f33d6110eafdfaaf4cff0824732e3)
2020-06-30tdf#133629 calc, crash on format borders on multiple sheetsNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: Ie862ec4a29d495c71aa3a21a1941f801fa3a789e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96957 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8cad16207cb6d6df098d2a2f307df4fbc7519035) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96994 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30tdf#133326 Crash after redoNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: I6a3d6b35dbd442014c84785d97cbd7eae19244cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96958 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 240758a972eb99dd4d26fa6040ff0b6614036621) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96995 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-30tdf#134243 only do the toc-terms localization when showing toc previewCaolán McNamara
and not when previewing another document, which sidesteps the infinite loop in this example Change-Id: Ideb41029f4c98a50555cd35227867d9fdd5ae5a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96889 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-06-30connectivity: fix mysql testMichael Stahl
* rename the gbuild target according to conventions * fix -Werror=unused-but-set-variable * disable assert in testMultipleResultsets() that fails presumably since commit 86c86719782243275b65f1f7f2cfdcc0e56c8cd4 * document how to set up mariadb for dummies like me in README Change-Id: I7f92b80fef90b47e69e4e9a7a02187882a4cab06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96537 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 0c07d849a4709f896072cb9c707af17c309c2f7f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96555 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-30notebookbar: early initSzymon Kłos
Change-Id: I2a129911b6949fd0e165065fd6d02f3546613407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97232 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-30sd: support changing position with .uno:EditAnnotationTomaž Vajngerl
Change-Id: Ie5c683c06079e4d77d42b242c60cf67257db5c16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97421 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit affe8a36c977d396e1e229b0d656cc8c2c062132) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97462 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29pdf: add text page object attribs, refactor ImpSdrPdfImport, testsTomaž Vajngerl
This refactors ImpSdrPdfImport to push more functions into the PDFium wrapper. The focus is on text page object attributes. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97366 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 4e9b03d04f740a0cbafa22a4f3cedfae7f37a994) Change-Id: Ie1faf5e3743eec7c77050835651533f9e227c2a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97451 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29pdf: support PDF Form object and getMatrixTomaž Vajngerl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97365 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit b5b8da80439419a2daa6a80c9d3979173fe2887a) Change-Id: I61f2004df7f9c9ac37959e0b50ea1ff83387c77a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97450 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29pdf: add PDFiumTextPage and PDFiumPageObject + testTomaž Vajngerl
Also use it in ImpSdrPdfImport. Change-Id: I6d353ef60d036c3516448e64a50b25a9befd5db8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97364 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 440cb3fb80d9fd356871eac410b9797f23433722) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97449 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29use PDFium wrapper in ImpSdrPdfImport (partially)Tomaž Vajngerl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97363 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 34745b022d0c58e262c7ad3bfd103e769b2cdd18) Change-Id: If13bcaa6a256354aceb2e1998521644041c03b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97448 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29pdf: fix text annotation (note) modification dateTomaž Vajngerl
The modification date wasn't encolsed in brackets, which is required for the modification date. Change-Id: Icf91516436b095a8577d3ab10b2a708d10d58cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97330 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 09c01a8d6f5dc072991450d215558555152764a8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97447 Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29sd: send annotation position for LOKit, fix multiple annotationsTomaž Vajngerl
This adds support to send annotation position in the document when sending the available annotations using LOKit. It also fixes an issue with the json structure for the annotations, which sends multiple annotation objects with the same (empty) key, that after parsing reduces to only one (so only one of the many annotations is present). This fix changes that so annotation objects have each its own unique key. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97329 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit f008bd0277001226f2dd695836a019c9b9c84799) Change-Id: I9d994383d6ee322f27f1426be5bd96ac81e8e609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97446 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29sd: ignore UNDO when importing a PDF with SdPdfFilterTomaž Vajngerl
Change-Id: I6c695ca4edb284d70726b6f30148a508d0e70911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96944 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c834ea3e4973ca20ae40d0353eb70a47bda9a7a4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97445 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29pdf export: add support for modification time/date in annotationsTomaž Vajngerl
Previously the modification date was written to the annotation "title" as string, together with the username. This is however not neccessary as PDF supports the modification date perfectly fine. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96766 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 235c54e115b66c880d3da0b8018f8ef29d20bc42) Change-Id: I6f55e4fe63d9c3c81ec557f6cfd3387f011e67c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97444 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29pdf export: support pop-up annotation for notes / commentsTomaž Vajngerl
This changes pdf export for annotation, so the comments are exported as "text" annotation with an child "pop-up" annotations. This seems to be more common what PDF readers do (even when text annotation only should be enough). Also changes the test, so that it now works as expected. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96765 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 51d529c18dadb05754590a01ce4c1f06f41cf412) Change-Id: I95bc12939f490effe7759dad54e136c44e44a2f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97443 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29pdf: clean-up PDFWriterImpl::createNoteTomaž Vajngerl
Change-Id: Ie2d50b92d448864e9e20098060b0e42f747f1638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96761 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 387a35fae2a539706f605f052322c1a384b07ce1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97442 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29sd: Test PDF Annotation roundtripTomaž Vajngerl
Change-Id: I2532ecb451362b3b48c8c08b79c010dcad67d5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96760 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 037463d2617e5d7bbaea6b99f6b8ffd265cb38af) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97441 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29support date and time for PDFium and use it for annotationsTomaž Vajngerl
PDF annotations have the modification date and time accessible in the PDF specific format. With PDFium we read the annotation date and time and convert that to css::utils::DateTime (by converting to ISO8601 compatible string first). Add support for modification date and tme for annotations into ImportPDFUnloaded and when the annotations are inserted into the document as comments (in Draw document). Change-Id: I24aacde84b7530365d67ed335b1eefbaee706eca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96759 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 4e3196ceedc2b79d58bb57dba86f2f0158d32998) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97440 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29sd: support adding PDF text / pop-up annotations as commentsTomaž Vajngerl
Change-Id: I3e072f011089864f3349a470a32412cc33bcc022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96758 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 3870dd43e94c440a5094a57c47d3b7565658d73c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97439 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29vcl: Add annotation reading to PDFiumLibrary c++ wrapperTomaž Vajngerl
Also add tests readin annotations from Evince and Acrobat modified PDF files. Change-Id: I4565c6b621774fc8485a6c33bc18708664917b73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96756 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 7e4dc3b1eabcb1993d4143c046a2f32fedc852ed) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97438 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29vcl: add PDFGraphicResult instead of std::pair in ImportPDFUnloadedTomaž Vajngerl
ImportPDFUnloaded returned graphics as a vector of std::pair with Graphic and Size. Instead, use a new struct PDFGraphicResult, so it can be extended in the future. Change-Id: Idda00a3b98a8efcbd9b8c8d0ee3982becfdc1d7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96755 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 03f0ea92bc381ef5a8df7de1ae9edf4aed45a3b2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97437 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-06-29vcl: use pdfium c++ wraper classes in ImportPDFUnloadedTomaž Vajngerl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96754 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 4fa45de60601d34b3a821b35b5aca72f494a7487) Change-Id: I1d0d97f4b981fa62aa38dc5ceaf89d3976bbccbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97436 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29vcl: wrap PDFium types in c++ classes to ease lifecycle managementTomaž Vajngerl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96753 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 526b09604399a71c17b15ee80bab48967563bfb6) Change-Id: Idd33dfe752a22b6628750c06f02e9467a69802bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97435 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-29Attempt to fix three more places of just "hoping" that things work rightTor Lillqvist
Change-Id: I81c87740b36beeb1288649712f6415cb6074348f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97416 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-29tdf#128502: Fix (haha) for a crash with multiple docs open in the iOS appTor Lillqvist
Just a band-aid to avoid a crash. The LibreOfficeKit-related code would need a thorough re-factoring to properly be prepared for multiple open documents. Change-Id: I8c31e2badd747f3086526f89638fa495f4dcf295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97205 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97403
2020-06-29Let's not run on hopeTor Lillqvist
Change-Id: If2fb2c55d53321ec2e5beff0ade9974c02811f7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97120 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97402
2020-06-29Avoid crash with multiple documents open in the iOS appTor Lillqvist
Also add a FIXME. Just 'hoping' is not good enough. But yeah, much of this code indeeed works mostly by accident. Change-Id: Ic6bcbc10229a0b7cdd8d696794efe152fca4faea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97117 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97401
2020-06-29sd signature line: allow move / resize of shape before signingMiklos Vajna
Once the initial rectangle is drawn, a certificate is attached to this shape. Allow modifying this shape (and only this one) before the actual signing, in case the user wants to fine-tune the geometry. (cherry picked from commit 5d296183072dc7cfe7a9985c38388b56f37d873c) Change-Id: Icdf4ffa99eaf02f81d60884d45c26b3500ea73d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97368 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: pass the model down to xmlsecurityMiklos Vajna
So it can avoid SfxObjectShell::Current(), which is only correct when a single document is open. Also add an sfx2::DigitalSignatures interface so this can be done without UNO API changes. (cherry picked from commit c3f8702241b625db994bcb059d8c91c25fd43e53) Conflicts: xmlsecurity/source/component/documentdigitalsignatures.cxx xmlsecurity/source/helper/documentsignaturemanager.cxx Change-Id: Ie81996b8f1e8851975b27c43a53f9d23e316004e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97258 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29[API CHANGE] extend css.security.XDocumentDigitalSignaturesbrinzing
Add support for macro and package signing with a provided certificate which is already possible for document signing since LO 6.2: boolean signScriptingContentWithCertificate( [in] ::com::sun::star::security::XCertificate xCertificate, [in] ::com::sun::star::embed::XStorage xStorage, [in] ::com::sun::star::io::XStream xStream); boolean signPackageWithCertificate( [in] ::com::sun::star::security::XCertificate xCertificate, [in] ::com::sun::star::embed::XStorage xStorage, [in] ::com::sun::star::io::XStream xStream); (cherry picked from commit 697989d11e25b3eb83e5ca2dad5d71b178abfbc1) Change-Id: I9783cd317a7202691913be186eca95964b1e0ff7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97257 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: place shape on the correct pageMiklos Vajna
PDFDocument::Sign() had this hardcoded to always place the signature widget on the first page, add a way so that xmlsecurity/ can tell the pdf signing code to put it on an other page. This way in case the user created the signature line shape on the Nth page, it'll end up on the Nth page of the PDF result as well, as expected. (cherry picked from commit 022f6bb1f7ed06edb126a2b85719d8622104bb57) Conflicts: vcl/Module_vcl.mk Change-Id: I63decba98774151e9634ea924c2fed0f7814cb28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97256 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: don't ask for certs on non-first pagesMiklos Vajna
FuConstructRectangle::Deactivate() is called when the drawing is done, but also when switching pages. Ask for the cert only once, when the drawing is done. With this, we don't ask for the cert multiple times if the signature rectangle is drawn on a non-first page. (cherry picked from commit 87592cc76a53374a7b177cdba65bc529e0203816) Change-Id: Ic34cf31cfd1353496bb957939bdaccba69daaa0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97255 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: support signing multiple timesMiklos Vajna
Reload the document after signing. This way in case the signature line is not exported correctly, we notice it immediately. Also the infobar state gets reset, allowing a next signature to be added. (cherry picked from commit 1904251af5944f8e9c277be1dffe387f85b52626) Change-Id: Iaeaf4c9aebadbd63b44a0620d345cd0dd0214f30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97254 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29Move data for signing tests to test/Miklos Vajna
This was duplicated under xmlsecurity and made it hard to have test code outside xmlsecurity, even if the core of the pdf signing is nowadays under svl/. (cherry picked from commit 81c0b6410ae7a604a97994c7f31113f24665167f) Conflicts: include/unotest/macros_test.hxx unotest/source/cpp/macros_test.cxx xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx Change-Id: If5ce8269bb72f503263727d8255fe856742dfa60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97253 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: add testcaseMiklos Vajna
Fails with commit 9b7a890fd59744459692d7f66402c6bdd25acec4 (sd signature line: include shape in the appearance widget, 2020-06-19) reverted. (cherry picked from commit fb8f0ef26d57986bd27c6c5088939c32453e6b06) Change-Id: Ib237774374553af5d37c9deaffdea6fae65a28f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97252 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: include shape in the appearance widgetMiklos Vajna
With this, finally the following works: 1) file -> digital signatures -> sign existing pdf 2) file -> digital signatures -> signature line 3) draw a rectangle 4) popup appears, select signing certificate 5) click on the "finish signing" button on the infobar The resulting pdf will have a signature on it, together with the pdf export of the signature line shape. (cherry picked from commit 9b7a890fd59744459692d7f66402c6bdd25acec4) Change-Id: Icef701aaa6fd4a625acb37094ad34b88283caf42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97251 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: extract page resource / content copy codeMiklos Vajna
So the "sign existing pdf" code can reuse it. (cherry picked from commit 3bb145bd4665a871491b08f75057223bab798d45) Change-Id: I63a811f0c6f2bc2eeb29507aff9bc35e92a081cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97250 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: teach PDFDocument how to use PDFObjectCopierMiklos Vajna
This will allow using the object copier in PDFDocument::WriteAppearanceObject(), so we can include the signature line pdf export result in a pdf signature of the original pdf. (cherry picked from commit f9ac4ab61fa2ebcafa8ea8957db01104a927bff2) Conflicts: include/vcl/filter/pdfdocument.hxx Change-Id: Iabc508081c5820f4ca997a2d264de9bdb06f82bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97249 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: extract copyExternalResources() from the pdf export codeMiklos Vajna
Because I would like to reuse this in the "sign existing pdf" code, in vcl::filter::PDFDocument::WriteAppearanceObject(). (cherry picked from commit 8277073ce3e33788d93b3df490a8f03d1814863b) Conflicts: vcl/source/gdi/pdfwriter_impl.cxx vcl/source/gdi/pdfwriter_impl.hxx Change-Id: Ia5e5c1e452bb0d0486bde2a082375b5131eea8c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97248 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: separate alloc and write of xref entryMiklos Vajna
The problem is that we need an object ID for the appearance object early, but by the time we ask for that we don't yet know the offset of the object, as we typically have object dependencies we have to copy over first. Solve that by separating the ID allocation and the final object update (remembering its offset). (cherry picked from commit 59482c5323ff9164eb1515b46adc1deef300e9b0) Change-Id: I99a242028f6ef2fb907628b96121b6804b8395e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97247 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: implement non-empty geometry during pdf signMiklos Vajna
Parse the pdf output which contains just the signature line shape on a page, take the same from it and use it at both places where previously the position / size was just a stub. (cherry picked from commit 4db25ccc736185c304f1bd090b8539868932700a) Conflicts: include/vcl/filter/pdfdocument.hxx Change-Id: Ifb2e0ebf7b3514ee027701b9bf360a0c996cdc82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97246 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29vcl: namespace PDFWriterImpl consistentlyMiklos Vajna
We had a mix of 'using namespace vcl;' and 'namespace vcl {', standardize on the later. (cherry picked from commit c43e62f26f8d51c2ad97f6c93877ce9d3ae9639e) Conflicts: vcl/source/gdi/pdfwriter_impl.cxx Change-Id: I088bb0e0c03f712242427bf6a0b31dd17755b9dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97245 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sfx2: add uitest for pdf signingMiklos Vajna
Fails with 058caeef45f9abf12e4e243aafbbb1c2ebcbc057 (tdf#130354 sfx2: make PDF signing UI work again, 2020-06-02) reverted. (cherry picked from commit bfe6500f2560f13a2114a52167bcee4f997da037) Change-Id: I4f4ffaeed4b93c033bc2fdaa76ff817d172c8853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97244 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: access the pdf shape from the appearance writerMiklos Vajna
PDFDocument::WriteAppearanceObject() is where we can turn the pdf data (containing a single shape only) into a form XObject, later. (cherry picked from commit 058c21ac4a552ee6f6ca2f67c0d134a819228d53) Change-Id: Id042c95af4a867d3997d6f7742a18659b8925c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97243 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29sd signature line: export shape with signature to PDFMiklos Vajna
So that later this can be used when writing the appearance object of the pdf signature. (cherry picked from commit 559765ca62f5e581dd5040bdf24e504cf38b0397) Change-Id: I98517b88723de8ffdc982d4eaae7225289603f1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97242 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-29LOKit: do not show 'Add to Dictionary' button for OnlineAndras Timar
Because user profiles (user dictionaries) are not persistent. Change-Id: I78261cccc068cfc1cc9fb2ddecd085ac58ff31c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97352 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-26notebookbar: don't overwrite popup heightSzymon Kłos
Change-Id: I41e0bab8f44b1d7be627e3a7e0f3293179f3977c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97215 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-26notebookbar: remove button which doesn't fitSzymon Kłos
Change-Id: I904ac23f6555dae1ed316a274ac2856c9c3b50f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97214 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-26notebookbar: remember LOKWindowId in interim buildersSzymon Kłos
In case of notebookbar we need to remember the same id in every builder for each view to be able to use interim widgets. Then widgets are added to the same map as main notebookbar widgets. SfxViewShell is used as a common id as it is easily accessible. Change-Id: I4fbf2da320396efc80b08bcee9e341c165b1a290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97199 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-20 16:17:01 +0000