summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-04Log unhandled exceptionsMike Kaganski
Change-Id: I1674730620b9c130b5a640bc0e67b72394752a22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119980 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-04Duplicating checksMike Kaganski
Change-Id: Ie4df9a0287876d12d320060468f635cea759d305 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119978 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-04EventWindow is always a svt::ControlBaseCaolán McNamara
Change-Id: I85220b91f23154c6480e7007eb24986c972ad8cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120001 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-04Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 879d0acff38f25a4219a9da35bda3ead3f8b4b63 - update translations for 7.2/master and force-fix errors using pocheck
2021-08-04establish that DbCellControl Window member is always a ControlBaseCaolán McNamara
and remove resulting known redundant dynamic_casting Change-Id: I5f098ef1adee3ad5d2a2bc5fcd30523f980df2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-04fix commentCaolán McNamara
Change-Id: Ia1783aff3fded7fd73de2b04b9aced647771a92c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-04sw lok: avoid expensive DLPre/PostPaint2() around InvalidateWindows()Miklos Vajna
This shows up on profiles and it's not needed. It was only there, because Online always needs an invalidation to have updated tiles, so there the paint was replaced with an invalidate. And then the drawinglayer setup/teardown was not made conditional by accident. The PaintTile() case goes via Paint() -> PaintSwFrame(), which still calls these functions; this commit only speeds up SwViewShell::ImplEndAction(), which is called synchronously e.g. on every keypress. Change-Id: I6c362f148bc2837bd842602754770c5267e16afd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119997 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-04tdf#143476 improve import of lockedCanvasRegina Henschel
A lockedCanvas is used in Word 2007 to include dml-shapes. It is treated similar to a group, only that its content is not editable. This patch changes the implementation so, that the lockedCanvas is imported as group. Prior only content was imported in the case the content was a single custom-shape or a single group. That has resulted in these errors: Image or line in a lockedCanvas were not imported at all. Only one of several shapes in a lockedCanvas was imported. I have changed mpShape to mpShapePtr to reflect the data type and be consistent with ShapeContext. The patch changes GraphicImport so, that lockedCanvas as special version of a group is detected and handled. That solves regression from commit 3262fc5ef3bde5b158909d11ccb008161ea95519 Change-Id: I57005e64ff073bca6ebb46a404486203fb6802ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119684 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-04osl::Mutex->std::mutex in VCLXPointerNoel Grandin
Change-Id: If96f20d8ce8c893ece59e9278aa79dd1a8f8223f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119953 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-04tdf#143499 don't search entire tree looking for insertion pointCaolán McNamara
keep a short insertion candidate vector up to date as the tree is populated for gen takes time from ~310ms to ~45ms Change-Id: I70e6c0243771cef39e54f4d039069cf54aa6d41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119956 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-04Always provision PATH the cygwin way under WindowsThorsten Behrens
With PATH essentially serving the role of LD_LIBRARY_PATH under Windows, there was the notion that this needs to be provided in Windows notation, for win32 gnumake. That was perhaps once true; currently we're always evaluating PATH inside a shell, not the Makefile. So this since a while only worked accidentally, due to cygwin transparently converting between DOS and UNIX PATH vars. It did break though for corner-cases, e.g. SRCDIR!=BUILDDIR, and BUILDDIR e.g. D:\FOO. With that simplification, also GNUMAKE_WIN_NATIVE can go. Change-Id: Ied5a0443dc70e7dc629c0c0620e6ce911d9a73d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119941 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-08-04osl::Mutex->std::mutex in VCLXRegionNoel Grandin
Change-Id: I8110539975721f515707f42f29dda94346805f93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119952 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-04Fix alternate JREs missing bin/ directory on java.library.pathSamuel Mehrbrodt
Exception looks like this: java stack trace: java.lang.UnsatisfiedLinkError: zulu11\bin\fontmanager.dll: Can't find depende nt libraries at java.base/java.lang.ClassLoader$NativeLibrary.load0(Native Method) at java.base/java.lang.ClassLoader$NativeLibrary.load(ClassLoader.java:2442) at java.base/java.lang.ClassLoader$NativeLibrary.loadLibrary(ClassLoader.java:2498) at java.base/java.lang.ClassLoader.loadLibrary0(ClassLoader.java:2694) at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2648) at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:830) at java.base/java.lang.System.loadLibrary(System.java:1873) at java.desktop/sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:57) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.desktop/sun.font.FontManagerNativeLibrary.<clinit>(FontManagerNativeLibrary.java:32) at java.desktop/sun.font.SunFontManager$1.run(SunFontManager.java:279) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.desktop/sun.font.SunFontManager.<clinit>(SunFontManager.java:275) at java.base/java.lang.Class.forName0(Native Method) at java.base/java.lang.Class.forName(Class.java:398) at java.desktop/sun.font.FontManagerFactory$1.run(FontManagerFactory.java:82) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.desktop/sun.font.FontManagerFactory.getInstance(FontManagerFactory.java:74) at java.desktop/sun.java2d.SunGraphicsEnvironment.getFontManagerForSGE(SunGraphicsEnvironment.ja va:189) at java.desktop/sun.java2d.SunGraphicsEnvironment.getAvailableFontFamilyNames(SunGraphicsEnviron ment.java:223) at java.desktop/sun.java2d.SunGraphicsEnvironment.getAvailableFontFamilyNames(SunGraphicsEnviron ment.java:251) Change-Id: I7a16bb5813d4c089ddb4de34a250280cf6fee137 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119880 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-08-04inline some typedefsNoel Grandin
Change-Id: I83cc2baf7df3f30b73b70caf1c6d0c0e79417fc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-04CppunitTest_sw_ooxmlexport: avoid DECLARE_OOXMLEXPORT_EXPORTONLY_TEST()Miklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: Ic3e15bff48d56349cead8391d32db92418c305a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119942 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-04getReference is unnecessaryNoel Grandin
Change-Id: I156c2e6dc714468f6af42f5c0f7cae923aec175c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119948 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-04osl::Mutex->std::mutex in MutableTreeNodeNoel Grandin
Change-Id: Iee3a1cfb70b99132810324177ab8e77b478e0c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119947 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-04osl::Mutex->std::mutex in VCLXBitmapNoel Grandin
Change-Id: I436f9079468a365622a91d015fddbe5f8fa923d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119946 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-04osl::Mutex->std::mutex in SimpleNamedThingContainerNoel Grandin
Change-Id: I051cd746cc44cc0929ccd0d43934ae3f16bdafc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119951 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-04osl::Mutex->std::mutex in getDefaultFormatsNoel Grandin
Change-Id: I884416cae7d968f1869fb949eb81ab378573a4dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119950 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-04Fix ambiguous calls in C++20Stephan Bergmann
...which added a > template<class It, class End> > constexpr basic_string_view(It begin, End end); ctor, causing > vcl/source/window/builder.cxx:2966:35: error: call to 'get' is ambiguous > sFinalValue = Translate::get({sContext.getStr(), sValue.getStr()}, m_pParserState->m_aResLocale); > ^~~~~~~~~~~~~~ > include/unotools/resmgr.hxx:67:33: note: candidate function > UNOTOOLS_DLLPUBLIC OUString get(std::string_view aId, const std::locale &loc); > ^ > include/unotools/resmgr.hxx:69:33: note: candidate function > UNOTOOLS_DLLPUBLIC OUString get(TranslateId sContextAndId, const std::locale &loc); > ^ etc. Change-Id: I638be4a3d310179ee73866c4a70b20c49925ede6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119957 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-04Remove harmful static_cast<int>Stephan Bergmann
...that were present ever since the code's introduction in 1ced26e19d769e2ac6ca83f57f82cddbd2cfd061 "INTEGRATION: CWS vcl15", but cause `instdir/program/soffice --headless --convert-to pdf` of doc/abi11923-2.doc from the crash-testing corpus to fail under UBSan with > vcl/source/pdf/Matrix3.cxx:30:35: runtime error: 2.14749e+09 is outside the range of representable values of type 'int' > #0 in vcl::pdf::Matrix3::transform(Point const&) const at vcl/source/pdf/Matrix3.cxx:30:35 (instdir/program/libvcllo.so +0x94098c5) [...] Change-Id: I3855027effa09c592345a9c85a9d5dee38d7c992 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119955 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-04Revert "tdf#104254 sw DOCX import: fix text wrapping in headers"Justin Luth
This reverts commit 798b69087119c01a3b51e0bb3240ef35cfededeb. The change affected not only DOCX compatibilityMode 15, but also DOC and ODT and older versions of DOC and everything else which should not have been affected. This reverted change of course affected layout. Some bug documents didn't loop after this layout breakage. That doesn't mean that those bugs were fixed. So just revert the tests: Revert "tdf#96840: sw_ww8export3: Add unittest" This reverts commit 975488594fc88aaba7298448e0ff727ebca7fe85. Revert "tdf#64997: sw_ww8export3: Add unittest" This reverts commit 02af9b8ef1f87bb6bc5fee22ad184681b20f201a. Change-Id: I54f7b801199bba45d8ca6f82f77e7060c7b3fcf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119887 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-04tdf#143388 rebind command search from CTRL+F1 to SHIFT+ESCTomaž Vajngerl
CTRL+F1 is reserved by the OS. Change-Id: I7b5804fc3c65edc8279559635f33ff932bf6ae45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119960 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-04 Add Handler for Pop Writepanoskorovesis
The handler separates MetaPopAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: Ifd6768f74b503bfd2831b6b595e442727cfa2eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119925 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-04 Add Handler for Push Writepanoskorovesis
The handler separates MetaPushAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I60d3b618ccb14e82b195c84271921189fe41b904 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119924 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-04Add Handler for Font Writepanoskorovesis
The handler separates MetaFontAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: Ib80f60afc355fd38729eb2505069851d26328101 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119923 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-04Add Handler for MapMode Writepanoskorovesis
The handler separates MetaMapModeAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: Ic0a2691eabb96a88ceafbe63af08566a38c6e469 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119922 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-04Add Handler for TextAlign Writepanoskorovesis
The handler separates MetaTextAlignAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I464389a0c1e4e5867759174e8580be9e0c239408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119921 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-04Add Handler for OverlineColor Writepanoskorovesis
The handler separates MetaOverlineColorAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I928af66b250d5f898303fad46c6a7a7339ec0e69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119920 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-04tdf#123919 - Sort custom document propertiesAndreas Heinisch
Sort custom document properties on opening the dialog under File > Properties > Custom Properties. The sorting order in the document's xml still depends on the generated handle of the document property itself. Change-Id: I12c4f641d22ca0a3db2f4c6ef54f41c113aeeaa5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115780 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-04tdf#143582 - Clear return value of the method before calling itAndreas Heinisch
Otherwise the function keeps a copy of its return value, which may be used in an upcoming call. Change-Id: I4977c39e1ce48cfd5ab067a4df4783f10505a9ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119905 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-08-03Related: tdf#143499 lookup id just onceCaolán McNamara
instead of twice for gen takes time from ~400ms to ~310ms Change-Id: Ic5e11e889c10fa90b23165aabdca751436ecf55c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-03Resolves: tdf#137637 keep user selection during initializationCaolán McNamara
Change-Id: Ibef83d132ce951393a996aae94b8cdee51da1a64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119940 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-03vcl: avoid native widget pieces for disposed BorderWindow.Michael Meeks
Fixes crash around help windows: vcl::Window::IsCompoundControl() const vcl/source/window/window2.cxx:1200 vcl::Window::Show(bool, ShowFlags) vcl/source/window/window.cxx:2243 (discriminator 3) vcl::Window::Show(bool, ShowFlags) vcl/source/window/window.cxx:2298 HelpTextWindow::ImplShow() vcl/source/app/help.cxx:371 Scheduler::ProcessTaskScheduling() vcl/source/app/scheduler.cxx:495 Change-Id: Ia0205813f3e9d306314577d59d6cdd1bdfa0ee71 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119854 Tested-by: Jenkins
2021-08-03tdf#143657 'execute' button doesn't get enabled when contents changedCaolán McNamara
since... commit 73c9ef661d9ef6237d3fd3c259fd040a545b44cf Date: Tue Jul 6 18:51:38 2021 +0200 tdf#132740 don't broadcast if modified status has not changed now we only get a notification on transition from unmodified to modified. So continue to launch a timer on transition but clear modification on firing so we will get notified on the next change and move the modify callback to the timer. modifications are now deferred until the timer fires, so reduce the timer to make it smoother Change-Id: I27980be54de20bb516b1f106c3ed1b303e2a4014 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119933 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-03tdf#142436 svx: fix handling of linked background imagesMiklos Vajna
Regression from commit 9fb7aaf570c03c8a26d763f1205fb8c890e8211a (Make linked graphic register into LinkedManager again, 2018-04-13), the problem was that now SvXMLImport::loadGraphicByURL() produces a Graphic that has its type set to GraphicType::Default, but when drawinglayer::primitive2d::createNewSdrFillGraphicAttribute() consumes this graphic, it expects that the type is either a bitmap or a metafile. Fix the problem by explicitly loading the image when the default-type, origin-url-set case happens: this is rendering, so no problem to load the URL and that will give us the expected graphic type. This is also meant to keep the original problem fixed, since the Graphic that is part of the doc model is unchanged. Change-Id: If5bba09faa23ef35f99152d4b5d30cd9cf67ace8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119935 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-08-03fix enable-gtk3-kde5 buildCaolán McNamara
Change-Id: I020e6e74f800e58bee71674d2219a89c40a70eda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119930 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-03Fix typo in codeAndrea Gelmini
Change-Id: I0ceb5910fec2dfd4ef5d360b47ae4e147eabec35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119931 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-08-03Fix typosAndrea Gelmini
Change-Id: Ie4809d5367d15dc155033db034d86aaa75cb5abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119932 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2021-08-03tdf#143626 "protect" always shown checked for sections linked to fileCaolán McNamara
Change-Id: I8a403a25ae5c5e3b6183ba559b0224f2886eb925 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-03osl::Mutex->std::mutex in TemplateFolderCacheImplNoel Grandin
Change-Id: Iaec29ac3706cac485032840776ba3a63b3727905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119896 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-03osl::Mutex->std::mutex in UriReferenceNoel Grandin
Change-Id: Ic5fb97774821be582af62e74bd2e00fca503b8f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119889 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-03simplify lookup maps in EnhancedCustomShapeTypeNamesNoel Grandin
simplify initialisation, and use OUString as the key to avoid conversions during lookup Change-Id: I0b1f1f461a4d2375cd92d13bb3333c8e0b887ee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119897 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-03Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' to 6ca79c5a1a97b43676bb8de4ac37389f69aec307 - Resolves: tdf#143131 fix shortcut documentation Related to tdf#82969 add global shortcut for autospellcheck https://gerrit.libreoffice.org/c/core/+/13088/ changed the key combo from Shift+F7 to Shift+F9, update the help to match Change-Id: I3d4e0204dc59e44bc512a4459935f5e7f10982b7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/119929 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-03Consolidate on C++17 std::scoped_lock instead of std::lock_guardNoel Grandin
as in commit 9376f65a26240441bf9dd6ae1f69886dc9fa60fa Change-Id: I3ad9afd4d113582a214a4a4bc7eea55e38cd6ff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119927 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-03Pass context and resource string down to boost::locale separatelyNoel Grandin
because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: I2a24a123a64b762fd0741c45eaca3ad4bdd5580d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-03Avoid unsigned integer subtraction causing wrap-aroundStephan Bergmann
...to a too-large positive value, causing `instdir/program/soffice --headless --convert-to epub` of cloudon/File_1149.docx from the crash-testing corpus to fail under UBSan with > writerfilter/source/dmapper/GraphicImport.cxx:562:27: runtime error: 7.73093e+11 is outside the range of representable values of type 'int' > #0 in writerfilter::dmapper::GraphicImport::lcl_correctWord2007EffectExtent(int) at writerfilter/source/dmapper/GraphicImport.cxx:562:27 [...] (where sal_uInt32 m_pImpl->getXSize() was 3731 and sal_uInt32 m_pImpl->getYSize() was 10583) Change-Id: Id0ae9d6e46c977753d11cc2496ba5d240d3102bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119926 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-03osl::Mutex->std::mutex in SwAccessibleContextNoel Grandin
Change-Id: Ieba232c5b4a337c126a760760c9eaa153a9c8607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119914 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-03tools::Long->sal_Int16 in FmXFormShellNoel Grandin
m_arrRelativeGridColumn is set from FmFoundRecordInformation.nFieldPos which is sal_Int16 Change-Id: Ifd3d72f8aa34d0d574d1b9fc2cbe755c32952b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-16 10:43:45 +0000