summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-12-29loplugin:unnecessaryparen improve return checkNoel Grandin
Change-Id: I8128aa4b5fc60efd1dbf5971cdde11e588f5f64b Reviewed-on: https://gerrit.libreoffice.org/47167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29PRIu64 is unusedStephan Bergmann
...since 2d9beb7854bdfa6e6140e78ab754414340725e38 "OSL_TRACE in sal/rtl/source/alloc_*.cxx leads to deadlock..." Change-Id: I7ede71b8257fa402f5f174dfb9c12fa5e648a017 Reviewed-on: https://gerrit.libreoffice.org/47177 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-29ofz#4829 Floating-point-exceptionCaolán McNamara
Change-Id: Ifadeff08fe0c7d88498c8c657ce3955f0a518ef9
2017-12-29ofz#4817 Chaos with multiple body tagsCaolán McNamara
Change-Id: I4f2ab3a3be0909176599963c8ca113e3af85c832 Reviewed-on: https://gerrit.libreoffice.org/47159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-29Updated coreIlmari Lauhakangas
Project: help 50b850013374e0f711b5cded92739934d758bf1f tdf#114709, tdf#112758, tdf#112757 Lots of changes and tweaks. Header and footer now span 100% width even on desktop. Font sizes were increased and content area made narrower. We now have two separate language menus so the menu is always visible on mobile. Google search moved out of the accordion panel. Accordion panel colours made darker. On desktop, expanded accordion panels overlap content. Change-Id: I976a67b1ca0cb2d21f0569da8d1fefd2b589d7d3 Reviewed-on: https://gerrit.libreoffice.org/47139 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-12-29loplugin:passstuffbyref improved return in xmlhelp,slideshowNoel Grandin
Change-Id: I57e235ecec733f1b5dd03f95f4e022769a369ae2 Reviewed-on: https://gerrit.libreoffice.org/47165 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29Elementary-icons: fix table border iconsandreas kainz
Change-Id: Ibe60237bfaf60773289525e987faeef3bf83d12c Reviewed-on: https://gerrit.libreoffice.org/47162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I0e56430afa65b6b5826d56212ac501c0244fce9b Reviewed-on: https://gerrit.libreoffice.org/47145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I3d16dc162e5fa2e08134d848a835eb392e64056e Reviewed-on: https://gerrit.libreoffice.org/47126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-29Fix typosAndrea Gelmini
Change-Id: I90f72b6a618436d8cd2115be4e57a07bac15befc Reviewed-on: https://gerrit.libreoffice.org/47161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-29simplify copy of ScQueryParamJochen Nitschke
define copy assignment for ScQueryParamBase and use default copy implementations for other structs. Change-Id: Ie384a4f9a3647e8492b4921055df0f2c6bff708e Reviewed-on: https://gerrit.libreoffice.org/47141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29loplugin:passstuffbyref improved return in svxNoel Grandin
Change-Id: I33bdbd416709ce46afb3c17aeab0d2e19a68ab30 Reviewed-on: https://gerrit.libreoffice.org/47150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29loplugin:passstuffbyref improved return in ucb,connectivityNoel Grandin
Change-Id: Ib2590648c9dced87693a58a506cb62d04e37b18d Reviewed-on: https://gerrit.libreoffice.org/47149 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-29add test for tdf#114182Markus Mohrhard
Change-Id: I08dd556814257e64cd0629bcfb2193f939d994e5 Reviewed-on: https://gerrit.libreoffice.org/47155 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-29export explosion property for pie chart property, tdf#114182Markus Mohrhard
Change-Id: I02b46929db1bfbff32e7b1228186079b868e7971 Reviewed-on: https://gerrit.libreoffice.org/47154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-12-29Elementary-Icons: update links for writer menueandreas kainz
Change-Id: Ifa487bd055b4a3cef9bf8c9b9f0f7d40f3fc0417 Reviewed-on: https://gerrit.libreoffice.org/47160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-12-28Use unique_ptr for VectorOfNodes (cui/treeopt)Julien Nabet
Change-Id: I318128452fc6d76038c0ed41fcb0a5e7999952c4 Reviewed-on: https://gerrit.libreoffice.org/47146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28ofz#4746 Invalid-bool-valueCaolán McNamara
Change-Id: I9be8bc2d37bbefa20861ea76522ed9ef985195fa
2017-12-28ofz#4765: Conditional jump or move depends on uninitialised valueCaolán McNamara
Change-Id: Ic8a4fd6cc62c7257f714e2ce2f155f60aa04aa2f Reviewed-on: https://gerrit.libreoffice.org/47157 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-28ofz#4733: align size typesCaolán McNamara
Change-Id: I43d136b131ba43401871a6afa455386f050d6c1e
2017-12-28follow-up tdf#89676 Add some explanation in commentLaurent BP
Change-Id: I740b91e801dc658551ff7ec848f7e4941b9273af Reviewed-on: https://gerrit.libreoffice.org/47113 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-28coverity#1311653 Uninitialized scalar fieldCaolán McNamara
Change-Id: I3006cf4397df6b04fa66bd181470756f39dac1e5
2017-12-28ofz#4814 asserts and Null-dereference on broken shapeCaolán McNamara
the attempt is made, but the shape isn't there, so m_bShapeSent wasn't set, so it will get called again and the markstacks are popped to many times. Lets set it when the effort is made. Change-Id: I58dfe11316112cca6ff69ea518ed0b4908f25d6c Reviewed-on: https://gerrit.libreoffice.org/47106 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-28Use returned iterator (dbaccess/rowsetcache)Julien Nabet
Change-Id: If53bbc8e3cdbbf71bed0d343f1ff358b72c46d21 Reviewed-on: https://gerrit.libreoffice.org/47147 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28Optimize a bit RowSetCache (dbacess)Julien Nabet
Change-Id: I051cb40b5dd854a4a104eae7124564cab8a35de1 Reviewed-on: https://gerrit.libreoffice.org/47151 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-28Use for-range loops in dbaccessJulien Nabet
Change-Id: I0be3aba4f03dcaba188670548901e4aef59c5ec0 Reviewed-on: https://gerrit.libreoffice.org/47148 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28rtl: support start/stop threads around pre-initAshod Nakashian
This is necessary to avoid having extra threads while forking. After forking, the second stage of pre-init is started and so we start the stopped rtl threads. The comment for rtl_alloc_preInit_phase_t has more details. Change-Id: I1a3f7be74d4b04d0b2fc4a72b02124c2faa3c047 Reviewed-on: https://gerrit.libreoffice.org/47060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-12-28tdf#104734 Firebird: Add LONGVARBINARY/Image typeTamas Bunth
Implement it as a user-defined Blob subtype. Change-Id: Ia369b6858e7d9191f34032445c1003931273e926 Reviewed-on: https://gerrit.libreoffice.org/47098 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-12-28Fix typosAndrea Gelmini
Change-Id: I0a8579406a70d2f63d96969c766e2a43d830ed6f Reviewed-on: https://gerrit.libreoffice.org/47114 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-28tdf#104870 - Impress crashes switching views in read-only modeTamás Zolnai
We need to check read only mode similar to SidebarController::CreatePanels() method. Otherwise SfxUnoPanels::getByName() creates an invalid panel. Change-Id: Ib7801b81c95f3f505a06c00f749ba4ed5809bfe0 Reviewed-on: https://gerrit.libreoffice.org/47116 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-28Full UBSan in external/firebirdStephan Bergmann
...after 6a312a4a3d642f0f9769df54c0ec25471c9916bd "Prepare external/firebird for sanitizers". Doing `make check screenshot` on Linux with Clang -fsanitize=undefined -fsanitize=local-bounds -fsanitize=nullability works now. Patches that might be unwanted in non-UBSan builds are added to sanitizer.patch while unproblematic ones are added to always-included ubsan.patch. CppunitTest_dbaccess_firebird_test, e.g., shows that comphelper::AsyncEventNotifierAutoJoin::onTerminated called base-class osl::Thread::onTerminated (which does nothing, anyway) of an already destroyed object, so just drop that. Change-Id: If50f442ee6dbe590db843c38681d1c1cade8fa6a Reviewed-on: https://gerrit.libreoffice.org/47122 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-28Try to handle fonts orphaned from cache gracefullyMike Kaganski
ImplFontCache::Invalidate deletes unused entries (with zero ref count), and keeps other entries, but clears everything (including still used fonts) from its instance list. In the same time, those fonts' mpFontCache pointers kept pointing to this cache object. External clients released font instance by calling its cache's Release method; this itself allows for broken invariants that cache's mnRef0Count is equal to number of unused font instances in its list. Also, those fonts never got released, leaking because ImplFontCache only ever deletes objects in its list. What is worse, sometimes font caches get deleted after invalidation (see OutputDevice::ImplClearFontData). As the instance list of the cache is empty at the point of delete, the cache destructor doesn't delete those fonts that were orphaned at the moment of invalidation (those fonts are still used by some client objects, so deleting them is clearly wrong). But since the font instances still have cache pointer referring the already deleted cache, releasing the instances (by calling deleted cache's Release member function) must lead do some weird results. This patch moves the Acquire/Release to LogicalFontInstance, which now checks if its cache pointer is valid, and if it is, the cache is used to do the work (as before); otherwise, the font handles its lifetime itself, and deletes itself when its reference counter is zero. The cache invalidation clears the cache pointer of the still-used instances. Change-Id: I29811272dda814cbc81f14668d63e385ce772332 Reviewed-on: https://gerrit.libreoffice.org/47111 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-28Fix typoAndrea Gelmini
Change-Id: I209c6d62c2e5cfbc6a35da406bc59fc155787ec9 Reviewed-on: https://gerrit.libreoffice.org/47127 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28loplugin:passstuffbyref improved return in editengNoel Grandin
Change-Id: I6aba5b79e588f28529052ddb30ad51807d73cfe5 Reviewed-on: https://gerrit.libreoffice.org/47120 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-28Firebird: use 32 bitTamas Bunth
Change-Id: I435524d1852a6691b382b93c9b6d2a7705938cd7 Reviewed-on: https://gerrit.libreoffice.org/47130 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-12-28tdf#104734 Firebird improve XClob implementationTamas Bunth
Create a more effective implementation of XClob::length() and XClob::getSubString() methods, where string is read segment-by-segment instead of reading the whole underlying blob. That way it is possible to handle big texts which would not fit into memory. Also allow reading Clob data from a resultset with getString() and writing it in a prepared statement with setString(). Implement XPreparedStatement::setClob(). Also implement a private version of setClob() for creating a clob from OUString: Allow the creation of a clob column with GUI by adding a new type in ODataBaseMetaData::getTypeInfo(). Change-Id: Ibcbbdd80e8eed5e2a3fe55b0fa196401f1bcbcdf Reviewed-on: https://gerrit.libreoffice.org/47093 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2017-12-28tdf#104734 Firebird: Add VARBINARY type to driverTamas Bunth
Change-Id: I9a1b3aa9bde855577078fe0db2e31a9c160031d7 Reviewed-on: https://gerrit.libreoffice.org/47092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-12-28tdf#104734 Firebird: Add Binary (fix) typeTamas Bunth
There is no explicit binary type in Firebird. It can be accomplished using the CHAR type with a special character set, which tells the database that it is binary data and there is no collation. (called OCTETS). Because of that, we also need the character set to decide the exact column type. And also refactor some parts of the driver: - Create class to determine internal type from firebird type, subtype, scale and character set. - Use internal type (DataType::XXX) in XDatabaseMetaData::getTypeInfo() indirectly. (We want to return a Firebird type for each internal type, not in the opposite direction. Change-Id: Ica56a84d89253e11936e7012086fe1d9f61a65f0 Reviewed-on: https://gerrit.libreoffice.org/47091 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-12-28tdf#114702 don't use XMultipleResultset unless DatabaseMetaData says we canLionel Elie Mamane
Change-Id: Icec98d35c2f60adf4a31e492c6cb708e82e47a58 Reviewed-on: https://gerrit.libreoffice.org/47080 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28firebird: return consistent (if wrong...) results for XMultipleResultsLionel Elie Mamane
Just in case we are called by code not checking our DatabaseMetadata to learn we don't support multiple resultsets. Change-Id: I6d8c5f4ef04bcd9ec8b66a83881607281e125b7b Reviewed-on: https://gerrit.libreoffice.org/47117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28dbaccess OStatementBase: correctly check database metadataLionel Elie Mamane
the previous test didn't make any sense: * if xMeta.is(), then the test evaluated to false * if !xMeta.is(), then it called supportsMultipleResultSets (or supportsBatchUpdates, respectively) on a NULL pointer, which guaranteed a segfault / assert. Change-Id: I6d6b93350557936b924a286732ae6d4f5ab2ce56 Reviewed-on: https://gerrit.libreoffice.org/47118 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-28Use unique_ptr for m_aLeaves/m_aGroupedLeaves (cui)Julien Nabet
and perhaps avoid memory leaks (see https://bugs.documentfoundation.org/show_bug.cgi?id=114457) Change-Id: Ib413b0bf6cc65a2696e3429965a67899b7b72d73 Reviewed-on: https://gerrit.libreoffice.org/47094 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-28Simplify dynamic_cast checkMike Kaganski
Change-Id: Ib16168c0b87c99bceae3970b739aaba1667b154b Reviewed-on: https://gerrit.libreoffice.org/47115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-12-28Fix spelling in commentsJohnny_M
Change-Id: I93b3e2dde7be65d2077e386b8f80ae7c3576c788 Reviewed-on: https://gerrit.libreoffice.org/47102 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-12-28tdf#113877 Insert document: merge two lists into oneSerge Krot
When inserting a new document into current position we need to concat to lists into one. Added unit test. Change-Id: I10689256e0ffc5cf93722b1d45f09f610211b14a Reviewed-on: https://gerrit.libreoffice.org/46978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-12-27tdf#109100: Hide label for margin control in ImpressAron Budea
Change-Id: Ib61656913df673ebfde61e2c921f84cb81195a3b Reviewed-on: https://gerrit.libreoffice.org/46974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-27Fix typosAndrea Gelmini
Change-Id: Icebbbb392d9187a11837b72116c00036247e9b74 Reviewed-on: https://gerrit.libreoffice.org/47104 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-27use right icons for the styles sidebar in breeze and elementaryandreas kainz
Change-Id: Idc2b686f754afe4708c15fefcda44b7c7742a2e9 Reviewed-on: https://gerrit.libreoffice.org/47097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-12-27ofz#4813: Direct-leakCaolán McNamara
Change-Id: I7bd257734a302ad00acf4336f4b478d6af4bc304 Reviewed-on: https://gerrit.libreoffice.org/47100 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-27ofz#4806 Infinite loopCaolán McNamara
Change-Id: I89a24fa3ce4034ef207233b96c5e26a7b7787444 Reviewed-on: https://gerrit.libreoffice.org/47096 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-16 13:39:58 +0000