Age | Commit message (Collapse) | Author |
|
CppunitTest_sw_ooxmlexport8's testN816593 failed in the
SW_FORCE_FLY_SPLIT=1 case because the re-import of the document merged
two tables into one.
The problem starts earlier, we didn't import the table with a <w:tblpPr>
as a floating table, but we should.
Fix the problem by never going via m_aPendingFloatingTables in the
SW_FORCE_FLY_SPLIT=1 case, since that was only a workaround for layout
limitations. This conditionally reverts commit
78d1f1c2835b9fae0f91ed771fc1d594c7817502 (fdo#68607 bnc#816593
DomainMapperTableHandler: don't always start a frame, 2013-09-03).
Also add a SwModelTestBase::FlySplitGuard, so it's just a one-liner
change to test the SW_FORCE_FLY_SPLIT=1 case from cppunit. The goal is
to have this on by default once it's mature enough.
Change-Id: I9d94a49f7a0c27dd43e8fd388867c65d6d25f2e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149044
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: I43fd96feb1e3d34a5f3327b2e6398ca4b5e9f928
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149049
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Refactory
Cause
Currency must be added in the MRU list in SvxCurrencyToolBoxControl::execute
method.
Unfortunately in this point the only information available is the number format.
It is not possibile to infer currency from number format (e.g: both USD and
AUD use symbol $).
Encapsulating currency data
In order to solve the problem currency data is enacpsulated in a SvxCurrencyData
struct. Added a vector of SvxCurrencyData to SvxCurrencyToolBoxControl.
Static and non static call
Former static SvxCurrencyToolBoxControl::GetCurrencySymbols has been
preserved, as it is called by SvxNumberFormatShell.
A new GetCurrencySymbols is used by the control.
To avoid code duplication, both functions call a static private function
inner_GetCurrencySymbols.
MRU Currencies
MRU currencies are stored in another member vector m_mru_curencies:
During currencies vector population (inner_GetCurrencySymbols) a space is reserved
on top of vector for mru currencies.
A new method addMruCurrency updates m_currencies. This method is called in
SvxCurrencyToolBoxControl::execute
Change-Id: I6f86179efd1839e31b089e0086b6ddbdda358f31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148896
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ic5bb7f36137afe112d1a542bd642355d996cf68c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149048
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
If the inpt matches one of the constants exactly, the result is the
name of that constant. If the input matches some combination of
constant values that are single bits, the result is the sequence of
the names of those constants joined with plus signs.
For instance, if the IDL has:
constants Constants {
const byte BIT0 = 1;
const byte BIT1 = 2;
const byte BIT2 = 4;
const byte BIT3 = 8;
}
The result of Constants::to_string(5) is "BIT0+BIT2", and the result
of Constants::to_string(17) is "17".
I am sure there are corner cases that aren't handled as would be
intuitive, especially with types that include unsigned values.
Correspondingly, the semantics of the generated to_string() functions
is not formally defined.
Also add a unit test for the new functionality.
Change-Id: I14aa826d0989ac6dfe97dd5c09119b1601c65643
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148995
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
If there's a paragraph scoped tab default distance defined,
use that as the default tab distance in the SvxRuler instead
of the document wide setting.
Change-Id: I9b0e7d0db0b25aee08bd27948b2e462b4a4ee496
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148060
Tested-by: Jenkins
Reviewed-by: Sarper Akdemir <sarper.akdemir@collabora.com>
|
|
Change-Id: I119552a4f1300eafc8b060f567777a74dc11772f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149038
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iaf664deeac5c5887f20c9579881cd921868b652f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148794
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit ae69dc05d3de876dade4fa8a9b6f6f693cc7c865)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148973
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
|
|
Change-Id: I6cbac308d2911a502381067398d72136ca2b5ae3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149045
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
where we are calling
append(OUString::createFromAscii(
and we can rather call
appendAscii
Change-Id: I2366b518fe6d8d2484b00bb831cb79fb49bc0293
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149043
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iebfbeecf43e139f39a70ca58bd3b30076856c4d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149042
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
The bugdoc has 2 rows: the 2nd row was split and the master row went to
page 1 and the follow row went to page 2. Word positioned the entire row
to page 2.
The problem seems to be that the layout code wants a "deadline" (so it
can grow the frame to that bottom position), but the deadline depends on
the height: split flys need to fit the body frame, then they can have a
vertical offset (resulting in an overlap between the bottom margin area
& the fly frame), in case the fly frame is still inside the page area.
This means that this deadline depends on the body height, the fly top
and the fly height at the same time. (Or in other words: the overlap is
only allowed if the fly would fit the body frame, but an additional
vertical offset pushes it to the bottom margin area, with an unchanged
height.)
Solve this fly height <-> deadline circular dependency by first checking
against the page size, using the current fly height; and then against
the body height, using the assumed / future fly height (assuming that
the fly will grow so its new height will match the deadline). This
results in a construct where usually you can't grow outside the body
area, but in some limited cases you can (till you only use the bottom
margin area), but only in case you grow your top position as well, which
is Word-compatible, but quite unusual at other places in Writer.
With this, the original tdf#61594 bugdoc gets rendered correctly, once
you opt in with SW_FORCE_FLY_SPLIT=1.
Change-Id: I016df1bad79f4b09abc7e2b4fe9ea613355e3794
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149039
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ibc05961b60cabcd3d7421116245713c217b40999
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149037
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib0d8c2674bfa4aa38cdf3a6449642407c2373093
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149036
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Ideally SwFrame should not really know anything about headers.
Change-Id: I96df0d14473564d39368b2af92794a796668676c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149006
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I71f557016c0e107b97ad839b0514efbae4f3665b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148977
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I5f361822048720a68ce2b6fc7246cb7cf7c87fa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148983
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I170eba4968743afbab3cc6aa943706612b3e1a57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149035
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Update the view options string based on the theme when tiled rendering,
and make sure only the currently active view is updated
Change-Id: Ib24111848f2926fe7ae858ca2e18e946d980e83f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148943
Tested-by: Paris Oplopoios <parisoplop@gmail.com>
Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
|
|
Add an uno command that changes the theme to the one specified in the
first parameter
Change-Id: Ia0fef2ca698415e07f1943cf80ab667fb5c37238
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148942
Tested-by: Jenkins
Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
|
|
Fix "!" behavior when it is not the first in a group.
Add testcases for "!" and Like.
Change-Id: Ia76fa26722b6546d08dd8842d83f55bb0c0ea5ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148720
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ic43a5bb4d243b2c4081fcd56130e20ed1c3b43a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149009
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Iaf8ad5edd483da25cad45d91afc27f9cc3aa9040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149002
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
in this dialog preview widget
Change-Id: Id33995d9a9557d235178be0d12cc6b44e146ff4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148997
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
See https://crashreport.libreoffice.org/stats/signature/SfxDispatcher::ExecuteList(unsigned%20short,SfxCallMode,std::initializer_list%3CSfxPoolItem%20const%20*%3E,std::initializer_list%3CSfxPoolItem%20const%20*%3E)
Change-Id: I7f5471f003798f260d9d015782bd2a798baa22d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148999
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to a0ef2acc2d24501a7373ab7ba03ddc9473814b54
- one character is found without plus in regular expression
reported by Kamil Landa
Change-Id: I53f11b8ccd89340d2545e3c26edd8abee8cf5e9a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/149005
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I556973587c2c7f4baab4cf696afe980186e82f6e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148930
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit cd428e3e564b9bca0badb5e947f78a6fe3ea39ec)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149014
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
|
|
Change-Id: I3825349e3889c45bbb5cbc467dad2f100ccd2298
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148952
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I44e9305ec4127f9567fb51ce7bf8c26f17727787
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148974
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If19fe618de0c316ffa6d74432b03c507b960a891
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib84525664ff8456b4eb8e100aaaea2783babaf30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148994
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...for which clang::IfStmt::getCond returns null
Change-Id: I8b86a033d52de87dedbdf6d867f2b3d3f57c1b5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148979
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I77e48dc05c2bd6a36c42e1860a209ed563e71ad8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148988
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I460ffc51d82ff8b727813228e93a6e0c95c8569a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148993
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Adds export of ParaTabStopDefaultDistance property into defTabSz.
Also adds a unit test that checks pptx roundtrip of the property.
Change-Id: I5be9ea88b15e3e8cab25af79488983a71b96dae1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148539
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Id6381d77cdf05c24a1b557206f530f4e004e8e52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148986
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@aliftype.com>
|
|
* Update helpcontent2 from branch 'master'
to 4453c0b2edae4934f87594d5974783c4a1a5ea54
- convert paragraphs with role="heading" & childelements to → h<level>
and also drop the language that was changed to implied previously/defaults to
en-US unless specified.
This change doesn't affect translations, only the content of the
paragraph/headings is extracted.
done with:
perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")/;} s#<paragraph(((\s+($base)){3})|(\s+($base|xml-lang="en-US")){4})>(?<body>.*?)</paragraph>#<h$+{level} $+{id}>$+{body}</h$+{level}>#g'
and manually undoing the one that uses <sup>in body that's not valid
according to the dtd in the h tags.
Change-Id: Ibd4aed3157ed168cd5005161575672a392e59202
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148797
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 77cb682cd1b004e7247560e60f603a4bb0565b8d
- convert plain paragraphs with role="heading" → h<level>
i.e. without child elements and also drop the language that was changed
to implied in the dtd previously/defaults to en-US unless specified.
This change doesn't affect translations, only the content of the
paragraph/headings is extracted.
done with:
perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")/;} s#<paragraph(((\s+($base)){3})|(\s+($base|xml-lang="en-US")){4})>(?<body>[^<]+)</paragraph>#<h$+{level} $+{id}>$+{body}</h$+{level}>#g'
(all permutations re order of attributes, and xml-lang="en-US" being
optional / implied)
Change-Id: I365a2bb983a3969af9390753fce7b7f3597c7b8b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148795
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 00567a452bb1e270dd2438dcc865359edba56c19
- convert plain paragraphs with role="heading" → h<level> (localize="false")
done with
perl -CSD -pi -e 'BEGIN {$base = qr/role="heading"|level="(?<level>\d+)"|(?<id>id="[^"]+")|localize="false"/;} s#<paragraph(((\s+($base)){4})|(\s+($base|xml-lang="en-US")){5})>(?<body>[^<]+)</paragraph>#<h$+{level} $+{id} localize="false">$+{body}</h$+{level}>#g'
Change-Id: I5d2b1b6326801adb8d000b3353d314d2fc9f322d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148796
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
e.g. in page style dialog, footnote page, line menubutton, if theme
changes from light<->dark while the line dropdown remains open.
Use the application settings, and not the current rendercontext settings
to get the up to date settings and not the settings at the time the
virtual device rendered to was created.
Change-Id: I674c94603f15c9035bbd07b4bd7247dcebc3124b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148982
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
e.g. in page style dialog, footnote page, line menubutton,
if theme changes from light<->dark while the dialog remains open
Change-Id: If8ca8b2cf9c4e4d620ce0ea1c92c50accbc8ebcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148981
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Introduce import of defTabSz using ParaTabStopDefaultDistance.
Change-Id: Ied59c2bc5d9dfffa6254ef87849c3dbad4c48d07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148059
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I791e4ad45daeeb77ca25e36ae6520168b2ece044
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148980
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to d29743de6f11453152a00222fddf0e4dd12c2c05
- Remove xml-lang from tags, since marked IMPLIED everywhere
Change-Id: I899df40cbad5ac86d9a25c448cf9e7d6032c4401
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148987
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Resize maTableColumnAttributes to match the amount of columns, fixes
crash upon undoing a column insertion on a table
Change-Id: Iad4b8ac5c38d5d1065d6ef1267ce3f5d3b28afa8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148492
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: If6dbc02f1ec22be9f020290572199f89548c76e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148939
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ife553269e0cdeb331931a885a3dd4f87c1c3d9bb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148940
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
...which I had added as part of 0025fa723afb9f6a0d94b9b3185ea14da18f1bd5 "Enable
loplugin:unnecessaryparen for integer and Boolean literals", and where I
apparently wanted to include a link but forgot to do so (and no longer know what
link that would have been)
Change-Id: I245725fea80ee0e13d76026656d433d5c42e4c19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148975
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ic49e0c167a020269fa7de58ea9e1ece0b66d57ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148950
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I6e1d881705282c7f7c219a345f61990a20c05cbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148951
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|