Age | Commit message (Collapse) | Author |
|
Change-Id: Ia3c3e8b6c1988561284d91545e98e4939973c4b9
|
|
Change-Id: Iac606a8e5e4fc9beb019d95d2a05f0ab9d9dad34
|
|
Change-Id: I9e7aefdd0309fd4f209fba6fb4f698b098856d01
Reviewed-on: https://gerrit.libreoffice.org/34133
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
...for e7aab255c1595c8cc54e0eab3d8d1059fb3d00f1 "warning C4018: '<' :
signed/unsigned mismatch"
Change-Id: I9a91244f2136e2cd31c480511e3b08c721b478e4
|
|
Not only saves a pointer per list element, but future versions could
hold a document pointer and/or drawing layer's draw page as well.
Change-Id: I85e05981239223bec88c47f2ebe4c22e50cd9a0d
|
|
The early return should just skip the code that's specific to pdf
images, not everything.
Change-Id: Ia9e02b05051a085a9fdf2f690c21f9ffccb7bf4d
Reviewed-on: https://gerrit.libreoffice.org/34685
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
There is nothing called FillPropertiesGroupContext. Rename the file to
"misccontexts.hxx" as I could not come up with some more specific name
that would describe the collection of classes defined in it. Rename
the corresponding cxx file, too.
Change-Id: I44db1db8c63c8e897774597b46a237a214aacedf
|
|
So bin two pointless and misleading comments that consist of just that
identifier.
Change-Id: I14724b21d43283dbda1856ab28c56ae44512c3cc
|
|
I dislike OSL_THIS_FUNC, it is too verbose, at least with Clang on
Linux. Just use the Class::Name without parameters and namespaces.
Change-Id: Ic8722a131463762ab70ff35d64ae7040c67bf595
|
|
Change-Id: If7f710aa62cea43e2c59d91e136daba9650b3912
|
|
This makes the code much more readable..
Change-Id: Ic9078daffeba28984749c61d059701b3cdcca8bd
Reviewed-on: https://gerrit.libreoffice.org/34687
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
...since ef40dde69e7fff331b7e31460638703a2c82bc9d "INTEGRATION: CWS dba30d"
Change-Id: I2dbd73bd77f71cbf88768dcc2dc4a38f65b84eef
|
|
Change-Id: I00438178582bd4c78bffeca18067abeb667b8367
|
|
- add some curly-braces
- join consecutive if statements
- declare variables inside for statement
Change-Id: I369452cdd684f71a7bd30b5dc072831b982ee1b3
Reviewed-on: https://gerrit.libreoffice.org/34686
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: Ie352e9b7fe52d41492141ebba9b5d332960dadd5
|
|
Change-Id: Icf0e75d0e213c4562f4ee57df0537d394031645b
|
|
Only one constructor to append an infobar
Colors defined at one place in infobar.cxx based on InfoBarType
Icons as an additional attribute of the notification
Change-Id: I4dc85c2b4ef0b7eafc139290b3b4ee21636da6ec
Reviewed-on: https://gerrit.libreoffice.org/34426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
|
|
Fails with commit 4ad249af88d15f2c8a09f0721a59d82718fcc201 (tdf#105093
sd PDF export: handle embedded videos, 2017-01-04) reverted.
Change-Id: I413ec9a5da3c0783541dcd28fb9a62dd896f955b
Reviewed-on: https://gerrit.libreoffice.org/34681
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Change-Id: I682b4e2750658efded5f4167d4f7026ed5fac8dc
|
|
Change-Id: I7f490335efef71b13aae66e9467cd74429509d7d
|
|
Change-Id: Idf47d1511aff3cdb7c139671173a97e405b6078e
|
|
Change-Id: I00e73eabb34ae98088a8e88d0c8677bf236a5e09
|
|
Change-Id: I2cd7be7ef49552acd84aa4b5042955dcb18f328f
Reviewed-on: https://gerrit.libreoffice.org/34679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <eszkadev@gmail.com>
|
|
This commit improves the user experience of different
Document Providers in the app.
In case ext sd card is not present, the option is disabled
in Navigation Menu.
If the device does not support USB OTG,
the option is disabled.
LibreOfficeUIActivity registers a broadcast receiver
in onCreate which detects if a USB device is connected
and directs the user to Settings page to configure it.
In case of errors in configuration in any case,
user is directed to Settings activity after appropriate toast.
Change-Id: I680f78a679e2071ce8330c8168d7aa4e95041723
Reviewed-on: https://gerrit.libreoffice.org/34650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
|
|
Change-Id: I631ea0012f8e999f14aa08b42f28d6115a73d084
|
|
Change-Id: I21edad9865717674217d2d10b9ec2a689d9d65f9
|
|
Change-Id: I3f00cd66a0a8aa0571733caf4db4d16dfd102683
|
|
Change-Id: I1ca1bd56289ea1005b76dd387ef7610ff1b0a3db
|
|
Change-Id: I3a30bc86796a7ad24616cb11ae10b6886e09c1e9
|
|
If you look at the oldest available version of SvPersistStream::WriteDummyLen in
8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import", it looks like there
was an issue with whetever earlier way was used to reserve a four-byte space in
the stream with "Sun sp" (whatever that shall mean).
Change-Id: I861a445ae72f1ced502f70917707336eb5dddf04
|
|
This is triggered by an upcoming unit test for tdf#105093.
Change-Id: I3c8e8662fcadaea1f6e19bf6194d8159916f368b
Reviewed-on: https://gerrit.libreoffice.org/34678
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
...to any elements actually written. Was like that ever since the code's
introduction in d3ffe3ed3fa1b80c7e54439673029e105940db80 "fdo#67737 : fix for
flip not being imported & rendered correctly".
Change-Id: I460c1c7c578bd7e53cc2e868da0b7aeb5f19194f
|
|
Patch doesnt solve the issue but makes the wizard dialog HIG compliant
Change-Id: Ib45b49671bc247ad2bce072e4cc4260ed551ef7c
Reviewed-on: https://gerrit.libreoffice.org/34652
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
having the ; on a separate line made all strings following that have the
string-ID of the next unit, altering the msgctx and thus translations
wouldn't apply anymore
Change-Id: Ia1e3c36a9d2a57725c90e6c3f33de99bed85ec41
|
|
Change-Id: I2e80e15ded19e09853ec16f9876e425a88cf910e
|
|
Change-Id: Id2771f413798ed9ceb76e9c4dd3113633d4e481e
|
|
Ever since 2010 commit 7edaf190 zeroes have been saved as XML_AUTO.
Ever since 2014 commit c2ccd20c, a numoffset of zero is no longer
considered to be auto (for MS compatibility) but is still treated
as auto during xml export. Thus, any older documents that had been
saved with a zero should still xml import as auto instead of as 0.
Change-Id: I1a0df32a8e2f1b30b2bedbf4c9bb07ebec239637
Reviewed-on: https://gerrit.libreoffice.org/33267
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
Change-Id: I3ada4fc8c8ebcf04962be03c048fb87bc0d6dbf8
|
|
Change-Id: I580639aecc4cf6a214a7aaba3bbe92f7459856d5
|
|
Change-Id: I1842a5e047e4566371b62511ad5b56d466e717da
|
|
Change-Id: If630131272b5ed4c589ed76be340a4107632c461
|
|
Change-Id: I05874c22883a98f09c9231c0e0ff0dff93e2d643
|
|
Change-Id: I40df0def8da88ba2c5719508a9df390e1d391fac
|
|
Change-Id: I7e87b2ecc107c91f9fcb9f385a8cace65776fc25
Reviewed-on: https://gerrit.libreoffice.org/34622
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I3e6297f4789bdf398e5eb2a3cec5df6e8b770b5d
|
|
- the code claimed this ownership before
- however it still tried to do stuff in SetMaster(..), which leads to
at least memory leaking, if not worse
- abort there for now
- SetMaster() likely needs to be removed from the base-class proper soon
as not all derived classes can possible implement it.
Change-Id: Id241b9330e6f98a126949a9236c60a8783cf8ea8
Reviewed-on: https://gerrit.libreoffice.org/34663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: I32782945c46762f1fd4edde7453f7fca200c9cd2
Reviewed-on: https://gerrit.libreoffice.org/34662
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
|
|
Change-Id: Iee166416aaca627e55f25a25ed69f468fa2e510d
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/34653
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I88ccbc63a02a8a873419874d220b94cf23c46e88
Reviewed-on: https://gerrit.libreoffice.org/34673
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|
|
Change-Id: Ib62cc9465bb874d48b4e294a6f18d98de04a5518
Reviewed-on: https://gerrit.libreoffice.org/34672
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
|