summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-02-28use memset instead of loopCaolán McNamara
Change-Id: I572f52658914a0814bc3d3990830e247275e110b
2017-02-28fix leakCaolán McNamara
Change-Id: I57d1ae4d8f3fed72f024672a9eefb748df83bb93
2017-02-28update creditsChristian Lohmaier
Change-Id: Iea0785f5ec1b55200d25d5cd55a63652ab5a38e1
2017-02-28update emoji autocorrect files from po-filesChristian Lohmaier
Change-Id: Ib837a679e359ac7f7c1e22f57cdfc0fddbdee931
2017-02-28fix leakCaolán McNamara
Change-Id: Id6171fbaffda1f0a20d33e9137d68e14c59e6aac
2017-02-28Updated coreChristian Lohmaier
Project: translations 2883419ce5b0406a375cea7774ab6918e27efd8f update translations for 5.3.1 rc2 and force-fix errors using pocheck Change-Id: I37d9df9e5daf10adc8baf905bb43c621c37d960e (cherry picked from commit 05788c2f5a2a282905055c813b3b3504a25938c3)
2017-02-28fix leakCaolán McNamara
Change-Id: Icce163a695ce5467d943019919de1bb604dd130b
2017-02-28ofz: detect failure earlierCaolán McNamara
Change-Id: I28be740fb15b3b9ed88d2575c94073c24d53579c
2017-02-28Fix incorrect function name in SAL_INFOTor Lillqvist
Change-Id: I75ee5f1a20fadef7c20103278bc03abd41b815cf
2017-02-28assert that nullptr captions are not in a listEike Rathke
Change-Id: I0c286891454d290ec4373dbc37e31d65c22c746d
2017-02-28fix leakCaolán McNamara
Change-Id: Id501339e1576277655c53e0cf0d172947640d64e
2017-02-28loplugin:subtlezeroinitCaolán McNamara
Change-Id: I29197c9a4093d904d1f7b990de08fbf8254c168e
2017-02-28hwp: avoid low hanging invalid inputCaolán McNamara
Change-Id: I06133d6db14edb9d915c38e4c120a9d0905495dd
2017-02-28might as well move append 'usage' into the msConfigPath from the startCaolán McNamara
Change-Id: Ie8a15f1a20621ebdd00ab4ed195495e0acd111a5
2017-02-28FontDescription.IsVertical is a tristateNoel Grandin
found by still in progress "UNO scoped enum" change Change-Id: I0a21b89e77be165bc96e914017a402cf8724d218 Reviewed-on: https://gerrit.libreoffice.org/34719 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28loplugin:unoanyStephan Bergmann
Change-Id: I57375d39aa2e84e40f2c2eb13e3e942497a78a3e
2017-02-28fix leakCaolán McNamara
Change-Id: I724c6e50392d70acd847c733e09a959c08c8c790
2017-02-28std::unique_ptr -> rtl::Reference for loplugin:refcountingCaolán McNamara
Change-Id: I83cccff1f4fb172e1b6aa5c1cfda93de2e4be525
2017-02-28fix leakCaolán McNamara
Change-Id: Ic84035f68075733a6777a7447cb2be092f17a189
2017-02-28Revert "move append 'usage' into the msConfigPath from the start"Caolán McNamara
oops This reverts commit dc1c69a4efe9368a1f4fae4bc11325485bcc0772. Change-Id: I5fb9016040636fb44d4337567a6b894bfe16f503
2017-02-28fix leakCaolán McNamara
Change-Id: I20e665a2b0bfadd44976b1659d85b1828e10311f
2017-02-28might as well move append 'usage' into the msConfigPath from the startCaolán McNamara
Change-Id: Ic3e141d91607f8e34ff4a74cd1ae3276e42934e7
2017-02-28Add back tests that got lostStephan Bergmann
...with 198c41c4fe8be4ce8a6ddab43ae0c5f17a4889ac "new loplugin unoany" Change-Id: Ia4e59356ad8ef3af899209a287ac5326e1389c5e
2017-02-28fix leakCaolán McNamara
Change-Id: I88e652fa2eab8738d0e1a235cf1a3f9066bfc230
2017-02-28new loplugin unoanyNoel Grandin
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-28Keep the order that is in the header.Jan Holesovsky
Change-Id: I6171668b91e13cbcddf223645333e435cf08cb2a
2017-02-28tdf#77111 sw: add unit test, fix getting PageNumberOffset propertyMichael Stahl
There are 2 places where the style:page-number attribute is handled, in XMLNumberWithAutoInsteadZeroPropHdl (for paragraphs) and SvXMLExportItemMapper/SvXMLImportItemMapper (for tables) Apparently for the paragraph case, 0 was never written to mean "auto", this happened only for tables (see 7edaf190e2b18fe5dd9b7dd8d8e7e24b2ff26520). The test reveals that SwXParagraph::Impl::GetSinglePropertyValue_Impl() was kinda broken by 7d9bb549d498d6beed2c4050c402d09643febdfa, which converts void values of "short" properties to short(0), wrongly assuming that the Any contains a long. (Fortunately this is then mapped to "auto" in XMLNumberWithAutoInsteadZeroPropHdl.) Change-Id: I3dc6d5533ac96955440b1589f1999d06750101af
2017-02-28Run macro:// via LOKitKatarina Behrens
Change-Id: I54d3c734d86d4b44e1dfe1ad7728e2f51cd26d53 Reviewed-on: https://gerrit.libreoffice.org/34538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-28tdf#103931 DOCX import: fix lost section breakMiklos Vajna
When there are multiple sections in a document, every <w:p> element triggers a handleLastParagraphInSection() call, and that's how the previous section is ended and the next one is started if necessary. In case the section contains no paragraphs at all, the section was lost on import. Fix this by also calling handleLastParagraphInSection() on <w:sectPr> as well. It's not a problem if there are both <w:p> and <w:sectPr> in a section (which is the usual situation) as only the first call closes the previous section / starts the next one. Change-Id: I64f2c403dcb2ceca76d444ab06df3052235d2795 Reviewed-on: https://gerrit.libreoffice.org/34715 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-28fix leakCaolán McNamara
Change-Id: I195094adfd0a68401d26ef97b6489b105424b99b
2017-02-28ofz#704 fix tiff leakCaolán McNamara
Change-Id: Id43fd11b5503d1fdd967d146a71445e2fed4192f
2017-02-28sal_uLong->sal_uInt32Caolán McNamara
Change-Id: I49d926f4ff064871e3773fce089d7f927df9b099
2017-02-28fold CreateVirtObj()Bjoern Michaelsen
- only one caller, and throwing around nacked pointers to owned objects should be avoided anyway Change-Id: I2ecc716a844c73e42a0838ac048caf0c20c045a1 Reviewed-on: https://gerrit.libreoffice.org/34705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28use a vector of unique_ptr for explicit memory managementBjoern Michaelsen
Change-Id: Ieda786709343a14e8191d1c408375d3e5b061095 Reviewed-on: https://gerrit.libreoffice.org/34704 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28fix leakCaolán McNamara
Change-Id: I1c1e861c5608ccd2071baf683f5456c3012a47f6
2017-02-28remove DestroyVirtObj memberBjoern Michaelsen
- had only one caller - didnt even do what it claimed in the comments (removing from container), so removed to a simple delete statements with pointless noop decorum Change-Id: I3eeaebbc6199a516b24106d3c2fc27a3067cb34d Reviewed-on: https://gerrit.libreoffice.org/34703 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28remove const code duplicationBjoern Michaelsen
Change-Id: If8330d3f1ce0c92122dcecfc22c32b005deffeb3 Reviewed-on: https://gerrit.libreoffice.org/34702 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28Fold SetMaster() CompletelyBjoern Michaelsen
- was called only from two places - one could be replaced by a one-line setting of a bool Change-Id: Ife85303518417f44755636f8d627ac0e8db98c13 Reviewed-on: https://gerrit.libreoffice.org/34701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28make SetMaster private in SwDrawContactBjoern Michaelsen
Change-Id: I9d4f35c8973e3240cc5e9cd870fcdc4ed70a717c Reviewed-on: https://gerrit.libreoffice.org/34700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28Avoid -fsanitize=nullStephan Bergmann
...during CppunitTest_xmlsecurity_pdfsigning: > tools/source/stream/stream.cxx:1220:20: runtime error: null pointer passed as argument 1, which is declared to never be null > /usr/include/string.h:43:28: note: nonnull attribute specified here > #0 0x7fb2116abe4a in SvStream::ReadBytes(void*, unsigned long) tools/source/stream/stream.cxx:1220:13 > #1 0x7fb1dee7a4f0 in xmlsecurity::pdfio::PDFStreamElement::Read(SvStream&) xmlsecurity/source/pdfio/pdfdocument.cxx:3639:13 > #2 0x7fb1dee350ec in xmlsecurity::pdfio::PDFDocument::Tokenize(SvStream&, xmlsecurity::pdfio::TokenizeMode, std::__debug::vector<std::unique_ptr<xmlsecurity::pdfio::PDFElement, std::default_delete<xmlsecurity::pdfio::PDFElement> >, std::allocator<std::unique_ptr<xmlsecurity::pdfio::PDFElement, std::default_delete<xmlsecurity::pdfio::PDFElement> > > >&, xmlsecurity::pdfio::PDFObjectElement*) xmlsecurity/source/pdfio/pdfdocument.cxx:1153:44 > #3 0x7fb1dee464d3 in xmlsecurity::pdfio::PDFDocument::Read(SvStream&) xmlsecurity/source/pdfio/pdfdocument.cxx:1306:12 > #4 0x7fb1e7916ffe in PDFSigningTest::verify(rtl::OUString const&, unsigned long, rtl::OString const&) xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx:127:5 > #5 0x7fb1e791dd86 in PDFSigningTest::sign(rtl::OUString const&, rtl::OUString const&, unsigned long) xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx:178:5 > #6 0x7fb1e791ef8e in PDFSigningTest::testPDFAdd() xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx:189:29 > #7 0x7fb1e798885b in CppUnit::TestCaller<PDFSigningTest>::runTest() workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6 > #8 0x7fb22b8bfd8b in CppUnit::TestCaseMethodFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #9 0x7fb211f6699f in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) test/source/vclbootstrapprotector.cxx:36:14 > #10 0x7fb22b87e3ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #11 0x7fb21ba510cf in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #12 0x7fb22b87e3ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #13 0x7fb21f6ff2c4 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #14 0x7fb22b87e3ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #15 0x7fb22b7fc350 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #16 0x7fb22b87e3ce in CppUnit::ProtectorChain::ProtectFunctor::operator()() const workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:25 > #17 0x7fb22b87ae70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:77:18 > #18 0x7fb22b93a0f5 in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:181:28 > #19 0x7fb22b8bdfa4 in CppUnit::TestCase::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:13 > #20 0x7fb22b8c27a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #21 0x7fb22b8c1819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #22 0x7fb22b8c27a7 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:30 > #23 0x7fb22b8c1819 in CppUnit::TestComposite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #24 0x7fb22b9785c9 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:27 > #25 0x7fb22b93840d in CppUnit::TestResult::runTest(CppUnit::Test*) workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:148:9 > #26 0x7fb22b97989b in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:14 > #27 0x53043c in (anonymous namespace)::ProtectedFixtureFunctor::run() const sal/cppunittester/cppunittester.cxx:305:20 > #28 0x52c089 in sal_main() sal/cppunittester/cppunittester.cxx:455:20 > #29 0x52a742 in main sal/cppunittester/cppunittester.cxx:362:1 > #30 0x7fb229b05400 in __libc_start_main /usr/src/debug/glibc-2.24-33-ge9e69e4/csu/../csu/libc-start.c:289 > #31 0x437d49 in _start (workdir/LinkTarget/Executable/cppunittester+0x437d49) Change-Id: I8bf8c28219b4525874f83fbb164eb5eec02ac1b6
2017-02-28move troublesome SetMaster from SwContact down to SwDrawContactBjoern Michaelsen
Change-Id: I4fc0565175cda316e5b26c78fd0a05a4e27e527a Reviewed-on: https://gerrit.libreoffice.org/34699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-28mpMediaItem might be nullptrMarkus Mohrhard
This fixes at least two crashes reported through the crashreporter: http://crashreport.libreoffice.org/stats/signature/avmedia::MediaItem::getTime() http://crashreport.libreoffice.org/stats/signature/avmedia::MediaItem::getDuration() Change-Id: I92eeca229fa46921317586d0317e9f00309e793b Reviewed-on: https://gerrit.libreoffice.org/34710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28we can just comment the variable name outMarkus Mohrhard
Change-Id: Idcb2365f3ba39a086eaa4698457fcd02cec780f8 Reviewed-on: https://gerrit.libreoffice.org/34709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28VBA: unit test for PtrSafe and compiler directivesJustin Luth
#If Vba7 Declare PtrSafe Function xx #Else Declare Function xx #End if Change-Id: I807efb9fa68b5ac50f2bd59ba7cfa45c499af189 Reviewed-on: https://gerrit.libreoffice.org/34522 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28VBA: allow and ignore compiler directivesJustin Luth
Instead of erroring out on this: #If Win64 Then Declare PtrSafe Function aht_apiGetOpenFileName Lib "comdlg32.dll" #Else Declare Function aht_apiGetOpenFileName Lib "comdlg32.dll" #End If just treat the # commands as remarks and continue on. This type of coding will become more common as 64bit versions of Office require such constructs. Change-Id: I63bfb8cbe9ad3ef35bab4c041d9d94daa7fbba18 Reviewed-on: https://gerrit.libreoffice.org/34518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28tdf#48140 Replace CellRangeAddress with ScRangeBartosz Kosiorek
Change-Id: I5aa1dabf938e1567d386fceb153e2986862f70a6 Reviewed-on: https://gerrit.libreoffice.org/34707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-28starmath: Add test cases for errors at parsingTakeshi Abe
Change-Id: Ic8de7f1c925d7a77520681121cbdd00c036ccab8 Reviewed-on: https://gerrit.libreoffice.org/34683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-02-27uitest: catch more exceptions during shutdownMarkus Mohrhard
Change-Id: Ie4bfc28c32b4b21c75ca92b95521c03a0683db32 Reviewed-on: https://gerrit.libreoffice.org/34692 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27uitest: move the processing of actions into the idle handlerMarkus Mohrhard
Change-Id: Idead7314096f879f147dd87e6ce8f4b79b8f70c1 Reviewed-on: https://gerrit.libreoffice.org/34691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-02-27uitest: add scheduler method that runs until a signal is receivedMarkus Mohrhard
The other method only runs 1000 events. Change-Id: I43076988e9e25b35e3fdfd8dff19270d9e066d9a Reviewed-on: https://gerrit.libreoffice.org/34690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>