summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: Idea363ebc0948c83d739b5f9ed8fbf44c734935c Reviewed-on: https://gerrit.libreoffice.org/67643 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I463614e55ff9bae7bf3223a67d2ad2ab7725ee3e Reviewed-on: https://gerrit.libreoffice.org/67644 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I0f4e864ed27a5a9e071489c74f72859118627b08 Reviewed-on: https://gerrit.libreoffice.org/67645 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Precalculate all needed tokens and use indexingMatteo Casalin
Change-Id: If83e1b89e0116f0b20549daf839bd24621c926be Reviewed-on: https://gerrit.libreoffice.org/67647 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I28d1a4f5a32bbe6e2278e9694c85d9a72dde8a23 Reviewed-on: https://gerrit.libreoffice.org/67650 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Simplify style processing in ScVbaFont::setFontStyleMatteo Casalin
Change-Id: If4a2b9d864a007ceae063a4561c6a7172a4e73a1 Reviewed-on: https://gerrit.libreoffice.org/67653 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: I12f621a433d2f044fed11f7fac854c68efff9b5e Reviewed-on: https://gerrit.libreoffice.org/67658 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17weld HangulHanjaEditDictDialogCaolán McNamara
Change-Id: If0d49a65735b66eaa8db11686099ed29b01711c4 Reviewed-on: https://gerrit.libreoffice.org/67929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-17use Application::AddKeyListener to be able to mark key events as handledCaolán McNamara
Change-Id: I1f9ced535bcd12569c355c332652babf5740434c Reviewed-on: https://gerrit.libreoffice.org/67931 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-17Use indexed getToken()Matteo Casalin
Change-Id: Id26dc4262ca7030f5165a56be019a009e043d893 Reviewed-on: https://gerrit.libreoffice.org/67660 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-17disable werror for now for updater buildsMarkus Mohrhard
Change-Id: I1d7a261549efa5aad2d86e23d8ee8898c27983e5
2019-02-17tdf#123488 add curencyfield for colibre 32pxandreas kainz
Change-Id: I59fa76f9bfb0533559896ec37132e71e757a389e Reviewed-on: https://gerrit.libreoffice.org/67937 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-17Sifr icon theme updateandreas kainz
Change-Id: I7b6ce4cfd02c57c9dbcfa5b5a16499882a507556 Reviewed-on: https://gerrit.libreoffice.org/67930 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-16uitest for Chart X axis dialogZdeněk Crhonek
Change-Id: I21d904e614e81ad8a0f4b2189ad8a03ce2dd6871 Reviewed-on: https://gerrit.libreoffice.org/67928 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-02-16weld DBChangeDialog_ImplCaolán McNamara
Change-Id: I8d5330f07e4c76c6cdf51a878949bcac9ad3e92e Reviewed-on: https://gerrit.libreoffice.org/67915 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-16Options pops up a dialog, so add ... to itCaolán McNamara
Change-Id: I01a72c0a74fa4a57dd641f8d513a28b35f1e2dcd Reviewed-on: https://gerrit.libreoffice.org/67916 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-16MSForms: Rework the MS compatible Forms menu a bitTamás Zolnai
* DateField is saved as a content control in MSO file formats so let have it under content controls submenu * The MS compatible forms menu is a Writer specific thing so better to have the related commands as Writer commands. Change-Id: I2d66130f54c055a422f56b18ff2c98667e4f6469 Reviewed-on: https://gerrit.libreoffice.org/67912 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Make Control Properties menu to work with drop-down form fieldTamás Zolnai
Always forward the Execute and State method to the form shell, so if a form control is selected the Control Properites will work correctly. Otherwise we check whether there is any field next to the cursor. Change-Id: I25055c17d887a2f2a716d8325f46825cc408179e Reviewed-on: https://gerrit.libreoffice.org/67911 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Don't show popup dialog of drop-down field when there is no item listTamás Zolnai
Change-Id: Ife361e0ee18437da6f188e77713ea51403b70dbc Reviewed-on: https://gerrit.libreoffice.org/67910 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Introduce a properties dialog for Drop-down form fieldTamás Zolnai
- Dialog created similar to the edit dialog of Input field - On the dialog, the user can edit the list of the drop down field - This dialog is only for editing of the field, so the user can't select an item from the list to display in the field. Change-Id: I6222aba9b211afeb0e9d10d97a49347921ff7353 Reviewed-on: https://gerrit.libreoffice.org/67909 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Make Drop-Down form field to have a default sizeTamás Zolnai
Similar to MSO Drop-down form field and LO Input List. Change-Id: Idba278d8c2a2106b6f3cc22d8b9f8570f45bfae9 Reviewed-on: https://gerrit.libreoffice.org/67908 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Insert Legacy Form Fields from MS compatible Forms menuTamás Zolnai
I added a new submenu under MS compatible Forms menu called Legacy Forms. Under this submenu user can insert the three legacy form fields. These fields were already supported by DOC / DOCX filters, but were missing from the UI. When inserting text form field we insert 5 enspace to make the field visible, otherwise we use the same insertion methods what is called by DOC import. Change-Id: I1fb8c03d969b4c547ca92e783ac5e216767685d5 Reviewed-on: https://gerrit.libreoffice.org/67907 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Show restart dialog when MS compatible Forms menu setting is changedTamás Zolnai
Change-Id: Icb98dac73dea5f5cb18e1ca34e37e9d9bf84782e Reviewed-on: https://gerrit.libreoffice.org/67906 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Introduce a new Forms menu which is compatible with MS WordTamás Zolnai
* It's a Writer only menu by now * Displayed when the compatibility option is set * The menubar is changed during creation, so the option has an effect only after a restart. * MS compatible Forms menu contains only some ActiveX controls now Change-Id: I459f489c15ea7a25514f379b1800b926cc2087ce Reviewed-on: https://gerrit.libreoffice.org/67904 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Extract menu creation to a separate methodTamás Zolnai
No functional change is intended. Change-Id: Ieb88e746b08c6a6daac14c08a206db73cbeef8a9 Reviewed-on: https://gerrit.libreoffice.org/67903 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16MSForms: Introduce a new compatibility flag to enable MS compatible Forms menuTamás Zolnai
* It's a global option not a document level setting (like other compatibility options) so I created a separate section on the GUI for this option on the same tab page. * In the configuration the option is placed under Compatibility/View since the existing Compatibility/FormattingOptions seems related to document formating and not the GUI. * Since it was added with a new configuration root I needed to add also a new ConfigItem derviative class to handle this option. Change-Id: I54668ae9808a1ca3c3b7fe81f2f201720257b3fb Reviewed-on: https://gerrit.libreoffice.org/67902 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-02-16drop newly unused codeCaolán McNamara
drop now unused ListBoxWrapper Change-Id: I19271de67269a9e23cf889a32910405cf3dc7a2a drop unused SingleControlWrapper Change-Id: I80bd639a9d64a1b35249c1c59c1c9d134ae6f1ca drop unused PosValueMapper Change-Id: I5e3d9ed48b5f544215ae82ba7899a62be4e59a25 drop unused ControlWrapperBase Change-Id: I1890f492604ac848775e8d4b0070a3189a719a18 drop now empty itemconnect.cxx Change-Id: I5374dbf91dbe715a563e7c694c9d96fb07d8f9c8 drop unnecessary controlwrapper.hxx Change-Id: Ide633f64ca2851aee4f29a7f86e09cb78043d388 Reviewed-on: https://gerrit.libreoffice.org/67887 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-16getToken+comparison ==> startsWith, reuse available informationMatteo Casalin
Change-Id: Ie7eef48ee20da9bc01d0b046435bb270f8d1e18f Reviewed-on: https://gerrit.libreoffice.org/67654 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-16Use optimized string concatenationMatteo Casalin
Change-Id: If9d9af8255639e4d7e5c2e8020c1b3675498980f Reviewed-on: https://gerrit.libreoffice.org/67657 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-16Use optimized OUString concatenationMatteo Casalin
Change-Id: I931290d8c4136f772677ffe1b8c8de29d1c4f67a Reviewed-on: https://gerrit.libreoffice.org/67659 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-16Use optimized string concatenationMatteo Casalin
Change-Id: I88499f04630b3a3ee507408435cfbd293a16fba3 Reviewed-on: https://gerrit.libreoffice.org/67655 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-16Use optimized string concatenationMatteo Casalin
Change-Id: I66df8c63fb2d35b923faa5b586f60c92bd9a3a8b Reviewed-on: https://gerrit.libreoffice.org/67656 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-16Same token is used in both branches of if/elseMatteo Casalin
Change-Id: I6d678b2969f0e16afe7f7f88e0610175553714b5 Reviewed-on: https://gerrit.libreoffice.org/67651 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-16Simplify name validation in ScVbaNames::AddMatteo Casalin
Change-Id: Idd73659fdd76a1efd9ceb9fdc221622367d4922c Reviewed-on: https://gerrit.libreoffice.org/67652 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-16tdf#123021 Fix options dialog cancel doesn't cancel chart color changesJim Raykowski
...and add missed variable inititialization in options uitest that causes Jenkins to report test failure when testing patches concerning options charts default colors page. Change-Id: I324bcbb7834abf1a270bfce01eb84db280420409 Reviewed-on: https://gerrit.libreoffice.org/67236 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-16Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - Document some Calc shortcuts Shift+Space, Ctrl+Space and Ctrl+Shift+Space were undocumented. Change-Id: I133bd7e92f43d53f0d6ab22bdf249ff5528dc777 Reviewed-on: https://gerrit.libreoffice.org/67899 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-02-16Fix typosAndrea Gelmini
Change-Id: Ic0ab859d7b9bfbce8d55c1c9dc11bfae760626f3 Reviewed-on: https://gerrit.libreoffice.org/67898 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-15Revert "tdf#49684 Don't focus on Navigator or Sidebar on show"Jim Raykowski
See tdf#122900 for unwanted behavior changed caused by this. This reverts commit 88cbc3ea2db8358bbedff01361f95f972f2b0231. Change-Id: I9451a4b1f059b40d33b66b06f23228fc64170d8d Reviewed-on: https://gerrit.libreoffice.org/67853 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-02-15lok: Fix the font previews in eg. Format -> Character... dialog.Jan Holesovsky
Change-Id: I5d25249c58f55c501e3e5610419753a68423b0f2 Reviewed-on: https://gerrit.libreoffice.org/67613 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-02-15tdf#113020 Change horizontal-align to justifyLaurent BP
Some frames in templates were horizontal-align to left, which prevent from centering text Change-Id: I1de654af6ebfcad52352ed9031d14da00d72eff5 Reviewed-on: https://gerrit.libreoffice.org/67790 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-15tdf#123451 qt5: Detect decimal separator on keypadMichael Weghorn
'QtKeyEvent::key()' doesn't return a special value for the decimal separator key on the keypad ("," or "."), but just returns 'Qt::Key_Comma' or 'Qt::Key_Period'. However, the 'Qt::KeypadModifier' modifier is set in this case, so check for this one in addition and return 'KEY_DECIMAL' if those are combined. Change-Id: Ia80826e2ad5e47a1f49bef450168523d766c1d6a Reviewed-on: https://gerrit.libreoffice.org/67886 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-15sw btlr writing mode shell: fix cursor positionMiklos Vajna
By implementing the SwRect variant of SwTextFrame::SwitchHorizontalToVertical() for the IsVertLRBT() == true case. The blinking cursor position after doc load is now correct. Change-Id: I4862a6de286d3c0a34235fa0be8be2746b1a4151 Reviewed-on: https://gerrit.libreoffice.org/67880 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-02-15These items are of type SfxUInt32ItemStephan Bergmann
...see include/svx/svxids.hrc for SID_ATTR_NUMBERFORMAT_VALUE and chart2/source/inc/chartview/ChartSfxItemIds.hxx for SCHATTR_AXIS_CROSSING_MAIN_AXIS_NUMBERFORMAT, and as reported by -fsanitize=vptr in sc/qa/uitest/chart/tdf122398.py recently added to UITest_chart (<https://ci.libreoffice.org/job/lo_ubsan/1188/>). Change-Id: Ic1e2f3390bd54b722730e6dd7962d613587774b1 Reviewed-on: https://gerrit.libreoffice.org/67884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-15weld ScDPFunctionDlgCaolán McNamara
Change-Id: I49428a9e6cd07a962c55939477f8408822170590 Reviewed-on: https://gerrit.libreoffice.org/67881 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15weld ScDPSubtotalDlgCaolán McNamara
Change-Id: I33403031421a9f372c240cddea320591ac72bfc2 Reviewed-on: https://gerrit.libreoffice.org/67878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15weld ScDPSubtotalOptDlgCaolán McNamara
Change-Id: I986346fa26f397fee6f0a2d9d724a1bdfb2e4220 Reviewed-on: https://gerrit.libreoffice.org/67872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15BitmapColor string representation - fix proper paddingTomaž Vajngerl
Change-Id: I42727152e71b2dce4c2b5ce71f9a54464388a7fb
2019-02-15disble test of rendering BitmapEx with alpha on Windows for nowTomaž Vajngerl
Tinderboxes fail, but Jenkins was fine so we must have problems with rounding errors in some code paths. Change-Id: I38a457c0ee7a079bebaa599794b0e65c433dfe64
2019-02-15work around Werror=format-truncation in onlineupdate for nowMarkus Mohrhard
Change-Id: I6230cc8c76313b5d180ef3fbebec4bc20b794150 Reviewed-on: https://gerrit.libreoffice.org/67879 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2019-02-15Mention that temporaryHackToInvokeCallbackHandlers() is for LibreOfficeLightTor Lillqvist
Change-Id: I0b53fea8df48bea17c56678d6d9b7d43c571d0a1