summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-20drmemory: fix small leakCaolán McNamara
Change-Id: Ib7f6beb52dc832ee570e21ac5ab65d25946b622f Reviewed-on: https://gerrit.libreoffice.org/43597 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20Drop redundant castTakeshi Abe
Change-Id: I8f0835a910bef2eac058a8408a86edc774ab8777 Reviewed-on: https://gerrit.libreoffice.org/43594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-10-20OSX implement direct timeout processingJan-Marek Glogowski
Basically works in the same way then in the Windows backend. Change-Id: If48e2b55f037563839a5e716830ce75ed78381e4 Reviewed-on: https://gerrit.libreoffice.org/43530 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-20shrink ww8 fuzzerCaolán McNamara
Change-Id: Ic2ee596b1d2dbba4f685100aef1862ce0e5e435d
2017-10-20RotGrfFlyFrame: Clang error fixArmin Le Grand
Change-Id: Ifae68d4d5a17446f01c97ce2e94cd0419217259e
2017-10-20RotGrfFlyFrame: Added interactive rotation modeArmin Le Grand
The FlyFrames containing a graphic now support an interactive rotation mode. Added a rotation icon to the Toolbar close to right/left 90degree rotation. When activated, works as similar to draw object mode as possible. Shear and move of the rotation center is deactivated since not supported. It uses as much of the existing interaction stuff as possible. Change-Id: Ia1a4e5c064d8576b114c3fcf3a96ccb42c9372bb
2017-10-20RotGrfFlyFrame: Corrected position for CropHandlesArmin Le Grand
Position was taken from OuterBound FlyFrame, even in current master which is wrong. There can be a distance defined between InnerBound and OuterBound that has to be taken into account Change-Id: Id88f99c0b218bd26fa1daa5e8215eced00c0baa6
2017-10-20RotGrfFlyFrame: Implemented Handle Update on rotation changeArmin Le Grand
WIth rotaiton being allowed the handle visualisation may be dependent on this, so it is necessary to refresh their visualisation on rotation chnage, e.g. for crop handles Change-Id: I218e326894999381fc4058b7eba432491a0cf23b
2017-10-20RotGrfFlyFrame: Encapsulated matrix decomposesArmin Le Grand
Change-Id: I432766970ef06c7d85a0056d3f24280cf2acd47d
2017-10-20RotGrfFlyFrame: Adapt Crop functionality to rotated GraphicArmin Le Grand
The FlyFrame which may contain a Graphic needs working Crop, interactive and in core. Adapted this to work with now possible rotation, changed common code in svx which has to handle cases for Draw/Impress/Calc and Writer differently. Tried to use as much in common as possible. Additionally furter adaptions to rotation itself. Change-Id: Ia961e9490e2627c74220b186116f5aa4fcabca78
2017-10-20RotGrfFlyFrame: Minimal working rotation solutionArmin Le Grand
This version allows rotation (in 10th degrees) and perserves it over save/load cycles. Rotation of multiples of 90 degree behave close to original except not changing the contained Graphic and being adaptable to all kinds of graphic. The rotated Graphic is displayed centered and under preserved AspectRatio in the available frame space (so no rotation, 180 degree is identical, 90/-90 is identical with 1:1 ratio of the graphic) Change-Id: I54b3385f709ee0d34a55324aca919dcd2ce0c009
2017-10-20RotGrfFlyFrame: Initial adaptionsArmin Le Grand
To allow free rotation of Graphic FlyFrames in Writer, several adaptions are necessary. This change takes care of all needed changes to internally support a freely definable rotation angle for that case. Save/Load round trip is working, the graphic does no longer get modified and added in 90-degree-changed state to the object, the original will be preserved. Support for needed slot in core/ui is implemented. Rotation can be applied from Menus/Toolbars in the known 90/180 degree steps. Added a slot/Button/command to reset rotation in these cases. Added support in Sidebar to rotate using the rotation wheel and/or numeric field. These fields and support added to Image TabPage, too, fully functional. Missing now is a solution for displaying the rotated Graphic. For now, it just gets rotated, but this will not be the final state of this change. Change-Id: I6f3b85ebb5be2b4ad3311c536d54f27a37a494e7 RotGrfFlyFrame: Linux build adaptions Change-Id: I365287ecd6525b1972e8436d61332f7121d88649
2017-10-20Resolves: tdf#113252 missing tabs in basic library organizerCaolán McNamara
Like SfxTabDialog, as in interim measure throw away the TabPage if its not suitable for reuse Change-Id: If8247ea37dfca42e690716a8b687677e0f73c9a8
2017-10-20ofz+ubsan: left shift of negative valueCaolán McNamara
Change-Id: I304532162fc75b69807d5e45227368ab25736b93 Reviewed-on: https://gerrit.libreoffice.org/43586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20sw layout xml dump: show validity flags of SwFrameMiklos Vajna
Change-Id: I48ef2d7b2f88421c90a5128785e21868dc2cef32 Reviewed-on: https://gerrit.libreoffice.org/43589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-20sw: fix unusual boolean prefix for pointer in tabfrmMiklos Vajna
Change-Id: I0a0e896c57e8b6d659e0038bbbd89996aedb1147 Reviewed-on: https://gerrit.libreoffice.org/43588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-20sw: drop temporary debug code in sectfrmMiklos Vajna
Change-Id: Ic9a7ecae8533adc76d440525e9f7a7cafa272be8 Reviewed-on: https://gerrit.libreoffice.org/43587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-10-20tdf#55528 ww8export: export table width percentJustin Luth
Confirmed in MSO 2003 and MSO2013. Change-Id: I91362571294c3869ecd7c5fd37d2f781e2655fe6 Reviewed-on: https://gerrit.libreoffice.org/42919 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2017-10-20coverity#1419948 silence Operands don't affect resultCaolán McNamara
Change-Id: I68c42f6d9c6cfda90446a07ecd6bbf02abb22af9 Reviewed-on: https://gerrit.libreoffice.org/43593 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20coverity#705523 silence Dereference null return valueCaolán McNamara
Change-Id: Ic7719a543b341ca78264a24568b63cc69069c8e5 Reviewed-on: https://gerrit.libreoffice.org/43592 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20Resolves: tdf#113230 crash in finishParagraphCaolán McNamara
Change-Id: I94535a51a87be097ff7356edff935877b42c3272 Reviewed-on: https://gerrit.libreoffice.org/43598 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-20tdf#113244 - UI Inconsequent naming for Zoomheiko tietze
Renamed toom level into zoom factor Change-Id: Ib7cadc822b4bca33d1252e9aea844319ba4c90d6 Reviewed-on: https://gerrit.libreoffice.org/43544 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-10-20loplugin:finalclasses in ucb,ucbhelperNoel Grandin
Change-Id: I5a0f75cb2b19123ac5f9f149a6dcaa06ef3f8923 Reviewed-on: https://gerrit.libreoffice.org/43585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-20use std::unique_ptr in SwSortOptionsNoel Grandin
Change-Id: I5854e1492388d765a0503193a45f7c0f1bd14004 Reviewed-on: https://gerrit.libreoffice.org/43528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-20offapi: update TextFitToSizeType documentation for tdf#97630 fixMichael Stahl
Change-Id: Id4fad147002d0ec18d1462764f842a3791b48d3a
2017-10-20offapi: fix TextFitToSize propertyMichael Stahl
Change-Id: I3c519e1377c09b53f02f360bb53f422ac1bad2b5
2017-10-20Very quick EPUB icons for GalaxyAdolfo Jayme Barrientos
Change-Id: Ie9e62b87a125c0bb86b3078a6eed80cfcfc1f522
2017-10-20tdf#97630 xmloff: ODF extended draw:fit-to-size messMichael Stahl
The plan: 1. As Regina points out, there is already (in ODF 1.2, but not ODF 1.1) a style:shrink-to-fit attribute for shapes, so use this to represent the AUTOFIT value. The fallback from AUTOFIT to draw:fit-to-size="true" was a stupid idea anyway, probably "false" is less annoying in practice. There are 2 different shapes that implement TextFitToSize property: a) text shapes already interpret ALLLINES and PROPORTIONAL exactly the same b) fontwork custom shapes interpret ALLLINES but do nothing for PROPORTIONAL As Regina points out, there is no shape that needs to distinguish between ALLLINES and PROPORTIONAL, so we do a minor behavioral API CHANGE and from now on interpret PROPORTIONAL as ALLLINES on fontwork custom shapes. This obviates the need to distinguish the values in ODF and so we don't need a new attribute, just use draw:fit-to-size="true" for both. On import, use MID_FLAG_MERGE_PROPERTY to combine the 2 attributes into one value. 2. Restrict the export of draw:fit-to-size to only the standard values "true"/"false". This implements step 1, the step 2 will be done in the future when most users have the import of the style:shrink-to-fit. Change-Id: I4a378aa110fdb82db7a99a839d7ff207248a73e7 Reviewed-on: https://gerrit.libreoffice.org/43521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-20Disable CppunitTset_sc_*_functions_test for linux_aarch64 for now, tooStephan Bergmann
> Oct 20 10:21:31 <sberg> erAck, when "Testing > file:///run/build/libreoffice/sc/qa/unit/data/functions/array/fods/linest.fods" > in CppunitTest_sc_array_functions_test fails with non-informative expected 1 > vs. actual 0, how can I reasonably debug that? (and no, I don't have an X11 > connection to the relevant machine, to see what opening that .fods with LO > would look like there) > Oct 20 10:25:04 <erAck> sberg: sigh.. we're still lacking an "analyze steps" > in the functions test loader, so far only loading the doc and inspecting > provides that; maybe getting individual cell results via UNO would work So disable these tests for aarch64 for now too, to get Flathub builds unstuck, until somebody finds a way to actually debug this. Change-Id: I9bf30d0d7185497f9ad4b04b60b6a67f34a8c44e
2017-10-20WIN guarantee direct timeout handlingJan-Marek Glogowski
The code did acccount processing of an invaild timeout system message as a valid timeout event. Change-Id: I3c31f8b9cec592631b4089411163dadecffde816 Reviewed-on: https://gerrit.libreoffice.org/43529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-20tdf#98212 make paragraph dialog alignment tab preview updateJim Raykowski
Change-Id: Ibd1d4f2c59bb832d6b2bba597e3f022c628e1887 Reviewed-on: https://gerrit.libreoffice.org/43577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-20pdfextoutdevdata: Rearrange code for readability and efficiencyMike Kaganski
Change-Id: I506e77d97940570b076274a35cc92d3ec7278d3c Reviewed-on: https://gerrit.libreoffice.org/43584 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-20tdf#112100 Select shape name in NavigatorTamas Bunth
After the selection of a shape the shape name is selected in the Navigator tab under the Drawing Objects entry. It scrolls to the corresponding entry as well in case the scrollbar is visible. Change-Id: I298e8fe6bdab01eb20c53e1730812192c46770c5 Reviewed-on: https://gerrit.libreoffice.org/43566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-10-20shrink ww6 fuzzerCaolán McNamara
Change-Id: Ic84ebb2327d6f99b04a6f2722f71fe401d2a9e09
2017-10-20loplugin:constmethod in codemaker,registry,storeNoel Grandin
Change-Id: Ie75875974f054ff79bd64b1c261e79e2b78eb7fc Reviewed-on: https://gerrit.libreoffice.org/43540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-20use std::unique_ptr in EscherSolverContainerNoel Grandin
Change-Id: I46d10aec5b69d120dfca8fea076013664cbb3278 Reviewed-on: https://gerrit.libreoffice.org/43527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-20Fully ignore inappropriately named loplugins in unit-test modeStephan Bergmann
...even if they implement PPCallbacks, so filtering them out in HandleTranslationUnit was ineffective. Change-Id: I9df8103a50739f3176e6d63accfd0334da7faa9a Reviewed-on: https://gerrit.libreoffice.org/43575 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-20tdf#87808 Add missing tooltips to Media Playback toolbarGabor Kelemen
For the Position and the Volume sliders Change-Id: Ie7eee332b05e9a6cfc8165cf7b7b59695c58b458 Reviewed-on: https://gerrit.libreoffice.org/43571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-10-20svtools: SvTreeListEntry's copy ctor is unnecessaryTakeshi Abe
Change-Id: Idce8773d96e30dacfc9ce13fdb9b399c2a8bf341 Reviewed-on: https://gerrit.libreoffice.org/43485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-20Replace list by unordered_set for m_aAlternateFiles (vcl)Julien Nabet
Change-Id: I66ea61972fed87245b33dfe355eff58d23041120 Reviewed-on: https://gerrit.libreoffice.org/43520 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-20Kill unused SV_LBOX_DD_FORMATTakeshi Abe
Change-Id: I242339aa7a3f7c12b84cdcd97fe670491a0217a5 Reviewed-on: https://gerrit.libreoffice.org/43541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-10-20tdf#107111: DOCX export: restore HideTabLeader... attribute after TOXVasily Melenchuk
Previously m_bHideTabLeaderAndPageNumbers value was not restored after TOX finish and so causing visibility problems with following hyperlinks. Change-Id: I4ba5ce1f70e05d706d17d60e1a33a62995701f9e Reviewed-on: https://gerrit.libreoffice.org/43310 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-20ofz+ubsan: runtime error: left shift cannot be represented in typeCaolán McNamara
Change-Id: Ic153b39475abbd562e4c81b47089ca8280080cff Reviewed-on: https://gerrit.libreoffice.org/43569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-19sw: enable ooxml export tests also for Win32Serge Krot
* seems they work fine these days * also removed magic number from fdo69649 test in favour of getting the value straight from the document Change-Id: Ife9d96eb413740b56b771df0d23e590f44f9452f Reviewed-on: https://gerrit.libreoffice.org/43568 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-19Move slideshow include files to common include directoryStephan Bergmann
...that are included from various places. Change done in preparation of loplugin:includeform. Change-Id: I6507189a380a547321903d71e3cb425c37bb16ad Reviewed-on: https://gerrit.libreoffice.org/43563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Make Library_sdfilt find Library_sd include files via -IStephan Bergmann
...instead of through ../../... paths. Change done in preparation of loplugin:includeform. Change-Id: I1b4476f32573c2ef19d2a145e6e617b63006d40b Reviewed-on: https://gerrit.libreoffice.org/43562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Make include file found through -Isd/source/ui/incStephan Bergmann
...instead of implicitly next to the including file, in preparation of loplugin:includeform Change-Id: I954b6f7132db103c6b89a4ca1577b16f94e800c2 Reviewed-on: https://gerrit.libreoffice.org/43561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Make include files found through -Ilotuswordpro/incStephan Bergmann
...instead of implicitly next to the including file, in preparation of loplugin:includeform Change-Id: I4a666e8cd1cd3b1bf67af697be02879217dbc83a Reviewed-on: https://gerrit.libreoffice.org/43560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Move SchXMLAutoStylePoolP.hxx next to SchXMLExport.hxx including itStephan Bergmann
Change-Id: I21a805d90f04432a864ec2567fd707da27bc7be3 Reviewed-on: https://gerrit.libreoffice.org/43559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-19Consistently use #include <LibreOfficeKit/...> in include/LibreOfficeKitStephan Bergmann
Some of the include files there had used #include "..." while others had used #include <LibreOfficeKit/...> for references among those include files. In preparation for loplugin:includeform, consolidate on the latter (even if that's clearly a misuse of the <...> form). Change-Id: If142c844863e4e63b6fd8f2200732972860befd3 Reviewed-on: https://gerrit.libreoffice.org/43558 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>